- 22 Oct, 2019 39 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0ce6d876771d..ca28b0ef0037 git log 0ce6d876771d..ca28b0ef0037 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 vapier@chromium.org autotest_quickmerge: fix under Python 3 2019-10-22 manojgupta@google.com cros_fuzz: Install virtual/implicit-system only if needed. 2019-10-22 vapier@chromium.org cros_branch_unittest: encode captured output 2019-10-21 vapier@chromium.org trigger_cr50_signing: fix __call__ signature Created with: gclient setdep -r src/third_party/chromite@ca28b0ef0037 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id53ce3d8ed196d4c29be413ba1a67cb498fdf143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873325Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708082}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f5594ef1fc7..ea7ed55c01a4 Created with: gclient setdep -r src-internal@ea7ed55c01a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0630c9723438ff1fc8f02b56230ecf5262b1d6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873326Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708081}
-
Darren Shen authored
There are some logic in JS that determines whether to send keys to Mojo or not. We need to move this code to C++. Original code: //chos/pk/rulebasedcontroller.js We decided to move this code to the IME service side, i.e. all keys are now sent via Mojo, but only some keys are processed by the rule-based engine. This shouldn't change behaviour, apart from performance, since we now send Ctrl keys etc. over Mojo where we didn't before. However, we'll need to send these keys for UIL-based IMEs anyway, since Mozc needs to handle shortcut keys. Once this CL lands, we will delete the corresponding code in JS. Bug: 1009903 Change-Id: I1cf9dc7bde47bf6f19d16d475e6380aaa6883439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837312 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708080}
-
Evan Stade authored
Lazy creation meant that sometimes, at least in tests, UserScriptListener wasn't created early enough to do its job (profiles were added and user script update notifications were sent before UserScriptListener was created). Bug: none Change-Id: Id0a3c394da2d5bd2c58da5d26118f4448c68107d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853912 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708079}
-
Peter Kasting authored
Bug: 82078 Change-Id: I87af44296ebacdf71a0c80caa1899f8798d5f4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872933 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708078}
-
Peter Kasting authored
Bug: 82078 Change-Id: I444a23b749667b59f6f33b36c76e00e2ff03ff6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873274 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708077}
-
siyua authored
The metrics for avatar highlight will be added later. Bug: 932818 Change-Id: I2bee343bd0b550897cfb3dc4cc4a2ca151840a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860512 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#708076}
-
Daniel Hosseinian authored
Change-Id: Ib2a9cf2b39eb758d120cff562c385d17a6d5c526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861139 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#708075}
-
Jian Cai authored
While testing llvm-libunwind for unwinding, we ran into a build failure caused by nacl being built with --rtlib=libgcc, and requiring libgcc for unwinding. Force it with --unwindlib=libgcc. Bug:870480 Change-Id: I4a1b601cd254b6a77c2612342e783cc2e0b083fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836152Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Auto-Submit: Jian Cai <jiancai@google.com> Commit-Queue: Jian Cai <jiancai@google.com> Cr-Commit-Position: refs/heads/master@{#708074}
-
Fergal Daly authored
I'm not deleting them because the set up is a bit complex and we can just leave them empty and ready to use if needed for now. All tests pass when built with is_component_build=false. android_browsertests https://chromium-swarm.appspot.com/task?id=480617e093827910 content_shell_test_apk https://chromium-swarm.appspot.com/task?id=48062ebc37df7010 chrome_public_test_apk https://chromium-swarm.appspot.com/task?id=48059c46554c9d10 content_browsertests is more complex and will come in a later CL. Bug: 1016230 Change-Id: I7a2a0af9906589903dadf2fd0334fec9415497d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872071Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708073}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f228038ddeb4..5335faaece2a git log f228038ddeb4..5335faaece2a --date=short --no-merges --format='%ad %ae %s' 2019-10-22 jonahr@google.com Robust validate_step_info in generate_stats.py Created with: gclient setdep -r src/third_party/angle@5335faaece2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I18ce91c1039c092637f39541662d9e9997eee629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873089Reviewed-by:
-
Jordan Bayles authored
This patch adds a thread checker to the ChromePlatformClient class in the Open Screen platform code under media router. This thread checker ensures that the members on the ChromePlatformClient singleton are properly teared down on the right thread. Change-Id: I6e4dfcfbbece12b86329b1936224ae602b5d03bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869447 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#708071}
-
Alexandre Courbot authored
On some devices (e.g. Cheza), the actual coded width of a buffer may differ from the macroblock-aligned width the driver works on. This can lead to the following DCHECK to be raised: FATAL:v4l2_video_decode_accelerator.cc(671)] Check failed: egl_image_size_.width() == adjusted_coded_width (320 vs. 384) Interestingly we already had code that fixed this by setting the EGL width to the actual buffer's width, but this code was only used in case an image processor was present. This CL generalizes the code to all cases. Bug: b:143049464 Test: video_decode_accelerator_tests passing on Cheza and Hana. Change-Id: I7c65ca469f637bd360259fb6b3d94a6eba8a73e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871529 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708070}
-
Alexandre Courbot authored
AllocatedSizeFromV4L2Format() returns the calculated size of a buffer, being given its V4L2 format. This method does not modify the format whatsoever ; thus, pass it as const reference in order to avoid an unneeded copy. Bug: None Test: video_decode_accelerator_tests passes on Kevin. Change-Id: Ifd0bf98022efe44a6b72f6c684a452c969add83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871490 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9fd87c45f43..8f5594ef1fc7 Created with: gclient setdep -r src-internal@8f5594ef1fc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I75dbaa037a6ffe4564d99e18132582875fc8380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873090Reviewed-by:
-
Reilly Grant authored
This is a follow-up to r707007 which enables the route for chrome://settings/content/serialPorts. Otherwise the "Serial ports" option is visible but clicking it does nothing. Bug: 967863 Change-Id: I53a04345cb63fe5045e0de2a475dc7b61945a676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872738 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#708067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/94e1a5268692..81e8d3b29662 git log 94e1a5268692..81e8d3b29662 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@81e8d3b29662 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I746b21b4f6355d1819b88572c8d7a778e7a7a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871647Reviewed-by:
-
Ken MacKay authored
Thereby making it more efficient. Merge-With: eureka-internal/326819 Bug: internal b/127963522 Change-Id: Idc7db2c86d54c3b14293f407744c51ac6e9d40e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869128Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#708065}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/75c59424e3f1..53f9e0979a58 git log 75c59424e3f1..53f9e0979a58 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 martiniss@google.com Roll led to latest version 2019-10-21 ehmaldonado@chromium.org depot_tools: Include httplib2 using vpython. Created with: gclient setdep -r src/third_party/depot_tools@53f9e0979a58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1015682,chromium:1002153 Change-Id: Ia7715d47c6389847d0c79059d63b1992ca21c87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871645Reviewed-by:
-
Miguel Casas authored
This CL removes the 3 flags enable-webrtc-hw-{h264,vp8,vp9}-encoding because they were deprecated in M76 and will be hidden in M78. These flags are used in peerconnection/rtc_video_encoder_factory.cc to filter the supported codecs to be added to the SDP. The same filtering effect can be obtained by using the still existing flag --disable-webrtc-hw-encoding which is also surfaced to chrome:flags and used in peerconnection/video_codec_factory.cc [1], albeit at a coarser granularity: no codec-level enable/disable is available. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/peerconnection/video_codec_factory.cc?type=cs&q=IsWebRtcHWEncodingEnabled&g=0&l=180 Bug: 599650 Change-Id: I35bde6cd50c88ca8641dd9a6bd5a3e44394cde43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863153Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708063}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I3e63dc63920c2c23782c955f13f19b1a42c3bc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872159Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#708062}
-
Evan Stade authored
This re-lands f72a8099 "WebLayer: add tests for DownloadDelegate" Bug: none Change-Id: Ie18d955d2754baa9a91d742844ba42fdbc823d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872461 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#708061}
-
Dan Beam authored
Bug: none Change-Id: I796e54e6d92123dde787df0a674c4ba556fcf56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869750 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708060}
-
minch authored
Bug: 1002733 Change-Id: I9627f1c3208a0c0a8aaf1c1fe393266dfaa4bfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872755Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#708059}
-
Regan Hsu authored
Currently, on Krane devices, the wallpaper preview header navbar is cut off awkwardly because there is a hardcoded length. This CL ensures that the navbar changes size based on the screensize, so the navbar doesn't cut off awkwardly. screenshots (both after): https://screenshot.googleplex.com/5wXNJCk2nww https://screenshot.googleplex.com/wprpDqdd7mP Bug: 997474 Change-Id: I99e89c57cf822c4e363313d2096aade2519f1101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868595 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Eric Willigers authored
This initial implementation always displays the buttons in app windows when the new "DesktopMinimalUI" feature flag is enabled. For now, the buttons are shown in the top-right corner. Remaining work: - only show the buttons when minimal-ui is specified in the app manifest - move the buttons to the top left corner - decide on a color to use when "Back" is disabled Screen shots: https://bugs.chromium.org/p/chromium/issues/detail?id=1007151#c6 TBR: alemate@chromium.org Bug: 1007151 Change-Id: I1a6bf03823462f684326d34f019f201902a1589b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863050 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
tby authored
Bug: 959679 Change-Id: Ibe31eb89715b60313fef5b6772d9a1c5f2bd3c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866090Reviewed-by:
-
Daniel Hosseinian authored
The current base32 component only has an encoder. A decoder would be valuable, especially in testing situations where the input of the encoder can be compared to decoded output of the encoder. Change-Id: Ic675bb7dff405237d04f563f465a89966270bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865545Reviewed-by:
-
Matthew Mourgos authored
When the 'shelf-hotseat' flag is enabled, the back button will only be shown in tablet mode when in-app. Some unittests have been changed to ensure the back button functionality still works both with and without the 'shelf-hotseat' flag enabled. Bug: 1012043 Change-Id: I9754f7a3d08473d4ecdd1573aa1ecf6ce33186ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857186 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#708054}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eef5e4ffc239..ead0ec9a2017 git log eef5e4ffc239..ead0ec9a2017 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 elrello@microsoft.com Add firing of OnRemoveTrack and OnRenegotationNeeded during rollback 2019-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8587b26e..b528279c (707701:707828) Created with: gclient setdep -r src/third_party/webrtc@ead0ec9a2017 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:980875,chromium:None Change-Id: I9a36982fae02d10eee067a1f65a552788666c6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872895Reviewed-by:
-
Toby Huang authored
I added an example usage code snippet to the comments above LoggedInUserMixin to further clarify how to use this class. Bug: None Change-Id: I22e13b93e736c5bc4fe3164815adf0ac49e42ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873136Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708052}
-
nancy authored
AppServiceDataSource is used for the Apps searching on Chrome OS, so the Extenions, ARC and Crostini's DataSource can be removed. Related AppResult is removed too. ExtensionAppResult is removed as well. So the unit test for ExtensionAppResult is removed. BUG=1016159 Change-Id: Ibf3c67b10178419772e2aabb2466721799658336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858538Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708051}
-
Ted Choc authored
When triggering a share intent chooser, use startActivityForResult as it allows Chrome to receive a callback when the activity finishes and can propagate the cancel much sooner. This required swapping out Activity for WindowAndroid in the share API, so it is largely a mechanical swap in the various places triggering share. BUG=636274 Change-Id: Id3628e65757ca54713a57eefcd47efec24fc65a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832589Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708050}
-
Dominick Ng authored
This CL refactors the handling of icons in AddToHomescreenDataFetcher so that WebAPKs which have maskable icons have that icon correctly masked in the A2HS prompt, but still use the raw icon in the WebAPK itself. Using the raw icon in the WebAPK is necessary to ensure that the OS and WebAPK server always have the original icon on which to apply their own masks. However, that original icon is inappropriate to show the user in the A2HS prompt, so ensure we mask it manually before it is shown. BUG=977173 Change-Id: Ib3e469d31e236ef961f72d25dfb2170723fa73c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869151 Commit-Queue: Dominick Ng <dominickn@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#708049}
-
Yun Liu authored
Bug: 985574 Change-Id: Ib2b3bee4601b3fe01aa3ff59548dc66fd4ed6ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872926Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#708048}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c21b70d6b576..e9fd87c45f43 Created with: gclient setdep -r src-internal@e9fd87c45f43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib06a94ac8460f365bcbbe4aba47120065d2b4ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872896Reviewed-by:
-
Livvie Lin authored
This is a reland of a9df5b29 Differences from original cl: - PageInfoUI::SecurityDescription GetSecurityDetails() changed to PageInfoUI::SecurityDescriptionType GetSecurityDescriptionType() - Initialize security_description_type_ in the header file - In safety_tip_page_info_bubble_view_browsertest, static cast to a regular page info bubble instead of safety tip bubble for CheckPageInfoDoesNotShowSafetyTipInfo Original change's description: > Handle Safety Tip learn more link in page info > > Bug: 1007497 > Change-Id: I4498d39cabf4736a697294ad027082a53894a623 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857166 > Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706076} Bug: 1007497 Change-Id: I8dcebe8a7ab974e72eea24280578f8f6830031b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867478Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708046}
-
Erik Jensen authored
Looking through some of the comments on the pam_systemd module, it looks like there were a couple things that weren't quite correct. This (mostly) fixes them. It has the added benefit of enabling GNOME sessions to launch within CRD on Ubuntu 18.04 (though not at the same time as on the local console). Bug: 1016583 Change-Id: I45441b346866dc0bbf02e43096e49c7d985ae4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873245Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#708045}
-
David Tseng authored
With the on-going changes in the Blink tree, ChromeVox can once again not rely on nodes persisting their ids. Blink may choose to destroy and re-create an entire subtree of nodes in reaction to a page making some kind of update. The actual DOM does not change, but Blink re-creates the accessibility subtree (resulting in new nodes, with new ids). Note that ChromeVox has flip flopped on using tree path recovery in the past. Related bugs: 885244 945708 (each of these were verified to work after this change). Related changes: https://chromium-review.googlesource.com/c/chromium/src/+/1889165 https://chromium-review.googlesource.com/c/chromium/src/+/1539262 Change-Id: I1c0bb78ce448c601d116aa90e408c36cab21b3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872557Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#708044}
-
- 21 Oct, 2019 1 commit
-
-
Miriam Zimmerman authored
Fix the following classes of lint errors For i18n-content use javaScriptCase. Found lines longer than 80 characters This CL was generated manually, using code-search to double-check that all references were updated. BUG=None TEST=Deploy to eve, check feedback dialog Change-Id: Iaaf3d565fafcca251096fe97b48a3a4f363d8f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869995Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#708043}
-
