- 02 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24e74c9857fa..03a0d5b08cac 2020-06-02 tandrii@chromium.org git-cache: delete support for internal repos. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0255bfc07c4dd4f212701b5add7103e6fb3f810d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774018}
-
Cherie Cheung authored
For ARCVM, DriveFS path will be handled by Seneschal SharePath request. For ARC++, legacy fd passing will be kept for the time being (b/157297349). Bug: 147618164 Test: Files on DriveFS can be opened by an android app Change-Id: I99e5704610d5a922a95e4c3d885b6b62d9b9a144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212114Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774017}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5891b0910066..77e5316a515d 2020-06-02 jiajie.hu@intel.com Pull in Android-only dependencies behind a condition If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I7e8fac65ada179512f523fe195b54a45b091ed18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226044Reviewed-by:
-
rbpotter authored
Closure compiling: - copies_settings_test - color_settings_test - custom_margins_test Bug: 1000989 Change-Id: I4e9d9068d1f5d63d5a618bcc9980f52358fd1ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223265 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#774015}
-
Austin Eng authored
These were marked as failing on only Windows and Linux. A Dawn change is coming which will update the Metal backend to also throw OOM on large buffer allocations. Pre-emptively marking as failing to prevent test failures. The main issue here is that the test incorrectly does not allow the implementation to throw an OOM error on enormous buffer allocations. Bug: dawn:433 Change-Id: Id5123ea1608bf68916a5c40d2d682f8c715e3a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225792 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#774014}
-
Kuo Jen Wei authored
Bug: 1087777 Test: tast run <DUT> camera.CCAUIIntent Change-Id: I98bdafe9f131fc5b3e2b8194e9687f9a1b491fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224937 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#774013}
-
David Bokan authored
This CL makes it so that all tests in layer_tree_host_impl_unittest.cc pass when the scroll unification flag is turned on. A followup mechanical CL adds parameterized test suites to ensure it stays that way. The main changes here are that under unification, cases where ScrollBegin would previously cause a scroll to be routed to the main thread are now handled on the impl thread. In cases where the hit test was unreliable or had a non-fast scrollable region, the return now requests a main thread hit test. For simple main thread scrolling reasons, a hit test isn't necessary. Also made some minor updates to a few tests to ensure they're running under the most realistic scenario by making sure they setup the viewport correctly. Bug: 1086625 Change-Id: I20fbd4c431c583e0a63241e91a3adaeb298bed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222262 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774012}
-
Peter Kotwicz authored
This CL extends the expiry date for the following histograms: WebApk.Startup.Cold.NewStyle.ShellLaunchToSplashscreenVisible WebApk.Uninstall BUG=1086221,1072540 Change-Id: I7f1f031ba05dbb094467853042e36f588cbda1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222036Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#774011}
-
Fergal Daly authored
The previous expectation was that navigating a subframe would not change the WbUI object. This changes the test to expect a new object. It's still unclear if having a new object is actually OK. This is behind a flag, so we can figure it out. Change-Id: I6fc1703c7997942412d66e8b29d32fc94cf3a910 Bug: 1064944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141486Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#774010}
-
nancylingwang@google.com authored
For Crostini, though LoadIconFromVM loads the penguin icon, fallback_icon_resource_ is set as the default icon IDR_APP_DEFAULT_ICON. So the penguin icon is reloaded by the default icon. Modify LoadIconFromFileWithFallback and set the fallback resource as kInvalidIconResource to not load the default icon for Crostini. BUG=1088393 Change-Id: Icd7b264f225047224a6d0b3d0dac04dedbfe2ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226102Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774009}
-
Fergal Daly authored
The crash has not occurred since https://crrev.com/c/2186901, submitted on May 12. Some of the dchecks etc remain and some todos updated to point to the main RenderDocument bug. Bug: 1006814 Change-Id: Id078eed913addbc4444050dff5f76e357e8a3e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214766 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#774008}
-
Hirokazu Honda authored
We formerly settle enabled features in the test initialization. However, if base::TestSuite::Initialize() is called, it turns out that these features are overwritten and thus no effect in the test. There is no way to stop the overwrite. Therefore, this workarounds the behavior by re-enabling features in TEST_P. Bug: None Test: video_encode_accelerator_unittest on eve Change-Id: I26ec9afcbb4d88786fd18d4701a6dde3938ecc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210186 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#774007}
-
Yuzu Saijo authored
This CL removes the call to DeleteForCurrentDocument from the destructor of ManifestManagerHost. This intends to fix a crash which happens from time to time using RenderDocumentHostUserData. Change-Id: I1336fb62328dcb0cf9991499f399bf3665d29b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224737Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#774006}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ced839500960..ab74e294602d 2020-06-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I09be1ba1e40e75b71e338c6adeee8081f2c5f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226047Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e9a386951413..a5d0662b82d0 2020-06-02 dberris@chromium.org refactoring: Remove MockIssueTrackerService If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087803 Tbr: nuskos@google.com Change-Id: I36c6a2c41d125ce826e6be38a57b2ddfec548c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226046Reviewed-by:
-
shrekshao authored
Mark conformance2/textures/misc/origin-clean-conformance-offscreencanvas.html as RetryOnFailure. No-Try: True Tbr: kbr@chromium.org Bug: 1082525, 1090201 Change-Id: I9a59e245a6b3cfa765ad43a434b08fbcc8b8eec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226085Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#774003}
-
Tetsui Ohkubo authored
It is possible for a Wayland client to trigger drag & drop operation from the touchscreen. Exo have used GetCursorScreenPoint() as the initial drag shadow position, but the method does not return the expected location when DnD is triggered from the touchscreen. TEST=manual BUG=None Change-Id: I7febd3dacd60603893dee16a96adba05460d6422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224886Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#774002}
-
Hirokazu Honda authored
video_encode_accelerator_tests can accept compressed data as input and decode it by using SW decoder before encoding. The code copies the entire decoded frames to encoder input data. However, the decoded frames might have different stride from the expected resolution. For instance, compressed data has 320x192 video frames and the SW decoder produces 384x192 video frames. The test must copy the resolution area that is specified by json file. Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: I3f6b5a78a30ef0e9e96211bee2c981af437607cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217831 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
As above - this fixes: external/wpt/css/css-overflow/webkit-line-clamp-004.html We weren't performing the correct relayout if the lines exactly matched the requested number of lines. Bug: 993813 Change-Id: I4ab3a702161bcb8e8cd10fc8ea6837931ebac16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224601 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774000}
-
Kenichi Ishibashi authored
This test depends on ServiceWorkerRegistrationInfo. The test should be moved to ServiceWorkerRegistryTest as a preparation for moving ServiceWorkerStorageTest to the Storage Service. The test is renamed as we might want to remove GetAllRegistrationsInfo in the future (but we won't remove ServiceWorkerRegistrationInfo). Bug: 1055677 Change-Id: Ib3c6a86ed9d364d43dd5cbcd94a02e5276973699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224936Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773999}
-
David Munro authored
We keep forgetting to update the dashboard scripts when adding new return codes, add a link in a comment above the enum so we hopefully remember. Test: None Bug: None Change-Id: I07a8b8b49118dc19bf352282f658ab95f1d21253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220115 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773998}
-
Hitoshi Yoshida authored
Implements fooNonNull() and hasFooNonNull() APIs for nullable dictionary members whose return type requires base::Optional<T>. Bug: 839389 Change-Id: I1696645234338b36ff54e6f01a13e7e1b578c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224484 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#773997}
-
Jarryd authored
Extend by a year so that we can continue to monitor eviction behavior around the new quota paramaters such as extended quota. Bug: 1072671 Change-Id: I6aa30f620d3c933c49c81519b0f50437c27b927c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207628Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773996}
-
Giovanni Ortuño Urquidi authored
This reverts commit 0af7d7aa. Reason for revert: Causing failures on multiple tests in linux-trusty-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12178 Example stack trace: Received signal 11 SEGV_MAPERR 000000000008 #0 0x56517bc8acf9 base::debug::CollectStackTrace() #1 0x56517bbf6703 base::debug::StackTrace::StackTrace() #2 0x56517bc8a895 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f12826f7330 (/lib/x86_64-linux-gnu/libpthread-2.19.so+0x1032f) #4 0x56517c963d2e x11::RandR::QueryVersion() #5 0x56517ca4e18f ui::GetXrandrVersion() #6 0x56517ca4d101 ui::XDisplayManager::XDisplayManager() #7 0x56517d4af33b views::DesktopScreenX11::DesktopScreenX11() From: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878654764661294768/+/steps/extensions_browsertests_on_Ubuntu-14.04/0/logs/Deterministic_failure:_BluetoothSocketApiTest.Listen__status_CRASH_/0 Original change's description: > [XProto] Remove all remaining non-event usages of XRandR > > BUG=1066670 > R=msisov > CC=sky > > Change-Id: Iecd593c0c77878a80bf84e9e3c504fd90815db6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220686 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773876} TBR=jamiewalch@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: Id94555856b3e06dcafc0f4c78a7a737718ddd37d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225998Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773995}
-
Yoshifumi Inoue authored
This patch changes "last-empty-inline.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I273a2978f313c93aef033bc72725759d86e551c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224593 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Johann authored
Use HeapMojo wrappers so that Oilpan will GC the objects. BUG=chromium:1049056 Change-Id: I4d63383514d691cb40afe7e42fa5e57c8fe57589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226096Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#773993}
-
Hirokazu Honda authored
This CL adds VideoFrameValidators that check SSIM and PSNR, respectively, to StreamValidator. It eenables video_encode_accelerator_tests to check the quality of encoded images produced by VideoEncodeAccelerator. Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: I5bca3b7f74e664488c38ab749d6d491883d7f356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190468Reviewed-by:
-
nancylingwang@google.com authored
When a component observes AppRegistryCaches for the multiple users case (e.g. Ash), OnAppUpdate could be called for multiple AppRegistryCaches. Add the account id in the AppRegistryCaches and AppUpdate class, so that the AppRegistryCache observer can know the current AppUpdate is for which account in the OnAppUpdate interface. Unit tests are modified to test the account id in the OnAppUpdate interface. BUG=1068884 Change-Id: Id07b2e8480330667c45ff11fe1cf21d3ebe048ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222244Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Hugo Benichi authored
This was migrated to kMeteredProperty in Change-Id I83f4ca01521947edb39785053308cb88b658a69e. BUG=b:156302252 TEST=Compiled. Change-Id: If6ad3879d96232b640e5f13cf2b8981cd4031eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217683Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb2717b7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0b8ccf1c1f14204ae7e8b74496924dacf89be427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773989}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/011959aafddc..859bfe8981d6 2020-05-28 dmauro@google.com Googletest export 2020-05-28 dmauro@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export 2020-05-28 dmauro@google.com Merge pull request #2767 from mvoorsluys:OutputXmlSkipped 2020-05-28 dmauro@google.com Googletest export 2020-05-28 dmauro@google.com Merge pull request #2862 from prehistoric-penguin:prehistoric-penguin-patch-1 2020-05-28 dmauro@google.com Merge pull request #2845 from matepek:readme-update-with-opensource-proj 2020-05-28 dmauro@google.com Merge pull request #2677 from IYP-Programer-Yeah:fix-file-path-normalize-function 2020-05-28 dmauro@google.com Merge pull request #2698 from aribibek:patch-1 2020-05-28 absl-team@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export 2020-05-28 durandal@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export 2020-05-28 absl-team@google.com Googletest export If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,pwnall@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome Tbr: isamsonov@google.com,pwnall@chromium.org Change-Id: I352391966ec7e41632b92dee97aaf09f9f057fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225712Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591041546-66c2ea2b6b7d4112794a73d0a3fdd90d1b4804af.profdata to chrome-win64-master-1591055861-b616b8ef5787fabc8c6bebc449f3453e58d43322.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I013346875989ec62ee145ca3fab14bb6d03a3a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226039Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f32ae562fe52..634973155ab5 2020-06-02 thestig@chromium.org Use more RetainPtrs in CXFA_FFTabOrderPageWidgetIterator. 2020-06-02 thestig@chromium.org Clean up CXFA_FFTabOrderPageWidgetIterator. 2020-06-02 thestig@chromium.org Fix an UnownedPtr error in CXFA_FFTabOrderPageWidgetIterator. 2020-06-02 thestig@chromium.org Mass rewrite dtors to use "= default". 2020-06-02 thestig@chromium.org Remove unused CXFA_FFPageWidgetIterator members. 2020-06-02 thestig@chromium.org Remove DeviceType::kUnknown. 2020-06-01 nigi@chromium.org Update comments and add an embeddertest for FPDF_LCD_TEXT. 2020-06-01 thestig@chromium.org Mark CFX_RenderDevice::SetDeviceDriver() as protected. 2020-06-01 thestig@chromium.org Mark CFX_RenderDevice ctor as protected. 2020-06-01 thestig@chromium.org Make CPDFXFA_Page annot iteration methods more consistent. 2020-06-01 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from a8f20a1dacc2 to a70177d4a2e5 (3 revisions) 2020-06-01 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 31b81b84c957 to 91fa1462a88f (119 revisions) 2020-05-29 nigi@chromium.org Remove repetitive |FXTEXT_CLEARTYPE| usages in fxbarcode/oned/. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:980116,chromium:980161 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie371134e4b5618bb5dbef9d2fd0ae33d76e4bae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226041Reviewed-by:
-
David Bokan authored
This CL specifically fixes behavior for the test LayerTreeHostImplTest.ScrollBeforeRootLayerAttached as well as some others that check the "viewport fallback" behavior when the scroll unification flag is enabled. This test was a regression test for a crash that was occurring when a scroll occurred prior to a root layer being attached. In this case, we hit test to a nullptr for the layer. Today, we drop the scroll in this case. The initial scroll unification implementation inappropriately requestes a main thread hit test. The fix here replicates this logic in the kScrollUnification branch of ScrollBegin so that behavior is unchanged. When a hit test doesn't hit any layers, we currently fallback to using the inner viewport scroll node. There are some cases where the inner viewport scroll node doesn't exist: - UI Comopsitor never has viewport nodes - OOPIF never has viewport nodes - Have not committed from Blink yet The key problem here was that the scroll node hit test returning nullptr is actually two distinct cases that we weren't distinguishing: 1. The compositor realizes it doesn't have enough information to perform the hit test (e.g. hit a non-fast scrolling region) 2. The compositor is able to perform the hit test and there simply isn't a ScrollNode. 1 requires a main thread hit test where 2 must drop the scroll. The HitTestScrollNode method is modified here to return the additional information and makes this explicit. Bug: 1047182,1086625 Change-Id: Id547e73dc307f0118b6c8cd3625a26661b57a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222140 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773985}
-
François Degros authored
Fixed comments. Made zipFileCannotOpen more consistent with zipCannotZipFile. BUG=912236 TEST=browser_tests --gtest_filter="*/zip*" Change-Id: I8ff87195fff80435e1f78ffc29fee509b06bac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225996 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#773984}
-
chrome://histogramsJun Kokatsu authored
This change removes dummy histograms in chrome://histograms Bug: 1085912 Change-Id: I4fda6a684a20ce2effd601e78a7d601cdd29f4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214041Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773983}
-
Harkiran Bolaria authored
As a note - this patch jumps from 47 to 49 in WebSchedulerTrackedFeature so as to prevent merge conflicts with the patch here: https://chromium-review.googlesource.com/c/chromium/src/+/2212934 Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Change-Id: I884e7b5262938c453cea7e1792b505c3a55447bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225355 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#773982}
-
Kenneth Russell authored
This is occasionally causing GPU process crashes, leading to random flakiness throughout the test suite. This will be handled more generally soon. Bug: 1085899, 1088465 Tbr: bsheedy@chromium.org Change-Id: I90b40c7232a1dc0238e8a7792b577a4290b84535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225979Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773981}
-
Gyuyoung Kim authored
This CL converts VideoDecodeClientPtr to mojo::PendingRemote<VideoDecodeClient> in the all uses of VideoDecodeClientPtr. Bug: 955171 Change-Id: Ia18b3d9ed4bd4062e2b0c94dc499f6ba84c7dcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223837Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#773980}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I622f9f642fb456f6c540f206f8e968ab4f1b6a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224021Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773979}
-
