- 03 Aug, 2018 40 commits
-
-
David 'Digit' Turner authored
This CL simplifies and refactors a bit the GN templates used to build the [mono]chrome[_modern]_public_XXX templates (including APKs and bundles). - Add build/android/docs/android_app_bundles.md to better explain what is going on here. - Unsynchronized proguarding of application bundles was broken by the CL that introduced synchronized proguarding. This CL fixes it by simply making synchronized proguarding the default for all app bundles (when proguard_enabled is true). It doesn't really make sense to support regular proguarding, since the chances that something wrong will happen are too high. This also reduces the number of build state variants that need to be supported for an individual bundle module. - The chrome_public_apk_tmpl_shared() GN template defined in chrome/android/BUILD.gn was not very useful and only serves to add some dependencies. Remove it and adjust all callers to add the equivalent dependency list to their |deps| variable instead, to simplify things. - Remove chrome_modern_public_apk_or_module_tmpl() entirely. Instead, add an |is_modern| variable to chrome_public_apk_or_module_tmpl() that takes care of adding the necessary declarations corresponding to modern builds to the template. - Hard-code version_name to chrome_version in chrome_public_apk_or_module_tmpl() since all callers define it to |chrome_version| anyway. - rules.gni: Add missing variable forward, required for the clank/ targets only. - Rename chrome_public_apk_tmpl() to chrome_public_common_apk_or_module_tmpl() to match its intended usage. Note that chrome_public_apk_tmpl() wrappers are still available to ensure the clank/ build doesn't break. Similarly, define monochrome_public_common_apk_or_module_tmpl() (yes, a bit long, but really only internal). - Add documentation to various intermediate GN templates to make it easier to understand what's going on. BUG=865108 R=agrieve@chromium.org, tiborg@chromium.org, yfriedman@chromium.org Change-Id: Ia4f79429a8e32c97630c90ce126362eb7534252c Reviewed-on: https://chromium-review.googlesource.com/1154979 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580522}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/434a112d2537..da77c7f91f1d git log 434a112d2537..da77c7f91f1d --date=short --no-merges --format='%ad %ae %s' 2018-08-03 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@da77c7f91f1d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4cd08bc8b2dbe5e51362f89f0221eb9b567fdcc0 Reviewed-on: https://chromium-review.googlesource.com/1162101Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580521}
-
Hayato Ito authored
I've confirmed that we need to set recalc flag definitely here. Without that, a lot of crashes would happen. Change-Id: I6fad0f9587b3c16d92dd848eae961d7bdac49f38 Reviewed-on: https://chromium-review.googlesource.com/1161842Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580520}
-
chcunningham authored
Another step on the path to deprecating SigninManager. This method replaces SigninManager::SignOut*(). See design discussion here: https://groups.google.com/a/chromium.org/d/msg/identity-service-dev/hNrtJ_nIXJ4/6nMXfIcVBwAJ Bug: 806781 Test: New unit tests Change-Id: I39fe49925c980362b0cdf58db2ce961e107241b6 Reviewed-on: https://chromium-review.googlesource.com/1154985 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#580519}
-
Friedrich Horschig authored
The descriptions of password suggestions are now loaded and read by Talkback (e.g. "Password for m.park@gmail.com") to uniquely identify the single list entries. The key icon now indicates that it toggles the password bottom sheet. Bug: 870627 Change-Id: I2efce0c5eea06cab16702cc817f0c081af459aa6 Reviewed-on: https://chromium-review.googlesource.com/1161909Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#580518}
-
stkhapugin@chromium.org authored
Adds a check for the URL length and only disables clipping on URLs longer than 800 characters. Bug: 860790 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idf7ccf4582a107ca61e384451dd1415b63337dc0 Reviewed-on: https://chromium-review.googlesource.com/1160491 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#580517}
-
Vasilii Sukhanov authored
It's questionable whether the popup should move back to the generation state. Curently for automatic generation it does and the bug isn't observed. For manual generation it doesn't and therefore the editing prompt remains open. The CL fixes that. Bug: 870217 Change-Id: Ib9758f87208d82fd8bd52cdcd1aef664d4f2cba5 Reviewed-on: https://chromium-review.googlesource.com/1160849Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580516}
-
Henrique Grandinetti authored
Change-Id: Iac4be6a4a32ca598f9e90a0033a651fc8a43eb62 Reviewed-on: https://chromium-review.googlesource.com/1160722Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#580515}
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same namespace/scope and conflict. This happens for the function UpdateMetadataForUsage. This commit solves the issue by moving the function to a shared util file. Bug: 869381 Change-Id: I57b8f9c96c785a3bbfc8250f0edbe7690c3b3ff7 Reviewed-on: https://chromium-review.googlesource.com/1160482 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#580514}
-
Jérôme Lebel authored
This Chrome flag is only for debug purpose, and it is not meant to be turned on by default. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib52d02611f383114e302e2e600da9397d7ff6641 Reviewed-on: https://chromium-review.googlesource.com/1158827 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7f2df29563db41980615d9b8949de9bf6479f87e Reviewed-on: https://chromium-review.googlesource.com/1161918Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#580512}
-
Luciano Pacheco authored
Update DirectoryModel.clearAndScan_ to stop requesting previous directory's content metadata, that caused issue 867974 where we were sending too many metadata requests. However we still need to fetch metadata for the currently selected directory so is available to use by menu/commands. Change the File Manager CommandHandler to update all commands when the metadata gets updated. This fixes the commands that should be disabled based on metadata properties canCopy, canCut, can*. Bug: 867974 Change-Id: I5254f70b8993a6e9b536f53543d1f3ed2ca0d87f Reviewed-on: https://chromium-review.googlesource.com/1161843Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#580511}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/091fee47..e82ab695 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9c5ed337a080fc5a0759ea1c31e9987b3292def7 Reviewed-on: https://chromium-review.googlesource.com/1161981Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580510}
-
Balazs Engedy authored
This reverts commit a445460b. Reason for revert: MSAN warning in USS/TwoClientBookmarksSyncTestIncludingUssTests.CreateSyncedBookmarks See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11051 https://chromium-swarm.appspot.com/task?id=3f17cf427082ec10&refresh=10&show_raw=1 Original change's description: > Reland "[Sync::USS] Bookmark sync conflict resolution" > > This is a reland of 553ec6da > > Original change's description: > > [Sync::USS] Bookmark sync conflict resolution > > > > This patch addresses the problem of conflict in bookmarks upon > > receiving a remote update for a node that has local changes. > > > > The general polic that is implemented is that server wins except in > > case of deletion. > > > > Bug: 516866 > > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 > > Reviewed-on: https://chromium-review.googlesource.com/1157006 > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580436} > > Bug: 516866 > Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e > Reviewed-on: https://chromium-review.googlesource.com/1161861 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580496} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I22a2a0f518fdbefe7baa3c4840884090459e62a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516866, 870668 Reviewed-on: https://chromium-review.googlesource.com/1161884 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580509}
-
Stefan Zager authored
With this patch, a node rendered by LayoutNG will be highlighted with a different color when you hover over the node in the inspector. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I648d7cfa6bfd93a7829ffb480fe029b7e64a67c9 Reviewed-on: https://chromium-review.googlesource.com/1158391 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#580508}
-
Dan Elphick authored
In cases where arguments are checked using arg->Is*Type*, convert Values using arg.As<Type>()->Value() instead of the deprecated parameterless *Type*Value() methods. In other cases where the type is not guaranteed coerce the conversion uses *Type*Value(Local<Context>). Since these functions return a Maybe, use FromMaybe() on the return value to guarantee a return value even if the conversion could throw an exception. Change-Id: If14cf9d4b4698bb1f24d42a6d3258121d2939d82 Reviewed-on: https://chromium-review.googlesource.com/1153247 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580507}
-
Mike West authored
Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ANnafFBhReY/1Xdr53KxBAAJ Bug: 588931 Change-Id: I6dc296734ea6b1fdf1478bea7a1e80ca8afe38ac Reviewed-on: https://chromium-review.googlesource.com/1160644 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580506}
-
Michael Lippautz authored
Previously, only V8EventListener were handled in the helper. With crrev.com/579347 this changed and all types of V8 event listeners use this mechanism. Their common superclass is V8AbstractEventListener which is returned here. Bug: chromium:870351, chromium:843903 Change-Id: I4407cf5abfddf10d644c3fd7e1add86dbfa5d5f9 Reviewed-on: https://chromium-review.googlesource.com/1161907 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#580505}
-
Hitoshi Yoshida authored
In general, V8 uses some random numbers not to make their environment non-deterministic. However, it prevents us from caching v8_context_snapshot.bin in test runs. This CL sets "--predictable" flag in the snapshot generator to fix the random seed and generate identical snapshot files in every run. Bug: 870584 Change-Id: I90e60d9636cbd31263658a6fa19c942d89442568 Reviewed-on: https://chromium-review.googlesource.com/1161853 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 856179 Change-Id: I67e4265709e034febff732cab339ae6ef19b24b7 Reviewed-on: https://chromium-review.googlesource.com/1161917Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580503}
-
chcunningham authored
Splitting this out of review https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I0221d901537e39e2c2d66adca254b3ff77df4823 Reviewed-on: https://chromium-review.googlesource.com/1160497Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#580502}
-
Kinuko Yasuda authored
R=kouhei, ksakamoto Bug: 803774 Change-Id: Ia0543486846c137fef02f230b804e3d613c29875 Reviewed-on: https://chromium-review.googlesource.com/1161851Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580501}
-
chcunningham authored
This brings the fake a little closer to real SigninManager. The added behavior is critical to *upcoming tests for the IdentityMager ClearPrimaryAccount() (aka signout) API. *https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I4d533e67223dfe4bce6ca26eee7aea6f7cc075fd Reviewed-on: https://chromium-review.googlesource.com/1160495Reviewed-by:
-
Mohamed Amir Yosef authored
This is a reland of 94d8037b Original change's description: > [Sync:USS] Enable more two client bookmarks integration tests > > This CL enables more integration tests for bookmarks to run > against USS archiecture. > > > Bug: 516866 > Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f > Reviewed-on: https://chromium-review.googlesource.com/1158691 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580434} Bug: 516866 Change-Id: Ia922ab75b92c013cc2e06cb3ec5a549875390316 Reviewed-on: https://chromium-review.googlesource.com/1161882Reviewed-by:
-
Balazs Engedy authored
The test is extremely flaky on Linux. Bug: 870604 Change-Id: I02242da7c685075ce148a6f302b67afe1b5804a4 TBR: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1161921Reviewed-by:
-
François Beaufort authored
This CL enables Picture-in-Picture in chrome apps by implementing EnterPictureInPicture and ExitPictureInPicture in AppDelegate. Bug: 863309 Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b Reviewed-on: https://chromium-review.googlesource.com/1156513 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Mohamed Amir Yosef authored
This is a reland of 553ec6da Original change's description: > [Sync::USS] Bookmark sync conflict resolution > > This patch addresses the problem of conflict in bookmarks upon > receiving a remote update for a node that has local changes. > > The general polic that is implemented is that server wins except in > case of deletion. > > Bug: 516866 > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 > Reviewed-on: https://chromium-review.googlesource.com/1157006 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580436} Bug: 516866 Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e Reviewed-on: https://chromium-review.googlesource.com/1161861Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9adf7905..091fee47 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib35b94b64ad14b45db621938f4ad10e2e7d907c8 Reviewed-on: https://chromium-review.googlesource.com/1161750Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/84dd183a82c3..434a112d2537 git log 84dd183a82c3..434a112d2537 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 cb4ae446080b..81f891d043cb (1 commits) Created with: gclient setdep -r src/third_party/skia@434a112d2537 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ib2399fae7ab104c5f26413e3a7077ad74625fb12 Reviewed-on: https://chromium-review.googlesource.com/1161152Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91470e7e. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22267 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ibfee270916940a6d4b630cce7a17c411eae70f0c Reviewed-on: https://chromium-review.googlesource.com/1161746 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580493}
-
BUG=762641 TBR=alemate@google.com Change-Id: I544632383b2930a1e52567c29d3b722113cae153 Reviewed-on: https://chromium-review.googlesource.com/1160729Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580492}
-
Balazs Engedy authored
Bug: 870236 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I28598b680ec8901f0b0bf2fb0c9496ec8366e190 TBR: vmpstr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1161912Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 843161 Change-Id: I433cad8d86b34d64de99e13281d84c953d9bf3b1 Reviewed-on: https://chromium-review.googlesource.com/1150225Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Bernhard Bauer authored
This will allow extracting a mediator that interacts only with the model. Bug: 847420 Change-Id: I2cfc0f816ae04570dcc12f40757339fc4ed5de0c Reviewed-on: https://chromium-review.googlesource.com/1142153Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580489}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb4ae446080b..81f891d043cb git log cb4ae446080b..81f891d043cb --date=short --no-merges --format='%ad %ae %s' 2018-08-03 oetuaho@nvidia.com Make sure ProgramGL stays usable after failed glProgramBinary Created with: gclient setdep -r src/third_party/angle@81f891d043cb The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I893a6271f0a645c116661a2e9aaa50fc1a887187 Reviewed-on: https://chromium-review.googlesource.com/1161150Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580488}
-
Boris Sazonov authored
This CL connects together ConsentBumpFragment and ConsentBumpMoreOptionsFragment. It also adds slide_out_left and slide_in_right animations resources used for the transition between two fragments. Bug: 869426 Change-Id: I1ff4f6fc1a3585bdd667bb24d567365a60ec9468 Reviewed-on: https://chromium-review.googlesource.com/1159074Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#580487}
-
Boris Sazonov authored
This CL adds a check to hide the description text view in RadioButtonWithDescription if it contains an empty string. Bug: 869426 Change-Id: I9e0b26303a0d98b2d44944818927f0acea5aaa59 Reviewed-on: https://chromium-review.googlesource.com/1159072Reviewed-by:
-
Jérôme Lebel authored
Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2f2e14ceba73ebecbc9c0222ae87ea86e4f91a49 Reviewed-on: https://chromium-review.googlesource.com/1159062Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580485}
-
Adam Rice authored
Enable WebSocketHandshakeReuseConnection in fieldtrial_testing_config.json so that it gets testing coverage on the bots before it becomes the default. BUG=423609 Change-Id: I692aa12c5685d61a47b26aa014d10db7bb91d98a Reviewed-on: https://chromium-review.googlesource.com/1151182Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580484}
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same namespace/scope and conflict. This happens for the function UserDataKey. Since the function relies on that the static int is unique this function could not be moved to a shared util file. Instead, the issue was solved by renaming the function. Bug: 869381 Change-Id: Ifd67ac865e9d0bad272cc51ef1af8c3a5b382893 Reviewed-on: https://chromium-review.googlesource.com/1160487Reviewed-by:
-
