- 31 Oct, 2018 40 commits
-
-
Martin Kreichgauer authored
CtapMakeCredentialRequest and CtapGetAssertionRequest previously only stored the hashed client data. This moves hashing out of AuthenticatorImpl and into these request classes so that FidoAuthenticator instances have access to the unhashed string if they require (e.g. in the Windows WebAuthn API). Bug: 898718 Change-Id: I4a08987a0be5d6ca07318d37f8c0bcc6c8612a06 Reviewed-on: https://chromium-review.googlesource.com/c/1300677 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604148}
-
Luciano Pacheco authored
This test is flaky/failing on MSAN, disabling until is fixed. TBR: joelhockey@chromium.org Bug: 899664 Change-Id: I89646e80d9bbb8735d0056c26c882b056b4c9e97 Reviewed-on: https://chromium-review.googlesource.com/c/1308239Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604147}
-
Xiaocheng Hu authored
This patch stops passing VisiblePosition to the functions, and hoists creation of VisiblePosition to the callers, to decrease the usage of VisiblePosition. This is a preparation for a VP-free version of Previous/NextPositionOf() Bug: 657237 Change-Id: I46fe45f9c28458e1dbffddf26b106372ff433fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1309142Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604146}
-
Fergal Daly authored
* accessibility/element-role-mapping-normal.html * accessibility/table-header-column-row.html The flakiness is due to slowness which is fixed by https://crrev.com/c/1306965 Bug: 898049,899885 Change-Id: If4a9a770833344b3b55e89bbc3379f3cc9560e0e Reviewed-on: https://chromium-review.googlesource.com/c/1309375Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604145}
-
Naoki Fukino authored
Files app and its companion apps recognizes *.3gp files as 3GP video files, but they don't recognize *.3gpp files. Since ARC++ Camera app saves captured video with *.3gpp extension, it should be handled correctly. Bug: 844252 Test: Manually tested repro steps on Kevin. Change-Id: If5c84bdb00188f123a739d5ddffceb741880278d Reviewed-on: https://chromium-review.googlesource.com/c/1308955Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#604144}
-
Luciano Pacheco authored
Add MYFILES_VOLUME_ENABLED in private strings to be able to have the feature flag in the JS/UI code. Change VolumeManager to use MyFiles folder for Downloads volume, the method |GetMyFilesFolderForProfile| takes care of returning the right value based on the feature flag MyFilesVolume. Change NavigationListModel to support MyFiles as Volume when MyFilesVolume feature flag is enabled: 1. MyFiles volume is the Downloads volume (after the feature flag is removed we can rename it accordingly). Setup Downloads volume as VolumeEntry, 2. Create a NavigationModelFakeItem with "My files" label, based on the VolumeEntry (step #1). 3. Skip adding "Downloads" to Myfiles, since now MyFiles is in fact Downloads volume. 4. Continue to add Linux and Play files to Myfiles. Test: unit_tests --gtest_filter='VolumeManagerTest.GetVolumeListMyFilesVolume' and browser_test --gtest_filter='FileManagerJsTest.DirectoryTreeTest:FileManagerJsTest.NavigationList*' Bug: 873539 Change-Id: Ia242d52a1e4d7b4fb3c7ca219d9cfdc4fce72543 Reviewed-on: https://chromium-review.googlesource.com/c/1308235 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
TBR=karandeepb@chromium.org Bug: 900447,696822 Change-Id: I963f072f0c43f644e18fd29adc9d1784ea6b28e7 Reviewed-on: https://chromium-review.googlesource.com/c/1309376 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604142}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9877e8407b5c..9bf8120cabd6 git log 9877e8407b5c..9bf8120cabd6 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 jvanverth@google.com More YUV cleanup 2018-10-30 herb@google.com Remove uniqueID fields from SkGlyphRun 2018-10-30 herb@google.com Cleanup interface between SkGlyphRunPainter and SkDraw 2018-10-30 kjlubick@google.com [canvaskit] Expose nima animation as POC 2018-10-30 brianosman@google.com Pass and return GrColor4h by const& when possible 2018-10-30 caryclark@skia.org remove SkPaint Align from doc examples 2018-10-30 mtklein@google.com remove old shader routines from SkColor4Shader 2018-10-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-30 kjlubick@google.com Refactor Nima code Created with: gclient setdep -r src/third_party/skia@9bf8120cabd6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Idf6a2bc5615a9c2e88ef78a7f2fb831de52b2f5b Reviewed-on: https://chromium-review.googlesource.com/c/1309325Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604141}
-
dpapad authored
Also remove paper-item-body element, which was never used. Bug: 843350 Change-Id: I01f940f47856a6e739b9844ba194c85a19901fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1307073 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#604140}
-
Vikas Soni authored
Disable AImageReader on Imagination and NVIDIA gpu as they are buggy. Remove android version checks for disabling AImageReader as its not required. Bug: 838725 Change-Id: Ie05ecffbec4f758175a38bed81da98aed2aebeb3 Reviewed-on: https://chromium-review.googlesource.com/c/1308602Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#604139}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/295328449111..1e185db4498d git log 295328449111..1e185db4498d --date=short --no-merges --format='%ad %ae %s' 2018-10-31 thestig@chromium.org Roll tools/clang/ 7792d28b0..3041f30dd (3 commits) 2018-10-30 tsepez@chromium.org Follow-up from CFX_GlobalData rename. 2018-10-30 tsepez@chromium.org Rename CJS_{KeyValue,GlobalData,GlobalVariableArray}.{h,cpp} to CFX_ 2018-10-30 tsepez@chromium.org Test error cases in util.printd() and printx(). 2018-10-30 tsepez@chromium.org Prefer single-byte form of CFX_V8::NewString() with literals. 2018-10-30 thestig@chromium.org Clean up CPDF_RenderOptions and CPDF_OCContext. 2018-10-30 tsepez@chromium.org JSMessage::kUnknownMethod and kTooManyOccurances are XFA-Only. 2018-10-30 tsepez@chromium.org Better testing for AFRange_Validate. Created with: gclient setdep -r src/third_party/pdfium@1e185db4498d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1f7d7b0c8d81a32c2c80bf2937d93e032ebe7c33 Reviewed-on: https://chromium-review.googlesource.com/c/1309326Reviewed-by:
-
Giovanni Ortuño Urquidi authored
StartScan just send the command directly to the active adapter. Future iterations will cause the state to change to kTransitioning, and support concurrent calls. Bug: 870192 Change-Id: I54da3c6026d474a9e70bc744bd03dfde1a3e766e Reviewed-on: https://chromium-review.googlesource.com/c/1295609 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#604137}
-
Regan Hsu authored
Add success of enabling and disabling features for devices. Bug: 870138 Change-Id: I27a96eceb4d1c9ec3fe00ad37c1606785ab4449d Reviewed-on: https://chromium-review.googlesource.com/c/1306915 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#604136}
-
Danyao Wang authored
Refactored |webView:didCommitNavigation| and |webView:didFinishNavigation| to allow DCHECK as early as possible in both methods. Bug: 893154 Change-Id: Ia4b480b87ddbcb66df19e22a1f9d0113e277fc3e Reviewed-on: https://chromium-review.googlesource.com/c/1303050 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#604135}
-
khmel@chromium.org authored
BUG=b/118447711 TEST=Manually + unit-test Change-Id: If307a9f64bf8a6e8937bc4b17683ef621155c786 Reviewed-on: https://chromium-review.googlesource.com/c/1300690Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604134}
-
Eric Karl authored
This CL sets EnableGpuRasterizationViewportRestriction to false on bots, removing the restriction that GPU rasterization is only used for mobile sites on Android. This will allow us to collect data on performance and memory impact and prepare for launch. Bug: 899399 Change-Id: I60e7c8ab99020c4a4a498ce9cc924de012ad8b64 Reviewed-on: https://chromium-review.googlesource.com/c/1306345 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604133}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/af9dd6080188..193a284d34d2 git log af9dd6080188..193a284d34d2 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 jmadill@chromium.org Vulkan: Split vk::CommandGraphResource. 2018-10-30 jmadill@chromium.org Make perf tests faster in correctness-only mode. 2018-10-30 syoussefi@chromium.org Run DifferentStencilMasks tests 2018-10-30 jmadill@chromium.org Try to reduce variance in angle_perftests. 2018-10-30 jmadill@chromium.org Vulkan: Enable more perf tests. 2018-10-30 jmadill@chromium.org Vulkan: Add warnings for cache struct packing. Created with: gclient setdep -r src/third_party/angle@193a284d34d2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:806557 TBR=ynovikov@chromium.org Change-Id: Ib1b19719f3892ec093455e3a6bbc042457b118fd Reviewed-on: https://chromium-review.googlesource.com/c/1309324Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5e1c1c293b07..9662809abb16 git log 5e1c1c293b07..9662809abb16 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 dtu@chromium.org [pinpoint] Show full stack trace on invalid user input. 2018-10-30 achuith@chromium.org Disable sounds when running chromeos tests. 2018-10-30 ulan@chromium.org Fix summary options for the MMU metric histogram. Created with: gclient setdep -r src/third_party/catapult@9662809abb16 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900275 TBR=sullivan@chromium.org Change-Id: Ieac3b98e597b7d9535a9aaa18e0f389eb6c73c23 Reviewed-on: https://chromium-review.googlesource.com/c/1309076Reviewed-by:
-
Koji Ishii authored
This patch rebaselines paint invalidation test results for when floats within an inline formatting context changed, because our reuse-line-box in phase 1 is not going to support when there are floats/oof in the inline formatting context. Bug: 714962 Change-Id: I617a4e198d3dfa0b70b22356074451392d9ed748 Reviewed-on: https://chromium-review.googlesource.com/c/1307031Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604130}
-
John Z Wu authored
This fixes issues where string resources are not found on ios tests. Change-Id: Iaff172daad6100ba2036a90bd6e685c205ab8cbf Reviewed-on: https://chromium-review.googlesource.com/c/1302328Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604129}
-
Mustafa Emre Acer authored
This character (ˬ) is easy to miss between other characters. It's one of the three characters from Spacing-Modifier-Letters block that ICU lists in its recommended set in uspoof.cpp. Two of these characters (modifier-letter-turned-comma and modifier-letter-apostrophe) are already blocked in crbug/678812. Bug: 896717 Change-Id: I24b2b591de8cc7822cd55aa005b15676be91175e Reviewed-on: https://chromium-review.googlesource.com/c/1303037 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#604128}
-
Sidney San Martín authored
Bug: 900293 Change-Id: I86b7bab7ce9fb2f332f44f7a825544b7ca4eddd3 Reviewed-on: https://chromium-review.googlesource.com/c/1308760Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604127}
-
jonross authored
We'd like to eventually remove the caching of LocalSurfaceIds everywhere. As a step along the way, this updates ChildLocalSurfaceIdAllocator::GenerateId to be a void method. The rest is a mechanical refactor of the callsites, switching them to the pre-existing ChildLocalSurfaceIdAllocator::GetCurrentLocalSurfaceId to cache. We'll update each area separately in follow ups to remove the caches. Bug: 655231 Change-Id: I2107e95a1938e046ed994d4106d86e7be887720d Reviewed-on: https://chromium-review.googlesource.com/c/1307875 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604126}
-
Collin Baker authored
This removes its subclasses and changes their clients to use FeaturePromoBubbleView directly. Change-Id: Ie220ab3b4e7c7653ffefe5b6fc266f76d60b492b Reviewed-on: https://chromium-review.googlesource.com/c/1298394 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#604125}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/034e897f55b6..a847559555af Created with: gclient setdep -r src-internal@a847559555af The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idc48b84ce6bb587828ec7013a7bbf961ebbd10d5 Reviewed-on: https://chromium-review.googlesource.com/c/1309323Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604124}
-
BUG=762641, 897540 TBR=oshima@chromium.org Change-Id: I497be0962d522a8e3ce19ff5e09754a8c91f6a3a Reviewed-on: https://chromium-review.googlesource.com/c/1303654 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#604123}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a92cd7312ca..b3f887b82310 git log 1a92cd7312ca..b3f887b82310 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 benwright@webrtc.org Expose key derivation through a simple interface for use in WebRTC. Created with: gclient setdep -r src/third_party/webrtc@b3f887b82310 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie616f3ecf9b9811cc8d393cc0d8701fff0766b52 Reviewed-on: https://chromium-review.googlesource.com/c/1308702Reviewed-by:
-
Zhuoyu Qian authored
LogoDelegate was used as a mechanism for decoding untrusted logo images. Now, all platforms use the same LogoDelegateImpl, based on image_fetcher::ImageDecoder. LogoDelegateImpl should be removed, in favor of using an image_fetcher::ImageDecoder directly. Bug: 761828 Change-Id: If5734629a0c16a0a8867421c783b6d49fad2545c Reviewed-on: https://chromium-review.googlesource.com/c/1290583 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#604121}
-
Ian Kilpatrick authored
This lambda-izes AllLayoutOpportunities, so that FindLayoutOpportunity doesn't need to iterate over a Vector to find something that fits. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0cf9d5ce16608032850e326173a9fb4d501a9181 Reviewed-on: https://chromium-review.googlesource.com/c/1193942 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604120}
-
Tetsui Ohkubo authored
This CL ports following tests from browser to ash: * TrayAccessibilityTest.ClickDetailMenu * TrayAccessibilityTest.CheckMarksOnDetailMenu Other TrayAccessibilityTest browser_tests will be refactored to use SystemTrayTestApi mojo interface and kept on the browser side, because these tests are hard to do in ash unit tests. This CL also removes following tests: * TrayAccessibilityTest.ShowTrayIcon (browser_tests) * TrayAccessibilityTest.VisibilityFromMenu (ash_unittests) * TrayAccessibilityTest.VisibilityFromSettings (ash_unittests) * TrayAccessibilityLoginScreenTest.LoginStatus (ash_unittests) They either have the replacement in AccessibilityFeaturePodControllerTest, or simply the feature is removed. TEST=ash_unittests, browser_tests BUG=850014 Change-Id: I4d7c8d99cb6ce5df9de4115d874fc56d7a0c276a Reviewed-on: https://chromium-review.googlesource.com/c/1306937 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604119}
-
Ryan Hamilton authored
Change QUIC ConnectionCloseError histograms to break out errors for Google hosts in an attempt to diagnose some unexpected errors. Change-Id: I56a795474abda715025b7fbf015d4880537c8748 Reviewed-on: https://chromium-review.googlesource.com/c/1303045Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604118}
-
Christian Biesinger authored
No need to call IsLayoutBlock/IsLayoutNGMixin twice R=eae@chromium.org, mstensho@chromium.org Change-Id: Id63f3833040d4eb58dd67dcb204a139522e08a9b Reviewed-on: https://chromium-review.googlesource.com/c/1308653 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Before crrev.com/c/1277654 when we created text results for ref tests most of which don't need text baselines, we let reftest's text baseline be optional, so that most reftests can ignore the text results, while a few of them for which the text result is significant can still check the text results. After crrev.com/1277654, reftests no longer produce text results thus don't need text baseline, unless a test explicitly produces text result. In this case, we can just let the test determine if the text baseline is needed, instead of run_web_tests.py checking existance of the text baselines. About existing reftests producing text results but without text baselines: 1. for tests that don't actually need text results, modify them so that they no longer produce text results. This includes some tests previously calling testRunner.dumpAsTextWithPixelResults() just to dump pixel results. 2. for tests that produce meaningful text results, create text baselines. 3. for tests that don't produce text results intentionally, but the text results are created because of some console messages, etc. also create text baselines. There are several cases: a) the message shows the purpose of the test, e.g. intentionally testing with some invalid values. New text baselines are created in this CL. b) the message shows some problem of the test that doesn't need to fix for now, e.g. the test is using some deprecating API. New baselines are created in this CL. c) the message indicates some fatal bug in the test, e.g. using undefined variable, invalid JavaScript grammar, etc. The bugs are fixed in this CL. Bug: 703899 Change-Id: I82a6b25c61d1fb794840fdaa0da248909a690592 Reviewed-on: https://chromium-review.googlesource.com/c/1298120 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#604116}
-
John Z Wu authored
Change-Id: I53fc40fe8efebf71c0fe4831cfbd8bcb8deab138 Reviewed-on: https://chromium-review.googlesource.com/c/1289438 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#604115}
-
Yutaka Hirano authored
Looks like they are due to infra flakiness. Bug: 626703, 898687, 898153 Change-Id: I424c2d7cd0eaaec37605bc78d0d25865ed0b778a Reviewed-on: https://chromium-review.googlesource.com/c/1304037 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#604114}
-
Maks Orlovich authored
This CL's contents are entirely: cp chrome_async_socket.cc network_service_async_socket.cc cp chrome_async_socket.h network_service_async_socket.h cp chrome_async_socket_unittest.cc network_service_async_socket_unittest.cc ... done as a separate change so that the CL making the actual porting changes gets a usable diff between net and NetworkService versions of code. The "new" files are not included in compilation and this is meant to be landed together with https://chromium-review.googlesource.com/c/chromium/src/+/1232034 Bug: 875032 Change-Id: Idcdc85125c910662e642258adb71d58406752a64 Reviewed-on: https://chromium-review.googlesource.com/c/1237214Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604113}
-
Sunny Sachanandani authored
NV12 uses 4:2:0 subsampling which means there's one U and V sample per 2x2 block of Y samples. This means to have an integral number of U and V samples, both width and height of the surface (or Y plane) must be even. Scrolling on a page with video causes swap chain to be resized when the video's visible rect changes. Without forcing even width and height for NV12 swap chains, creating the swap chain often fails with fallback to BGRA swap chain. With this fix, creating the swap chain never fails. Includes a unit test for testing that swap chain is created with even dimensions after rounding, if necessary, and that the format of the swap chain is indeed NV12. Also, includes some minor cosmetic changes to logging to make clear that the errors codes are hexadecimal. Bug: 869677 Change-Id: Ief5999149d438e4883fc9c2bb397ab8a7d2b294e Reviewed-on: https://chromium-review.googlesource.com/c/1308906Reviewed-by:
-
Leonard Grey authored
Bug: 898278 Change-Id: I24ae7ef4e8accd54244dfd09721fa376dadfba34 Reviewed-on: https://chromium-review.googlesource.com/c/1305498Reviewed-by:
-
Alan Cutter authored
This CL makes OpaqueBrowserFrameView test for whether the user is using the system theme for the browser before using the hosted app theme color algorithm. This CL also updates the foreground color algorithm to always use the actual frame color to avoid readability bugs like this in general. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=365224&signed_aid=05pRAK75RpeItQNbJQ32zA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=365225&signed_aid=5PQmY9poCGVOGL8cIt7X3g==&inline=1 Change-Id: Id428054a636b408f59f88c49a0911f6a5052ccc5 Reviewed-on: https://chromium-review.googlesource.com/c/1307032Reviewed-by:
-
Peter Boström authored
r598108 made GG900 primary text color in GetAuraColor / common_theme.cc which made the ShouldIgnoreHarmonySpec check (kColorId_LabelEnabledColor == SK_ColorBLACK) fail. This caused the Harmony colors to be ignored for OSes outside Windows that use the default aura colors. This change meant that GetHarmonyTextColorForNonStandardNativeTheme was pretty much always used for colors, instead of using the Harmony colors. Bug: chromium:896891 Change-Id: I394e25d2eda5da5c0bb0532056d6eebff2a855c2 Reviewed-on: https://chromium-review.googlesource.com/c/1308901Reviewed-by:
-
