- 15 Aug, 2019 40 commits
-
-
Brian Salomon authored
Bug: 990918 Change-Id: I01625c93fa7f901414d59b80c7d78abb93ce68ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756149Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#687379}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ c152cc559..4abb566fb (11 commits) https://quiche.googlesource.com/quiche.git/+log/c152cc559e6c..4abb566fbbc6 $ git log c152cc559..4abb566fb --date=short --no-merges --format='%ad %ae %s' 2019-08-14 vasilvv Improve logging for BandwidthSampler map size bug entry. 2019-08-14 bnc Call BlockingManager methods from QpackEncoder when decoder stream instructions arrive. 2019-08-14 bnc Refactor QpackEncoderTest. 2019-08-13 nharper gfe-relnote: Call QuicSession::OnCryptoHandshakeEvent in TLS handshake. Protected by quic_supports_tls_handshake. 2019-08-13 bnc Only send Header Acknowledgement from QpackDecoder if required insert count is not zero. 2019-08-13 quiche-dev gfe-relnote: Stop registering ephemeral QBONE streams in the blocked list. Not flag protected, no functional change other than to reduce memory pressure. 2019-08-13 wub Internal QUICHE change 2019-08-13 dschinazi Send correct version negotiation to prober 2019-08-13 fkastenholz Add convience functions to end_to_end test 2019-08-13 renjietang Removed unused UberQuicStreamIdManager methods. 2019-08-13 dschinazi Client-side workaround for probes receiving unexpected length prefixes Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: Ic2673a098e7ac038673ded4bcc9775a197751c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756156Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Ian Swett <ianswett@chromium.org> Cr-Commit-Position: refs/heads/master@{#687378}
-
Ted Meyer authored
Change-Id: Idd502786dc49b4bef25ae22e86a44ef6516275c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756436Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687377}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eefe89513262..0b1cbfc167ec git log eefe89513262..0b1cbfc167ec --date=short --no-merges --format='%ad %ae %s' 2019-08-15 saklein@chromium.org ArtifactsService: Add CPE export functionality. 2019-08-15 seanabraham@chromium.org chromeos_config: make mistral experimental Created with: gclient setdep -r src/third_party/chromite@0b1cbfc167ec The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4fef182393a24e615cb4cadc804f71850dcd714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687376}
-
Mitsuru Oshima authored
* Update the widget bounds when added to the root window only when window is dragging (and dropped). This is necessary to keep the bounds of the window at target position (as the window has the bounds of the previous display). The correct bounds will be sent from Android (which should be (almost) same as current one). * Use the display id to compute the local bounds in zcr_remote_shell.cc Bug: b/130897153 Test: manual. make external display primary, and have one window there. disconnet display. Change-Id: Icd594e48efa9a5118f957d914a86147c68052b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745767 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#687375}
-
Tom McKee authored
The following histograms were marked as 'heartbeat' metrics in histograms.xml but are not considered heartbeat metrics anymore. Event.Latency.ScrollBegin.Wheel.TimeToScrollUpdateSwapBegin4 Event.Latency.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin4 PageLoad.PaintTiming.ForegroundToFirstContentfulPaint PageLoad.PaintTiming.ForegroundToFirstPaint PageLoad.PaintTiming.NavigationToFirstImagePaint This change removes the stale 'heartbeat' designation and also sets an expiry date of about one year on each histogram. This way, stale histograms get taken out of circulation eventually but not before owners have a chance to review. Bug: 991343 Change-Id: I1125602cd1cd267a6c363ca40609ee650deff8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754281Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Tom McKee <tommckee@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#687374}
-
Dominik Röttsches authored
Organise Blink font fallback into two main functions: * Retrieving a fallback font from the legacy path which finds a fallback font from hard-coded lists that have been curated manually and maintained. * Retrieving a fallback font through DWrite fallback API, either by calling Skia API in-process, which in turn uses DWriteFontProxy out of process bridging, or calling a Mojo method to retrieve a fallback family name. Use the LegacyWindowsDWriteFontFallbackEnabled RunTimeEnabledFeature to decide which fallback font to return, if the flag is on, always use DWrite. If the flag is off, on Windows 8 and below, only use the hard-coded fallback path. On Windows 8.1 and above, prioritze the hard-coded path, but try the API path if the hard-coded path did not find a result. This is intended as an interim flag to control which fallback font code path to use and to measure quality and availability of fallback fonts in the new code path. The flag is to be removed once we are confident to switch to the new code. Add UMA metric to record 4 different cases * Legacy hard-coded list did not find a font * API based fallback did not find a font * No font was found by either * Legacy fallback and API fallback disagreed on fallback font Record these metrics per ICU UBlockCode. Using API based fallback leads to a number of improvements exposed by some of our tests. For Japanese locales, Yu Gothic UI is selected in favor of Yu Gothic, which chooses the better screen-optimized, more modern variant of the font (fast/text/international/001.html, fast/text/international/002.html, fast/text/international/wrap-CJK-001.html). For traditional Chinese, YaHeng UI is selected in favor of SimSun, improving screen display of Chinese ideographs ( fast/text/justify-ideograph-complex.html, fast/text/justify-ideograph-simple.html). For untagged Han ideographs, Yu Gothic UI and Microsoft JhengHei UI are chosen vs. SimSun-ExtB and SimSun before. For Thai, Leelawade UI is selected over Tahoma. So, with less hand-curated fonts and removing code, we get much improved CJK and Thai fallback. Brief design doc linked from the bug. Bug: 976737 Change-Id: I3adff65cddb50061c884b81a3ae00de75d4ba735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708138 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#687373}
-
Tricia Crichton authored
In the log_replay tool, the functions to compare logged and replayed commands were using the old ELEMENT tag. Updated this to the new W3C tag so that element Ids would be marked as variable, and not explicitly compared. This resolved 3 test failures, leaving 4 failures in client_replay_test.py needing future corrections for W3C mode. Bug: chromedriver:3076 Change-Id: I20d079992f7d69680b1b8dc53ff9e9c6b19822e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756431 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687372}
-
kylechar authored
This CL finishes most of the cleanup of non-surface sync code path in src/content. It's no longer possible to disable surface sync so this is dead code. Most of this code was for Android which put extra information in CompositorFrameMetadata. This information is sent to the browser through RenderFrameMetadata now. Remove the unnecessary member variables and all usage of them. Also update tests that check LayerTreeHostImpl sets metadata correctly. The existing tests checked the information contained in CompositorFrameMetadata instead of RenderFrameMetadata. In particular LayerTreeHostImplTest.RenderFrameMetadata is based heavily on the existing LayerTreeHostImplTest.CompositorFrameMetadata test. Bug: 985009 Change-Id: I0d52a575764a193302180f52bd5916703185bee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746301Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#687371}
-
Ken Rockot authored
With the recent refactor off of Service Manager, a bug was introduced which can cause the Client interface to be used from arbitrary threads via calls from libassistant. This fixes the bug by ensuring that calls to RequestAudioStreamFactory always happen from the main thread. Bug: b:139480195 Change-Id: Ie3dca871929ccc913d7d4f1bf3ad2e17b8db7a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756546 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#687370}
-
John Rummell authored
Rather than duplicate the logic in cdm_paths.cc, pass cdm_platform_specific_path from cdm_paths.gni using BUILDFLAGS. Bug: 971433 Test: EME browser_tests pass Change-Id: I0cdfb768b36e991fc407291093ee00bf3cd5cffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747197 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#687369}
-
Aran Gilman authored
This is a follow-up to a comment in https://crrev.com/c/1637036 about moving IsLight() to within DarkModeColorClassifier(). This change removes IsLight() and makes CalculateColorBrightness() from the .cc file publicly available via a static method in DarkModeColorClassifier. Change-Id: I71497cbd4d6776134debade82960df7af01b1157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755054Reviewed-by:
-
Ryan Hansberry authored
Unlocking by pressing the submit button is initially disabled, and only enabled when Smart Lock finds the phone and the phone is unlocked. This change makes sure that Smart Lock cleans up after itself if the phone can no longer be found or becomes locked (making the submit button disabled again). Bug: 943211 Change-Id: Ie347cb009732fd60ac7ba27f13c44f337c3ae793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755187 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#687367}
-
Robert Ogden authored
Needed to add another testing param class for https://chromium-review.googlesource.com/c/chromium/src/+/1738644 Bug: 971918 Change-Id: I4cfd2108dacc57029f80d5b433f8684d25e1d164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756544Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#687366}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bacb821c428a..5b218519a4b1 git log bacb821c428a..5b218519a4b1 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 michaelludwig@google.com Add helpers for creating new contexts 2019-08-15 rmistry@google.com [perf_skottiewasm_lottieweb] Increase loops to 5 2019-08-15 ethannicholas@google.com unified Metal uniform buffers Created with: gclient setdep -r src/third_party/skia@5b218519a4b1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: Ib29cade4f7abc17fd0ab973b8e636cc85ac0c8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756445Reviewed-by:
-
John Lee authored
This will be used in the Tab Strip WebUI to retrieve favicons for tabs, and the Tab Strip WebUI uses JS modules. Bug: 965770 Change-Id: I34e2cc4c7dbb1913e946b055a48d12c69a87acfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748113Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#687364}
-
Ryan Hansberry authored
Bug: 943211 Change-Id: I181ad7956e30e9919b7084fce274a62d0158e5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755188Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#687363}
-
Peter Boström authored
This is under an experiment that will be used to determine how much of an impact an extra web renderer has on browser stats. The experiment also logs the time of creating the footer as well as the first visually non-empty paint. This experiment will be used to provide data for discussions regarding running parts of Chrome's in a web renderer. Bug: chromium:993502 Change-Id: I70b96c4e04a76b721e5ef7301d749182866a019a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753058 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#687362}
-
Stefan Zager authored
The rest of the MapToVisualRectInAncestorSpace code will do inclusive intersections when the kEdgeInclusive flag is set, as required by IntersectionObserver to correctly handle zero-area targets. This patch adds coverage for this situation to the existing WPT for cross-origin IntersectionObserver. Since the bug only affects IntersectionObserver running inside an OOPIF, this also updates the test to force the iframe into a different domain, rather than just using the sandbox attribute (which is not sufficient to trigger OOPIF). BUG=978759 Change-Id: I7dbe52d2f3e39e029fed3dda5be31190c593a1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754595Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#687361}
-
Erik Chen authored
This requires a sufficiently new version of ld64. I confirmed that the one that comes bundled with Xcode 10.12.1 is new enough. There's no harm in setting this for older versions of ld64. This is currently gated behind the gn arg mac_deterministic_build because lldb has a bug that causes it to fail to load object files when the binary is built deterministically. Bug: 330262 Change-Id: I9802420a46f487888f4768c01168dae1b8d88359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711105Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687360}
-
Collin Baker authored
This improves on the color picker's keyboard and screenreader behavior. Bug: 989174 Change-Id: I3be7227afe3616636a311c66b3393683be65bd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754273 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#687359}
-
Danton Vu authored
The overview grid should scroll by itself when flung. Tests: Bug: 991599 Change-Id: If3534f841f56202389d3c96d2aeac5de84e3c9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752917 Commit-Queue: Danton Vu <dantonvu@google.com> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#687358}
-
Jun Cai authored
This CL adds a README.md file in the //content/browser/sms directory to give a brief introduction of what this API does, where related docs are, and where the sms code (production and test) is located in the chromium code base, etc. Bug: 989798 Change-Id: Ifacab30ed11dc7b1a40bdac4ecfb4b39655e0d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747396 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#687357}
-
Chris Hamilton authored
BUG=910288 Change-Id: I9d5676dfe744fa2bc5234a29a6dafe33a8f601ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752982 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#687356}
-
Chromium WPT Sync authored
Using wpt-import in Chromium af4e0c1f. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" 02426f68 "Rewrite interpolation-testcommon.js" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor ecobos@igalia.com: external/wpt/css/css-display foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/CSS2/text nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6454bce6303c1afc939a43e36db7533efbd3814f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756343Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687355}
-
Ted Meyer authored
Change-Id: I68ce750219cc8f8c5d97b62bff0128011b9504a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755643Reviewed-by:
-
Min Qin authored
This is no longer being used. BUG=984227 Change-Id: Id6c8aabec72b84ae8dbdf71159a4bebb202a29f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752915Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#687353}
-
Alexander Dunaev authored
This CL adds the missing handlers that enable window move via the non-client area of the window. Bug: 991512 Change-Id: I4890969ea8fc4c0aa405cdf0db7fca7769dc7b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741684 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#687352}
-
chrome://os-settingsRegan Hsu authored
With the exception of typing "chrome://os-settings" (or any subpages) into the url bar, any navigation to OS Settings or its subpages should open the standalone chrome OS settings surface. Bug: 990540 Change-Id: I6b868d4f96c045b536afa5e2426f01fe216fd0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747071 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#687351}
-
Brian Geffon authored
Similar to WebContentsProxy this CL adds support for a ProcessNode to retrieve (on the UI thread) the corresponding RenderProcessHost. Bug: 993569 Change-Id: I3bf9bec1ff75783ae1fb19cfc5b277652623bf35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752884 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
-
Bruce Dawson authored
Official builds - the PDBs and the PE files - often get published to a symbol server. For PE files the path name in the symbol server is: "%s\%08X%s\%s" % (peName, timeStamp, imageSize, peName) Since the peName for a particular DLL/EXE never changes and since the size often doesn't change this means that the timeStamp is the only differentiator between nearby builds. With the strategy of setting the build timestamp to 5 am of the last commit time it is easy to get a build that overwrites the previous build on the symbol server. This happened when build 75.0.3770.143 overwrote all of the PE files from build 75.0.3770.142, which complicated the investigation of (restricted view, sorry) crbug.com/964273. This probably happened many other times. The PDB files were never overwritten which is why this was not noticed earlier. When the 5 am quantization was added we were using the current time for the build timestamps. Now that we are using the last commit time it is less important to quantize to 5 am so this change removes that quantization, for official builds only. An increased number of days where we do multiple builds of one channel means that this issue is hit more frequently than when the quantization was initially added. Bug: 993509 Change-Id: Ibfac95569b713ede056d3ff070db0c05b4a38c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754527Reviewed-by:Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#687349}
-
Peter Collingbourne authored
Some of these definitions are present in the headers provided by newer NDKs, so we need to depend on those headers when compiling against the newer NDKs instead of defining the constants ourselves in order to avoid a symbol redefinition error from the compiler. Bug: 891999 Change-Id: I078099ade1b006006fd48a0deb085856591383bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753191 Auto-Submit: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#687348}
-
Ali Juma authored
This adds the file as an EG2 target, and updates #includes. Bug: 987646 Change-Id: Iece7bdc789b49e36443566f6fc00fb9be6902fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756213 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#687347}
-
David Bokan authored
This will allow us to easily turn the feature on and off for testing. This CL adds a Feature for the Blink RuntimeEnabledFeature and plumbs it through to about:flags. Today, Blink stores scroll offsets for scrollers using integral values. For user scrolls, we can apply subpixel precision deltas (e.g. on high DPI screens or if the user zooms) since the compositor stores a floating-point scroll offset. However, when the offset is sent to/received from Blink it is truncated. Therefore, script set and read offsets are always integer values (of physical pixels). The FractionalScrollOffsets feature allows Blink to store offsets in a floating point representation. This will reduce bugs and maintenance burdens related to the truncation between CC/Blink. It also helps fix issues in the web platform as WebAPIs will now store and return any number in the floating point range. Bug: 414283 Change-Id: I036402977204821ba92b592c1c88c2b46e64c7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753546Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Ian Clelland authored
This will cause bugs to be filed when third-party WPT imports introduce new test failures. Change-Id: Ie5db9bfffede22227e2ea4ef6ef73077f010811f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756391 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#687345}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/87531182b181..eefe89513262 git log 87531182b181..eefe89513262 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 mmortensen@google.com Extend image service to support building factory image. Created with: gclient setdep -r src/third_party/chromite@eefe89513262 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie5d89e276ed4d3dd2b80474b65ef66bf3d6bf279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756444Reviewed-by:
-
Akihiro Ota authored
Bug: 923068 Change-Id: I4aab963244f8e84c5fb749794587d60a64a083f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747975Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#687343}
-
Khushal authored
This reverts commit 77418db6. Reason for revert: Temporary change landed for diagnostic purpose. Original change's description: > android: Temporarily generate crash dumps for all renderer hangs on Q. > > R=dtrainor@chromium.org > > Bug: 983310 > Change-Id: I88d7a60b2938355fb1253707ebf45ab8bffe1c82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699422 > Auto-Submit: Khushal <khushalsagar@chromium.org> > Commit-Queue: David Trainor <dtrainor@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677090} TBR=dtrainor@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983310 Change-Id: I705e5e3adc344d36fcb27c0e7e06163ef3d0b397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756393Reviewed-by:
-
Himanshu Jaju authored
Reuse syncer::DeviceInfo instead of SharingDeviceInfo Bug: 993780 Change-Id: I82ca01edc5dab5038394a862ff9e38c563fe8c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755909Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#687341}
-
Justin Cohen authored
Tests needed a few calls to grey_scrollInDirection for the shorter screen. Bug: 994233 Change-Id: Iee2128409e75d97ddbd6bbb2b907a50b90087090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756246 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
