- 19 Aug, 2019 40 commits
-
-
Sam Maier authored
We are rolling mainly to remove assertions, which was a bug in R8: https://issuetracker.google.com/issues/139307059 Bug: 992809 Change-Id: Id7879e3ae72be7428f5c64a80d88969e18fa27fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760462Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#688251}
-
Andrew Luo authored
Bug: 934168 Change-Id: I083a79024282c245eb53b26d0c7bbdc92be5a7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759186Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688250}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/27e17f7851e2..d5e9e0c38f85 git log 27e17f7851e2..d5e9e0c38f85 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 misterg@google.com Merge pull request #2397 from kuzkry:custom-type-traits-is_reference 2019-08-19 misterg@google.com Merge pull request #2381 from Yannic:fix_bazel 2019-08-19 absl-team@google.com Googletest export 2019-08-19 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@d5e9e0c38f85 The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Ibe3c208d94d03005e9feace74608f5320cd49f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Staphany Park <staphany@google.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688249}
-
Xing Liu authored
This CL replaces std::deque with base::circular_deque. This can reduce the APK size by 160 bytes. Notice there are some side effects for base::circular_deque, like can't dereference iterator while modifying the containers. Also std::sort on base::circular_deque is taking +500 bytes increase in APK size, which makes this replacement less efficient. Bug: 972191 Change-Id: I25f4ae780b0f8be5a970ced561c461a68f1c93fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759228Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688248}
-
Peter Kasting authored
See comment 8 on the bug for the spec link. Bug: 883451 Change-Id: I218eb090519bb44d37afd75bf0fb7ad66c323949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756711 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#688247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4dfd57b8be2c..7dcd6b790228 Created with: gclient setdep -r src-internal@7dcd6b790228 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If17f84f12107386aa92b163f7acade35c7cf8ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761210Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688246}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: If5c875f2b94bb41a8c81dc49603b801903a8e69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760735 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#688245}
-
Rune Lillesveen authored
Type rule invalidation sets are not used on the global ruleset, only rulesets for specific stylesheets. Those RuleFeatureSets are disposed with the whole RuleSet and re-created every time which means this did not cause a bug. However, we should clear to be consistent and on the safe side. Change-Id: Icaade0122a34d3f0945f95093dcab6427e02509b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760733 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#688244}
-
Kyle Milka authored
Bug: 995079 Change-Id: I2366ab1cdc470dffc942fe91194a6ca947e69ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761047 Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#688243}
-
Jimmy Gong authored
- It was redundant to disable a network protocol option when the dropdown was already disabled if there is no connectivity or is a USB printer. Bug: 947183 Test: End to End manual, browsertests Change-Id: Iff171ad14a2db8a2911357b3aa5225d6b5ded177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748004 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#688242}
-
Mason Freed authored
The spec [1] is clear that :enabled and :disabled should *not* match link elements. Prior to this CL, links would match :enabled in Chrome, but would never match :disabled. This is obviously contrary to the spec, and it also does not match other browsers' behavior: Firefox (68), Safari (12.1), Edge (18) and IE (11) all work according to the spec. Now, neither :enabled nor :disabled match links in Chrome. [1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-enabled Bug: 993387 Change-Id: I745a314fdac720243ebf37eed4fdcf57228cc3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754509 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#688241}
-
Jazz Xu authored
Bug: 964380 Change-Id: Ifd8883adb8f93a27694046f8c13a5b89545097c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759229Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688240}
-
Gyuyoung Kim authored
This CL applies the new Mojo types into WebShare classes. - ShareServicePtr is converted to mojo::Remote<>. - mojo::Binding is converted to mojo::Receiver<>. Bug: 955171 Change-Id: Ide5d49a710e57bfcb5d99e0b590381eaa6d8450a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757961 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Kush Sinha authored
Please check the attached bug for context. Bug: 995248 Change-Id: I2e8e83fb4eb75417f106e1175e9238d645b69ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760217Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#688238}
-
David Benjamin authored
Specifying privacy_mode and load_flags separately risks the callers mixing the two up, which can corrupt the socket pool state. Indeed network_context_unittest.cc itself mixes them up. Along the way, fix the documentation which claims privacy_mode makes the connection untrackable, which is false. The only thing it does is pools it with different requests. This CL should be a no-op behavior-wise. Bug: 799935 Change-Id: Iaf770cd556d7dbfaa296abfac22c070ecc903c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752628Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#688237}
-
Hesen Zhang authored
- Change a vector of icons to small_icon and large_icon explicitly. - Wrap Skbitmap to an Icon struct for future extension. Bug: 963290 Change-Id: I6bd9459dc05e169e281659b67747a55c464e45bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758708Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688236}
-
Sergey Ulanov authored
Now all VMOs created by chromium code will have name set. This doesn't affect VMOs allocated using mmap(). Bug: 991805 Change-Id: I2a8e13bb58e1a3b9f27216c636584a92af8d2219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758842 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688235}
-
Chris Harrelson authored
Bug: 977514 Change-Id: I3c141db1860169da3064a049796bbead93f4407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760536Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688234}
-
Peter Kasting authored
This also switches to using these tints to calculate the frame (and incognito toolbar button) colors, so the two cannot get out of sync in the future. Bug: 865130 Change-Id: I386be5409589b9a7b45abadef567b1e41f593c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759292 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#688233}
-
Daniele Castagna authored
On some new chromebooks the panel is mounted with a rotation in respect to the natural orientation of the device. KMS already exposes a property on the connector that can be used to determine the orientation of the panel. This CL reads the property and passes it around that it can be read anywhere where we use DisplaySnapshots. Bug: b/139500237 b/133207693 Change-Id: I4c75221051d30f23ae5203fdf0115a10713fa3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758428Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#688232}
-
Tarun Bansal authored
Bug: 960961 Change-Id: I9cb66d13461cae042ec5626bd27b7b3633abcd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759231 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#688231}
-
Karan Bhatia authored
This CL enforces a secure extension page CSP for any extension using the "content_security_policy" dictionary key and for all manifest V3 extensions. The restrictions placed are same as those for secure isolated world CSPs. This should facilitate preventing these extensions from loading remote scripts. BUG=993530 Change-Id: I66191e7688a772eb0cf8321f09370d6dba4b0cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753470 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688230}
-
Tommy Steimel authored
This CL updates the scrollbar of the global media controls dialog to be an overlay scrollbar instead of the standard scrollbar. Bug: 991370 Change-Id: I21e78636749e2429b731c5bb4aa5b2edddc498ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758334Reviewed-by:
-
Mohamed Amir Yosef authored
This CL reports the time spent in BookmarkModelTypeProcessor::ModelReadyToSync(). This is a critical step that runs on every startup on the UI thread. It caused recent UI jank issues due to inefficient implementation. Change-Id: I0aa9e64e964e0fa49d2ca8ec0e121414859d3196 Bug: 950869,516866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760914 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688228}
-
Dominic Battre authored
This is an attempt at fixing the flakiness of a number of autofill interactive ui tests by changing the pattern from action(); wait_for_result(); to setup_waiting(); action(); wait_for_result(); The former pattern might lose some events in case action() happens to complete before wait_for_result() is called. Bug: 967588 Change-Id: I66800ed03fd27d9e6cf4be6ee53cc0f29200f21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757019Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#688227}
-
Becca Hughes authored
The close button is not accessible by ChromeVox since it is not drawn. Therefore, we should switch between a blank image and the icon. BUG=994838 Change-Id: I008b08b8620c20504806958eedeb8e26a112c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758718 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aad8cfca57fd..fd72dd0a439f git log aad8cfca57fd..fd72dd0a439f --date=short --no-merges --format='%ad %ae %s' 2019-08-19 chrisforbes@google.com Order timestamp writes correctly wrt renderer work 2019-08-19 chrisforbes@google.com Add newlines to SPIRV optimizer messages 2019-08-19 chrisforbes@google.com Add feature support check for VkPhysicalDeviceShaderDrawParametersFeatures Created with: gclient setdep -r src/third_party/swiftshader@fd72dd0a439f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:139469122,chromium:b/139528538 Change-Id: Id652973b29cd85ab5d9da970978f7ec33a50bf33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760679Reviewed-by:
-
Ken MacKay authored
https://chromium-review.googlesource.com/c/chromium/src/+/1752925 introduced an issue on mono devices without dynamic channel count enabled, where the check for valid number of postprocessor outputs would fail. Change-Id: I3d66144c50ca11cc6e90c79b318737a19c10dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761053 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
-
Clark DuVall authored
I forgot to assign the ScopedCrashKeyStrings to a variable (oops). Also adds one more crash key. Bug: 934317 Change-Id: I773ff3d65b175e9619a5fe5746a86bf952cb1cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761059 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#688223}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05137a76..0803a22a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id49355153f7eab01c11dd49bd943e2d6662ff0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760416Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688222}
-
Xinghui Lu authored
Previously, Timeout task never gets scheduled if OnGetDomFeatures() doesn't get called. Move Timeout task schedule into OnWhitelistCheckDone() to make sure it always gets called. Bug: 977719 Change-Id: I9cf5cd390f68e6f9275cf79cb8f19a9bd046001a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736517Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688221}
-
Findit authored
This reverts commit 9e12e07d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 688212 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzllMTJlMDdkMzQwZjJkZDNiY2IyYjdhMWU3MTJhYTAzMGVmODNlNWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-ozone-rel/89256 Sample Failed Step: compile Original change's description: > Refactor dependency on memory_instrumentation.mojom out of process.mojom > > Deprecates use of memory_instrumentation.mojom.GlobalMemoryDump struct > in process.mojom and ArcProcessService. Uses new struct ArcMemoryDump > instead. > > manager for Android memory footprint > > Bug: b:139190852 > Test: Build cheet_x86 and flash betty-arcnext, check Chrome OS task > Change-Id: Ib21dfcf8ab7c23dfd60573341dfdddbcb744f166 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749456 > Commit-Queue: Willie Koomson <wvk@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688212} Change-Id: I642591284693919f312d8e1af3d3713a5a5e0874 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:139190852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761229 Cr-Commit-Position: refs/heads/master@{#688220}
-
siyua authored
In SaveCardIconView, the controller should not be created every time GetController() is called with new web_content. Add a Get function. Bug:991110 Change-Id: I43817889d4f9c9b52d6a630b08813fa3309298e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754786Reviewed-by:
-
Alexander Hendrich authored
Temporarily whitelist Imprivata extensions until a WebUSB solution is ready to go (target M79/M80). Bug: 995294 Change-Id: I13266d0ead964155f19924bbab098c9529e137ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760741 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Chris Palmer authored
This enables us to re-use it for other probabilistic purposes, such as probabilistically scribbling memory on free. Bug: 984742 Change-Id: I09267647e22a0644b2aa25464f2ec135c872c89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757734Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688217}
-
Siye Liu authored
We need to reject out-of-bound ranges. Currently setting range that is outside the bounds of the text buffer in views::Textfield crashes, as Textfield uses RenderText to store the text buffer and RenderText will crash if the range is outside of the cached text buffer. Hence, we change views::Textfield::SetCompositionFromExistingText to clear the composition when the provided range is out-of-bound. Bug: 966484 Change-Id: I770457a1290ca4466b21779264e967789cbb80f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754498 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688216}
-
Tiancong Wang authored
We have been setting up orderfiles for Chrome OS for a while. We have an automatic pipeline to generate orderfiles, and an autoroller to update the version of orderfiles to the latest. Experiments show that using orderfile can bring us performance improvements by 1-3% on different Chrome OS boards. BUG=chromium:950627 TEST=The orderfile is tested on toolchain nightly tests. Change-Id: I3a6b5edf853250987168b758019de6fd2be39326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759894Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#688215}
-
Jenna Himawan authored
Bug: 814417 Change-Id: I9b9083cbbb10e8735579e64ee4a594c0afe69547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726636 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#688214}
-
Eric Roman authored
Bug: 994326 Change-Id: I199a53fa3325b7cd9d0629ccb7f0d987592f0912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756941 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
-
Willie Koomson authored
Deprecates use of memory_instrumentation.mojom.GlobalMemoryDump struct in process.mojom and ArcProcessService. Uses new struct ArcMemoryDump instead. manager for Android memory footprint Bug: b:139190852 Test: Build cheet_x86 and flash betty-arcnext, check Chrome OS task Change-Id: Ib21dfcf8ab7c23dfd60573341dfdddbcb744f166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749456 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#688212}
-
