- 20 Apr, 2018 40 commits
-
-
https://chromium.googlesource.com/angle/angle.git/+log/3ec304dba28d..5f21df8318e9 $ git log 3ec304dba..5f21df831 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 tobine Roll (1/2) LVL version forward and disable VANGLE 2018-04-19 ynovikov Use EGL_KHR_no_config_context in Android GLES backend, when available 2018-04-20 ynovikov Print more logs 2018-04-10 geofflang Refactor packed enum generation to support EGL enums. 2018-04-20 geofflang Use LIKELY and UNLIKELY macros to wrap error generation. 2018-04-20 jmadill Fix WebGL compat feedback loop null deref. 2018-04-19 tobine Make Mock ICD json file a data_dep of Mock ICD 2018-04-19 lucferron Refactor Texture::syncState to pass down the Context Created with: roll-dep src/third_party/angle BUG=chromium:609673,chromium:834943 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ifbfe7a6eec5c1771a9ecf20a9cd31f5070758588 Reviewed-on: https://chromium-review.googlesource.com/1022720Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552520}
-
Peter Kasting authored
The Create() signature change will also be useful in an upcoming test. BUG=834728 TEST=none Change-Id: I49dd07d3b3f56b9d012af9017af954eb1b62c647 Reviewed-on: https://chromium-review.googlesource.com/1020306 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#552519}
-
Kim Paulhamus authored
Bug: 819256 Change-Id: I8fb3a646ebd390530c611aa4a42db501168db62f Reviewed-on: https://chromium-review.googlesource.com/1020441 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552518}
-
Devlin Cronin authored
Manifest v1 extensions will no longer be loaded in M67. We need to update this extension to manifest v2. Update the manifest, and add a trivial browser test to at ensure the extension is properly loaded on CrOS (since it looks like we don't have any other coverage for this). Bug: 835392 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I36734dd22b85a93639cf6603841ada430b3bdf50 Reviewed-on: https://chromium-review.googlesource.com/1022258Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552517}
-
danakj authored
SharedBitmapManager is now a service-side only concept, so remove all client-side APIs. This includes the ClientSharedBitmapManager, the SharedBitmapAllocationNotifier mojo and c++ APIs, and the allocation method (and impls) in {Server,Test}SharedBitmapManager. Also removes the instance and bindings for these things from the renderer process in RenderThreadImpl, and the service-side connections in RenderProcessHost{Impl}. R=piman@chromium.org TBR=groby Bug: 730660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia976eb0e2a805c8e00803291214d346423315914 Reviewed-on: https://chromium-review.googlesource.com/1022180 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552516}
-
Sylvain Defresne authored
There are two syntaxes to declare an Objective-C block taking no arguments and returning no value (so of type void(^)()): 1. ^{ ... } or 2. ^() { ... }. The syntax 1. appears to be the most popular in the codebase with at the time of writing 11643 references while 2. only had 58. Conversion was automated with the following command: sed -i '' -e 's/\^ *() *{/^{/' $(git grep -l '\^ *() *{') Bug: none Change-Id: I4f6ccf1578342d64de8d60f4d29b4b327e6ecd6e Reviewed-on: https://chromium-review.googlesource.com/1022730Reviewed-by:Yuwei Huang <yuweih@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552515}
-
Erik Chen authored
The initial CL had a logic bug in browser_window_controller.mm that caused crashed on macOS. > This CL is a refactor with no intended behavior change. > > Previously, the method returned a raw pointer, and ownership was implicitly > passed. This CL updates the method to returned a unique_ptr. In this process of > updating all call sites, this CL also: > * Gets rid of UnloadControllerWebContentsDelegate, which added an unnecessary > layer of abstraction. FastUnloadController can directly inherit from > content::WebContentsDelegate, which removes an extraneous class. > * Updates FastUnloadController to hold WebContents waiting for deletion in a > vector of unique_ptrs. Previously, the WebContents were simply dropped on > the floor, and then UnloadControllerWebContentsDelegate would delete the > pointer it received in a callback. > * Updates DevToolsWindow to use clear ownership semantics for the > main_web_contents_. Ownership passes between DevToolsWindow and its member > browser_, based on the |is_docked_| parameter, but ownership was not being > explicitly specified. > > Change-Id: I4c21f04fe5d60a5149d79bda7b6ba3535bef2b7f > Bug: 832879 > Reviewed-on: https://chromium-review.googlesource.com/1012938 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552063} Change-Id: Ic2af1f7a8c02e923eda3cfd980d0b845d619f00d Bug: 832879 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1022750 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552514}
-
Elly Fong-Jones authored
There is special logic in ChromeCommandDispatcherDelegate's prePerformKeyEquivalent: method that handles user key equivalents for builtin browser commands. This same logic needs to happen in the Views browser, so the Views-side logic needs to consult the BrowserView's accelerator table to see if the key is bound. This involves an ungainly bridge, because it's not possible to include BrowserView and BrowserWindowController's full definitions at the same time - they have conflicting C++ and Objective-C class names in their dependencies. Bug: 834754 Change-Id: I67a62064d58cb7dba9c3bd532917ed1f90959340 Reviewed-on: https://chromium-review.googlesource.com/1022530Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552513}
-
Sylvain Defresne authored
There are two syntaxes to declare an Objective-C block taking no arguments and returning no value (so of type void(^)()): 1. ^{ ... } or 2. ^() { ... }. The syntax 1. appears to be the most popular in the codebase with at the time of writing 11643 references while 2. only had 58. Conversion was automated with the following command: sed -i '' -e 's/\^ *() *{/^{/' $(git grep -l '\^ *() *{') Bug: none Change-Id: I2c799e1931c8d87352040bc91d56a8368b17cb89 Reviewed-on: https://chromium-review.googlesource.com/1022713Reviewed-by:Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552512}
-
Xianzhu Wang authored
This avoids many extra Save/Transform(identity)/../Restore, Save/../Restore without transform. Also simplifies Save/ClipRect/Transform(identity)/Save/ClipRect/Transform/../Restore/Restore to Save/ClipRect(combined)/Transform/../Restore. This especially fixes the performance regression of perf tests containing svg images. https://pinpoint-dot-chromeperf.appspot.com/results2/16c651cec40000 shows 18% improvement of frame_time of tough_canvas_cases/rendering_throughput/bouncing_svg_images.html. Bug: 823452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4576646cbe9c59bc8a7f56b67ef59f2ad57f159d Reviewed-on: https://chromium-review.googlesource.com/1020152 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552511}
-
David Black authored
AshAssistantController needs to be cleaned up while there is still a valid Shell instance. Will do follow up CL to add unit tests. Bug: 835410 Change-Id: I44edcb86e224cb6ade956db564228eb66d5bad83 Reviewed-on: https://chromium-review.googlesource.com/1022528Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#552510}
-
Becky Zhou authored
+ Histogram of settings enabled state + Histogram of user preference enabled state + User action on clicking the preference Bug: 832914 Change-Id: Icc266929cf66fc1593bfd5f1ed3188dbcd4e7c1b Reviewed-on: https://chromium-review.googlesource.com/1015761 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552509}
-
Chris Mumford authored
Moved the leveldb::Env from the FileSystemOptions to the FileSystemContext class. With this change the FileSystemContext owns the Env and is responsible for deleting it when no longer needed. This is the first of two changes to eliminate this memory leak. The second change is to ensure that FileSystemContext is kept alive until it's backends are deleted which ensures the Env is no longer used and can be deleted. Bug: 823854 Change-Id: Ic2cfc71683e85110774fde91ce0973cd93dd970e Reviewed-on: https://chromium-review.googlesource.com/971941 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#552508}
-
Wenzhao Zang authored
This is a reland of e88248f6 The original CL makes a test flaky. (crbug.com/835242) The detailed failure reason is, in the refactored code, saving the wallpaper file does not (and should not) block the response to the wallpaper picker renderer, so the test fails when the file saving operation hasn't completed. Since the CL moved the implementation to //ash, that test should ideally be deleted since //ash already has the same test coverage. Original change's description: > mash: Remove //ash dependency in wallpaper_private_api.cc > > We need this because: > 1) Mustash requires all //ash dependency except //ash/public to be > removed from //chrome. > 2) Currently saving and retrieving online wallpapers are handled > separately in //chrome and //ash, and it has duplicate logic in the > path calculation. > 3) Currently wallpaper_private_api.cc is responsible for saving online > wallpapers, so it defeats the goal of making wallpaper paths > internal to //ash. > > Also fixed a bug: on Linux build, online wallpaper is lost at login > screen. > > Bug: 827062 > Change-Id: I0d3ea5daf537db6e189c7a8b2ede469521e9dcbf > Reviewed-on: https://chromium-review.googlesource.com/1013211 > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552244} TBR=xdai@chromium.org, sammc@chromium.org Bug: 827062 Change-Id: I6cef49c2f17048e8412e1006088ab1ccb32c2f9b Reviewed-on: https://chromium-review.googlesource.com/1022431Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552507}
-
Siddhartha authored
If a page does not have any favicon, do not try to fetch an icon from large icon bridge and wait for callback to update the notification icon. We know if the page has favicon or not by tracking if onFaviconUpdated was ever called. BUG=827602 Change-Id: I3356470ca7088871540360621ee3140a3304621b Reviewed-on: https://chromium-review.googlesource.com/1000314Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#552506}
-
crystallambert@chromium.org authored
Get started tutorial code snippet was causing an error. This update corrects this issue on tutorial page and completed file. Bug: 834614 Change-Id: Ia3d61ef1510383b3b278ac957deeab047142fcd9 Reviewed-on: https://chromium-review.googlesource.com/1022950Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#552505}
-
Bence Béky authored
Factor out "https://www.example.org/foo.dat" to a file scope constant in spdy_network_transaction_unittest.cc. Change-Id: I1fdb9d848d8213f8b3aa48e546370441e3d2e166 Reviewed-on: https://chromium-review.googlesource.com/1022293 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#552504}
-
Jao-ke Chin-Lee authored
Bug: 731555 Change-Id: I89002781928761b392645153658f90fb9f6f4ba9 Reviewed-on: https://chromium-review.googlesource.com/1022117Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#552503}
-
John Chen authored
This reverts commit ac6125e4. Reason for revert: This change completely broke ChromeDriver for users who run multiple instances of ChromeDriver. The seed for the new random number generator can easily lead to same seed used by multiple processes. Original change's description: > RandUtil: Add Mersene Twister Enginer to thread's local storage to avoid > the overhead associated with seeding the generator. > > One can do ~18 M (~26 M) calls per second when using > unifom_int_distribution on top of Mersene engine versus <1M (~ 8M) calls > per second when using the current implementation on POSIX and Windows, > respectively. > > Note that these figures are obtained when the generator is seeded once, > otherwise the figure obtained for the suggested implementation would > be <1M (this is for POSIX, we don't have the figure for windows). > To that end, we use thread's local storage to seed the generator once. > > Change-Id: I628d2e0ab882a9703e52b4007d53fa5cf49d4d47 > Reviewed-on: https://chromium-review.googlesource.com/982115 > Commit-Queue: Farah Charab <farahcharab@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550496} TBR=gab@chromium.org,altimin@chromium.org,farahcharab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I999423e955aa163c3863297ea9c81575a2ce8066 Reviewed-on: https://chromium-review.googlesource.com/1022250Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552502}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/263de54c..6b76faea Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If710e264a4a418e26980fbda2011728cd810adff Reviewed-on: https://chromium-review.googlesource.com/1021912Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552501}
-
chrome://flagsRoger McFarlane authored
Bug: 824834 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia1ad9ddf170cd3b20f735d04074b3101023a3d05 Reviewed-on: https://chromium-review.googlesource.com/1021681 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#552500}
-
James Cook authored
The old code was reaching into ash to get the shelf alignment. This won't work with out-of-process ash (see //ash/README.md). Convert to using ash/public/cpp and profile pref. This enables the first run browser_tests under mash. Bug: 770866, 756057 Test: browser_tests --enable-features=Mash Change-Id: I43b202ef255301f637593e24a588a42bacdc7fff Reviewed-on: https://chromium-review.googlesource.com/1022523Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#552499}
-
Jordy Greenblatt authored
Bug: 835388 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I85a4f50b315dc37769d762a2de2d6e5f15a33261 Reviewed-on: https://chromium-review.googlesource.com/1022390 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#552498}
-
Charlie Harrison authored
This CL adds four new metrics: - Logs an isolated/non-isolated bit per request - Logs real-delay per request - Logs the expected delay per request - Logs the queueing (i.e. unexpected) delay per request Bug: 829042 Change-Id: Id31f3e062cda0f9b644466eb06be21b471a80d4e Reviewed-on: https://chromium-review.googlesource.com/1021913Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#552497}
-
Devlin Cronin authored
The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is unpredictable and can return surprising values in certain circumstances. It is deprecated and should be removed to ensure that callers are using the WebContents they expect. Update the bookmarks-related APIs (bookmarks and bookmarkManagerPrivate) to use GetSenderWebContents() instead. Bug: 461394 Change-Id: Ie65a5bca0a029946175ae38e75bdc0a4213dbadc Reviewed-on: https://chromium-review.googlesource.com/1022115Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552496}
-
Bence Béky authored
Also write parametrized unittest to cover new functionality as well as a number of existing test cases. Bug: 554220 Change-Id: Ib26b842e87bda13fe72f2a2a8fbf35e3d3580673 Reviewed-on: https://chromium-review.googlesource.com/1022292Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#552495}
-
Tommy C. Li authored
Updates the background color of Omnibox in Material Refresh. Only affects behavior when Touchable or MD Refresh flag is on. Bug: 823535 Change-Id: I2bf12f72011d78855edc51207f078128d9181aed Reviewed-on: https://chromium-review.googlesource.com/1019735Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552494}
-
David Black authored
Per offline discussion w/ dcheng@, initial security concerns have been satisfied. Change-Id: I7915b78ce1e7d137bf0476482769822a60ffc6a9 Reviewed-on: https://chromium-review.googlesource.com/1022712Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#552493}
-
Lei Zhang authored
This effectively reverts one file in r551457 which was confusing. Add a comment to explain what is going on. BUG=834172 Change-Id: I27279382d1b6bbc08688a31a3dc308a791bbc37f Reviewed-on: https://chromium-review.googlesource.com/1020068Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#552492}
-
Ken Rockot authored
Migrates from the deprecated thing to the not-deprecated thing. Bug: 799482 Change-Id: Ic77e6a450de3b2deb03009c5d7eea17550504757 Reviewed-on: https://chromium-review.googlesource.com/999307 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#552491}
-
Peter Kasting authored
This can happen legitimately (after thinking through it, I decided that trying to prevent it would cause more potential bugs than it would solve), and in this case, the InfoBarView has no parent. Null-check before dereffing parent(). This is a minimal patch to make it suitable for merging to the M67 branch; a unittest is coming separately. BUG=834728 TEST=none Change-Id: I1061f3a21be18f41a106098cfbc12a4c7d15b61e Reviewed-on: https://chromium-review.googlesource.com/1019877Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#552490}
-
Xiaohan Wang authored
- Roll src/media/cdm/api/ 57e20546b..163f87884 (1 commit) 2018-04-17 xhwang cdm: Add CDM_11 interface - Add CDM_11 support. But since the interface is still in development the support is not enabled by default. - Update CDM_10 implementation to adapt to the interface change that RequestCdmProxy() has been removed. CDM_10 support is not enabled by default yet. - Update browser_tests to run tests using CDM_11. Bug: 733821 Change-Id: Id0c51468f1d426bb7445398862e8f8ffedad34a7 Reviewed-on: https://chromium-review.googlesource.com/1020881Reviewed-by:John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552489}
-
Miguel Casas authored
This reverts commit 5e1aa79b. Reason for revert: broke some tests, see https://crbug.com/835379 Bug:835379 Original change's description: > ShapeDetection: Parse landmarks of the detected face on Mac Vision > > Update the mojom interface definition of landmark to match the Spec, and adjust > the usage in services/blink/LayoutTests. > Export eyes and mouth landmarks that detect with Mac Vision Framework, the points > are normalized to the bounding box of the detected face, with the origin at the > bounding box of the detected face's lower-left corner. > > Link Mac 10.13 build bots [1] and Face Detection demo[2] here. > > [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/ > [2] https://codepen.io/miguelao/pen/PmJWro > > BUG=799319 > > Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng > Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80 > Reviewed-on: https://chromium-review.googlesource.com/982579 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Junwei Fu <junwei.fu@intel.com> > Cr-Commit-Position: refs/heads/master@{#552217} TBR=dcheng@chromium.org,reillyg@chromium.org,mcasas@chromium.org,junwei.fu@intel.com,mark@chromium.org Change-Id: Ia6de675508ad324e12b4b9e98ae510b12d06b672 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799319 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1022891Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#552488}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/be5df6080154..3b460db214b5 $ git log be5df6080..3b460db21 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 martin configure: Use both check_header and check_lib for pthreads 2018-04-18 marpan vp9:aq-mode=3: Keep perc_refresh fixed for screen content mode. 2018-04-18 marpan vp9: Add condition of real-time mode to scene detection. 2018-04-18 marpan vp9: Rate control fix for CBR mode. 2018-04-18 marpan vp9: Remove limit on QP on key frame for CBR. 2018-04-16 jianj SVC: Fix duplicated run of svc datarate tests. 2018-04-16 marpan vp9: Changes for scene detection overshoot and SVC. 2018-04-17 linfengz Update variance avx2 functions 2018-04-17 marpan vp9: Remove this_key_frame_forced setting for CBR. 2018-04-16 linfengz Update variance sse2 functions 2018-04-16 jianj vp9: fix multiple run for vp9 datarate tests using one bitrate. 2018-04-14 martin configure: Test linking pthreads before using it 2018-04-12 jianj vp9: refactor vp9 datarate test for better sharding. 2018-04-13 jianj Clean up is_two_pass_svc. 2018-04-13 jianj Clean up svc comment in vp9_bitstream.c 2018-04-12 jianj Silence warning when built with --enable-internal-stats. 2018-04-11 jianj vp9 svc: Refactor svc datarate test for better sharding. 2018-04-09 jzern vpx_image: remove unused image formats 2018-03-29 paulwilkins Add extra case to wq_err_divisor() Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I1a128f710a06e272100a7e96288022f9580ca5a3 Reviewed-on: https://chromium-review.googlesource.com/1022114Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#552487}
-
Fabrice de Gans-Riberi authored
This is a preliminary change to remove the posix source exclusion filter in a future commit. Bug: 835405 Change-Id: I62942475e2e3b14c1fb94623213ad9b36307b5a0 Reviewed-on: https://chromium-review.googlesource.com/1022310 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#552486}
-
Sylvain Defresne authored
There are two syntaxes to declare an Objective-C block taking no arguments and returning no value (so of type void(^)()): 1. ^{ ... } or 2. ^() { ... }. The syntax 1. appears to be the most popular in the codebase with at the time of writing 11643 references while 2. only had 58. Conversion was automated with the following command: sed -i '' -e 's/\^ *() *{/^{/' $(git grep -l '\^ *() *{') Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib5c609989af96a145e593c9747af041e4c175f2d Reviewed-on: https://chromium-review.googlesource.com/1022714Reviewed-by:Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552485}
-
Stephen Martinis authored
This reverts commit c24c2363. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1018590 broke webkit Original change's description: > Reland "Only retry failed tests for layout tests" > > This reverts commit 23ea7f24. > > Reason for revert: Issue fixed > > Original change's description: > > Revert "Only retry failed tests for layout tests" > > > > This reverts commit ecb97ada. > > > > Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid > > > > Original change's description: > > > Only retry failed tests for layout tests > > > > > > Recently layout tests have been fairly flaky; this is causing extra load > > > on the CQ. Every time layout tests fails, they are retried without patch > > > to determine if the failure is a flake or a failure at tip of tree. This > > > means that layout tests are running more than other test suites, and > > > since layout tests take a long time to run, we end up consuming more > > > capacity from our swarming pool than we should. > > > > > > Isolated script tests don't have the ability to retry only the tests > > > that failed, which is what other test suites do. This CL changes that so > > > that layout tests, when re-run without the patch, retry on the tests that > > > fail, which should significantly reduce swarming load and cycle time for > > > running layout tests without patch. > > > > > > Bug: 533481 > > > Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423 > > > Reviewed-on: https://chromium-review.googlesource.com/1015843 > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#551821} > > > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > > > Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 533481 > > Reviewed-on: https://chromium-review.googlesource.com/1018161 > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551877} > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 533481 > Change-Id: If8c572258d9ed3abc020bc5bad56d1b06107ee0f > Reviewed-on: https://chromium-review.googlesource.com/1022552 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552482} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: Ibd7819d1adb43895e33b74622438aa61517a036d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 533481 Reviewed-on: https://chromium-review.googlesource.com/1022558Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#552484}
-
Sylvain Defresne authored
The function was only ever called with a block wrapped into a base::Closure via base::BindBlockArc, so change the function to take a block directly and create the closure internally. Rename the function to RunBlockOnIOThread to reflect its new prototype. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I42fd666f51b21a345d99b866d72984fcb2292cca Reviewed-on: https://chromium-review.googlesource.com/1020455 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#552483}
-
Stephen Martinis authored
This reverts commit 23ea7f24. Reason for revert: Issue fixed Original change's description: > Revert "Only retry failed tests for layout tests" > > This reverts commit ecb97ada. > > Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid > > Original change's description: > > Only retry failed tests for layout tests > > > > Recently layout tests have been fairly flaky; this is causing extra load > > on the CQ. Every time layout tests fails, they are retried without patch > > to determine if the failure is a flake or a failure at tip of tree. This > > means that layout tests are running more than other test suites, and > > since layout tests take a long time to run, we end up consuming more > > capacity from our swarming pool than we should. > > > > Isolated script tests don't have the ability to retry only the tests > > that failed, which is what other test suites do. This CL changes that so > > that layout tests, when re-run without the patch, retry on the tests that > > fail, which should significantly reduce swarming load and cycle time for > > running layout tests without patch. > > > > Bug: 533481 > > Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423 > > Reviewed-on: https://chromium-review.googlesource.com/1015843 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551821} > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 533481 > Reviewed-on: https://chromium-review.googlesource.com/1018161 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551877} TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 533481 Change-Id: If8c572258d9ed3abc020bc5bad56d1b06107ee0f Reviewed-on: https://chromium-review.googlesource.com/1022552Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#552482}
-
Min Qin authored
Once download becomes a service, Chrome needs to start download without content::DownloadManager. Split some DownloadManager functionalities into InProgressDownloadManager. The InProgressDownloadManager will manage the InProgressCache, and own the UrlDownloadHandlers. This CL moves the regular URL download and navigation interception logic into InProgressDownloadManager, so that InProgressDownloadManager now owns the UrlDownloadHandlers. BUG=803135 Change-Id: I97c81b9f9f3d88d5823fe8b94456e5b4d033a029 Reviewed-on: https://chromium-review.googlesource.com/1012987Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552481}
-