- 23 Jun, 2020 40 commits
-
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/2eba343b51..10cb35e459 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/2eba343b51..10cb35e459 Bug: None Change-Id: I71dc1be758e46f2ca522308fd57cd6349540bac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259856Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#781284}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7acac32cb402..d69e945fe7dd 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in security/mainView.css 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in security/sidebar.css 2020-06-23 bmeurer@chromium.org [third_party] Roll wasmparser 2.2.5 2020-06-23 mathias@chromium.org Add stylelint-config-standard dependency 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in security/lockIcon.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432,chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0d5773ea1d6202b3d10ce13286dbe8cffa36eec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781283}
-
Omid Tourzan authored
Update the background to use semantic color. This doesn't change the currently supported light color scheme but makes it compatible to some of the texts (like banner and dialog) that use semantic colors, so they will be visible when testing dark color scheme. Also updating the file label color to semantic one for the same purpose. Bug: 1096951 Change-Id: I8d891181784b0bdac4c9430355738281d4938296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251642 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781282}
-
Andrew Walbran authored
This matches the threshold applied on other platforms in ValueToButton. Also set the touched state for all non-zero values, and fix a typo in the comments. BUG=1073130 Change-Id: Ied8db827b098c95b6a697f1df8a940de1a501166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245484Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andrew Walbran <qwandor@google.com> Cr-Commit-Position: refs/heads/master@{#781281}
-
Yoshifumi Inoue authored
This patch changes |NGBlockLayoutAlgorithm::Layout()| to calculate baseline offset for empty line then set it |NGPhysicalBoxFragment| to allow flex layout algorithm to use valid baseline offset, e.g. "align-items: baseline" CSS property. This patch also introduces |LayoutBlock::BaselineForEmptyLine()| to share baseline offset calculation with legacy latyout. Note: The test[1][2] verify this change. [1] third_party/blink/web_tests/css3/flexbox/baseline-for-empty-line.html [2] third_party/blink/web_tests/inline-block/contenteditable-baseline.html Bug: 707656 Change-Id: I2a19fb3e457925c03b34ee509b80ba15dff523b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259675 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781280}
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: Ie039b080b8c76fa29dfd5b52f5f1135ed53a40b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259535 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781279}
-
Mohammed Abdon authored
Install extension, Sets the change-password page to an embedded test server, then simulates submitting a password-change form to that server, and redirects to URL to simulate what happens in IdPs page. Bug: 1080626 Change-Id: I18db071dc318d0910f7b41da97c34b79c72c3d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255471 Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781278}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I85ed36c1dd1805d66a2c473ab4598e3d1a06e5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259144Reviewed-by:
-
Nohemi Fernandez authored
Feature ClearSyncedData has been enabled by default. Clean up code. Bug: 1005509 Change-Id: I8eaea684e754afda13bcde2134e4fa5e2434c9ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260193 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781276}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iab08bacb8fb8e05871268751f5611b08ab4d6a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259731Reviewed-by:
-
Henrique Ferreiro authored
Ozone's cursor factories load and cache Chrome provided image assets when a default platform cursor isn't available. This CL moves that responsibility to CursorLoader, which was already doing this for image cursors loaded through that class. Additionally, apply the proper scaling to the fallback cursors. Now, CursorFactory will only handle the creation of image cursors and loading of default platform cursors (e.g. X11 cursors). This also reduces their dependency on //ui/base/cursor, a step into moving ownership of CursorFactory to CursorLoader. Bug: 1029142, 1054278 Change-Id: Ic4387deabf3a628133fc3db3af3860b3a08872ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252342 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#781274}
-
Scott Violet authored
BUG=none TEST=none Change-Id: If82677ec23c81f8051a86a9286c6b64e34d7a22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255309 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
The latest rewrite attempt revealed a couple more classes of compiler errors, that would be hard to handle automatically in the rewriter. Bug: 1069567 Change-Id: I844bd3f6bd8e562b8869702bfc55002557254580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255920 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Vidhan authored
boxes This CL introduces the functionality for detecting and filling of the <select> fields, having options consisting of the phone country code along with an additional text. Also, sending votes for the server classification. Bug: 1081219 Change-Id: I00ee0125d457abadf4f59fb16b3850e27274006b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198785Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#781271}
-
Stepan Khapugin authored
The bug is happening because we call -[UIApplication requestSceneSessionRefresh:] in non-scene lifecycle, therefore the passed argument is nil, which hits an assert in iOS. Bug: 1097916 Change-Id: I7872ad45dcce89e8c6750bb7c0f60036154e8b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260232 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#781270}
-
Koji Ishii authored
This patch moves the ownership of |NGLogicalLineItems| from |NGInlineLayoutAlgorithm| to |NGInlineChildLayoutContext|. This change: * Avoids moving |NGLogicalLineItems| to |NGFragmentItemsBuilder|. |NGLogicalLineItems| has an inline size that moving is more expensive than regular |Vector|. * Can reuse the buffer (if expanded) for the next line. Also, when clearing |NGLogicalLineItems|, make sure it doesn't release the allocated buffer. Bug: 982194 Change-Id: I8fa2416769618823876cd2a2669208e60623faeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259755 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781269}
-
Yoshifumi Inoue authored
This patch changes "paste-text-at-tabspan-003.html" to utilize |selection_test| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I04fe69c24cbbd3d783331ab6c101c54f487e0bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259736 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "insert-text-at-tabspan-003.html" to utilize |selection_test| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I2cdf61e03341f0cb9417992f86c049115538548d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259875 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Instead of reading data pipes using a watcher in ScriptResource and synchronously in ScriptStreamer, instead move all datapipe reading logic to ScriptStreamer (and StreamingSource). Also, given that we always start streaming for ScriptResources that allow streaming (i.e. stream-on-preload is enabled by default), we can remove the complexity around allowing streaming to be started later. This has several consequences: * A ScriptStreamer is created exactly when a ScriptResource that can stream receives a data pipe. * The ScriptStreamer is aware of the data pipe load completing, so it no longer needs to rely on signals from ScriptResource. * Thus, the ScriptStreamer can send a single callback back to ScriptResource (via the response body loader client callbacks) to signify both loading and streaming completed. * Thus, the ScriptResource can assume that NotifyFinished means that streaming has completed (or should be cancelled), and never needs to suppress the base NotifyFinished call. * The ScriptStreamer only needs the ScriptResource to read its data buffer, so if it were to keep its own copy of incoming data it wouldn't need the ScriptResource at all (useful for making streaming decisions on the background thread in the future). Bug: 891637 Change-Id: I0c66497ea7f550921397995b6ab6dcde70506f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530907Reviewed-by:Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#781266}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/758d13cf2772..3d01eda10798 2020-06-23 dberris@chromium.org pinpoint: Use git_hash instead of commit 2020-06-23 dberris@chromium.org pinpoint: Rotate the y-axis title If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: If169c5cd6b5bf31099ee10b07c64c848281a2c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259730Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/008ec94fc147..7acac32cb402 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in console/consoleView.css 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in components/jsUtils.css 2020-06-23 bmeurer@chromium.org [CXXDWARFSymbols] Roll new version of LLVM. 2020-06-23 bmeurer@chromium.org [wasm] Remove stale comments about bytecode offsets. 2020-06-23 szuend@chromium.org Fix stylelint-config-standard issues in console/consolePrompt.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1043047,chromium:1083142,chromium:1083146 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I58633f5c903d67b759de62c82aeeb734a09eca32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260112Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "hit-test-on-text-with-line-height.html" to utilize |selection_test| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I1dfb8994fe43f080017242a30abc5e6748184f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260153 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Ramin Halavati authored
For better readability Profile::IsSameProfile() is renamed to IsSameOrParent(). This CL does not modify any behavior. Bug: 1033903 Change-Id: Ic8a2007699faae4baecf4f01cb384a9c74fcb488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218108 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#781262}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9daab8cbffb7..ea15439b6b92 2020-06-23 syoussefi@chromium.org Add mipmap generation perf test for emulated formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Iea4d7541208a464d679b6bf16ee8b08ccbe084e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259446Reviewed-by:
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: Ib3b0749032a3d34baea5eca8f4a4724552242c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257123 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
Currently, all icons for Web App kiosks are being loaded automatically during browser startup, meaning that decoding hapens unconditionally. Now, the load will start only after kiosk app menu is being clicked at. Bug: 1066496 Change-Id: Id6cd7e247c35636792c2e39ef6650582f21a9ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128140 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781259}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 49fb0fdf. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mustaq@chromium.org: external/wpt/html/interaction/focus NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I9d69547dac6ab345d229d550d4755307232429ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259556Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781258}
-
David Munro authored
Test: CQ Bug: chromium:1064512 Change-Id: Ie504706d4bb900638ba4ba4772dec7cfa79b8fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259752 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#781257}
-
Oleh Lamzin authored
Move browser test related target to test/BUILD.gn file. Bug: b:158566609 Change-Id: I9ba8a796fd77b3286fca4a04bc88ae30b8022821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244212 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#781256}
-
Nohemi Fernandez authored
The feature has been launched to 100% stable. Enable by default. Bug: 1005509 Change-Id: I62051ded200e047901cf376c11e5c944b6c07c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257325 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#781255}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c969abf14f2f..62f76f09dd6f 2020-06-23 primiano@google.com Docs: fix typo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7fae0c2cf83d569b611608a0e20995da14951c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259729Reviewed-by:
-
Clemens Arbesser authored
This is a reland of ae61a59a I reproduced the build failure and added the missing include. Original change's description: > [Autofill Assistant] Added ForEach interaction. > > Note: this is an alternative solution for http://crrev/c/2235698 > > This interaction executes a number of callbacks for the input loop value. This is intended to be used to inflate UI elements for client-only values, i.e., for values that the backend can't specify. > > Internally, ForEach loops are implemented by introducing the concept of callback contexts, which will change value and view lookup accordingly. > > In particular, callback contexts are used to automatically replace placeholders of the form ${i} in value and view identifiers (where 'i' is the loop identifier). This allows creating and referencing values and views with templated names, such as "created_view_${i}" and "value[${i}]". > > Bug: b/145043394 > Change-Id: I53089252fe1cc14b2b1fb74cfc56d7314bc4b37c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241975 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Marian Fechete <marianfe@google.com> > Cr-Commit-Position: refs/heads/master@{#780785} Bug: b/145043394 Change-Id: I36b64f8d5a64f66f9e9081137a61a20c31ade8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259847Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#781253}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592884413-6b42064f372939c6b2068eeb31d6b96cefc4be86.profdata to chrome-win32-master-1592887944-a5350dcd6f0f1194a03615a841b47284864b512a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id94bb540bab9e4b7eb1df6b6a753fce131918919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259604Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ifb68d5f797e5d3fc41d5433795548fe523e7194c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259728Reviewed-by:
-
Ramin Halavati authored
CanOpenBrowser used IsOffTheRecordProfile instead of IsIncognitoProfile, applying incognito policy selections on all OTR profiles. It's now updated to only affect incognito. Bug: 1033903, 968028 Change-Id: I889cbbcacfe2fb0a42c81debc6d738487e1fdd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249932Reviewed-by:
-
Christian Dullweber authored
When a user grants a permission in regular mode, we replace the ALLOW content settings with an ASK setting in incognito mode. These settings should not be shown in the UI if ASK is the default setting. The current behavior also fails an assert in PermissionParamsListBuilder::createPermissionParams, which is fixed by this CL. Bug: 1092809 Change-Id: Ic74f77cca11b6d3ff0839e6f908002cf76838c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235822Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#781249}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d4b9f576ebb4..36b5bb701da9 2020-06-22 rharrison@google.com Add support for different default/trunks in roll-deps (#3442) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I23d5602369caa2848e1a53844a0c852828155426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259605Reviewed-by:
-
Vikas Soni authored
Metric to record whether an aggregated frame has video or not. Bug: 1085628 Change-Id: I08dca785bd664e92208a1943142acf7c597bde82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252618 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#781247}
-
Mikel Astiz authored
The whole get_commit_ids.h file is going away and hence integration-like tests in SyncerTest can be deleted. Change-Id: Ic9cedcf88cd4d9e517742413f7bccc9a0dc7cbd4 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257188Reviewed-by:
-
Christoph Schwering authored
This CL adds a left margin of 8px. Bug: 1095904 Change-Id: I77a797ddabe5639190f1133065ffc628b7b4b44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257853Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#781245}
-
