- 07 Apr, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7d3d87233190..4e3abc1ad5f0 $ git log 7d3d87233..4e3abc1ad --date=short --no-merges --format='%ad %ae %s' 2017-04-07 reed cacherator upscales colortables to unify caching 2017-04-03 halcanary SkMultiPictureDocument : clean up MultiPictureDocumentReader interface 2017-04-07 robertphillips Make GrCopySurfaceOp friendlier to GrSurfaceProxy (take 2) 2017-04-07 scroggo Simplify subset computation in SkGifImageReader 2017-04-06 mtklein stop disabling threadsafe statics 2017-04-07 borenet Fix missing valgrind.supp in recipe-bundled tasks 2017-04-07 kjlubick Add ChromeOS Test/Perf jobs and recipe changes 2017-04-06 halcanary SkTypeface_win_dw: populate_glyph_to_unicode uses lowest unichar 2017-04-06 mtklein simplify SkRRect serialization 2017-04-06 mtklein Try disabling MSAN workarounds in SkJpegCodec 2017-04-07 borenet Reland: Use bundled recipes for all test/perf tasks 2017-04-06 mtklein jumper, gather_f16 Created with: roll-dep src/third_party/skia BUG=538133 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I31295c32b1fde854b28bc400f41c82c3c9bfe307 Reviewed-on: https://chromium-review.googlesource.com/471049Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#462950}
-
dgozman authored
We have a few users of it, which are better to use underlying models. We also have a log of SDKObject's like classes which do not inherit from SDKObject - that means this abstraction doesn't really work. As a bonus, we only inherit from Common.Object when necessary, reducing the overhead. BUG=none Review-Url: https://codereview.chromium.org/2801943003 Cr-Commit-Position: refs/heads/master@{#462949}
-
meacer authored
Content-initiated main-frame navigations to data URLs are being blocked in crbug.com/594215. After crrev.com/2702503002 lands, these test will stop working because they navigate to data URLs. The fix is to change the data URLs in these tests to HTTP urls, but doing that causes the tests to fail more often -- they start to fail on Windows. I investigated the failures and can't see a good way of fixing them (https://crbug.com/703727#c8) so I'm disabling them in the meanwhile. BUG=594215 Review-Url: https://codereview.chromium.org/2803813002 Cr-Commit-Position: refs/heads/master@{#462948}
-
rhalavati authored
Test Network traffic annotation tag is added to network requests of unittest in chrome/browser/*. BUG=656607 Review-Url: https://codereview.chromium.org/2804023003 Cr-Commit-Position: refs/heads/master@{#462947}
-
juncai authored
This is a follow-up CL for: https://codereview.chromium.org/2785383002/diff/80001/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc This CL added some test characteristic and descriptor UUIDs to bluetooth_test.h and updated device bluetooth unit tests to use them. BUG=None Review-Url: https://codereview.chromium.org/2798193002 Cr-Commit-Position: refs/heads/master@{#462946}
-
dougt authored
In Jan 20015, this test case on a ASAN run caused timeouts. An exception was added and life moved on. Re-running this tests locally does not appear to cause any timeout, and so we're going to re-enable the exception to see if there still exists a problem. BUG=446661 Review-Url: https://codereview.chromium.org/2799743007 Cr-Commit-Position: refs/heads/master@{#462945}
-
pkasting authored
This removes the forced Google URL re-check on a profile reset. The old behavior was added to correct cases where users said "no" to a server request to use a new TLD. Nowadays we don't prompt about this, so users can't be stuck on "the wrong" server. BUG=244291 TEST=none Review-Url: https://codereview.chromium.org/2799083003 Cr-Commit-Position: refs/heads/master@{#462944}
-
juliatuttle authored
Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This wraps the context in a service that keeps the implementation details of Reporting private while implementing and exposing the high-level operations that other components require from it. BUG=704259 Review-Url: https://codereview.chromium.org/2770443002 Cr-Commit-Position: refs/heads/master@{#462943}
-
zijiehe authored
After discussing in http://crbug.com/702251, we decide to enable browser shortcuts when the tab-strip / toolbar is visible on Mac OS. There is no comparable behavior on other platforms. This change adds a BrowserWindow::IsToolbarShowing() function to indicate whether the toolbar is showing up on the screen. BrowserWindowCocoa needs to override this function, which has not been done yet in this change. BUG=680809, 702251 Review-Url: https://codereview.chromium.org/2781633003 Cr-Commit-Position: refs/heads/master@{#462942}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c5350347..ef8c92ef Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2807573002 Cr-Commit-Position: refs/heads/master@{#462941}
-
hongchan authored
As a first step of ASSERT removal from modules/webaudio, this CL removes all DCHECK_IS_ON() condition check from isGraphOwner() and put the check inside of the method. The method is only used inside of DCHECK() so it must be no-op in the release build. That is why it returns false, so we can catch the anomaly when it happens. BUG=707643 Review-Url: https://codereview.chromium.org/2805823003 Cr-Commit-Position: refs/heads/master@{#462940}
-
schenney authored
The test is slower than slow. TBR=ellyjones@chromium.org BUG=709009 Review-Url: https://codereview.chromium.org/2806743002 Cr-Commit-Position: refs/heads/master@{#462939}
-
qyearsley authored
This change was made automatically with update-test-expectations. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media/autoplay-muted.html,http/tests/inspector/service-workers/service-worker-manager.html,fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html,http/tests/inspector/resource-tree/resource-tree-non-unique-url.html,http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/inspector-enabled/console-stack-overflow-source-url.html,virtual/mojo-loading/http/tests/security/link-crossorigin-preload-no-cors.html,http/tests/inspector/tracing/timeline-script-parse.html,http/tests/media/media-source/mediasource-seek-beyond-duration.html,virtual/mojo-loading/http/tests/media/media-source/mediasource-seek-beyond-duration.html,external/wpt/fetch/api/redirect/redirect-location-worker.html,external/wpt/fetch/api/redirect/redirect-location.html,external/wpt/fetch/api/redirect/redirect-origin-worker.html,external/wpt/fetch/api/request/request-cache-default-conditional.html,external/wpt/service-workers/service-worker/registration-iframe.https.html BUG=691045,564403,651343,581468,666628,664839,678489,678490,705490,697087 Review-Url: https://codereview.chromium.org/2800123002 Cr-Commit-Position: refs/heads/master@{#462938}
-
jkrcal authored
This CL allows to set different intervals for soft fetches for wifi and fallback connections. This puts soft fetches on par to persistent fetches with respect to parameters. Previously we prioritized soft fetches triggered by NTP_OPENED. This feature is removed by this CL for the sake of simplicity (NTP_OPENED is the only trigger that we employ on M57 Stable). BUG=708146 Review-Url: https://codereview.chromium.org/2794313002 Cr-Commit-Position: refs/heads/master@{#462937}
-
lukasza authored
BUG=702300 TBR=lazyboy@chromium.org Review-Url: https://codereview.chromium.org/2805443005 Cr-Commit-Position: refs/heads/master@{#462936}
-
fsamuel authored
cc::Surface and SurfaceDependencyTracker used CompositorFrameMetadata's referenced_surfaces to determine dependencies of a CompositorFrame. This causes issues when referenced_surfaces contains surface IDs of hidden windows. Hidden windows do not generate CompositorFrames and so the parent CompositorFrame would block for four BeginFrames waiting for a child CompositorFrame that would never arrive. This effectively reduced the frame rate from 60fps to 15fps. This CL addresses this issue by introducing an embedded_surfaces set in CompositorFrameMetadata that only refers to surface IDs for which SurfaceDrawQuads were generated and thus will be visually present in the frame. In a subsequent CL, referenced_surfaces will be renamed to retained_surfaces and will only contain the set of surface IDs to which the parent wishes to retain the corresponding surfaces but does not embed them in SurfaceDrawQuads. Once generalized frame eviction is complete, we can drop the retained_surfaces field all together. BUG=672962 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2803913004 Cr-Commit-Position: refs/heads/master@{#462935}
-
bsheedy authored
Tests that the device capabilities reported by WebVR match expectations, although currently all tested devices have the same expectations. Automates one of our manual test cases. BUG=702700 Review-Url: https://codereview.chromium.org/2794383002 Cr-Commit-Position: refs/heads/master@{#462934}
-
mkwst authored
Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AqSrOMzwrlk/wUglQnTJCgAJ BUG=680970 Review-Url: https://codereview.chromium.org/2794303002 Cr-Commit-Position: refs/heads/master@{#462933}
-
liaoyuke authored
The original logic in |AddPendingItem| does nothing if the URL of the pending item is the same as the last committed item, except that the pending item is added due to form submission. However, this doesn't work with the new Request Desktop/Mobile Site because the new functionality requires adding a pending item with the same URL, but different UserAgentType. This CL re-factors |AddPendingItem| so that a pending item with the same URL can be added successfully as long as the UserAgentOverrideOption is not INHEIRT. This CL also adds corresponding unit tests to test the logic. BUG=678047 Review-Url: https://codereview.chromium.org/2794723002 Cr-Commit-Position: refs/heads/master@{#462932}
-
dfalcantara authored
* It's technically infeasible to assume that the search box can animate to the correct location all the time. Instead, just remove all of this code and keep it simple. * Since we're allowed to add resources now, move most initialization of the SearchActivity layout to XML. * Make the SearchActivity's LocationBarLayout inherit from the LocationBarPhone, instead. That's how it behaves anyway. * Makes the Omnibox full bleed like UX requested. BUG=708844 SCREENSHOTS=https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDdGF1NVo3ZWptTzQ Review-Url: https://codereview.chromium.org/2799783003 Cr-Commit-Position: refs/heads/master@{#462931}
-
tsergeant authored
This fixes an issue where the menu would appear blank in MD Downloads and Bookmarks. BUG=708892 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2804623005 Cr-Commit-Position: refs/heads/master@{#462930}
-
xhwang authored
Implement MediaDrmStorageImpl using PrefService. TBR=sdefresne@chromium.org BUG=493521 TEST=New unit tests added. Review-Url: https://codereview.chromium.org/2791903004 Cr-Commit-Position: refs/heads/master@{#462929}
-
guidou authored
The tests raced because each test case was changing a global flag potentially in parallel. Instead of having separate test cases that each set the flag, have separate tests objects for each value of the flag, and set the flag in the constructor to avoid races. BUG=709112 TBR=hbos@chromium.org Review-Url: https://codereview.chromium.org/2805903002 Cr-Commit-Position: refs/heads/master@{#462928}
-
kenrb authored
In an OOPIF process with a remote main frame, currently the size of the WebViewImpl is not set, because it is not relevant when there is no main frame to render. However, the VisualViewport size is required so OOPIF resizes set it appropriately. This has caused a problem during printing because it saves and then restores the WebViewImpl size, which unfortunately also wipes out the VisualViewport size. This CL sets the WebViewImpl size along with the VisualViewport in order to keep them consistent. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG=705867 Review-Url: https://codereview.chromium.org/2801143002 Cr-Commit-Position: refs/heads/master@{#462927}
-
liaoyuke authored
Per localization request, increasing the character limit of Request Mobile Site messageto 25em. BUG= Review-Url: https://codereview.chromium.org/2797923009 Cr-Commit-Position: refs/heads/master@{#462926}
-
malaykeshav authored
Currently a call to |GestureRecognizerImpl::TransferEventsTo()| can lead to an incorrect state for touch events. Specifically, the event ACKS are getting routed to a different reference of GestureProvider from the one where the original events were routed to. This patch stores a mapping of every event that was dispatched along with its corresponding GestureProvider. This allows the event ACKS to be routed correctly despite a call made to |TransferEventsTo()|. BUG=698843 COMPONENT=Gesture Recognizer, Touch Gestures, Drag and Drop Review-Url: https://codereview.chromium.org/2789203006 Cr-Commit-Position: refs/heads/master@{#462925}
-
rtoy authored
Manually converted test to use new Audit. BUG=704967 TEST=BiquadFilter/biquad-automation.html Review-Url: https://codereview.chromium.org/2785703003 Cr-Commit-Position: refs/heads/master@{#462924}
-
tedchoc authored
The two methods that fetch the currently selected image can be collapsed into one. BUG=655359 Review-Url: https://codereview.chromium.org/2804913003 Cr-Commit-Position: refs/heads/master@{#462923}
-
lukasza authored
BUG=708861 TBR=sebsg@chromium.org Review-Url: https://codereview.chromium.org/2806693003 Cr-Commit-Position: refs/heads/master@{#462922}
-
spqchan authored
BUG=704579 Review-Url: https://codereview.chromium.org/2802143002 Cr-Commit-Position: refs/heads/master@{#462921}
-
ellyjones authored
This test is flaky on Linux BUG=709524 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2804313002 Cr-Commit-Position: refs/heads/master@{#462920}
-
changwan authored
- Remove mDisableTextAccessibilityEvents and replace it by mIgnoreTextChangeFromAutocomplete which is renamed from mIgnoreAutocomplete - Change the scope of setIgnoreTextChangesForAutocomplete() to be exactly the code that should be affected. - Remove unused methods and fields BUG=539536 Review-Url: https://codereview.chromium.org/2802803002 Cr-Commit-Position: refs/heads/master@{#462919}
-
gchatz authored
Previously, if the promo text parameter was not found in the localization lookup table, the promo would be considered valid and the text would be displayed as is. With this CL, it is now required that the text parameter exist in the lookup table in order for the promo to be valid. The CL also does general NTP Promo cleanup and adds unit tests. BUG=703440 Review-Url: https://codereview.chromium.org/2799383002 Cr-Commit-Position: refs/heads/master@{#462918}
-
mtrofin authored
Spec available at: https://github.com/WebAssembly/design/blob/master/Web.md#webassemblycompile This CL introduces the WebAssembly.compile overload in Blink. Notably, we do not currently check the mime type (chromium:707149). The V8 side is still under development. We currently exercise a skeleton API with a trivial implementation. Once the full implementation is implemented, we will enhance the blink side of the feature - for instance, we can introduce back pressure information. BUG=chromium:697028 Review-Url: https://codereview.chromium.org/2780693003 Cr-Commit-Position: refs/heads/master@{#462917}
-
chfremer authored
Link to original CL: https://codereview.chromium.org/2769543002/ PatchSet 1 is state as reviewed previously. PatchSet 2 applies a fix for the issue described below. This was reverted because it caused a test flakiness for test MediaDevicesDispatcherHostTest.GetVideoInputCapabilities on Windows. Analysis of the issue: The CL created a race condition that could cause the test method to exit before the exercise had finished executing. What made the difference is that VideoCaptureSystem::GetDeviceInfosAsync() invoked by VideoCaptureManager now actually runs asynchronous, i.e. it posts invocation of its |result_callback| to the end of a message queue. Before this CL, VideoCaptureManager directly called VideoCaptureDeviceFactory::EnumerateDeviceDescriptors which, despite its asynchronous-looking API invoked its callback synchronously. The test code was relying on this being the case. After the CL, the following bad sequence could happen: 1.) Test calls |host_->GetVideoInputCapabilities()| which eventually kicks of asynchronous work A on the "device thread". 2.) Test method reaches statement |media_stream_manager_->FlushVideoCaptureThreadForTesting()| and blocks until the already posted work A on the device thread finishes. 3.) Work A posts new work B to the device thread. 4.) Work A finishes. 5.) FlushVideoCaptureThreadForTesting() returns and the test method exits before work B has run. Description of fix: The way that the test was waiting for the asynchronous exercise to complete was based on dangerous (and now incorrect) assumptions of how and where the implementation under test internally posts task. The fix is to eliminate these assumptions and, instead, block the test method until the waited-for callback arrives. Original CL description: This CL is supposed to be a pure refactoring. There should be no changes to existing behavior. This is part of a series of CLs with the goal of separating the class VideoCaptureManager from knowledge of things that are going to be private implementation details of the video capture service. The end goal is to have VideoCaptureManager talk to an abstraction that can be implemented by either the video capture Mojo service or the existing (legacy) in-process implementation. Changes in this CL: * Move nested struct VideoCaptureManager::DeviceInfo to struct media::VideoCaptureDeviceInfo. * Create abstraction VideoCaptureSystem and move caching of VideoCaptureDeviceInfo to there. This allows us to use this functionality in both InProcess and MojoService code paths. * Simplify BuildableDeviceCallbacks interface. With the mapping from device_id to descriptor being moved into VideoCaptureSystem, BuildableDeviceCallbacks no longer needs to offer a LookupDeviceDescriptor() method. This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL18. BUG=584797 TEST= content_unittests --gtest_filter="*Video*" content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Review-Url: https://codereview.chromium.org/2805533002 Cr-Commit-Position: refs/heads/master@{#462916}
-
twellington authored
Adds a custom message displayed in a toast when the user taps on a pinned home screen shortcut for the disabled static 'New incognito tab' launcher shortcut. BUG=708743, 707446 Review-Url: https://codereview.chromium.org/2807613002 Cr-Commit-Position: refs/heads/master@{#462915}
-
justincohen authored
In preparation for back-porting UIViewControllers in the NTP, add support for loading contentViewControllers inside the clean NTP's scroll view. This also adds stubs for the NTP mediator and consumer, as well as fix some navigation errors when loading and unloading the NTP. BUG= Review-Url: https://codereview.chromium.org/2785893003 Cr-Commit-Position: refs/heads/master@{#462914}
-
dpapad authored
This fixes a regression where the scroll position changed after closing the sidenav, and is more correct, since the container is the scroll target. BUG=708960 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2802073002 Cr-Commit-Position: refs/heads/master@{#462913}
-
fdoray authored
This CL is identical to https://codereview.chromium.org/2664953004. The race condition that it highlighted in a TaskScheduler test the first time that it landed was fixed by https://codereview.chromium.org/2798373002/ There is no good reason to block in SimpleThread::Start(). In addition to introducing unnecessary latency, blocking in Start() prevents a non-joinable DelegateSimpleThread from being deleted from Run() without external synchronization (it is wrong to delete SimpleThread while Start() is waiting on the |event_| member). BUG= TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2801073005 Cr-Commit-Position: refs/heads/master@{#462912}
-
marpan authored
https://chromium.googlesource.com/webm/libvpx.git/+log/32b3d2f174f6..6af42f5102ad $ git log 32b3d2f17..6af42f510 --date=short --no-merges --format='%ad %ae %s' 2017-04-06 jianj Fix compile warnings with enable-internal-stats flag. 2017-04-06 marpan vp9; Move the denoising condition for speed 5. 2017-04-04 jianj vp9: speed 8: Compute y sad without int_pro_motion_estimation. 2017-04-05 marpan vp9: Temporal denoising: avoid denoising for speed <= 5. 2017-03-31 jianj Refactor: Clean memory allocation for copy partition. 2017-04-05 linfengz Update 32x32 high bitdepth idct NEON optimization 2017-04-04 jianj vp9: Remove legacy comments for avg_source_sad. 2017-04-04 marpan vp9: Adjust condition of golden update with cyclic refresh. 2017-03-29 marpan vp9: 1 pass CBR: cleanup to cyclic refresh. 2017-03-22 ranjit.tulabandu Fix for out of range motion vector bug in sub-pel motion estimation 2017-03-28 yunqingwang Enhance the row mt sync read to accept the sync_range greater than 1 2017-03-30 marpan vp9: SVC: Fix issue with artifact for svc-denoising. 2017-03-29 jzern vpxdec: silently ignore -frame-parallel 2017-03-29 jzern vp9: make VPX_CODEC_USE_FRAME_THREADING a no-op 2017-03-29 jzern rtcd,unit tests: fix ppc64 build 2017-03-29 marpan vp9: SVC: fix to allow output of denoised result. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Review-Url: https://codereview.chromium.org/2804593006 Cr-Commit-Position: refs/heads/master@{#462911}
-