Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 01 Nov, 2017 15 commits
    • Reilly Grant's avatar
      Devirtualize calls made on a mojo::InterfacePtr<T> · 91165cea
      Reilly Grant authored 
      This patch devirtualizes calls to interface methods made through a
mojo::InterfacePtr<T> and mojo::AssociatedInterfacePtr<T> by making
get() and the -> and . operators return the proxy type directly and
marking the interface methods on the proxy as final.

The motivation of this change is performance and binary size. The non-
virtual call sites are slightly smaller but not enough to effect the
complete binary. Performance should be net-positive but as yet has not
been accurately measured.

Bug: None
Change-Id: I463bc32c1989853606d118f57ded5c9dd9f34e2f
Reviewed-on: https://chromium-review.googlesource.com/747884
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: default avatarYuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513030}
      91165cea
    • Tien-Ren Chen's avatar
      [Blink/Paint] Expands visual rect for objects that have a clip-path · fc2679df
      Tien-Ren Chen authored 
      With a recent change we removed bounds parameter from drawing display
items, now all drawing display items are assumed to be bounded by its
owning client's visual rect. This does not necessarily hold true for
clip-path, because clip-path can be bigger than its reference box.

This CL expands the visual rect of a layout object with its clip-path's
bounding box (if one is present).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I117169b302c4574df4628ffe67496e9f95aab8fb
Reviewed-on: https://chromium-review.googlesource.com/742354
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513029}
      fc2679df
    • Alex Loiko's avatar
      AGC test shouldn't enable AEC. · 5a81a99f
      Alex Loiko authored 
      The test
WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio
sets up a WebRTC audio-only one-way connection between two Chrome
tabs. The first tab receives recorded audio from a fake microphone and
sends it to the second tab. The second tab plays the audio which is
then recorded.

The WebRTC connection is negotiated with constraints "{audio: true}",
which enable the AEC. The AEC affects audio levels, and changes in it
potentially cause alerts such as this one:
https://chromeperf.appspot.com/group_report?bug_id=779057

On some test settings (with '--single-process'), the AEC of one tab
sees the playout stream (reverse) of the other tab, causing it to
cancel the 'echo'. That leads to heavy speech distortion and often
test failure (see the bug chromium:779057).

This change disables AEC in the AGC tests.

Bug: chromium:779057
Change-Id: Ie774e2faba41f057e47fb2ed4ee402217da8aaf3
Reviewed-on: https://chromium-review.googlesource.com/746641Reviewed-by: default avatarPatrik Höglund <phoglund@chromium.org>
Commit-Queue: Alex Loiko <aleloi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513028}
      5a81a99f
    • Becky Zhou's avatar
      [Chrome Home] Remove BottomSheetContent when switching to different mode · b50535ae
      Becky Zhou authored 
      Before this fix, bottom sheet contents are not updated when creating new
tab in a different mode with a new tab already opened. It also causes
duplicate calls to destroy pref observers. OffTheRecordProfile is not
necessary for PrefChangeRegistrar, and to fix bottom sheet content
separately, we now remove BottomSheetContent when switching mode.

Bug: 779474
Change-Id: I263d9041184701c737cbada78e725a96ca9ade6b
Reviewed-on: https://chromium-review.googlesource.com/745221Reviewed-by: default avatarTheresa <twellington@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513027}
      b50535ae
    • Thanh Le's avatar
      Fix the layout of chrome://interventions-internals. · e1674b04
      Thanh Le authored 
      The tab navigation bar is now stretch across the page The table also
fit to the device width, and the "URL" column in the "Logs" tab is now
scrollable to make it nicer for longer hostnames on mobile

Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3MlA2bnNYNUhfdVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3RXQ3clFLRFBtaVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3THd0Q3JVcm44c00

Bug: 764419
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieba316275f2acfa60dea480be701995c68fb2f7a
Reviewed-on: https://chromium-review.googlesource.com/747865Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Reviewed-by: default avatarRyan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513026}
      e1674b04
    • Tommy Steimel's avatar
      Continue showing sound setting in Page Info until navigation · 18360517
      Tommy Steimel authored 
      This CL adds a WasEverAudible method to WebContents which returns true
if audio has played since the last navigation. This is then used by the
Page Info bubble to decide whether or not to show the sound content
setting.

Bug: 779878
Change-Id: I66453161dfe17df6868e66f11e7fce0b3c3a87b8
Reviewed-on: https://chromium-review.googlesource.com/747069Reviewed-by: default avatarLucas Garron <lgarron@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513025}
      18360517
    • John Chen's avatar
      Add playback ID to media trace events used by media metric · 5b164a0a
      John Chen authored 
      Use the MediaLog ID associated with each WebMediaPlayerImpl object as a
unique identifier, to allow the media metric to handle multiple media
playbacks in a single trace.

Bug: 775264
Change-Id: I412bbf5bf8ccab223c027cb5c936fac3de47251e
Reviewed-on: https://chromium-review.googlesource.com/741143Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513024}
      5b164a0a
    • Philip Rogers's avatar
      Turn off tickcount from default app shell LOG setting · 93f92b3b
      Philip Rogers authored 
      The app shell (content shell) sets the default LOG setting to
have tick counts. This means a LOG(INFO) looks like:
[42745:775:1031/103842.350408:395648516798307:INFO:LocalFrameView.cpp(3456)] test

This patch updates the default setting to not have the tick
count so LOG is less verbose. I think this will promote more LOG usage
and happier developers. A LOG(INFO) now looks like:
[42846:775:1031/104021.499705:INFO:LocalFrameView.cpp(3456)] test

Change-Id: I37b27730114519e8f08f59bf076eb3b090bcb12e
Reviewed-on: https://chromium-review.googlesource.com/747363Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513023}
      93f92b3b
    • Sonny Sasaka's avatar
      Don't log as error when Stop() discovery failure is expected · 281a2ea6
      Sonny Sasaka authored 
      This is a continuation from crosreview.com/737056. When Stop() discovery
fails because Discovering property changes to false, that means all the
discovery sessions have been stopped bluez, so Stop() is expected to
fail and there is no need to log this as error.

BUG=777953
TEST=Reproduce the case and check that device event log is categorized
as DEBUG instead of ERROR.

Change-Id: I41f6e3e83e9f6377bf28f4bb2210be34bdf1c732
Reviewed-on: https://chromium-review.googlesource.com/747603Reviewed-by: default avatarMiao-chen Chou <mcchou@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513022}
      281a2ea6
    • rbpotter's avatar
      PrintPreviewHandler: Add second preview test · 667c8da0
      rbpotter authored 
      Test that PrintPreviewHandler forwards renderer messages from the
PrintPreviewUI to the Print Preview javascript correctly, and that it
tries to kill the renderer if it receives unexpected messages.

Bug: None
Change-Id: Iec26fcd115270a167de6370aba2b90d5c68cf380
Reviewed-on: https://chromium-review.googlesource.com/742649
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513021}
      667c8da0
    • Mark Pearson's avatar
      Clarify Memory Histograms Emit Times · 64b55601
      Mark Pearson authored 
      In many memory histograms, the last sentence is "Emitted once per UMA
ping."  But actually some subset of those are emitted multiple times,
one for each process.  In most of those cases, reading the rest of the
histogram description will make that clear.  In a few, it's not crystal
clear; one of them confused me for example.  I was going to simply
fix the more confusing ones, then simply decided that it's best to be
consistent.

This changelist adds "per process" to the last sentence as appropriate
on all memory histograms.

Bug: 765470
Change-Id: Ia8187581381a13913f9eada5a1b0d82b8d1b3fbe
Reviewed-on: https://chromium-review.googlesource.com/747629Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Commit-Queue: Mark Pearson (busy Oct 31) <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513020}
      64b55601
    • Chris Bentzel's avatar
      Fix comment in PageLoadMetricsObserver::OnLoadedResource. · 52576f6c
      Chris Bentzel authored 
      The comment indicated that blob, data, and other URLs could be included.
However, the implementation in MetricsWebContentsOvbserver::OnRequestComplete
filters out requests that do not have HTTP or HTTPS schemes.

Change-Id: I8873a2bb57eb8a548ae2a8c8b4a4f32596fd5bed
Reviewed-on: https://chromium-review.googlesource.com/745827Reviewed-by: default avatarBryan McQuade <bmcquade@chromium.org>
Commit-Queue: Chris Bentzel <cbentzel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513019}
      52576f6c
    • James Cook's avatar
      cros: Fix ash ScreenshotDelegate ownership and creation · 5e9d3403
      James Cook authored 
      Many ash_unittests fail under --mus and --mash because the
TestScreenshotDelegate is not created. This happens because of some
legacy AcceleratorControllerDelegate code that dates back ~18 months
to when we couldn't use aura::Window* in mash code. That isn't a
problem anymore.

* Move ownership of ScreenshotDelegate to ScreenshotController
* Create the delegate in ShellDelegate, similar to how we do other
  ash delegates
* Move screenshot accelerator code back into AcceleratorController
* Re-enable tests under mus and mash via filter files

Screenshots don't work yet under --mus and --mash due to lack of
graphics readback support and lack of a mojo interface, but we now
exercise more of the UI and accelerator handling code.

Bug: 557397, 632111
Test: ash_unittests (--mus, --mash), manually take screenshots
Change-Id: I7dd1946ddc30bddb407c9dbf6095caf8efb4fd1f
Reviewed-on: https://chromium-review.googlesource.com/744295Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarVladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513018}
      5e9d3403
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ 90dabec62..4dbdc677a (23 commits) · 17a37fce
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/90dabec62f9b..4dbdc677affd

$ git log 90dabec62..4dbdc677a --date=short --no-merges --format='%ad %ae %s'
2017-10-31 csmartdalton Fix undefined behavior in normalize_t_s
2017-10-31 csmartdalton Allow GrAppliedClip to have >1 clip coverage FP
2017-10-25 mtklein Some lowp refactoring
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ b8ee9dd35..c1f14fbea (1 commit)
2017-10-31 brianosman Use color filter to undo GBR (actually BRG)
2017-10-31 mtklein Revert "Fix int overflow issues with clip and path bounds."
2017-10-31 caryclark cataloger
2017-10-31 bsalomon Devirtualized token management in GrDeferredUploadTarget.
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 1b605ee34..b8ee9dd35 (1 commit)
2017-10-31 kjlubick Add Pixel 2 XL to waterfall
2017-10-25 mtklein clean up SK_LEGACY_LOWP_STAGES
2017-10-31 bsalomon Make deferred upload handling and draw recording be virtual interfaces implemented by GrOpFlushState.
2017-10-31 scroggo Simplify SkColorSpace::MakeICC
2017-10-31 bungeman Remove SK_IGNORE_SUBPIXEL_HINTING_FIX.
2017-10-31 fmalita Don't store legacy colors in gradient shaders
2017-10-31 mtklein Revert "gbr- has been brg- this whole time..."
2017-10-31 robertphillips Add a GM to test out odd matrix draws (take 2)
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 2c5c41f9b..1b605ee34 (1 commit)
2017-10-31 mtklein gbr- has been brg- this whole time...
2017-10-31 jvanverth Fix int overflow issues with clip and path bounds.
2017-10-31 robertphillips Revert "Add a GM to test out odd matrix draws"
2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ d922775b6..2c5c41f9b (1 commit)
2017-10-31 mtklein update valgrind suppressions for revised keepalive thread

Created with:
  roll-dep src/third_party/skia
BUG=743617,779346


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I6c60d600f1b6ac2555e482e37465f2220492326a
Reviewed-on: https://chromium-review.googlesource.com/747886Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513017}
      17a37fce
    • Ted Choc's avatar
      Add additional logging in SearchActivityTest to diagnose flakes. · 9cba33b1
      Ted Choc authored 
      This removes the similar Activity launching logic in SearchActivityTest
and replaces it with the same functionality in ActivityUtils.  In
addition, it adds additional logs in ActivityUtils on failure to
attempt to help figure out what the state of the system is.

BUG=778239

Change-Id: Ic2aac185958044a8ba733213ac8daf5a4c8aa618
Reviewed-on: https://chromium-review.googlesource.com/738843
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: default avatarYusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513016}
      9cba33b1
  3. 31 Oct, 2017 25 commits