- 13 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4a486be696b4..2b1c0b0e92e7 2020-08-13 jiawei.shao@intel.com Clean up BufferZeroInitTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I739f3b608b86fdedac4591a702465e85ebffbbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797669}
-
Bret Sepulveda authored
TBR=estark@chromium.org Bug: 1115551 Change-Id: Ic5351b9eef808df37718b1a8581414db9c270070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353335Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797668}
-
Aaron Leventhal authored
Fixes regression from CL:2142611 where a menuitem inside of a group no longer gets an accessible name. This was due to moving kMenuButton inside the NameFromContents() switch, such that it would no longer get a name from contents. Currently, a role=menuitem inside a role=group gets remapped to kMenuButton via AXObject::RemapAriaRoleDueToParent(). The purpose of remapping menuitem inside of a group to kMenuButton is to expose it as AXMenuButton instead of AXMenuItem on OS, per CORE-AAM. This remapping may be removed in the future, and is an open issue in CORE-AAM. See https://github.com/w3c/core-aam/issues/78 Bug: 1114712 Change-Id: Iae23b2351e72486e1cf3bf4b96ce1ff283e4ad97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353019Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797667}
-
Miguel Casas authored
VaapiWrapper has two lists to store the VABufferIDs waiting to be sent to vaRenderPicture(): |pending_slice_bufs_| and |pending_va_bufs_|. Both are created and manipulated at the same time and in the same ways, so this CL merges them into a single vector. Bug: b:162962069 Change-Id: I6403be0b55e746a829b90fa79a9c922eef68832c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353014Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#797666}
-
Miguel Casas authored
To help finding performance hotspots. (This is mostly for tracing the vaCreateBuffer() call -- since it allocates a BO, it needs to clear it and takes a bit of time; the question is how much, compared to video decoding in vaEndPicture()). Bug: b:162962069 Change-Id: Icde7df8f44c36065c04e5e55e2f9866e73197e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353015 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#797665}
-
Friedrich Horschig authored
This CL ensures all primary change buttons have properly aligned icons. Screenshot in the bug. Bug: 1115117, 1092444 Change-Id: I3c60600f27e209d261fd727d20708a19ffbd5fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353332Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797664}
-
Bret Sepulveda authored
TBR=corising@chromium.org Bug: 1115950 Change-Id: Ib81a1d2937db2783cbd9e65a3f79f4e160ab6b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352917Reviewed-by:
-
Tal Pressman authored
Frames for non-ordinary pages don't report signals (such as FMP or onload). They also have no parent frame, so they are considered main frames, and they use arbitrary agent cluster IDs. This can create situations where we will "affect" queues forever. The solution is to not add such frames to the "waiting for signal" set. This avoids waiting for them indefinitely, while also not throttling them. The CL also changes it so that we don't try affect queues not associated with a frame (i.e.: have no FrameScheduler), as those are "global" queues that are not associated with a single agent. Bug: 1090251,1115389 Change-Id: I8e624626694aa5aded7bce1ab6243c57eb69ebd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352584 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797662}
-
Jérôme Lebel authored
+ Updating SigninSSOIdentityListRequestCacheState enum + NotPopulated in SigninSSOIdentityListRequestDurationCacheState suffix This patch is required for crrev.com/i/3208484 (which uses the cache APIs from SSOService). Bug: 897470 Change-Id: I59794f8838b75bc7f72e26afe1500f8fd176415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346666 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797661}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597298325-7a1b28e7d249f4f2f87ee413bc832fdaab0b39d9.profdata to chrome-mac-master-1597319582-be9645d468b25404b91084b442e1381733e63a51.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I4dbc6a5be8c981262d10f14d327df0e62677163e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354217Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit 1fb711f6. Reason for revert: https://crbug.com/1115935 Original change's description: > Reland "service worker: Use mojo version of GetUserDataForAllRegistrations" > > This is a reland of 853e0dd9 > > The original CL was reverted due to a data race. The race was fixed > in crrev.com/c/2340297 > > Original change's description: > > service worker: Use mojo version of GetUserDataForAllRegistrations > > > > This CL starts using mojo version of > > GetUserDataForAllRegistrations{,ByKeyPrefix}(). > > > > The type of the return value of these methods is also changed from > > map<registration_id, value> to array<ServiceWorkerUserData>, > > and ServiceWorkerUserData now has registration_id. > > These changes are required to handle a situation where a > > registration_id is associated with multiple values. Some features like > > payments could associate multiple values for a registration_id. > > > > Bug: 1055677 > > Change-Id: I29e9ae7c1722316b2ac2f163cfc5b50fe7590d54 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331376 > > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794447} > > Bug: 1055677 > Change-Id: I9f9ea4f6deb9953c4b18af941e6e8b70b66afb66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340417 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795690} TBR=falken@chromium.org,kinuko@chromium.org,bashi@chromium.org,nhiroki@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1055677 Change-Id: I73617bc2236730c6729c8b7af5621594bde5065d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353451Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#797659}
-
Anatoliy Potapchuk authored
This test was flaky because sometimes it was going to the network confingure screen(because there was no network), now we are always online. Bug: 964333 Change-Id: I397a873e7a0393a5646993475b934f226661e9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352889Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#797658}
-
Rouslan Solomakhin authored
This patch adds a Mojo IPC method to invoke the TWA payment app in ARC. Bug: 1061503 Change-Id: I617460dc1313de5c9968c215eac7022f64d6108d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245644 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#797657}
-
Mohamed Heikal authored
Usages in internal repo have been fixed, so we should make the real material design target private and only allow access to the public alias. Bug: 1110346 Change-Id: Id9bf2b705d51ef95eac6b2154c1d796369e4ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347957 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797656}
-
Bret Sepulveda authored
Failing on Chrome OS. TBR=avi@chromium.org Bug: 1115886 Change-Id: Ia9d3e8861e6ee7685d21a2a8a324b7328756c979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352816Reviewed-by:
-
Dominic Battre authored
Passwords can be keyed by multiple subdomains and it is important to support all of them. Bug: 1095627 Change-Id: I952bd06cb5a7f7123d149787613c4335ccdeff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352933 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Milica Selakovic <selakovic@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797654}
-
Omar Morsi authored
This CL separates non service-related definitions from platform_keys_service.h Bug: 1115581 Change-Id: Ic9912960009968b9d348c72217b3523d531dafc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352793Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#797653}
-
Florent Castelli authored
The parameter is not optional and has never really been optional as calls would fail with empty values. Bug: 803494 Change-Id: I44a2f25b9368f9759f296a95d9ad878de1292faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351836Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797652}
-
Rouslan Solomakhin authored
This reverts https://crrev.com/c/2351959, https://crrev.com/c/2345928, https://crrev.com/c/2302970, and https://crrev.com/c/2257090 because they are causing hard-to-diagnose crashes in production for a feature that is supposed to be still turned off. The patches should be relanded with more test coverage. TBR=jdragon.bae@gmail.com, manukh@chromium.org, maxlg@chromium.org Bug: 1114556, 1052493 Change-Id: Ic221c99e28246676d24bcd2185773657abef4781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354149 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797651}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/86c9a7134948..522a635391bd 2020-08-13 szuend@chromium.org [ts] Type-check ui/ProgressIndiciator.js with TypeScript 2020-08-13 szuend@chromium.org Revert "Reland "eliminate initial timeout in waitForFunction"" 2020-08-13 szuend@chromium.org [ts] Type-check ui/FilterSuggestionBuilder.js with TypeScript 2020-08-13 szuend@chromium.org [ts] Type-check ui/DropTarget.js with TypeScript 2020-08-13 patrick.brosset@microsoft.com Copy formatted HTML when the console selection contains a table 2020-08-13 jobay@google.com Reland "eliminate initial timeout in waitForFunction" 2020-08-13 kimanh@chromium.org Gate dwarf extension api behind wasmDWARFDebugging experiment flag 2020-08-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1112346,chromium:1112692,chromium:1115011 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6d61142415b9561157dd1456e19b443d4250c9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353485Reviewed-by:
-
Francois Beaufort authored
This CL makes sure initialized callback from the MediaStream constructor is called asynchronously as it was causing a JavaScript crash potentially caused by the fact that the MediaStream was not completely registered with oilpan. Bug: 1114398 Change-Id: If6058b183bdd07fa747d810efe0f6abed4914e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352800Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#797649}
-
Rainhard Findling authored
* The current translation screenshot presubmit check flags messages which got modified but for which no new translation screenshot got uploaded. It thereby also flags messages that got modified, but of which the message content itself did not change. This is the case, for example, if only the message description for translators got changed. * This CL restricts the translation screenshot presubmit flagging modified messages. It will trigger 1) if the message did not have a screenshot at all so far, or 2) if the message content itself changed. Only changing the non-visible part of a message that already has a translation screenshot does not trigger it anymore. Bug: 1103844 Change-Id: I254ce2a7267a7d2308b606b16d080c74188d582b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328669 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797648}
-
Caitlin Fischer authored
Calling TearDownAuthForTesting() causes a crash in SigninManager::signOut() (Java). This is because the sign-out operation started during the test body does not finish before TearDownAuthForTesting() is called. In other words, we try to sign out during tear down while sign-out is already in progress. We don't need to sign out during tear down, so we'll stop doing this. However, we'll continue to reset the AccountManagerFacadeProvider. Bug: 1102746 Change-Id: I0cc97c8cfa04591d150305418858eaa0abe4b38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350231Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#797647}
-
Rossana Monteriso authored
In the current master state the grid highlighted by Inspector Tool is always being calculated and rendered with direction:ltr, regardless of its CSS direction property. This CL adds getColumnPosition function, that checks if grid's direction is ltr or rtl. If direction is rtl, it translates the coordinates to rtl. getColumnPosition is then called by BuildGridInfo to evaluate PhysicalOffset and PhysicalSize when painting the grid. BUG=1086923 Change-Id: Ic43463b9aa643358d2ad06e2a6f4f7755c6c48f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213530 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797646}
-
Marc Treib authored
This CL adds code to notify the IPH tracker of relevant events related to the PasswordsAccountStorage IPH: - When the feature was used, i.e. a password was saved to the account store. - When the feature was "disabled", i.e. the user explicitly chose to save to the profile store instead. The IPH tracker can use these events to decide whether to show the IPH bubble. Bug: 1115476 Change-Id: I97f1c1b4a3d6d536968083b2ac0dac5fe693eb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352874Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#797645}
-
Rune Lillesveen authored
Change-Id: I3d1fbd99faac4fb12b7d8decba24e282737c521b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353254Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797644}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc958e0e8703..31e5a5d45d5d 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 13f04d59c727 to cda86eff6461 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibf2dfcc6eae2f3d8e1a511fb1337062c91afaffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353482Reviewed-by:
-
Monica Basta authored
This CL adds the 'Customize' button. On click, the user will be directed to manage profile settings sub page for the selected profile. Bug: 1063856 Change-Id: I0b85f01e9efe0a2fb9a2ca20885147d48b83a3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353249Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#797642}
-
Dylan Cutler authored
participation. Bug: 973801 Change-Id: Ic5e2c7f2118c10dc2b277ad032a282f59741e6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353110Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#797641}
-
Matt Wolenetz authored
Improves MediaSourceRegistry code readability by DCHECKing in its URLRegistry overrides and in its LookupMediaSource interface that the KURL |url| in the former, and the wtf::String |url| in the latter are not empty (or null). The former is prevented by the FILE API PublicUrlManager already, and the latter is now (by this change) protected against in MediaSourceAttachment::LookupMediaSource(). This is a follow-up on a review comment in an MSE-in-Worker CL: https://chromium-review.googlesource.com/c/chromium/src/+/2300804/7/third_party/blink/renderer/modules/mediasource/media_source_registry_impl.cc#74 BUG=878133 Change-Id: I2ef93b8d3fc894ee71b1a605acdc58df88e722d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346797 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#797640}
-
Robbie Gibson authored
On iOS 14, using pasteboard.string triggers a notification saying that the app pasted. There is a better property hasStrings that doesn't trigger this notification. It is also the recommended way from Apple to check if the pasteboard contains any strings. Bug: 1110848 Change-Id: Ia892c76ee17d5230582e8907db927ad3a27e82b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351832Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#797639}
-
Eric Sum authored
See internal buganizer bug for context. Bug: internal b/163291366 Test: Build locally. Change-Id: Iac091d9a0cd9d4c39e22b51a1d89a442536e9909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345723Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Eric Sum <esum@chromium.org> Cr-Commit-Position: refs/heads/master@{#797638}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6e1012fcb6bb6c85720af7d0a7a98e60ed3dec82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351764Reviewed-by:
-
Nohemi Fernandez authored
During the EG1 to EG2 migration a duplicate testing class was created to help expose necessary class-specific methods to EarlGrey. Now that the transition is complete we will remove the dependency to SigninEarlGreyAppInterface helper class and only expose SigninEarlGrey to client code. This patch also uses the more canonical 'verify' prefix for EarlGrey assertions. Bug: 1103274 Change-Id: I7cf71df0826068e79c8e0006744907fe36c70be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352931 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797636}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dbee93ac203d..e1360ddcec9e 2020-08-13 simonmacm@google.com Merge "Fix O(n^2) wakelock merging in android_batt.sql." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8e839835a6eaf2834fe04d53811c47646f65eb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353484Reviewed-by:
-
Bret Sepulveda authored
This reverts commit 1523bb86. Reason for revert: ClipboardTest/TestClipboardTest.TextTest is failing on linux-lacros-tester-rel. See for example https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/944 Original change's description: > [ozone] Improved clipboard tests and de-duplicated string constants. > > This CL pays a bit of technical debt in the clipboard implementation. > > First, it updates a test that verifies that putting text into clipboard > registers the proper set of MIME types, as had been suggested in [1]. > > Second, it enables for Ozone the test that verifies selection buffers. > > Third, it de-duplicates some string constants. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2306252 > > Change-Id: I6beb6b5b3827f0ec09cf19bc1868e7955141f680 > Bug: 911992, 1105892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346338 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Cr-Commit-Position: refs/heads/master@{#797572} TBR=sky@chromium.org,adunaev@igalia.com Change-Id: I376620331b967c70225b10d67b5e6e467802cf5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911992 Bug: 1105892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352802Reviewed-by:
-
Peng Huang authored
Bug: 1115065 Change-Id: I45873297b649d6b229823bfab100c00fb9fbbe52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351956Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797633}
-
Carlos Caballero authored
Bug: 1111720 Change-Id: I03f07bb982b2f98ab7213cbeb50911c6affe78b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339616 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Hirokazu Honda authored
Bug: b:155054799 Test: video_decode_accelerator_tests test-25fps.vp9_2 --use_vd on rammus Change-Id: I53103feebd9987583eaf029320f3b490d98f7298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350719Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797631}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ida05281d3ce64dbafeb186fff3911304eb2e0bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352959 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797630}
-
