- 30 Sep, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/581e894f..1370481f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1d99384fa1b5db51fdce44cf6356589c5e57b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831214Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701090}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a427da0bffc4..01cd0891cf7a Created with: gclient setdep -r src-internal@01cd0891cf7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9b52f2b6d22eedc286c10c00644cc111f133c1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832037Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701089}
-
Rohit Agarwal authored
This is a reland of a7fc60bd Original change's description: > Add three UMA metrics for bookmarks addition. > > First metric collects stats on bookmark addition > sliced on profile. Second and third metric collects stats > on the count of open tabs during bookmark all tabs, for > regular and incognito users. > > Bug: 966747, 1006145 > Change-Id: I29add57c472cf5344951b4a91be465872db45485 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793184 > Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699859} Bug: 966747, 1006145 Change-Id: I656d44090fdba00ca794006dd82700c375ea704d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823855 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701088}
-
Philip Rogers authored
The existing UMA for GPU tile memory, TileManager.TilesGPUMemoryUsage, only reported on low-memory devices. This patch deprecates that metric and adds a new one, TileManager.TilesGPUMemoryUsage2, that reports on all devices. Bug: 1008942 Change-Id: I07ab7ba59c5e249f583475474db975b92814f855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829982Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701087}
-
Rune Lillesveen authored
The rule was introduced to implement a default font-display value when font-display is not present in the @font-face rules. This was problematic for syntax, and controversial during spec-discussions. Instead the Google fonts apis added a possibility to provide a font-display parameter. Removing the code that never shipped as web-exposed. Bug: 777846 Change-Id: I1f4842ea62a9d9c27cbf35b552ccb746095318bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828910Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#701086}
-
Pâris MEULEMAN authored
This CL initially changed the JNI interface to its modern form. https://crrev.com/c/1814696 was landed first, also containing this change, so this one now renames simply renames oAuth2TokenFetched to onOAuth2TokenFetched as discussed with Boris in the comments. Bug: 934688 Change-Id: I90a8f19ef643f0a15f5d8140932be6f15d898636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760294 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701085}
-
Mathias Bynens authored
This patch makes the pre-existing `Emulation.setEmulatedMedia` API in the Chrome DevTools Protocol support emulating CSS media features, in addition to CSS media types (which it already supported). The new functionality can be used to emulate `prefers-color-scheme` (light/dark mode), `prefers-reduced-motion`, and any other media features Chrome implements from now on. Design doc: https://goo.gle/devtools-dark-mode Bug: chromium:1004246 Change-Id: I62ade2fa978a78e90e00b47915101950ca735c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821608Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#701084}
-
Fredrik Söderquist authored
Avoiding duplication is done via the management of the Condition class', so we shouldn't be adding any duplicates. Thus the default instance pointer comparison should be sufficient. Bug: 998526 Change-Id: I2ba96a84133a9baf3949346260d614918afdfeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826790 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#701083}
-
Olivier Robin authored
Crash reports show that the last committed item can be null. It is not clear at the moment what steps can be to this scenario, but this CL adds a check to avoid crashing when this happens. Bug: 1005210 Change-Id: Ib29b0ffb5e8ca09821c200e1765ba269846ea171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827283Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#701082}
-
Jan Krcal authored
This CL makes the guest mode icon lighter gray and most notably makes the color consistent with the user menu by using the same helper function to create the icon. Bug: 967317 Change-Id: I0df790897b00533a20558caf9c834db3d15ce363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829703 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701081}
-
Anatoliy Potapchuk authored
This CL updates proto for DeviceLocalAccount policy and adds a new type of DeviceLocalAccount itself, which holds all the data. Bug: 1006230 Change-Id: I446594f8d28350353cdf8c7a7687a9c3bd2abdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816508 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701080}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/message_center to the recommended methods/types. Bug: 1007852 Change-Id: I98daa048c8729aaa3d42b35e69d562178c04ab95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831859 Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701079}
-
Henrik Grunell authored
Bug: None Change-Id: Idada1454b183b2266ecf4b77a170807e1e9939a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826884Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#701078}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc3587418d3b..2449d7aa7828 git log fc3587418d3b..2449d7aa7828 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 nisse@webrtc.org Refactor legacy FrameBuffer to use EncodedImageBuffer::Realloc 2019-09-30 ilnik@webrtc.org Video: Log scalability configuration on encoder reconfigure Created with: gclient setdep -r src/third_party/webrtc@2449d7aa7828 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I7ef0dc051a2e093d9e3fdcc77cec778a12c6c79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701077}
-
Sergey Poromov authored
Example: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/384996 TBR=asvitkine@chromium.org Bug: 1009360 Change-Id: I24c0999ff863c3e6f4561cf3bb594eb75bc35e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829347Reviewed-by:
-
Stephen McGruer authored
This CL implements the accumulative operation described in https://github.com/w3c/fxtf-drafts/issues/371. Bug: 788440 Change-Id: I0ecf0a29110650ef5166b92bc0b8f1396c4b18dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830568 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701075}
-
Alan Cutter authored
This CL tests that we don't continue manifest updating when the site has an invalid manifest. Bug: 926083 Change-Id: I902b828e50f6ec3b32cf254cda9d55a0b1f2729f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831659Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701074}
-
Mikel Astiz authored
Reland "[SendTabToSelf] Use new cache guid method to assert that local device is not listed as a target" This is a reland of 38392a67 In this reland, the old logic remains unchanged as a fallback mechanism in case the GUID-based detection fails (as the reports suggest). Original change's description: > [SendTabToSelf] Use new cache guid method to assert that local device is not listed as a target > > Bug: 966413 > Change-Id: I29fe887806b07a51d7490603aaf81415a5a349cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721379 > Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682341} Bug: 966413 Change-Id: I85ae3c33c83f29f9a59cb8f3c2219e22e31a2bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828817 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701073}
-
Sergey Poromov authored
Example: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/384805 TBR=parastoog@google.com Bug: 1009364 Change-Id: I573054886372babd541a83bf67e1842180677deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831900Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59d894e2d057..e242d0ea937c git log 59d894e2d057..e242d0ea937c --date=short --no-merges --format='%ad %ae %s' 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 7f506bde16f1..71c1138d6739 (6 commits) Created with: gclient setdep -r src/third_party/skia@e242d0ea937c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None Change-Id: I3c713ba737a798f1e2a618c41cdcdc51e2326b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830514Reviewed-by:
-
Tim van der Lippe authored
The Chromium/Google style guides does not enforce curly braces for single-line if-statements, but does strongly recommend doing so. Adding braces will improve code readability, by visually separating code blocks. This will also prevent issues where accidental additions are pushed to the "else"-clause instead of in the if-block. This CL also updates the presubmit `eslint` to run the fix with the correct configuration. It will now fix all issues it can fix. Change-Id: I4b616f21a99393f168dec743c0bcbdc7f5db04a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821526 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#701070}
-
Sergey Poromov authored
The following tests sometimes fail with a memory leak: GCMDriverBaseTest.SendWebPushMessage GCMDriverBaseTest.SendWebPushMessageServerError GCMDriverFunctionalTest.UnregisterRemovesEncryptionInfo Example: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/384983 TBR=peter@chromium.org Bug: 1009185 Change-Id: Icb4bb3cc40116cf98a29b56c83a9ceb3566c5597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831799Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8a351eec4f9..a427da0bffc4 Created with: gclient setdep -r src-internal@a427da0bffc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ic1aea4d62470b4895341616e4aa4c19308884419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830511Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e9e3d2e9e79..f656f57a367a git log 1e9e3d2e9e79..f656f57a367a --date=short --no-merges --format='%ad %ae %s' 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f656f57a367a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I18903fbc8e4996f8d5b038b267e4ad991f5ac2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830512Reviewed-by:
-
Benedikt Meurer authored
For live expressions it doesn't make sense to trigger break points, as that doesn't match the users expectation of the feature. This commit uses the newly introduced "disableBreaks" parameters for "Runtime.evaluate" to suppress break points and explicit `debugger` statements for live expressions. Bug: chromium:1001216 Change-Id: Ie331761ca66afb813816c7d31e77085a5637ea8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831798 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 093c468a. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I61fbdb26a16765694754e9fba057a6aa5f42c41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831209Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701065}
-
Tim Volodine authored
Re-enable ServiceWorkerClientTest#testServiceWorkerClientInterceptCallback CTS test on the bots (P and up) Re-enable the testServiceWorkerClientInterceptCallback test, as it was updated in http://ag/2336567. Excluding the N and O bots for now, pending fresh N and O CTS release (with http://aosp/1129272 merged in). BUG=675809 Change-Id: I1d2ea6feb242633a411fc394a2b14f4c832a5cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824110Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701064}
-
Marian Fechete authored
This CL is adding a new UMA histogram for the Autofill Assistant DFM installation. The metric contains the following values: installing of the DFM is deferred, the installation is happening in the foreground and it succeeded, the installation is foreground and failed, the DFM was already installed. The metric cannot currently distinguish whether the deferred installation succeeded or failed. Bug: b/140369065 Change-Id: Ie250567996efeea809bd1be0c5fe5ef037b75be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825358Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#701063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/578270d9d23a..fc3587418d3b git log 578270d9d23a..fc3587418d3b --date=short --no-merges --format='%ad %ae %s' 2019-09-30 philipel@webrtc.org Use new RtpFrameObject ctor for unittests. 2019-09-30 nisse@webrtc.org Change FrameBuffer::CombineAndDeleteFrames to allocate a new buffer 2019-09-30 danilchap@webrtc.org Propagate task queue to create test::DirectTransport by TaskQueueBase interface Created with: gclient setdep -r src/third_party/webrtc@fc3587418d3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If9b0ac4daf18e28827229385620e0bcf359763af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830508Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/10951a7c9a13..85c67b5e08ee git log 10951a7c9a13..85c67b5e08ee --date=short --no-merges --format='%ad %ae %s' 2019-09-27 stevenperron@google.com Record trailing line dbg instructions (#2926) 2019-09-27 rharrison@google.com Add removing references to debug instructions when removing them (#2923) 2019-09-27 paulthomson@users.noreply.github.com spirv-fuzz: allow interestingness script arguments (#2925) 2019-09-27 ehsannas@gmail.com Add Kokoro bots for building with Bazel. (#2914) Also rolling transitive DEPS: src/third_party/spirv-headers/src 601d738723ac..842ec9067462 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@85c67b5e08ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Bug: None Change-Id: I66b89f650aa9e6e2cc8b2de46a9824c81a87ea8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831439Reviewed-by:
-
Sergey Poromov authored
MediaNotificationViewTest.* fails on TSan builds. Example: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/384740 TBR=steimel@chromium.org TBR=beccahughes@chromium.org Bug: 1009287 Change-Id: I1fe5ce0dca108c294631b0aa70500e7100cc22f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829265Reviewed-by:
-
Yasmin authored
Bug: 1005813 Change-Id: I7c135ef3a969bd774c735f89fa82413c73aa9ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825601 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701059}
-
Julie Jeongeun Kim authored
This CL converts PluginHostAssociatedPtr, PluginAuthHostAssociatedPtr, PluginRendererPtr, and PluginInfoHostAssociatedRequest to new mojo types using PendingAssociatedReceiver, PendingRemote, Remote, PendingRemote, AssociatedRemote, and Receiver. Bug: 955171 Change-Id: I4c2994c71c1b3a0e2f00008007b2d665a2b9bd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828725Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#701058}
-
Miyoung Shin authored
This change converts PaymentRequest mojom interface client in blink to use BrowserInterfaceBroker, and converts PaymentRequest{Ptr, Request} in chrome, components and blink to the new Mojo type. Bug: 936482, 955171, 978694 Change-Id: I254e341bfc32086d376e749c6aaa980b9a3bd7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824791 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#701057}
-
Paul Lewis authored
Change-Id: Ic49e9ca826a645289f1b7819f939ccffd612e9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829700Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/snapshot to the recommended methods/types. Bug: 1007853 Change-Id: I3e8fee3aa46ecd3c2fe5898c5e5294887f4f5eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829338Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701055}
-
Thomas Tangl authored
... for the sync settings button. Bug: 995720 Change-Id: Ibe4116fb350730c616821164c36791a73a3a302a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831797 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701054}
-
Julie Jeongeun Kim authored
This CL converts ChromeOSListener and RendererConfiguration to new Mojo types using AssociatedRemote, PendingReceiver, and Receiver. It also updates SetInitialConfiguration from renderer_configuration.mojom. Bug: 955171 Change-Id: I434fd7f5c4e2495dc53cc3e8b795c7e33d75d833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828728Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/286fb1607d36..1e9e3d2e9e79 git log 286fb1607d36..1e9e3d2e9e79 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1e9e3d2e9e79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I935d1d451a1fe843db4922cf771ee406e0991b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831441Reviewed-by:
-
Alex Danilo authored
The 'onclick' handler for panel items was being set up when the panel was attached to the DOM. Side effect from that is creating a panel type with buttons used 'null' for the click handler, causing the buttons to fail to do anything after the panel is attached to the DOM. Set the 'onclick' handler inside the constructor to ensure it's available for reference when setting the panel item type. Needs test. Bug: 1009318 Change-Id: I654626b59715d03e3ee14f6ac00eadb5bd9815ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831618Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701051}
-
