- 20 May, 2020 40 commits
-
-
Artem Bolgar authored
We are getting a crash in org.chromium.ui.base.WindowAndroid.setPreferredRefreshRate because getWindow() returns null and there is no nullcheck there. getWindow() CAN return null when there is no activity (and this is exactly our case, Oculus Browser is not using Activity). There are getWindow() nullchecks in other methods of WindowAndroid, but not in setPreferredRefreshRate which looks as oversight. Bug: 1085160 Change-Id: I6cbeac08787f9664abd4fdb2e619e100a09fa943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210673Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770793}
-
Tarun Bansal authored
Turns out the array object could be null in some cases. This CL adds a check for null array object and returns earlier in case it's null. Bug: 1084755 Change-Id: I9cb7f5f5e2b4fb724dca76bad3e0c558dc6b1d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209514 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#770792}
-
Swapnil authored
The browsertests of URL blacklist policy are moved from policy_browsertests to a separate file. Bug: 1084512 Change-Id: I20258570e63d0ddc6b07435f2a75b25195e3af70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207207 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770791}
-
Moe Ahmadi authored
Tests cover the functionality added in: -crrev.com/c/2194472 -crrev.com/c/2199361 Also fixes bugs and issues that came up while writing the tests: -Restores previous selection, if any, and if no match is selected by default. -Remove and Toggle buttons can be triggered by pressing 'Enter' and 'Space'. -Removes isTrusted check for mouse and keyboard events. This is not necessary and not commonly done in WebUI and makes testing complicated. Bug: 10846603 Change-Id: Id0274fa9a420a6e097a8f63538571498fd3e1d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194275 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770790}
-
David Tseng authored
Mostly speculative; pass with testing/xvfb.py out/d/browser_tests --gtest_filter=ChromeVox*.NavigationSyncsSelect !! & !! & !! & !! & TBR=dtseng@chromium.org Fixed: 976105 Change-Id: Ieb646dd0ab22d4b45f2355c89542a59c51af5888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209684Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770789}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a0139c0aa3d4..008b71ab1384 2020-05-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4bef4acf028f3235f72ad477d67f5542831f42db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770788}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589990279-037dea0eb6fc46c134bcb3d90d9f61194c559337.profdata to chrome-mac-master-1590004011-c7e121da0d5a86abd485d92fadbd2d4beb7d781b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9fe48bd86c151a1f58a500ade7ac5c7221573e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210905Reviewed-by:
-
Brian Sheedy authored
Enables the standard "gpu_telemetry_tests" set of tests on the GPU CrOS builders and suppresses found failures. Bug: 1080424, 1084796, 1084794, 1080375 Change-Id: Ie7a8fe63bb478395e3524aeccc9584456d13daaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209398Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770786}
-
Dave Tapuska authored
The viz::RenderPassDrawQuad's render_pass_id is a RenderPassId which is a uint64_t as is the mojom value. The struct trait although narrowed it to an int32_t. BUG=1082889 Change-Id: Ic2c851d40c46a7c5156209210285fb2961b1b20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210791Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#770785}
-
Robbie McElrath authored
This CL fixes the following Site Settings issues in WebLayer: * Fix launching system settings from certain links * Apply themes to the UI, copied from Chrome's * Hide unsupported settings categories * Finish implementing pref-based settings * Properly handle multiple settings instances by closing one Bug: 1049683 Change-Id: I9c8afa1b5a8faa9d2429d6c34b171225cc5f5af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209598Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#770784}
-
James Cook authored
This was added for mustash, but isn't used anymore. Bug: none Change-Id: Ib822df1f0760aa38b038305f5e3f8271b76f976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209681 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
inglorion authored
When first introduced in crrev.com/c/2067858, we limited parallelism for ThinLTO code generation on Goma, with the intent to ramp it up as load permitted. We believe it is safe to increase to 200. In some test builds I performed, this reduced chrome binary link time by about 15%. Bug: 1027456 Change-Id: I4b86570a1b726d9b1faf6b9fa1d3249687b3f32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194842Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#770782}
-
Lukasz Anforowicz authored
Google C++ Style Guide [1] is neutral on this subject, but asks to be consistent with surrounding code: Note that the C headers such as stddef.h are essentially interchangeable with their C++ counterparts (cstddef). Either style is acceptable, but prefer consistency with existing code. Most of Chromium uses <stddef.h> and this was confirmed in a 2019 discussion on cxx@chromium.org [2], so let's switch checked_ptr.h to use <stddef.h> instead of <cstddef>. [1] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes [2] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/cxx/Bc1XyEL9pp4/Ie4C-_AjCAAJ Bug: 1073933 Change-Id: I8a844e32fd5f1ced327932e8cfd27bc6555a4cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209603Reviewed-by:danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#770781}
-
Asanka Herath authored
Until C++17 a static constexpr member variable needs a definition. Without this, kEntryNameHash members and similar metrics name hashes can't be odr-used (ill-defined). So now generated UKM builders .cc files will go from (only modified snippet shown for a sample event): const char Identifiability::kEntryName[] = "Identifiability"; to: const char Identifiability::kEntryName[] = "Identifiability"; const uint64_t kEntryNameHash; And similarly for metrics hashes. While we are here, this CL cleans up the include header so that it doesn't include a double //. I.e. This: #include "services/metrics/public/cpp//ukm_builders.h" Becomes this: #include "services/metrics/public/cpp/ukm_builders.h" Bug: 973801 Change-Id: Icfd234ef953f2cefee5376803be266a2321df020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203767Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#770780}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 1084509 Change-Id: I48fcfdf1fd570e328289f801386fc10dab284808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211045Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770779}
-
David Schinazi authored
This feature never worked as advertised. IPv4-mapped addresses are a host-only concept. They never appear on the wire. For example, if I open a TCP socket to IPv6 address ::ffff:1.2.3.4 and port 443, my device will send out an IPv4 packet with destination address 1.2.3.4. It will not send an IPv6 packet. IPv4-mapped IPv6 addresses exist to allow applications to only use IPv6 but still work on IPv4 networks. More details here: https://tools.ietf.org/html/rfc4038#section-4.2 R=zhongyi@chromium.org Change-Id: I4e9f349c1753aaab19dbaf040fa5d40a6a1740d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204826 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770778}
-
Alexander Timin authored
When test tracing is enabled, by default browser tests generate a file name based on the test name. However, when a test a parametrised, it has slashes in its full name (e.g. All/Foo.Bar/0). Replace slashes with underscores to ensure that we don't fail to actually write a trace file to the file. R=sky@chromium.org Change-Id: I8073e0dbd925b9c35e97dd7f6726b6b5b9210d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207376 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b19e9782ebef..ab2265ec86ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1068160,chromium:1077221,chromium:1083995 Tbr: sebsg@google.com,kmilka@google.com Change-Id: I76366a3169787c5c88fa8c17cfc680192fb9192e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770776}
-
Jesse Schettler authored
Remove CreateStatefulPartitionResult() since it is unneeded. Also, explicitly set relevant policies to ensure they are tested. Bug: None Change-Id: Ic81c99c34e357fb9978081b2337deb9fd96da323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209595 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#770775}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37c97e9aca20..7f02db5d3be5 2020-05-20 sigurds@chromium.org Make progress typescriptifying DebuggerModel 2020-05-20 rreverser@google.com Move wasm_source_map to ES module; update Rust+wasm tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233,chromium:1082720 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4137bee705e4b16507a055cfdd8d21a8cceb84a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210649Reviewed-by:
-
Istiaque Ahmed authored
For the page that performs fetch, ensure it is controlled by the service worker before initiating fetch. This is ensured by waiting for oncontrollerchange event if navigator.serviceWorker.controller is null. Note that the worker claiming itself and messaging the page isn't enough, and causes flakiness. Bug: 1006129 Change-Id: I313bbc79e04bd162c8dbd302b61c9ced446be39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207861Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770773}
-
Joel Hockey authored
This object is needed outside of ash. Bug: 1083825 Change-Id: Id3ab099925ac6cee0810815eb377aa745b44e060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208883Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#770772}
-
David Tseng authored
Removes opening of web page which appears to be causing flakes according to logs. TBR=dtseng@chromium.org Fixed: 1065877 Change-Id: Ie80e84bfd1df56bff60d4d55292c3a8825c850d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210656Reviewed-by:
-
Maksim Moskvitin authored
The previous implementation of key retrieval notification on Android didn't notify TrustedVaultClient about changed keys upon completion. In order to detect completion of key retrieval pending intent, this CL adds TrustedVaultKeyRetrievalProxyActivity that just launches the real key retrieval pending intent, detects its completion and notifies TrustedVaultClient about changed keys. This activity doesn't require the Chrome browser process to be running when the user taps on notification. In order to avoid too many pending intents being created for this notification it's not allowed to create a new notification if one is already exists or being created. To ensure that newest real pending intent used for new notification, this CL also populates FLAG_UPDATE_CURRENT into PendingIntentProvider for Sync notifications. Bug: 1071377 Change-Id: Ibba3c9f02aa0bd233c128d98aa194f781a49d339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179547 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770770}
-
Dirk Pranke authored
I'm switching to using just my @google.com account everywhere. R=pinkerton@chromium.org Change-Id: I06ee1b3a7068107f71de4b6072f9ca0585dbd8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207588Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#770769}
-
Martin Kreichgauer authored
CreateAuthenticator() relies on VirtualAuthenticator IDs being unique, which they are. But if they weren't, it would first dereference and then return a dangling VirtualAuthenticator pointer. Since a similar code piece has recently shown that same bug, make this method more defensive so it doesn't regress under future changes. Also fix a possible nullptr dereference. Change-Id: Ia769929f94360eabcdadb5e0f706f83d031231f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209905 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#770768}
-
Shengfa Lin authored
After setting window bounds, could potentially wait for 1 second using retries for window state to reflect. Bug: chromium:1068467 Change-Id: I94cd7919487dcda3faf3b39b87b9378057bb192c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209898 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770767}
-
Dale Curtis authored
R=tguilbert Fixed: 1084886 Change-Id: I544bef88c9b727b4fa1e6f0672fb396200a1b957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209904 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#770766}
-
Michael Achenbach authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bc0292ca..aea6c4ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org Change-Id: I1bfdc3e0bf15b991ec2b4d0a93432318805991ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210444Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#770765}
-
Avi Drissman authored
FileChooserImpl is-a WebContentsObserver, which violates layering. Move it to web_contents where that’s OK. Bug: 1076947 Change-Id: I62d97a0b2a85cc370b252627df1ad94fe8c711b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202787 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770764}
-
Yue Zhang authored
This reverts commit 2808b517. Reason for revert: Add missed dependency. Original change's description: > Revert "Add simple info bar to opt-out for conditional tab strip" > > This reverts commit e4d36bfb. > > Reason for revert: breaks download stream compile, might be build issue. please do "gn check target". > > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879764778699702672/+/steps/compile/0/stdout > > Original change's description: > > Add simple info bar to opt-out for conditional tab strip > > > > This CL adds an info bar for conditional tab strip to allow user to > > opt-out the feature. Some behavior of the info bar: > > > > * It will show after three consecutive sessions of dismissals. > > * If user clicks the "Don't show again" button, conditional tab strip > > will never show for this user in later sessions. > > * If user clicks the "Show later" button, conditional tab strip > > will show again for this user in later sessions, and the info bar will > > never reshow. > > * If user clicks the dismiss button to dismiss the info bar, the info > > bar will reshow after another three consecutive dismissal, but the > > limit times of info bar showing is two, i.e. 6 consecutive sessions of > > dismissal. > > * When the info bar shows, the undo snackbar will not show. > > > > Note that this is the simple version of info bar that we want, in that > > it is tied to one tab and cannot live across tab navigation. > > > > Bug: 1076295 > > Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216 > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#770632} > > TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org > > Change-Id: Id57987bdbf4cb0bb461e9b3ee44f636fa9db330e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1076295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209899 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770647} TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1076295 Change-Id: I89ec83eb3211a090f8e21004418eede65330959d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209902 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770763}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/503f81b8fe09..ae2ed9f992e1 2020-05-20 sadrul@chromium.org Revert "[Telemetry] Add LocalFirstBinaryManager" 2020-05-20 fancl@chromium.org sheriff-config: Increase per instance resources 2020-05-20 bsheedy@chromium.org [Telemetry] Add LocalFirstBinaryManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1054583 Tbr: sadrul@google.com Change-Id: I9ca69e4918353a651f41dee0367fcee5ea85dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210648Reviewed-by:
-
Sophie Chang authored
Bug: 1085065 Change-Id: I7d702ecc4d44bcea29172de8b6b6eb359915feb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209604Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770761}
-
Matt Reynolds authored
On Linux, the physical device ID is the sysfs path of the device that best represents the physical device connected to the system. For USB and Bluetooth devices, this is a device node that represents the entire physical device as opposed to one particular HID interface exposed by the device. For some devices, this cannot be determined because the device driver does not expose the information or the device is not physical. For these cases, the sysfs path of the HID interface is used instead. BUG=1011499 Change-Id: Ia887baa3dd78c0132d6e9fa0d37791941cd17bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966499Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#770760}
-
Li Lin authored
CLD3 is the on-device language detector. The surrounding text is not sent to server. Bug: 1084381e Test: manual test Change-Id: I9f12151847122c30352883607ac724c45d5001b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207859Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770759}
-
Taylor Bergquist authored
Bug: 1082755 Change-Id: Id8e174625f16e9a319000eb7427ec8659174c7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204259 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770758}
-
rbpotter authored
Bug: 1048812 Change-Id: I1afeb8a40e320b05a3dcc56d89584b3e65eac968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209600Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#770757}
-
Miriam Polzer authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/69985fadf06b..2b37f52a06d9 $ git log 69985fadf..2b37f52a0 --date=short --no-merges --format='%ad %ae %s' 2020-05-06 mpolzer system_api: Add powerwash flag to update status 2020-04-21 clarkchung platform2: run gn format BUILD.gn and *.gni 2020-05-14 akhouderchah shill: Remove unused OfflineMode property 2020-05-10 ahassani dlcservice: Make install single DLC only 2020-05-12 acostinas system_api: Update System-proxy proto 2019-12-25 dtor system_api: introduce VM_ERR_SRV_SHUTDOWN_IN_PROGRESS for Plugin VM 2020-04-28 chirantan system_api: Add uid/gid map fields to seneschal's StartServer proto 2020-05-07 akhouderchah system_api: hermes: Update D-Bus interfaces/paths 2020-05-04 yichengli cryptohome: Add fingerprint auth session methods to userdataauth 2020-05-01 yichengli cryptohome: Add DBus methods to start/end fingerprint auth session Created with: roll-dep src/third_party/cros_system_api Bug: 1070563 Change-Id: I911bb7374142ca4fdec338983ca15d544471cfe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210356 Auto-Submit: Miriam Polzer <mpolzer@google.com> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770756}
-
Yury Semikhatsky authored
Schedule deletion of pipe IO threads in a way that doesn't trigger DCHECK in base::DeleteSoon (https://source.chromium.org/chromium/chromium/src/+/master:base/task/post_task.h;l=246). Bug: none Change-Id: Icba9fd2bebc9e8c30fee36864417a5ad161feca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210621Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#770755}
-
Natalie Chouinard authored
HyperlinkPreference is only used by About Chrome > Legal information settings screen, and is not going to be modularized as a shared component (see https://crbug.com/1044685#c1), so moving it alongside the code where it's used. Bug: 1044685 Change-Id: Icbd6f9cee42800bbd217b59816c1c49470f79a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210664Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#770754}
-
