- 26 Feb, 2018 40 commits
-
-
Primiano Tucci authored
This CL cleans up the hack put in place in base::Singleton to reset the TraceLog instance in tests, in favour of a least worst hack to reset the instance within trace_log.cc . Other than cleaning up singleton.h, this also removes a TSan violation caused by calling Singleton::OnExit() (see bug). The violation was reported, I believe, for the following reason: - A thread (that ends before the test reaches TearDown()) accesses the Singleton instance pointer in GetOrCreateLazyPointer with a load-acquire. - TearDown() clears up the Singleton instance pointer with a non-barriered write. This is enough to make TSan conclude "this will be racy" even if the race doesn't happen (because of causality in the TearDown(), all threads created by the tests should be gone once there). This CL fixes the problem by switching TraceLog's singleton to a base::NoDestructor. This should also make TraceLog::GetInstance slightly faster in production builds as it removes one layer of pointer dereferencing (Singleton's instance is heap-based, base::NoDestructor is bss-based). The ResetForTesting method is implemented by simply invoking the destructor, clearing up the static storage and re-placement-new-ing the object. This keeps the pointer returned by GetInstance() unchanged, but still achieves the reset needed by tests. Bug: 815234 TBR: rouslan@chromium.org Change-Id: I4c0dfc33ea45e64f36234da2006ece96905914b9 Reviewed-on: https://chromium-review.googlesource.com/935841Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#539307}
-
Fredrik Söderquist authored
After https://chromium-review.googlesource.com/716679, this method has no callers. Remove it. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3e2f427c8349bfa410718cd24782f64c7ad2e0e0 Reviewed-on: https://chromium-review.googlesource.com/735861Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#539306}
-
https://chromium.googlesource.com/catapult.git/+log/4607515962f8..38e8eedc7bb6 $ git log 460751596..38e8eedc7 --date=short --no-merges --format='%ad %ae %s' 2018-02-14 eakuefner Reland "[Telemetry] Remove FailureValue from the value system" Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I44eef5e712b51553df53aaae55ac2da2eecaabaf Reviewed-on: https://chromium-review.googlesource.com/938182 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539305}
-
Daniel Murphy authored
Since the tab restore code keeps a reference to the session namespaces of recently closed tabs (see sessions::ContentPlatformSpecificTabData and sessions::TabRestoreService), a SessionStorageNamespaceImpl can outlive the destruction of the browser window. A session restore can also happen without the browser context being shutdown or destroyed in between. This change keeps track of all 'alive' namespaces in a map. When a SessionStorageNamespaceImpl is created and there is an entry alive in that map, then that object is used instead. This allows the browser to re-use objects that are still alive thanks to the sessions component. Bug: 811189 Change-Id: I5c9e94ab4fe7b0017264c0f8f522d20134ea0c2b Reviewed-on: https://chromium-review.googlesource.com/930325 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#539304}
-
Lei Zhang authored
Change-Id: I22a02aaf461e425d5a1742370036a08c60319d69 Reviewed-on: https://chromium-review.googlesource.com/935757 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#539303}
-
Chong Zhang authored
http/tests/devtools/oopif/oopif-cookies-refresh.js failing since it's added in r539268 http/tests/devtools/network/oopif-targets.js turned into flaky instead of crash. (The original DCHECK was changed) TBR=kinuko@chromium.org NOTRY=true Bug: 805310 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I92e5b76383a0b882459e0f4853269a12c1eb8de9 Reviewed-on: https://chromium-review.googlesource.com/938649 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539302}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I64812517880f954b9c8f27d773b495eabe01bbfc Reviewed-on: https://chromium-review.googlesource.com/938663Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#539301}
-
Hongchan Choi authored
This CL adds |currentFrame| property to AudioWorkletGlobalScope according to: https://github.com/WebAudio/web-audio-api/pull/1493. 1. Previously the time stamp (currentTime) was updated when the first worklet processor gets called, and it was inconsistent with how it is updated in the other nodes. Now updating the frame number is streamlined, so the worklet processor also gets the same treatment. 2. In order to streamline this process, WorkerThread reference was added to BaseAudioContext. Due to the GC rule, BaseAudioContext cannot keep a reference of WorkletGlobalScope, so it always derives the global scope from the worker thread. Bug: 814794 Test: http/tests/webaudio/audio-worklet/timing-info.html Change-Id: I4b313377d80f8678c473cf788211e373fd1644cb Reviewed-on: https://chromium-review.googlesource.com/935157 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539300}
-
Majid Valipour authored
Intent to Experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AZ-PYPMS7EA/DEqbe2u5BQAJ Bug: 811922 Change-Id: I967df8e38d55cffc985ca8982f3762e95aa08ae7 Reviewed-on: https://chromium-review.googlesource.com/917125 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539299}
-
Eugene But authored
DownloadManagerCoordinator should not present another view controller if in existing download is replaced with a new download. Instead coordinator should simply update the UI by setting new download task to mediator. Bug: 815366 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0298b2be999be9acda3c200a8182ba425b318010 Reviewed-on: https://chromium-review.googlesource.com/935840 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539298}
-
Nasko Oskov authored
Change-Id: I27c3d145a2eef11930f16afbb33e73ba60f243c9 Reviewed-on: https://chromium-review.googlesource.com/937901Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#539297}
-
Dirk Pranke authored
The network traffic annotation checks are too slow to be run in the main CQ, so we're setting up an additional (FYI) bot to run the full check (and a matching optional trybot). R=jbudorick@chromium.org BUG=815295 Change-Id: I16c2bd8cdb2bf10178f1bcd9904b15a1ab90bc8b Reviewed-on: https://chromium-review.googlesource.com/935625 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#539296}
-
Matthew Jones authored
BUG=750381 Change-Id: Ieac331636c7c5ff495ff3498cd606ce66fcd2561 Reviewed-on: https://chromium-review.googlesource.com/938395Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#539295}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1be8e2e..ea820a19 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I603c5a37f8ed260bc5346a41b791ec35d1b1871e Reviewed-on: https://chromium-review.googlesource.com/938121Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#539294}
-
chcunningham authored
The spec allows for anywhere between 15 - 250 ms to fire periodic timeupdate events. These events trigger UI updates on custom media controls, so don't want to over trigger. Historically we _aim_ to fire every 250 ms (4x/sec) during playback. Some bugs: 1) The internal timer often fires a little early, causing frequency guards to fail and delaying the event until the next 250ms cyle. 2) Non-periodic timeupdates in the middle of the periodic cycle cause the next periodic update to be delayed a full cycle. 3) Periodic timeupdates were being scheduled by both CueTimeline and HTMLMediaElement 4) Post-seek timeupdates were being double scheduled This patch remedies (2) by resetting the timer to delay periodic updates following a non-periodic timeupdate by a consistent 250ms. Resetting the timer also allows us to remove the frequency checks, which fixes (1) (3) and (4) are fixed by removing the double scheduling. Kudos to dongheun.kang@lge.com for first addressing some of the above in https://chromium-review.googlesource.com/c/chromium/src/+/888383 Bug: 796557 Change-Id: Ia16689b2ea79c77e31b73cf96cd570ca7641bded Reviewed-on: https://chromium-review.googlesource.com/896624 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#539293}
-
Matt Mueller authored
Bug: 690704 Change-Id: Ic13f3545762124355279fbcb20b5187f6e77ce21 Reviewed-on: https://chromium-review.googlesource.com/933621Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#539292}
-
Wei Li authored
Handle two cases with dead subframes for pdf composition: -- When a web page has a dead subframe prior to printing, we need to detect the liveness of the subframe, and avoid requesting printing for such frame; -- If after we request printing a subframe, the subframe dies, we add monitoring for render frame's closed event to check whether it is one of our pending ones. If so, notify pdf compositor service about that. We add an interface in pdf compositor service to be notified about the frame's unavailability for either of the above cases. In this CL, we also add a map to record the subframes that are already printed and use it to avoid printing the same ones repeatedly. BUG=814086 Change-Id: Ibd69dd21a6498a5c2784dfe892bc5803e84fa6f0 Reviewed-on: https://chromium-review.googlesource.com/932018 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Sarah Hu authored
Bug: 798325 Change-Id: Icc0e4a8e6e61b01e5736d52e65632b3e47a1f0d6 Reviewed-on: https://chromium-review.googlesource.com/936003 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#539290}
-
Dominic Mazzoni authored
Bug: 610744 Change-Id: If7f3c8c5c3d7c2aaa5ae3608b52101dc55529676 Tbr: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/938361Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#539289}
-
Dominic Mazzoni authored
We have logic to iterate over all frames and wait for them to finish loading, but that logic doesn't work if there are two frames with the same url. Change the test to use frames with different urls. Bug: 805998 Change-Id: I4d7d514cc0d638a95b2ddf445a7dbf59f1d73cef Tbr: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/938028Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/611431decd9a..0bc02c152bd0 $ git log 611431dec..0bc02c152 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 tsepez Add some more missing consts. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I93248936cf499783ce943e706802c21e30356fc9 Reviewed-on: https://chromium-review.googlesource.com/938481Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539287}
-
Dominic Mazzoni authored
Bug: 515053 Change-Id: I6e79f56bf0571bdbe50cea0c1e4448e148f521cd Tbr: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/938262Reviewed-by:
-
Aaron Leventhal authored
The correct accessibility alert event was fired but screen readers ignored it since it was not on an object with the alert role. Bug: 812647 Change-Id: Id0cc1fbcbaeaeb20e2ef546b463304a3aaaa1af3 Reviewed-on: https://chromium-review.googlesource.com/924884Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Bug: 708759 Change-Id: I70bf3f5d7fdb6e4e9dded28d34751fd8a3ee02db Tbr: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/938153Reviewed-by:
-
Troy Hildebrandt authored
We currently force the text in the URL bar to display LTR if the URL bar is unfocused. This CL avoids that if we're displaying query terms instead. Bug: 776988 Change-Id: I563b903c24435adcfca9dad7efcaec3dd64770fa Reviewed-on: https://chromium-review.googlesource.com/935474Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539283}
-
Wez authored
Remove some duplication of code responsible for waiting for processes to exit on POSIX: - Use Process::WaitForExit[WithTimeout]() inside Process::Terminate(wait=true), to wait for the process to exit in response to SIGTERM, before giving up and issuing a SIGKILL. - Process::Terminate() will no longer record the process as Exited() except when wait=true and the process did actually exit. - The EnsureProcessTerminated() and EnsureProcessReaped() helpers are also migrated to use Process::WaitForExit[WithTimeout]() internally. Bug: 806451 Change-Id: I69b4b18ab040adcb1339a55036b679e6cd6809d2 Reviewed-on: https://chromium-review.googlesource.com/920922 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#539282}
-
Steven Holte authored
Records URLs of all NavigationContexts for URL whitelisting, and makes last committed IDs available for WebState objects. Bug: 792662 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If512086a73a893e8e0c4c49df28b4ef624764761 Reviewed-on: https://chromium-review.googlesource.com/877398 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Khushal authored
When taking a snapshot from an SkSurface, it internally maintains a cached copy of the SkImage which is invalidated only when the canvas contents change. This ensures re-using cached texture uploads from this image on subsequent uses. However, when building a PaintImage using this SkImage we generate a new content id for each draw, resulting in a cache miss on cc's decode cache and re-upload with color conversion. Ensure that we use a stable PaintImage::ContentId for the same SkImage. R=junov@chromium.org Bug: 814226, 814219 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie1d8ebb40ccf98593dac3e6f65ca705054e6d90b Reviewed-on: https://chromium-review.googlesource.com/932942 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#539280}
-
Reza.Zakerinasab authored
Bug:816645 Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9 TBR=sky@chromium.org Change-Id: Ifecbd85be7b27e5193d63089a1e0222c3674d1c9 Reviewed-on: https://chromium-review.googlesource.com/938387 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#539279}
-
Christopher Thompson authored
This adds a histogram for tracking the PageEndReason in the SecurityStatePageLoadMetricsObserver for pages during OnComplete (so tracking committed page loads only), split up by the final SecurityLevel of the page. This also adds histograms for tracking the time on page split by final SecurityLevel, and the security level at OnCommit and at OnComplete. Modifies the PageEndReason enum to be explicitly numbered, and added it to enums.xml for histogram tracking. Adds histogram tracking to each relevant browser test for the SSPLMO, and adds a new test for the page being reloaded. This also changes the behavior of the SSPLMO slightly. Before, if the SiteEngagementService did not exist, the SSPLMO would not get created. Now, it gets created, but the SiteEngagement tracking pieces are gated on the SiteEngagementService existing. Bug: 803540 Change-Id: Ic368dd3cb86557f147f49a7206c9919c93ec1a3b Reviewed-on: https://chromium-review.googlesource.com/914468 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#539278}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 816614 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icc16b53ce783c24072901a9d1ddb658e8c54f589 Reviewed-on: https://chromium-review.googlesource.com/938401 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#539277}
-
Khushal authored
When using a non-lazy (bitmap) image in the GPU cache, we assume the upload to be scaled at the mip-level required for draw, when we actually use the original image for the upload. Fix this by considering non-lazy scaled images as lazy generated. This also ensures we use lower gpu memory, by caching downscaled uploads. R=ericrk@chromium.org Bug: 815045, 814219 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4b7d3f4edbcf0e5ba5574512f662a3fdf53cabd6 Reviewed-on: https://chromium-review.googlesource.com/935441Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539276}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Icc2d9d0fedbeb4f2c99cccd7a9120b92b3375ad9 Reviewed-on: https://chromium-review.googlesource.com/922806 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Philip Rogers authored
LayoutBox::ForegroundIsKnownToBeOpaqueInRect is used to compute whether a box's background is obscured and works by recursively checking if any child fully covers the box's background. This logic did not consider children with css clip and a parent would incorrectly be considered opaque even if a child was partially transparent because of css clip. The check for css clip (!HasAutoClip()) has been added in IsCandidateForOpaquenessTest instead of LayoutBox::BackgroundIsKnownToBeOpaqueInRect because css clip applies to both foregrounds and backgrounds. A test has been added for this tricky case (BackgroundNotObscuredWithCssClippedGrandChild). Bug: 581441 Change-Id: Ia49627d7244920512511ed876692868cf8e81177 Reviewed-on: https://chromium-review.googlesource.com/936055Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers (OOO) <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539274}
-
David Benjamin authored
16MB is rather large and is not great for mobile. BoringSSL by default uses a 100kB limit, which is already quite generous. Match that. Bug: none Change-Id: I4bf01e68dc9e60e02af373af31e5b0f68a5f29e2 Reviewed-on: https://chromium-review.googlesource.com/938123Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#539273}
-
Yuwei Huang authored
This CL adds a FakeKeychain implementation that stores data in memory. This makes it easier for testing keychain logic without mocking keychain API calls. Bug: 811380 Change-Id: I2958c8e65eaeee61477498bb6d54ad90609ad20c Reviewed-on: https://chromium-review.googlesource.com/931994Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#539272}
-
Wez authored
Bug: 808075, 816143 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4a60a4e32218c1864a73036f08fc31d49b73c1c2 Reviewed-on: https://chromium-review.googlesource.com/927302Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539271}
-
Paul Jensen authored
Most of this CL is simply plumbing these APIs from the UrlRequest Java API to net::URLRequest. I'm also bumping the API version number so that users have a way to identify APIs with this support. I'm also adding support to Cronet's Java impl. This required moving my ThreadStatsUid class from Cronet's native impl jar to Cronet's common impl jar (as ThreadStatsUid is now used by both the native and Java impls). This required some BUILD.gn changes: In the cronet_package/ output directory we build jars for Cronet's various impls. Since deps of android_library's are only pulled into android_binary's but not into the android_library's output jar, to build Cronet jars containing all of the necessary deps so they can be used independently of Chromium's build infra we must manually unzip dependent jars and zip them back (package them back) into jars that can then be used independently. Cronet previously did this for our native impl jar, but with this change I now do this for our common impl jar as well. I tried to make this more explicit in Cronet's BUILD.gn file by moving these deps that should be used both for compiling the jar and repackaging the jar into separate "_java_deps_to_package" variables to avoid duplicating them at compile and repackage time. I added a test for the new APIs. Cronet tests run with StrictMode enabled to catch leaks. This however turned up a couple issues in my AndroidNetworkLibrary.SocketFd class: 1. In Android versions prior to Marshmallow, ParcelFileDescriptor.detachFd() didn't actually detach from the file descriptor and a later invocation of finalize() could inadvertently close a socket that might still be in use. I fixed this by generating FileDescriptors in a different way on Android version prior to Marshmallow. 2. Calling SocketFd.close() didn't actually result in a call to SocketImplFd.close() as I had intended because Socket.close() doesn't close the SocketImpl unless it had previously been created. I fixed this by avoiding the need to call close(). Bug: 520198 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib697ba6b9a9f1618ec6fedfec6004f4af7f38989 Reviewed-on: https://chromium-review.googlesource.com/930086 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#539270}
-
https://pdfium.googlesource.com/pdfium.git/+log/9141116074f9..611431decd9a $ git log 914111607..611431dec --date=short --no-merges --format='%ad %ae %s' 2018-02-26 thakis Fix -Wunused-variable warning if building with V8 snapshots disabled. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic32651af7414cab5a347d1d982547e483d37a011 Reviewed-on: https://chromium-review.googlesource.com/938284Reviewed-by:
-
Patrick Hulce authored
* Use isTopFrame to determine when to reset resources panel BUG=810000 Change-Id: I8cfde733fee4e97b7066411d849a844bc58525c5 Reviewed-on: https://chromium-review.googlesource.com/934962 Commit-Queue: Patrick Hulce <phulce@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539268}
-
