- 01 Feb, 2018 40 commits
-
-
Raymond Toy authored
Bug: 745778 Change-Id: I7c9d5803bf488e1f7c306b7cae652a182b64d633 Reviewed-on: https://chromium-review.googlesource.com/896392Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533768}
-
Nate Fischer authored
No change to production logic, only changes tests. This adds two new tests to check the Safe Browsing Extended Reporting checkbox: * The checkbox is visible by default * The checkbox can be hidden using onSafeBrowsingHit() This makes no assertion about the default *value* of the checkbox (since this depends on the user's last reporting preference within the browsing session). We're only checking whether it's hidden. This also does some refactoring: * Adds evaluateJavaScriptOnInterstitialOnUiThreadSync() method and uses it where applicable * Renames waitForInterstitialToLoad to waitForInterstitialDomToLoad (to clarify what it actually does) Bug: 738192 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsing*ReportingCheckbox* Change-Id: Ib1d6cc74c037f60d3c026c87264bf9f768884544 Reviewed-on: https://chromium-review.googlesource.com/896790Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533767}
-
Tibor Goldschwendt authored
Procedurally generate a controller model as a replacement for the Gltf mesh. Procedural controller is disabled for now until we have the proper button icons. Bug: 799606 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I09ce54d3374154db9baf352e5a2e7b5b923d1618 Reviewed-on: https://chromium-review.googlesource.com/887626 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#533766}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having two classes with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch renames two classes named DefaultDelegate so that they have different names. Bug: 746957 Change-Id: I15cdab5fd9e51223a76d295991513e6e815e3c51 Reviewed-on: https://chromium-review.googlesource.com/897942Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533765}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the same constant several times will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch deduplicates the kMHTMLExtension constant and puts it in the utility class. An alternative would be to use the literal string "mhtml" without going through a constant at all. Bug: 746957 Change-Id: I869f15c17bcf14a633a3e0711c7e469159e3083f Reviewed-on: https://chromium-review.googlesource.com/897944Reviewed-by:
-
Devlin Cronin authored
v8_helpers::SetProperty() just wraps Object::DefineOwnProperty(). However, with it, we lose the WARN_UNUSED_RESULT on the method, which can lead to dangerous assumptions or not handling edge cases. The method also doesn't really save us anything (the call to DefineOwnProperty is pretty concise). Remove v8_helpers::SetProperty(), and just use DefineOwnProperty directly. Bug: None Change-Id: I261ef1dc4f59f9541067f9fb87a115e49b32dc8d Reviewed-on: https://chromium-review.googlesource.com/896372 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533763}
-
Rouslan Solomakhin authored
Bug: 687438 Change-Id: If141c86a47e5455c94a3ed36b1d6d5bc95033d9f Reviewed-on: https://chromium-review.googlesource.com/897887 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533762}
-
Steven Bennetts authored
This fixes a couple of issues with the 'shared' logic in the config UI: * 'guid' != configured, use source != CrOnc.Source.NONE instead * Share toggle should be visible for all unconfigured networks, even if it can not be changed (i.e. in the login screen). Bug: 807494 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f068adbe04b9011763426e9b9f72ac0ebb01535 Reviewed-on: https://chromium-review.googlesource.com/896023Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533761}
-
Takumi Fujimoto authored
This CL makes WiredDisplayMediaRouteProvider not check for the primary display when there is 0 or 1 display. This should fix the crash in which WDMRP attempts to get the primary display when the primary display ID is invalid. Bug: 803881 Change-Id: I095ff7a69b1777c3466d2b6378fcd95e497c5641 Reviewed-on: https://chromium-review.googlesource.com/895389Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#533760}
-
Joy Ming authored
Many recent bugs in downloads notifications resulted in many different temporary fixes that made the logic for the service and notifications very confusing. This CL attempts to isolate out the Android-based corner cases related to notification adjustment for the foreground service. This makes these cases easier to test and understand. Change-Id: I9057ca59a88583c986a9d2d78e159ee02adf0a55 Reviewed-on: https://chromium-review.googlesource.com/879819 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#533759}
-
Peter Wen authored
android.test.TouchUtils is deprecated. Bug: 807766 Change-Id: Ib30f91f13afc9a1f7daf19a144dbd43eb06917b7 Reviewed-on: https://chromium-review.googlesource.com/897912Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533758}
-
Jonathan Metzman authored
TBR=mbarbella@chromium.org Bug: 769578 Change-Id: Id2039ce1c97d42723c5616c4655d2c9c39ed130f Reviewed-on: https://chromium-review.googlesource.com/897984Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533757}
-
Koji Ishii authored
On Windows, FontCache creates an SkFontMgr using SkFontMgr_New_DirectWrite() if the font manager isn't explicitly set, so that unit tests work. To clarify the suspicious that this test code is running in the production environment, this patch captures the information in the minidump. Bug: 561873 Change-Id: Ib60c9a569242a242c095180bffb0024fc03f129b Reviewed-on: https://chromium-review.googlesource.com/895167 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#533756}
-
Jonathan Metzman authored
TBR=thakis@chromium.org, mbarbella@chromium.org Bug: 769578 Change-Id: I7acdf703c5ac82a791e94fcad993d2b2f1657017 Reviewed-on: https://chromium-review.googlesource.com/896687 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
-
Dale Curtis authored
This specifically tests the force suspend signal sent by the browser when tabs are closed. Full suspend/resume testing is handled by layout tests for ease of test writing and ready state manipulation: https://chromium-review.googlesource.com/c/chromium/src/+/882283 This is part 1/2, a later CL will add an MSE variant of this test. BUG=756897 TEST=it's all tests! Change-Id: I588ccf5feb285f972e392c17498c2eaa071a86c6 Reviewed-on: https://chromium-review.googlesource.com/881832Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533754}
-
Dominic Mazzoni authored
The widget delegate can be null when the native widget is destroyed. Bug: 678889 Change-Id: Id6e24aceeec59caea48b736309b63a1301823136 Reviewed-on: https://chromium-review.googlesource.com/833181 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533753}
-
Eugene Ostroukhov authored
"other" service workers section should only collapse when the label was clicked. Bug: 807232 Change-Id: Ib048968ed555121c385a176a602a84a00853b152 Reviewed-on: https://chromium-review.googlesource.com/897913 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533752}
-
Kevin Bailey authored
This change is to split SetInputInProgress() so the notifications occur after the Start. This change reduces calls to StartAutocomplete from 2 to 1 on the first character typed. Bug: 669727 Change-Id: I6fbba62284a3cd6c8192ffb9c9d1381433ebe798 Reviewed-on: https://chromium-review.googlesource.com/883947Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533751}
-
Joe Downing authored
This flag will be used for development / testing of the KeyboardLock feature. My plan is to have something available for testing (but behind the flag) in M66. We also plan to use this flag for rolling out the change when it is ready for launch. BUG=680809 Change-Id: I2e4f7ea16c458cab053a998ae1de4d9d7ab7fbec Reviewed-on: https://chromium-review.googlesource.com/896022 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#533750}
-
Scott Graham authored
After https://chromium-review.googlesource.com/c/chromium/src/+/876683. Bug: 644525 Change-Id: Ic8f71d5f4cababaa252fd4c9155ea8b34b29158b Reviewed-on: https://chromium-review.googlesource.com/896695Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533749}
-
https://webrtc.googlesource.com/src.git/+log/10d9d59db164..28dbf9724281 $ git log 10d9d59db..28dbf9724 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ae6f051431514c07e64b999ef3b76b9384dcf5d Reviewed-on: https://chromium-review.googlesource.com/897934 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533748}
-
Evan Stade authored
This code does not appear to be necessary any more. Bug: 578868 Change-Id: I1437f18f800fe6293bc01ac207f604da2c9afb6c Reviewed-on: https://chromium-review.googlesource.com/897042Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#533747}
-
Daniel Park authored
Reverts to method before setClipBounds was used. Removes canvas.save and restore as they weren't doing anything Removes check for clip bounds = 0 since it was never 0 Adds scrollX() to rectangle clip bounds for canvas Bug: 805479 Change-Id: I3d32f8dd9526ca7d5504d702283f8fcd2364d678 Reviewed-on: https://chromium-review.googlesource.com/896635Reviewed-by:
-
Dominick Ng authored
This is a reland of 58ab87ff. Original change's description: > Consolidate app banner testing. > > This CL removes several different app banner testing files, and replaces > them by calling the necessary JavaScript setup code in one test file. > For instance, all tests will no longer have the "appinstalled" title > overwriting, as that will only be active when the appropriate setup > JavaScript is run. > > This allows future tests to be more easily added, and reduces collisions > when manipulating the page title. > > BUG=806923 > > Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 > Reviewed-on: https://chromium-review.googlesource.com/892182 > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532978} Bug: 806923 Change-Id: Ia85a5be0828ad0820a891f8cde9d9e492dc0b831 Reviewed-on: https://chromium-review.googlesource.com/896326Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Ran Ji authored
We have limited number of jni local references, leaking jobjects inside loop may cause local reference table to overflow. Bug: 726426 Change-Id: I4b1ffc9fcb74d1a78d0415f9d9c79533facb7839 Reviewed-on: https://chromium-review.googlesource.com/895843 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533744}
-
Marijn Kruisselbrink authored
Revoking right after navigating and/or loading script should not break the loading. Bug: 800901 Change-Id: I5b2fc378ae4681fb4d42e1e3742111f67a2d1a41 Reviewed-on: https://chromium-review.googlesource.com/894843 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#533743}
-
Gayane Petrosyan authored
When navigating to about:version/?show-variations-cmd an additional section will appear showing complete set of client's variations in the command line formatting that can be used to reproduce the same exact state of variations. The displayed info contains all the trials including not activated ones marked by '*' along with the corresponding group assignment. It will also contain enabled and disabled features where the ones that should use the default value will be marked with '*'(e.g. expired trials). Trials that are unforcable through command line will be shown but warning will be shown when processing the command line input with unforcable trial. This CL doesn't cover iOS. As the displayed text is huge I also changed the width of the text in the about:version page (not mobile) to be 60% of the page with a minimum of 800px as it used to be. Bug: 694675 TEST=unit test, manual testing 1. run chrome with --fake-variations-channel=beta 2. copying command line input from about:version/?show-variations-cmd 3. run chrome without channel but with command line input copied in step 2. 4. confirm about:version/?show-variations-cmd page shows the same info Change-Id: Ie73174bd5bd1a02baa75cd3294fd36cf63b3c923 Reviewed-on: https://chromium-review.googlesource.com/865286 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533742}
-
Miguel Casas authored
Every git cl upload I get a bunch of presubmits like: Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018) So this CL does the transition: Bind --> BindOnce, Closure --> OnceClosure, Callback --> OnceCallback, use of Base::Passed(), in method signatures, we change const & to moving the argument, and instead Run()ning the Callback we use std::move(cb).Run(). Threw in a few consts where applicable. No new code otherwise, tests (and asan etc) should cover it all. Bug: 803975, 714018 Change-Id: I48338984a99627b5de34c5da45dadbdc7c0409e5 Reviewed-on: https://chromium-review.googlesource.com/893822Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533741}
-
erikchen authored
Developers can still manually upload via chrome://memory-internals. Bug: 751321 Change-Id: If0f96419984c407cb073d5391f0042cdfaed1f04 Reviewed-on: https://chromium-review.googlesource.com/897744Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533740}
-
Joy Ming authored
This CL makes the DownloadsFilter enum into an IntDef. Change-Id: Idcec8f6ed8a818057e15be3825341da5f9336e9c Reviewed-on: https://chromium-review.googlesource.com/896122 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Peter E Conn authored
Bug: 808015 Change-Id: Id4a83971a028caa7bfd6e5b00d7d5f16bdb49213 Reviewed-on: https://chromium-review.googlesource.com/897527Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#533738}
-
CrystalFaith authored
Extension relied on persistent background script. Updated background.js to use storage. Updated manifest background to non-persistent. Bug: none Change-Id: I1e6e54d9da2b1d880367bb4369253f5d5e6ca0cb Reviewed-on: https://chromium-review.googlesource.com/885263 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533737}
-
Evan Stade authored
This hides all notification popups. Its only purpose is for making sure popups don't interfere with automated tests. Bug: 807101 Change-Id: I7776af1b0fbd795ed1899a78fa5a7aef1c7b6f9a Reviewed-on: https://chromium-review.googlesource.com/894152 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#533736}
-
Juan Antonio Navarro Perez authored
Bug: 807936 Change-Id: Iba1bf251aa822753251768deeea02e809cc93860 Reviewed-on: https://chromium-review.googlesource.com/897667Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#533735}
-
Samuel Huang authored
This CL adds ensemble patching (AKA Layer 3 patching) to Zucchini, where patches are generated and applied on "old" and "new" archives that contain uncompressed executable "elements", which need to be detected and matched first. - HeuristicEnsembleMatcher performs element detection and matching. - Resulting matched "elements" undergo architecture-specific patching (AKA Layer 2 patching), but on failure, raw patching (AKA Layer 1 patching) is used. - "Gaps" are contents in archives that are not elements. These use raw patching, and are computed separately from element patching to reduce peak memory (since these require suffix array of the entire "old" archive). - In the patch format, "gaps" are represented as "no-op" elements, i.e., raw patches without references. - This CL focuses on Zucchini-gen, since Zucchini-apply already supports Ensemble patch application. - After this CL, Zucchini will be equally usable as Courgette. Bug: 729154 Change-Id: Id828186cda74885ee6992b17f641e491efe79c40 Reviewed-on: https://chromium-review.googlesource.com/891489 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#533734}
-
https://pdfium.googlesource.com/pdfium.git/+log/1fc533150a27..71a7d377ff36 $ git log 1fc533150..71a7d377f --date=short --no-merges --format='%ad %ae %s' 2018-02-01 hnakashima Deprecate FPDFDest_GetPageIndex and create a fixed version. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5e5656b18e94dad049e11d8b6c6ad3446fd5a6e6 Reviewed-on: https://chromium-review.googlesource.com/897933 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533733}
-
Carlos IL authored
In preparation for an EV study, metrics from PageInfo actions need to be separate for SECURE sites and EV_SECURE sites. This CL deprecates the Security.PageInfo.Action.HttpsUrl.Valid histogram and creates Security.PageInfo.Action.HttpsUrl.ValidEV and Security.PageInfo.Action.HttpsUrl.ValidNonEV. Bug: 803530 Change-Id: I0e28b0ac7b53d3838cb74b61d10662d9d446fd18 Reviewed-on: https://chromium-review.googlesource.com/896184Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#533732}
-
erikchen authored
The heap dump v2 format requires that multiple heap dumps in the same trace share IDs for nodes and strings. Since the JSON exporter is stateless, and isn't aware of whether the dump will be part of a given trace, just give all nodes and strings a unique ID. Bug: 758739 Change-Id: I87002ce9a84c60ee7a41ac38d3702248a4aa6ae4 Reviewed-on: https://chromium-review.googlesource.com/895666Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533731}
-
https://skia.googlesource.com/skia.git/+log/5f9ee7cc53d2..82a4c055d14f $ git log 5f9ee7cc5..82a4c055d --date=short --no-merges --format='%ad %ae %s' 2018-02-01 kjlubick Get better stacktraces for *SAN builds 2018-01-30 csmartdalton ccpr: Pack wind into existing varyings 2018-02-01 reed validate indices for vertices 2018-02-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 8efd1268e..c0db9adde (2 commits) 2018-02-01 halcanary SkQP: remove model slack, README 2018-02-01 egdaniel Fix GrBackendTextureImageGenerator to hold context lock till all proxies are gone 2018-02-01 kjlubick Check for nullptrs when fuzzing region_deserialize 2018-02-01 caryclark auto table generation 2018-02-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 1776fd08e..8efd1268e (1 commit) 2018-02-01 robertphillips Implement GPU/OpList DDLs Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ideca9567f7475d7631405f9a9838e16794c4b494 Reviewed-on: https://chromium-review.googlesource.com/897931 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533730}
-
Nico Weber authored
clang will now warn on non-empty case and default blocks that don't end with a break statement. For cases where fallthrough is intentional, end the block with FALLTHROUGH; from base/compiler-specific Depends on these changes to DEPS rolling into chromium: https://pdfium-review.googlesource.com/#/c/pdfium/+/24790 https://chromium-review.googlesource.com/c/angle/angle/+/895728 https://chromium-review.googlesource.com/c/v8/v8/+/895704 https://chromium-review.googlesource.com/c/breakpad/breakpad/+/895705 https://github.com/google/cld3/pull/9 We'll enable this for more build configurations once they can build with the warning enabled. (Also change a single file that was needed to get the dcheck_always_on build to work, and another one that is built only in static builds.) Bug: 177475,808047 Change-Id: Ic6a3fbf78a9cb2b5e928ce7973e67e4a39629dfd Reviewed-on: https://chromium-review.googlesource.com/895726Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#533729}
-
