- 27 Nov, 2019 40 commits
-
-
Andrew Grieve authored
Was missing forward_variables_from() for these. Change-Id: Iacdbe5b00ffd39bb425f488a7604b86f522f57ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937512 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719647}
-
Miyoung Shin authored
This CL converts SharedWorkerConnector mojom interface client in content and blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ica85b49fa128fe6a6a15e0fd01b0189f7c8b1d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935780 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719646}
-
Javier Ernesto Flores Robles authored
Updates the way more info is presented to be in a popover. Which looks better and takes less space. See attached bug for screenshots. Bug: 1028095 Change-Id: I633a3e7ec614a4ec87d93bce1d02e8b50f015bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940169Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#719645}
-
Chris Sharp authored
Disable GooglePasswordManagerNavigationThrottleTestWithPasswordManager.PasswordsWithGPMAndSyncUserClickedLink This test is flaky on ChromeOS, so disable it there. TBR=vasilii Bug: 1029034 Change-Id: I0b67a7885d6e35951a5392c1c432adfa1efdb3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939910Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719644}
-
Chris Sharp authored
This reverts commit 26ae2ec0. Reason for revert: WebUITabStripInteractiveTest.CanTypeInOmniboxAfterTabStripClose is often failing on Linux ChromiumOS MSan Tests. Original change's description: > Re-focus View on tab strip close > > When the WebUI tab strip's WebContents gains focus, the focused > TextInputClient changes while the focused View does not. This causes > text input to stop working in the omnibox despite it having Views-focus. > > This blurs and re-focuses the currently focused View. For the Omnibox, > this makes it re-install itself as the focused TextInputClient. > > This is a workaround and should be removed once bug 994350 is fixed. > > Bug: 1027375, 994350 > Change-Id: I2be055110535dc6164a7d31a64a3cf503fae7a7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935729 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719473} TBR=dfried@chromium.org,collinbaker@chromium.org Change-Id: Ie42b57d5e4b40f28fc77eb48c36c9ecddf5caba7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027375, 994350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940451Reviewed-by:
-
Michael Spang authored
This needs to run autoreconf. Bug: 1026476 Change-Id: Ibe0c0553258dd6d05c43715e32b24e11b2c4cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938838 Auto-Submit: Michael Spang <spang@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#719642}
-
Juanmi Huertas authored
Trying to enable back these test as some fixes have been done related to crbug.com/922951 and it probably is fixed again. Bug: 1019079 Change-Id: I15c3bac8b75f329a3f65f1d3c44adfc80b02bcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932094Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#719641}
-
Matt Falkenhagen authored
Bug: 1007763 Change-Id: I6fc062daeefec9c2b0e748d1ad7aa9e0904dc774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938988Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f8a6ce70. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ice849f5c06bb9cfe0aba16624d6bd0b86d449cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940129Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719639}
-
Nico Weber authored
Except on Chrome OS for now, https://chromium-review.googlesource.com/c/chromium/src/+/1306406/23/components/exo/wayland/zwp_text_input_manager.cc#123 Bug: 1024203 Change-Id: I05995c4565e34f46c3f8cdb32a8cc3ab46ff17b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937652 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719638}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d1cfda327db2..5d4133ef0171 git log d1cfda327db2..5d4133ef0171 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 aerotwist@chromium.org Migrates settings/ to esm 2019-11-27 tvanderlippe@chromium.org Migrate cm_modes/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@5d4133ef0171 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1006759,chromium:1011466 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iad422469ba53141eb3c8b59087feccd235125f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939828Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719637}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a672dd089c5..552673083f4a Created with: gclient setdep -r src-internal@552673083f4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I700de5615b968f7019704a0901c4d75201bfcbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940448Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719636}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c241b5896524..861ac61cb1a9 git log c241b5896524..861ac61cb1a9 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jvanverth@google.com Fix warning in Fuchsia build 2019-11-27 rosasco@google.com Add deps file for manifest. Use libwebp always. Created with: gclient setdep -r src/third_party/skia@861ac61cb1a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Iada4ccb639efa18ce6809c0cd45a4f40b067da49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939773Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/27d3c9399925..74d4bf9893fc git log 27d3c9399925..74d4bf9893fc --date=short --first-parent --format='%ad %ae %s' 2019-11-27 syoussefi@chromium.org Remove !empty() assert on FastVector::data() 2019-11-27 jmadill@chromium.org Tweaks to roll_deps.py. Created with: gclient setdep -r src/third_party/angle@74d4bf9893fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026414 Tbr: cwallez@google.com Change-Id: I966adf7f5492d41b6ffbeaccc113a565d2bb6fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940079Reviewed-by:
-
Daniel McArdle authored
Bug: 1022111 Change-Id: Ie53859f448dff5fe60486738990e6bfd60cf5550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937783Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#719633}
-
Michael van Ouwerkerk authored
Bug: 1021150 Change-Id: Ia3c3c49bbcbcf614fafbc9c46246cc124c4bbbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940170Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719632}
-
chrome://flagsMounir Lamouri authored
kOnDemand mode isn't being used by default since M75. We are using the opportunity to deprecate the chrome://flags. SurfaceLayerMode is still needed because some targets need to disable the feature. Bug: 901513 Change-Id: Iaf55a1b583d080ce04379566aaf03deb0b9a9123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756396Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#719631}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b6f642d9c3b..9d27d96fff72 git log 5b6f642d9c3b..9d27d96fff72 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 buss@google.com Fix android x64 compilation using Ninja. Created with: gclient setdep -r src/third_party/perfetto@9d27d96fff72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I574c031fd5313aecfa31611f31a8203005087b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939829Reviewed-by:
-
jongdeok.kim authored
Change-Id: I7d6162c2dee31d1776d8ec36175ade1b360f0a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918787 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719629}
-
Tommy Li authored
For historic reasons, LocationBarView "dug into" OmniboxViewViews and triggered some additional actions on focus. This CL moves those actions into OmniboxViewViews to reduce the need for LocationBarView to be concerned with OmniboxViewViews' behavior. Also this CL deletes a feature flag that's been Enabled by default for a long time, and exists just as an unused killswitch. Bug: NONE Change-Id: Id29abca060b5e8b7f1cd8b31b6c202833303a849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937773Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#719628}
-
Miyoung Shin authored
This CL converts WebSocketConnector mojom interface client in content and blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I4177c048fa87cc18bffbcd31b1cd9d74825fc267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935291 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Ryan Harrison authored
BUG=dawn:285 Change-Id: I4d05df0baa8dadf4b52f908eab29176c9c50eabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940547 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719626}
-
Sam Maier authored
Change-Id: I299e3e6515afae265f24aa3330140e1958a887a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940528 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Josh Nohle authored
Bug: 951969 Change-Id: If303af7a91b01692e99c5b10cfafa8435262df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913180Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#719624}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/74cebd68792d..2559fc0b842c git log 74cebd68792d..2559fc0b842c --date=short --first-parent --format='%ad %ae %s' 2019-11-27 rharrison@chromium.org Removing for_fuzzers target Created with: gclient setdep -r src/third_party/dawn@2559fc0b842c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I38c59d366aa0841674d911b2034047cdfef5bb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939953Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5a297f389e0..df0056acafd6 git log b5a297f389e0..df0056acafd6 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 vapier@chromium.org tast_test_stages_unittest: handle json failure messages in Python 3 2019-11-27 vapier@chromium.org fake_cidb: fix sorting logic 2019-11-27 vapier@chromium.org report_stages: use utf-8 encoding with commands 2019-11-27 vapier@chromium.org cbuildbot: manifest_version: fix encoding when writing 2019-11-27 shaochuan@chromium.org Revert "chromeos_config: Disable betty-pi-arc-release VM Tests" 2019-11-27 vapier@chromium.org swarming_lib: sort --tags when adding 2019-11-27 vapier@chromium.org sdk_stages_unittest: fix test under Python 3 2019-11-27 vapier@chromium.org deploy_unittest: fix tests under Python 3 2019-11-26 ahassani@chromium.org paygen: disable payload verification 2019-11-26 victorhsieh@chromium.org setup_adb: remove unnecessary mtp config from adb trigger 2019-11-26 vapier@chromium.org avoid deprecated dict has_key method 2019-11-26 vapier@chromium.org buildbucket_v2/ts_mon: change protobufs imports to relative 2019-11-26 vapier@chromium.org cbuildbot: delete DetectRelevantChangesStage 2019-11-26 vapier@chromium.org artifact_stages_unittest: fix old exception message usage 2019-11-26 vapier@chromium.org puppet_metrics_unittests: switch to io.StringIO 2019-11-26 ahassani@chromium.org payload-tryjobs: Run uprev before initsdk 2019-11-26 vapier@chromium.org config: delete all CQ/paladins 2019-11-26 seanabraham@chromium.org lib: remove Legacy-Commit-Queue references 2019-11-26 vapier@chromium.org loman/repo_manifest: change ElementTree.tostring return to unicode Created with: gclient setdep -r src/third_party/chromite@df0056acafd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ic4847dc55581cfb023937319dca70808051d822d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939952Reviewed-by:
-
Marc Treib authored
On Android, Sync only subscribes for SESSIONS invalidations while the Recent Tabs page is open. Before this CL, the corresponding *un*subscription was delayed by one hour, to avoid subscription/unsubscription churn. However, this task was not persisted, i.e. it got lost if Chrome was shut down within that hour. The new FCM-based invalidations system does not do any cleanup on startup (in contrast to the old Tango system), meaning such an unsubscription would then never actually happen. This CL removes the unregistration delay, as a quick fix to avoid most of the "dangling subscriptions". It also adds a feature "SyncUseSessionsUnregisterDelay" (disabled by default) to go back to the previous behavior. Bug: 1024817 Change-Id: Iaaf1afca3ba8719a3837dd760e4bd169d4d3c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919209Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#719621}
-
behdad authored
Coping the strings used in tracing is not necessary because the used strings are static literals. Also this is not necessary in case of values (not category/event/argument names) passed to trace events. Bug: chromium:1025973 Change-Id: Iabd03e8bf54353663d886c9bb53b7daaa4001919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934772Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719620}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGViewElement> as new downcast helper 2. Use IsA<SVGViewElement>(element) in place of IsSVGViewElement(element) Bug: 891908 Change-Id: Ib22d10d67dfa70323919a4d3fdc03d85bbfde055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936689Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719619}
-
Stephen Chenney authored
I believe a patch landed to fix this issue, so the change is expected. TBR: chrishtr@chromium.org Bug: 946532 Change-Id: If1d27ee3508ce6ddbf3fad9ca9eaf408c00d1288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940508Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#719618}
-
Takumi Fujimoto authored
CastMediaSessionController receives media action commands from CastMediaNotificationItem and forwards them to a media controller in Media Router, which then sends the command to the Cast device. Bug: 987479 Change-Id: Ib7ce9b7be603d47f866e34e8c23154daf36bfeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927377Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#719617}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b5843d2..2e0e0a78 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I48a9dc62e22a2431655e14399750313b0e5073e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719616}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a64e0786130f..0a672dd089c5 Created with: gclient setdep -r src-internal@0a672dd089c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I210359c7fd271ea2a5eeeea9b42100b49ae280c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940291Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGScriptElement> as new downcast helper 2. Use IsA<SVGScriptElement>(element) in place of IsSVGScriptElement(element) Bug: 891908 Change-Id: I74d59ca2549e7e19291f205b37b721e4eb3da5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936690Reviewed-by: -
jongdeok.kim authored
This CL changes to use SetRoundedCornerRadius, and removes mask layer. Bug: 1005390 Change-Id: Id3b913ea2b20cb68c94ecda1d4cd14fa6e969283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936694 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#719613}
-
Roman Sorokin authored
Also center similar to other illustrations Bug: 1019879 Change-Id: I864c425d46694d9370d48636daf996c8b27d657e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939407Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719612}
-
Tim Schumann authored
Bug: 1028594 Change-Id: If251adbf93f56a674a1247d3ae20deb403eac9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936769Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719611}
-
kylechar authored
The existing RunOnceClosure<N> implementation wouldn't compile if the Nth argument was a OnceClosure passed by value. Use the same action machinery as RunOnceCallback<N> to fix this. Bug: none Change-Id: I4fe5fe187ead7bedd084b26575e74da7fab3f7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925556Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/03e4c95c31e6..c241b5896524 git log 03e4c95c31e6..c241b5896524 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 bsalomon@google.com Make fragment processor iterators work with range for loops. 2019-11-27 egdaniel@google.com Handle failures in VkCommandBuffer creation. Created with: gclient setdep -r src/third_party/skia@c241b5896524 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Iad0bea6f72f2c4a983b320f7ac7fa46225a1344d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939951Reviewed-by:
-
Corentin Wallez authored
This reverts commit 8834f5a3. Reason for revert: Likely culprit for consistent failure on Linux FYI Debug (NVIDIA): both GpuProcess_swiftshader_for_webgl and GpuProcess_feature_status_under_swiftshader fail DCHECK(gpu_feature_info_.IsInitialized()) Original change's description: > Replace GPU Compositing feature with GL > > GPU compositing is never specifically blacklisted in > software_rendering_list.json, only when all are disabled, so remove it, > and add GPU_FEATURE_TYPE_GL. Use this as a proxy for GPU compositing for > now. This will need to be fixed to support the case where GL is > blacklisted, but Vulkan is still enabled. > > Bug: 1005383 > Change-Id: I0330021cfa59c6c4cf2719785f7931e53ec50f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917753 > Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719399} TBR=zmo@chromium.org,kylechar@chromium.org,sgilhuly@chromium.org Change-Id: I65f801a3d790f864367101cbaabc7991308ffe03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940172Reviewed-by:
-
