GitLab

This CL refactors the logic to fit all the folder
dropping logic in CalculateFolderDropTarget().

BUG=419642

Review URL: https://codereview.chromium.org/614213004

Cr-Commit-Position: refs/heads/master@{#300068}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/95ffa59..e33da08

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/648293008

Cr-Commit-Position: refs/heads/master@{#300067}

Sometimes, [NSColor controlColor] returns "white". With no alpha. This
causes a failed CHECK().

This should be covered by NativeThemeMacTest.SystemColorsExist, but
AppKit doesn't cooperate there. In native_theme_unittests,
native_theme->GetSystemColor(kColorId_UnfocusedBorderColor) always gives
0xffe8e8e8. However, in the same Chrome process [NSColor controlColor]
can return both 0x??ffffff and 0xffe8e8e8 when opening up the
toolkit-views task manager.

This is probably an AppKit bug, but we shouldn't trust AppKit to give us
alpha channels anyway. So, this CL adds handling for single-component
system colors.

BUG=424040, 379086

Review URL: https://codereview.chromium.org/658033002

Cr-Commit-Position: refs/heads/master@{#300066}

TEST=./build_tools/build_sdk.py --tar
TEST=trybot
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3851

Review URL: https://codereview.chromium.org/619763005

Cr-Commit-Position: refs/heads/master@{#300065}

We don't need to wrap the data with WebThreadSafeData here. Just use a
pair of const char* and size_t.

This is Chromium side CL

Blink side CL: https://codereview.chromium.org/611923002/

R=yhirano,jam
BUG=417093

Review URL: https://codereview.chromium.org/610333002

Cr-Commit-Position: refs/heads/master@{#300064}

Platform-specific implementations now have their own derived classes.
This allows some cleanup of platform-specific hackery in clipboard.h,
and paves the way for adding a fake clipboard implementation in the
future for testing.

BUG=319285

Review URL: https://codereview.chromium.org/658963003

Cr-Commit-Position: refs/heads/master@{#300063}

This patch passes proper data instead of fake one to Notify(). Also, child
changes are now passed as a scoped_ptr and a reference to avoid unnecessary
copies.

Note, that end to end browser tests will come once notifications are wired to
chrome.fileManagerPrivate.

TEST=Tested manually.
BUG=248427

Review URL: https://codereview.chromium.org/656393002

Cr-Commit-Position: refs/heads/master@{#300062}

BUG=N/A
TEST=N/A

Review URL: https://codereview.chromium.org/654823002

Cr-Commit-Position: refs/heads/master@{#300061}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/660093004

Cr-Commit-Position: refs/heads/master@{#300060}

* pass --site-per-process and --gtest_filter as separate arguments (this was breaking the windows bot)
* use wildcards for better readability
* fix syntax by removing the extra "-" from the list of failing tests
* remove a test that we've recently fixed from the list

BUG=417518

Review URL: https://codereview.chromium.org/660133003

Cr-Commit-Position: refs/heads/master@{#300059}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/513e6f3..95ffa59

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/663703002

Cr-Commit-Position: refs/heads/master@{#300058}

BUG=414675

Review URL: https://codereview.chromium.org/660093003

Cr-Commit-Position: refs/heads/master@{#300057}

But.. first make some tests fail.

DesktopNativeWidgetNoPaintAfterCloseTest currently passes but it
shouldn't. WidgetTests DesktopNativeWidgetNoPaintAfterHideTest and
TestWindowVisibilityAfterHide were also passing, but
NativeWidgetMac::Hide() is a no-op, so that shouldn't be the case.

This CL (first) makes them all fail on Mac. To do this,
BridgedNativeWidget needs to call Widget::OnNativeWidgetPaint() rather
than painting the RootView directly. And TestWindowVisibilityAfterHide
must show the widget.

DesktopNativeWidgetNoPaintAfterCloseTest was then fixed by skipping a
paint when the window is not visible, as toolkit-views expects. However,
Cocoa paints the window before changing -[NSWindow isVisible]. To fix,
intercept -[NSWindow orderWindow:relativeTo:]. We need to do this anyway
to send Widget::OnNativeWidgetVisibilityChanged(), but that's left for a
follow-up.

BUG=378134

Review URL: https://codereview.chromium.org/654393002

Cr-Commit-Position: refs/heads/master@{#300056}

Some of the forward declarations and #includes are not necessary.
Hence, removing them.

Review URL: https://codereview.chromium.org/655433004

Cr-Commit-Position: refs/heads/master@{#300055}

Trivial file renaming...

BUG=359244
TEST=content_shell && content_unittests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/642813006

Cr-Commit-Position: refs/heads/master@{#300054}

Review URL: https://codereview.chromium.org/645043003

Cr-Commit-Position: refs/heads/master@{#300053}

From typ commit df1f462ec978d47c7f092e86f4be3fafc7cc446f:

    Rework typ to handle unimportable modules better.

    multiprocessing on windows requires that the __main__ module
    be importable in order to work properly. If developers are mostly
    working and testing on unix, it's possible for them to not realize this
    and attempt to call typ from a wrapper script that may not be
    importable, and then get unexpected errors.

    This change makes the typ entry points check if it is being called
    from an unimportable __main__, and error out if so. Developers
    must then specify several different ways to work around this by passing
    the 'win_multiprocessing' flag to typ.main() or typ.Runner.main().

    The flag takes one of the values specified in the typ.WinMultiprocessing
    class:

      ignore -  The tests are not expected to run on Windows, so ignore
                the fact that __main__ is not importable. (If the tests
                are actually run on Windows, it will err out).

      run_serially - Run serially (one at a time) on Windows, regardless
                of how many cores are available (hence multiprocessing is
                not used).

      spawn -   Typ will convert the args it was passed back into a command
                line, and spawn off an invocation of itself on Windows to actually
                execute the tests in parallel (Since typ itself is importable,
                this works fine). This mode cannot be used in conjunction
                with contexts or setup and teardown functions at this time.

      force -   This is like 'spawn', except that it forces the spawn even
                on non-Windows platforms. This mostly exists for testing.

    As part of this change, we also no longer expose spawn_main() as a public
    entry point (main() handles spawning instead), and merge the cmdline.py
    code directly into runner, as it didn't make sense to split things
    across the two modules once runner had to do the importability checking.

    We also add a host.call_inline() wrapper that is a dumb wrapper
    around subprocess.call(); it does not do the output capturing that
    host.call() does, and is used when spawning the typ subprocess if needed.

TBR=dtu@chromium.org
BUG=402172

Review URL: https://codereview.chromium.org/660133004

Cr-Commit-Position: refs/heads/master@{#300052}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cd824db..513e6f3

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/654613005

Cr-Commit-Position: refs/heads/master@{#300051}

This is to provide a more user friendly error. This:

  AssertionError: Pageset archive_data_file path must be specified.

instead of this:

  AttributeError: 'NoneType' object has no attribute 'AddNewTemporaryRecording'

BUG=

Review URL: https://codereview.chromium.org/660143002

Cr-Commit-Position: refs/heads/master@{#300050}

The browser action button on the far right is invisible when user will
be dragging the browser actions container.

Because the browser action buttons, which don't locate at the extension
bar, will be set to be hidden when the dragging finished. So the hidden
buttons must be set to be visible before the dragging starts in the next
time in order to let user know which extension is coming.

BUG=424080
TEST=manually tested.

Review URL: https://codereview.chromium.org/662593002

Cr-Commit-Position: refs/heads/master@{#300049}

- FILE_BROWSER_GALLERY_VIDEO_ERROR -> VIDEO_PLAYER_VIDEO_FILE_UNSUPPORTED
- FILE_BROWSER_GALLERY_VIDEO_DECODING_ERROR -> VIDEO_PLAYER_PLAYBACK_ERROR
- FILE_BROWSER_GALLERY_VIDEO_LOOPED_MODE -> IDS_VIDEO_PLAYER_LOOPED_MODE

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/611243003

Cr-Commit-Position: refs/heads/master@{#300048}

Create/Get have been replaced by Open which will first attempt to Get() followed by Create() if Get() failed.

CLs in this three-legged-patch:

*1. Add open to browser - https://codereview.chromium.org/664433003/
2. Add open (remove get/create) to Blink - https://codereview.chromium.org/638023003
3. Remove get/create from browser - https://codereview.chromium.org/663503002/

Note that the three CLs have been tested together and pass tests locally.

BUG=423942

Review URL: https://codereview.chromium.org/664433003

Cr-Commit-Position: refs/heads/master@{#300047}

BUG=413855

Review URL: https://codereview.chromium.org/640123002

Cr-Commit-Position: refs/heads/master@{#300046}

Some of the record_wpr unittests are causing issues. By passing in the --browser
flag with the existing browser_type for these tests, we should be able to avoid
this flakiness (caused by waiting for another browser to finish launching).

BUG=424439

Review URL: https://codereview.chromium.org/657293007

Cr-Commit-Position: refs/heads/master@{#300045}

Apparently at one point in time the GetCommandLine methods returned no
value for a missing process. Now it always returns a value or an
exception. So this code should be looking for the exception instead.

BUG=

Review URL: https://codereview.chromium.org/659073005

Cr-Commit-Position: refs/heads/master@{#300044}

Similarly to BufferingFileStreamReader, this CL introduces a analogical
BufferingFileStreamWriter class which groups consecutive Write() calls in order
to limit number of IPC calls.

TEST=browser_tests: *FileSystemProvider*BufferingFileStreamWriter*
BUG=398338

Review URL: https://codereview.chromium.org/502973005

Cr-Commit-Position: refs/heads/master@{#300043}

Otherwise the decoder attempts to clear the nonexistent framebuffer, which causes an unexpected error and later a crash.

BUG=424024

Review URL: https://codereview.chromium.org/664583004

Cr-Commit-Position: refs/heads/master@{#300042}

In this change only attachment payload is stored, support for metadata
will be in separate change.
Also in_memory_attachment_store_unittest is moved into test_template.
This test is now used for both stores.

BUG=
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/652723003

Cr-Commit-Position: refs/heads/master@{#300041}

BUG=423621

Review URL: https://codereview.chromium.org/660653006

Cr-Commit-Position: refs/heads/master@{#300040}

The associated bugs look addressed. In some cases, even the mentioned
classes themselves are not present any more.

BUG=none
TEST=it compiles.

Review URL: https://codereview.chromium.org/653243004

Cr-Commit-Position: refs/heads/master@{#300039}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6998a13..cd824db

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/664613002

Cr-Commit-Position: refs/heads/master@{#300038}

BUG=421393

Review URL: https://codereview.chromium.org/660733006

Cr-Commit-Position: refs/heads/master@{#300037}

BUG=419210, 423634
R=cpu@chromium.org, eroman@chromium.org, sky@chromium.org

Committed: https://crrev.com/1aa0fa75b65f403e08ae0f3f2fcb053c02cd9ef2
Cr-Commit-Position: refs/heads/master@{#299737}

Review URL: https://codereview.chromium.org/632833002

Cr-Commit-Position: refs/heads/master@{#300036}

The error message is "ERROR:location_bar_view_mac.mm(592)] Not implemented
reached in virtual void LocationBarViewMac::EndOriginChipAnimations(bool)".
It's been spamming for months, so it can't be that important.

BUG=408366

Review URL: https://codereview.chromium.org/660723005

Cr-Commit-Position: refs/heads/master@{#300035}

There are still ARRAYSIZE_UNSAFEs in ppapi/tests/test_audio.cc, but it
defines it itself, and it might be compiled by some older NaCl toolchain
that doesn't support C++11. third_party/npapi/npspy/common/format.cpp
also has its own ARRAYSIZE_UNSAFE, but I'm hoping to delete npspy
completely.)

I'll remove ARRAYSIZE_UNSAFE from base/macro.h separately, since it's
quite likely we have deps that use our base (and those deps may use it).

R=ben@chromium.org
TBR=armansito@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/663673002

Cr-Commit-Position: refs/heads/master@{#300034}

BUG=

Review URL: https://codereview.chromium.org/657393003

Cr-Commit-Position: refs/heads/master@{#300033}

The image_url, small_image_url, and the button urls are never
set in the current code base. Removing these URLs also means
removing the ImageDownloads of MessageCenterNotificationManager,
and also means removing unnecessary methods of NotificationDelegate.

I think NotificationDelegate::id() can be removed and then
we can completely remove ::NotificationDelegate class for now,
but that would be done in another CL.

This CL depends on https://codereview.chromium.org/554213003/

BUG=None
R=dewittj@chromium.org, peter@chromium.org
TBR=atwilson@chromium.org, vitalybuka@chromium.org, tapted@chromium.org, oshima@chromium.org
TEST=no functional changes, build succeeds

Review URL: https://codereview.chromium.org/580243004

Cr-Commit-Position: refs/heads/master@{#300032}

This change enabled fullscreen api for chrome shell

Review URL: https://codereview.chromium.org/662723002

Cr-Commit-Position: refs/heads/master@{#300031}

BUG=423621

Review URL: https://codereview.chromium.org/660913002

Cr-Commit-Position: refs/heads/master@{#300030}

In certain cases, we don't want to allow encrypting all data
(AKA, the CUSTOM_PASSPHRASE type).

BUG=424187

Review URL: https://codereview.chromium.org/656333002

Cr-Commit-Position: refs/heads/master@{#300029}