GitLab

BUG=None
TEST=Compile with clang.
TBR=altimofeev@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86611 0039d316-1c4b-4281-b951-d872f2087c98

Current implementation of message_pump_glib_x uses both X event queue and GDK's g_main_context_iteration to read event messages.

If the first X event in the X event queue can be dispatched directly, it will be extracted and dispatched.
If the first X event in the X event queue can't be dispatched directly, g_main_context_iteration will be called to translate X events into GDK evnets.
If the first X event can't be dispatched directly and is followed by X events that can be dispatched directly in the event queue,
those events that can be dispatched directly will also go through GDK and may get lost if GDK does not recognize them (e.g. XInput2 events).

To fix this, a GDK event filter is setup to intercept all the X events before they are translated into GDK events.
In the filter if the X events are found to be wanted, they will get dispatched directly instead of translated into GDK events.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7050030
Patch from Yufeng Shen <miletus@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86610 0039d316-1c4b-4281-b951-d872f2087c98

Cause compile failure
484>WebViewHost.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>NotificationPresenter.obj :error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ) referenced in function "public: static bool __cdecl WTF::SimpleClassHashTraits<class WTF::String>::isDeletedValue(class WTF::String const &)" (?isDeletedValue@?$SimpleClassHashTraits@VString@WTF@@@WTF@@SA_NABVString@2@@Z)
484>TestShell.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>MockSpellCheck.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>LayoutTestController.obj :error LNK2001: unresolved external symbol "__declspec(dllimport) public: bool __thiscall WTF::String::isHashTableDeletedValue(void)const " (__imp_?isHashTableDeletedValue@String@WTF@@QBE_NXZ)
484>C:\b\build\slave\Win_Builder__dbg__shared_\build\src\build\Debug\DumpRenderTree.exe : fatalerror LNK1120: 1 unresolved externals

BUG=none
TEST=none
TBR=dpranke

TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/7069011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86609 0039d316-1c4b-4281-b951-d872f2087c98

Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.

BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre

Review URL: http://codereview.chromium.org/7027006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86608 0039d316-1c4b-4281-b951-d872f2087c98

Nu functionality change: virtual is only added to destructors
that are already implicitly virtual.

BUG=83408
TEST=chromiumos clang bot goes green
TBR=battre

Review URL: http://codereview.chromium.org/6992062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83876
TEST=no
TBR=skerner@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83408
TEST=none

Review URL: http://codereview.chromium.org/7065027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83876
TEST=no
TBR=skerner@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86603 0039d316-1c4b-4281-b951-d872f2087c98

Fix extension_webstore_private_api calls to DefaultProfile. Instead of calling GetDefaultProfile in incognito mode, call GetOriginalProfile, which gives the non-incognito profile from which that profile was spawned. This makes things work with multi-profiles.

BUG=83792
TEST=existing tests still work.
Review URL: http://codereview.chromium.org/6992036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77477


Review URL: http://codereview.chromium.org/6979009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86601 0039d316-1c4b-4281-b951-d872f2087c98

R=altimofeev@chromium.org
BUG=chromium-os:11632
TEST=Check that network screen works as before. Run NetworkScreenTest.* browser tests

Review URL: http://codereview.chromium.org/7066020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15579
TEST=none

Review URL: http://codereview.chromium.org/7008010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dpranke

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86598 0039d316-1c4b-4281-b951-d872f2087c98

It's based on http://codereview.chromium.org/7029009/.

BUG=61676
TEST=QuotaTemporaryStorageEvictorTest.*

Review URL: http://codereview.chromium.org/7002024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83861
TEST=no
TBR=sky@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86595 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6992055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63656
TEST=host_content_settings_map_unittest.cc,content_settings_pref_provider_unittest.cc

Review URL: http://codereview.chromium.org/7064030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61676
TEST='QuotaManagerTest.*'


Review URL: http://codereview.chromium.org/6990055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86592 0039d316-1c4b-4281-b951-d872f2087c98

This broke the Chrome OS bot http://build.chromium.org/p/chromium/builders/Linux%20Tests%20%28ChromiumOS%20dbg%29%281%29/builds/607/steps/browser_tests/logs/stdio

BUG=no
TEST=no
TBR=ben@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86589 0039d316-1c4b-4281-b951-d872f2087c98

original review page (reverted due to chromeos breakage):
http://codereview.chromium.org/7054012/

BUG=none
TEST=FileSystemOperationTest.*
TBR=ericu

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86588 0039d316-1c4b-4281-b951-d872f2087c98

Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.

No functionality change: virtual is only added
to destructors that are already implicitly virtual.

Also fix a couple of in-line destructor definitions.

BUG=83408
TEST=none

Review URL: http://codereview.chromium.org/7064033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=PPAPITest.Transport
TBR=sergeyu

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86584 0039d316-1c4b-4281-b951-d872f2087c98

to make sure the generated tarballs can be built with NaCl support.

export_tarball.py is not the prettiest place for this,
but it's the easiest to modify (public repo),
and can easily be kept in sync with other scripts in the tree
in case anything changes.

BUG=none
Review URL: http://codereview.chromium.org/7066022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86583 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86575 - Revert 86573 - Add separate nonce version of connect calls to ChromotingScriptableObject.

It causes PPAPITest.Transport failure on Vista, but sergeyu told me
PPAPITest.Trasnport is flaky and the failure has nothing to do with
the original CL.

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7042022

TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/7069005
Review URL: http://codereview.chromium.org/7068006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=44850
TEST=None as it isn't yet called anywhere.


Review URL: http://codereview.chromium.org/7065029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86581 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org

BUG=none
TEST=none
TBR=

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86580 0039d316-1c4b-4281-b951-d872f2087c98

This functionality was recently broken by this cl: http://codereview.chromium.org/7029019

BUG=none
TEST=build Chrome of Chrome OS and run it on Linux with --stub-cros, no crash should observed

Review URL: http://codereview.chromium.org/6990003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86579 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86577 - Revert 86572 - Revert 86568 - Add initial framework for performance tests that measure frame rate.

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7068005
Review URL: http://codereview.chromium.org/7031043

TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/7008008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86578 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7068005
Review URL: http://codereview.chromium.org/7031043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86577 0039d316-1c4b-4281-b951-d872f2087c98

TEST=build all locally
BUG=83837
TBR=thakis@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86576 0039d316-1c4b-4281-b951-d872f2087c98

It causes PPAPITest.Transport failure on Vista

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7042022

TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/7069005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83286
TEST=None.


Review URL: http://codereview.chromium.org/7036019

TBR=shishir@chromium.org
Review URL: http://codereview.chromium.org/6979006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7042022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86573 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7068005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dpranke

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82171
TEST=


Review URL: http://codereview.chromium.org/7040021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83286
TEST=None.


Review URL: http://codereview.chromium.org/7036019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86569 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dpranke

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86567 0039d316-1c4b-4281-b951-d872f2087c98