- 21 May, 2020 40 commits
-
-
Brian Manthos authored
Change-Id: I3aa4903a069ab7c73b428ff5fb8dc5c685444c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211056Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Brian Manthos <brianman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771099}
-
Aaron Colwell authored
All other calls to CanBePlacedInDefaultSiteInstance() provide the user URL, but the call in SiteInstanceImpl::GetSiteForURLInternal() passes the effective URL stored in |url| instead. This can lead to differing behavior than other call sites. This change makes all the call sites consistent. This causes subtle change in behavior on a platform that chooses to enable default SiteInstance and uses effective URLs (e.g. hosted apps). I do not believe Chrome currently has a platform that combines these features. Bug: 1085275 Change-Id: I6ae445f2e45a31f91a4428a6c2fc0a340157b75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186639Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#771098}
-
danakj authored
Add helpers to RenderFrameImpl and WebWidgetTestProxy to get to the WebFrameWidget, because it's a big pain to go through WebFrame, to its local root, to the WebFrameWidget. R=dcheng@chromium.org Bug: 866140 Change-Id: I818e1f88512fb4a951059106079fd13feccd6271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210676 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771097}
-
Nico Weber authored
TBR=hans Bug: 1077698 Change-Id: I73ab941475c572bbecfdf40d293cd3acc838a138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211125Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771096}
-
Nico Weber authored
This reverts commit add913dc. Reason for revert: closed tree due to https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/13297? Original change's description: > Crash fast in case of an exception from ATL. > > BUG=108176 > TBR=fdoray@chromium.org > > Change-Id: I9723b07932b35fd098e40965735d1e92cb0c8946 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210466 > Commit-Queue: Greg Thompson <grt@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771073} TBR=fdoray@chromium.org,grt@chromium.org,nicolaso@chromium.org Change-Id: Idaa6e98d787d8dc33c08aede2c33dca919d2a612 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 108176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212255Reviewed-by:
-
Gabriel Charette authored
This reverts commit f34af30b. Reason for revert: broke android-pie-arm64-rel https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-rel/124453 ERROR at //third_party/android_deps/BUILD.gn:1408:30: Assignment had no effect. enable_bytecode_rewriter = false ^---- You set the variable "enable_bytecode_rewriter" here and it was unused before it went out of scope. See //third_party/android_deps/BUILD.gn:1404:1: whence it was called. java_prebuilt("org_robolectric_android_all_java") { ^-------------------------------------------------- See //services/BUILD.gn:106:7: which caused the file to be included. "$google_play_services_package:google_play_services_base_java", ^------------------------------------------------------------- Original change's description: > add robolectric_all to android_deps. > > This is the same file as included in > > https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/cipd.yaml;l=16?originalUrl=https:%2F%2Fcs.chromium.org%2F > https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=59?originalUrl=https:%2F%2Fcs.chromium.org%2F > > I'm just moving it to android_deps, so I don't think we need security > or license review. > > Will remove duplicate file when robolectric moves to android_deps. > I could possibly remove it now but sdk_texts writes in the location. > https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=268?originalUrl=https:%2F%2Fcs.chromium.org%2F > > Bug: 1060721 > Change-Id: I95fd2fc63d652c3b7274753532e6a86081f60a58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210094 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: benjamin joyce <bjoyce@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771084} TBR=yfriedman@chromium.org,wnwen@chromium.org,agrieve@chromium.org,bjoyce@chromium.org Change-Id: I0b12781d7df4416d76629c336373ceb608983c87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212464Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#771094}
-
Patrick Monette authored
This change is necessary to hook up service worker to shared worker clients in the performance manager's graph. This is because the notification that the shared worker was added as a controllee of a service worker comes before the shared worker could start. Bug: 993029 Change-Id: I6b6377712001be84a9071a34fb56265d4a45f802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199695 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#771093}
-
Benjamin Beaudry authored
In CL:2042214, we had to add an early return to AXPlatformNodeTextRangeProvider::NormalizeTextRange when inside of an editable text to avoid issues with Narrator not announcing deleted characters. That partial fix only works for plain text fields, like an <input>. It doesn't work for rich text fields. Furthermore, it causes additional issues with rich text fields that contains, for example, a list. For this reason, we decided to limit this early return only for plain text fields. AX_Relnotes: Fixes a bug whereby Narrator was not announcing that the user had entered or exited a list inside a rich text field. Bug: 1083481 Change-Id: I5b07875b648923db9b39edffbdb0802b00ef4aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204684 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771092}
-
Scott Violet authored
This reverts commit 83c14c4e. Reason for revert: ReadyToCommitNavigation is the right place for this. Original change's description: > content: adds comment to RenderFrameCreated() > > Hopefully this comment will help those trying to understand message > ordering. RenderFrameCreated() is a good place to send a message to the > renderer before loading starts. > > BUG=none > TEST=none > > Change-Id: Idd7e3d9b8c6e41daf6b1d50cd4088bd12132deae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212286 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771080} TBR=sky@chromium.org,danakj@chromium.org Change-Id: I59496bc0c1624395b1e0228faf852ffc2550c403 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211936Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771091}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ce285f432c39..1a4f6e1f3ce1 2020-05-21 tobine@google.com Vulkan:Migrate command buffers to pointers 2020-05-21 cnorthrop@google.com Tests: Add a common framebuffer config for perf tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: angle_perftests Change-Id: I73ca248b32c365e82deeae330f33f75a4fe51781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771090}
-
Daniel Rubery authored
This CL adds and tests a utility function that checks if the captured screenshot matches a given VisualTarget from the VisualModel. Bug: 1068617 Change-Id: I3cad89f7ce6aa16a0e97ac31e30c8205fb93d3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209475Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#771089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d042c5649f6..52e9a761fba0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC avi@google.com,vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080903 Tbr: avi@google.com,vasilii@google.com Change-Id: I6b07be344e8a9cf967daeca654d9002a87c1146d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212356Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771088}
-
Chromium WPT Sync authored
Using wpt-import in Chromium baa502f0. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ie1041caeaa2571184a4170c38977b1db9c5d6d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212382Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771087}
-
Sigurdur Asgeirsson authored
Bug: 1085007 Change-Id: I0cf4beaf1c10fabecb79eaa6d7a14d0b52eba6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210486Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771086}
-
Dale Curtis authored
This function actually produces a periodic Hanning window instead of a symmetric one. Change-Id: If921c08d990eafe3e9475de2fbf7b6a64c7879f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211363 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#771085}
-
Ben Joyce authored
This is the same file as included in https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/cipd.yaml;l=16?originalUrl=https:%2F%2Fcs.chromium.org%2F https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=59?originalUrl=https:%2F%2Fcs.chromium.org%2F I'm just moving it to android_deps, so I don't think we need security or license review. Will remove duplicate file when robolectric moves to android_deps. I could possibly remove it now but sdk_texts writes in the location. https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=268?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 1060721 Change-Id: I95fd2fc63d652c3b7274753532e6a86081f60a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210094Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#771084}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590061793-cada8ca96f7665a04948a973b6cd8e2e12d92609.profdata to chrome-mac-master-1590076755-1b22274f1ce7584ce2730bbd2446e2694cb4fc1a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I480cf742a5dc461d028d4911f0768a547bc9cb8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212582Reviewed-by:
-
Matt Jones authored
Post-chrome home, the BottomSheetTestRule has little functionality and gets in the way of modularization. All existing tests have been easily updated to work without it. Bug: 100227 Change-Id: I6ae907599f0d651ae9d540b483b32146d678ed18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210668Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#771082}
-
Jason Chase authored
Make |version| a named parameter instead of positional. This should make command lines less error-prone and magical (i.e. "what's this 3 in the middle of the command"). Change-Id: I7ac59fa0268c0015f99232a8d3e24a64dadee717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204627Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#771081}
-
Scott Violet authored
Hopefully this comment will help those trying to understand message ordering. RenderFrameCreated() is a good place to send a message to the renderer before loading starts. BUG=none TEST=none Change-Id: Idd7e3d9b8c6e41daf6b1d50cd4088bd12132deae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212286Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771080}
-
Evan Liu authored
This reverts commit bfe52a91. Reason for revert: The Chrome security team has prohibited the use of gRPC in its current state as it does not go through Chrome's network stack. The Cloud Speech-to-Text implementation will be replaced with an alternative REST-based API that goes through the network stack. Original change's description: > Add protos required by Cloud Speech-to-Text > > This CL adds the protos required by the Cloud Speech-to-Text service > used by the Live Caption feature. The proto files come from Google3 with > the following modifications: > > 1. The package name of some of the protos were changed to avoid > conflicting with identical protos in the third_party/grpc repository. > > 2. The license text was changed to align with Chromium conventions. > > 3. any.proto and status.proto were renamed to prevent conflict with > protos in components/offline_pages/core/prefetch/proto. > > 4. All protos are optimized for LITE_RUNTIME. > > Bug: 1071626 > Change-Id: I351d98c9272e7ec7991a8182dbc305673c8e239c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153759 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#764033} TBR=ajwong@chromium.org,nyquist@chromium.org,yuweih@chromium.org,lgrey@chromium.org,evliu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1071626 Change-Id: Ie0f8b65ed29217cbbedb28e8551e49189028203e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210799Reviewed-by:
Evan Liu <evliu@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#771079}
-
Bo Liu authored
Overall goal here is to ensure WindowAndroid instances are destroyed at the end of instrumentation tests, but there is change in behavior for production code. Eager destroy WindowAndroid in AwContents. When the destroy runnable for all AwContents that uses a WindowAndroid runs. Need to ensure at this time that the WindowAndroid is removed from the global map as well. This works because WindowAndroid lifetime and destroy runnable lifetime are essentially the same. Then in AwActivityTestRule, keep track of all AwContents created in instrumentation tests in a list of weak references, and destroy at the end of the test. Calling AwContents.destroy multiple is ok, so this should be safe. Need specific handling for AwUncaughtExceptionTest because it renders the UI thread useless at the end of the test. Instead synchronously destroy the AwContents in the test body itself. Bug: 1081250 Change-Id: Ic07e52c7b21bf1300942e8b0a7cf178b8e3858b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205879 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#771078}
-
Thomas Lukaszewicz authored
Previously ShellWindowDelegateView had its initialization happen in ViewHierarchyChanged(). This change splits initialization between the constructor and AddedToWidget(). This allows the ShellWindowDelegateView to support being re-parented to a Widget hierarchy multiple times. Bug: 1083822 Change-Id: I4e0da0bcf458683bea2d327613588754c7372945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206218 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#771077}
-
Aaron Colwell authored
There are a bunch of crashes that appear to be caused by invalid ChildProcessSecurityPolicyImpl::Handle objects. This change adds DumpWithoutCrashing() calls so we can see the call stacks that generate these invalid handles. Bug: 977169 Change-Id: I289c7c53eadd17eea8807e8244070259b72ad7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211136 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#771076}
-
Kyle Horimoto authored
Change-Id: If92458c27c98f08ae856e427de3ec99628e41283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211282 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#771075}
-
danakj authored
This moves the text/page zoom functions from eventSender to testRunner so that we can reset them from TestRunner in a way consistent with how we reset properties that can be changed on all frames/widgets/views now. We also move the text zoom API from WebView over to WebLocalFrame, where it can be called for any local root. The only production usage is Android WebView where it calls it for the main frame. In order to support site isolation, it would need to do so on other local roots as well. Since the renderer can't reliably tell what's a local root and is the one setting/resetting the zoom level, it only allows it on the main frame for now also. We add a reset call for the zoom level and the text zoom there, which have gone missing somehow in the refactoring process. We move other calls from WebWidgetTestProxy that are resetting things testRunner modifies over to the TestRunner class as well. For example, without this, running the following tests in order causes a failure: [1/2] paint/invalidation/svg/zoom-coords-viewattr-01-b.svg passed [2/2] paint/invalidation/svg/absolute-sized-content-with-resources.xhtml failed unexpectedly (text diff, image diff) R=avi@chromium.org Bug: 1083790, 866140 Change-Id: Idec021ba7a5d877a02b55b77d280454d6f8fb078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208543 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=108176 TBR=fdoray@chromium.org Change-Id: I9723b07932b35fd098e40965735d1e92cb0c8946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210466 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#771073}
-
Chris Lu authored
Bug: 1082728 Change-Id: I98c56d8348146e2d09be4ab159fcaaa2fada80f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206971Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#771072}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Several tests are updated to use the new API. This CL does NOT change any behavior. Bug: 1060940 Change-Id: Ic05f7cc010bd29b04097f167a5eeed3feb0aa90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210468Reviewed-by:
-
David Grogan authored
This makes browser_tests and unit_tests use FlexNG. It's required before launching a stable experiment. Bug: 845235, 1062484 Change-Id: If5e9672bcf11c62d8ff92f1939608d8ab969682b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205975Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771070}
-
Ramin Halavati authored
ChromePaymentRequestDelegate handles incognito mode differently in compare to other off-the-record profiles. This change updates ChromePaymentRequestDelegate::IsIncognito to return true for all off-the-record profiles. The function is also renamed to represent this change. Bug: 968028, 1074201 Change-Id: I543413c993d484fe2ede6a589a8dd06a1b2ce186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201596 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#771069}
-
Jeremy Roman authored
It is unclear why this returns a rectangle via out-param. Change-Id: Ic83f7feb8a7a9cf95e017c1b3d72453c55afaad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212481 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Toby Huang authored
This CL removes an unnecessary period in a tooltip string. Bug: None Change-Id: I1fd78a559e1a867d1478ec5cca3062b0350d0d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211090Reviewed-by:
-
Garrett Beaty authored
M81 is no longer an active milestone. Change-Id: I5e772550fa52ac5ec2d56b5560e3e3b2e95d5e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211121 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#771066}
-
Geoff Lang authored
Remove failure supression for deqp/functional/gles3/framebufferblit/default_framebuffer_00.html TBR=kbr@chromium.org BUG=angleproject:4632 Change-Id: I5baf02a8a80601dbadd5404fe8c3c3bde6bcc1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209332Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771065}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/8b78f8815623..7f483b5ee54c $ git log 8b78f8815..7f483b5ee --date=short --no-merges --format='%ad %ae %s' 2020-05-20 renjietang In QUIC, instead of looking up QuicConnection states, consult the session on whether the connection should be closed on STATELESS_RESET. 2020-05-20 nharper Handle 0-RTT in TlsClientHandshaker 2020-05-20 dschinazi Compute maximum transport parameter size upfront 2020-05-20 dschinazi Remove obsolete stateless reset token length override 2020-05-20 wub In quicconnection::sendallpendingacks, update instead of set the ack alarm. protected by --gfe2_reloadable_flag_quic_update_ack_alarm_in_send_all_pending_acks. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iee3a7d338f52619e7afc9dd5029f3604587b39e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206922 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771064}
-
Meredith Lane authored
Adds a setting to implement the Mac specific behaviour for aria-modal="true". The accessibility tree must be pruned of background content, as outlined in the spec: https://www.w3.org/TR/core-aam-1.1/#ariaModalTrue Eventually, this setting may be enabled on other platforms (such as Android). Followups to this CL include: - add blink tests and inspector protocol tests - consolidate logic with HTMLDialogElement AX-Relnotes: Adds support for aria-modal on Mac, to correctly expose modal dialogs to AT. Bug: 1050904 Change-Id: I76b7070e91a71ca7ee890886d9a6aa398911f118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065779 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#771063}
-
Raymond Toy authored
In WaveShaperCurveValues(), there are 5 work arrays that used to be allocated on the audio thread. Move these to the class so we don't do that anymore. And while we're at it, make them AudioFloatArray's so they're appropriately aligned for best SIMD/NEON performance. Running Spotify's Web Audio Benchmark shows that we get 10% improvement in speed for WaveShaper-1x, and about 3-4% for WaveShaper-2x and 4x. No functional changes; all tests pass. Bug: 1013118 Change-Id: Ide6340ee79d567068e0661abd0b20f14bb064166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210821 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771062}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/52fe4b9946f7..8ae7f6e09a0b 2020-05-21 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-21 jeroendh@google.com chrome_util: Copy libondeviceassistant.so when deploying Chrome 2020-05-21 bpastene@chromium.org gs: Update known AUTHORIZATION_ERRORS. 2020-05-21 richardfung@google.com Remove android-container-rvc targets 2020-05-20 vapier@chromium.org cros_mark_as_stable: relax self-repo checks in older branches 2020-05-20 wonderfly@google.com chromeos_config: Stand up master-lakitu-release on R81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I1fb18ebebc31a217403e36a0a22ee849e94fd318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212352Reviewed-by:
-
Henrique Ferreiro authored
//ui/base:base is a big component with many conditional dependencies, making it difficult to check the correctness of its deps and public_deps. This CL moves ui/base/cursor/ files into the //ui/base/cursor:cursor component, to make it easier to add/remove files and check their dependencies. As part of this reorganization, this target is limited to Aura builds. Also, includes were reviewed. Bug: 1085358 Change-Id: Ic835d0c79492c6a0945b12a82f538733f7e90fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181210 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
