- 07 Jul, 2017 40 commits
-
-
Kent Tamura authored
This CL includes RTL support. * If the UI locale is RTL, flip the bubble layout. - The default arrow position is on the right side. - The icon is on the right side. * If the default position of the bubble arrow doesn't point at the anchor element rectangle, move the arrow position. Implementation: - Set <body dir=> for the UI locale. - Found that it's difficult to adjust arrow position in RTL + position:relative. Switch inner arrow's position to 'absolute', and add spacer elements to secure height. - Fix the icon margin in RTL. - Drop layout tree dump from tests. Bug: 739091 Change-Id: I3da7f9ed3a248d1bf5a95d77d3b93667e3bdf9da Reviewed-on: https://chromium-review.googlesource.com/561048Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485002}
-
thildebr authored
Was using the wrong context from InstrumentationRegistry in ClearAppDataTestRule, so now that's fixed. Also enables the temporarily disabled tests now that they work again. BUG=739575 Review-Url: https://codereview.chromium.org/2970263002 Cr-Commit-Position: refs/heads/master@{#485001}
-
Allen Bauer authored
Added mulitple credential Sign In interacive browser test. Bug: 651681 Change-Id: I62fb366f4d2304e5fff2c7703b79d4187c9e21ac PreMD - https://drive.google.com/open?id=0B6LQg8CWo5bNZ3VqSzRiY2VXTWc MD - https://drive.google.com/open?id=0B6LQg8CWo5bNcm1SdGlCVmJvWXM Change-Id: I62fb366f4d2304e5fff2c7703b79d4187c9e21ac Reviewed-on: https://chromium-review.googlesource.com/561976 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#485000}
-
Daniel Vogelheim authored
Move the checking logic into ScriptResource, so it can be called from ClassicPendingScript::NotifyFinished and XMLDocumentParser::NotifyFinished. BUG=735719 Change-Id: Id7f485151eb5a6f74a9b7ac325168b1de5d8c423 Reviewed-on: https://chromium-review.googlesource.com/556033 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#484999}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/98308fb08168..aa6c777f7d7c $ git log 98308fb08..aa6c777f7 --date=short --no-merges --format='%ad %ae %s' 2017-07-07 reed add guard for android (needs rebaseline) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I52de8f6c139fabdbc9a959595fa2e872b24fde88 Reviewed-on: https://chromium-review.googlesource.com/563497Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#484998}
-
Rouslan Solomakhin authored
Instead of creating short-lived, self-deleting downloader objects for payment method manifests, use a single instance of the downloader that is owned by PaymentRequest. This reduces complexity of the JNI shim, reduces resource utilization, and makes the code more readable and stable. At long last, this patch adds integration tests that stress the full manifest download stack on Android. Bug: 735184 Change-Id: I64c64a275ee873f2546cdc89274ab37780582571 Reviewed-on: https://chromium-review.googlesource.com/559730 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#484997}
-
bsep authored
Revert of [Media Router] Add CastMediaSinkService (patchset #11 id:200001 of https://codereview.chromium.org/2927833002/ ) Reason for revert: Causing unit_tests failures on multiple bots For example: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/44050 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/20527 https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/8549 Original issue's description: > [Media Router] Add CastMediaSinkService > > NOTE: those extensions header files and extensions::api:: namespace will go away when https://codereview.chromium.org/2913033003/ lands > > Discover process is similar to DialMediaSinkService: > - CastMediaSinkService::Start() registers itself with DnsRegistry > - CastMediaSinkService::OnDnsSdEvent() gets invoked when Dns services comes back and starts a 3s timer > - Start opening channel for each service on IO thread > - CastMediaSinkService::OnChannelOpenedOnIOThread() gets invoked when channel open finishes > - Post task back to UI thread via CastMediaSinkService::OnChannelOpenOnUIThread() > - Create MediaSinkInternal and store it in CastSinkService's sink map > - Invoke MediaSinkBase::FetchCompleted() and send sinks to MRP when timer expires > > TODO: > Unit test > Implement CastSocketService::OpenChannel > > BUG=687377 > > Review-Url: https://codereview.chromium.org/2927833002 > Cr-Commit-Position: refs/heads/master@{#484979} > Committed: https://chromium.googlesource.com/chromium/src/+/b9a2a9b60034d3ee2138c4815bc3c66b13cee3b5 TBR=mfoltz@chromium.org,imcheng@chromium.org,zhaobin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687377 Review-Url: https://codereview.chromium.org/2973983002 Cr-Commit-Position: refs/heads/master@{#484996}
-
Dave Schuyler authored
This CL changes an instance of paper-icon-button to paper-icon-button-light as part of the long term goal of removing paper-icon-button from chrome. (code health) Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3e85b61df0df319ea592ceba0388dcff1fbd5ca Reviewed-on: https://chromium-review.googlesource.com/560670 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#484995}
-
Matthew Halpern authored
The following changes address ambiguity regarding the methods related to the CoordinationUnitImpl property store: 1. Eliminate the mojom::Property struct Previously, a mojom::Property struct was used to set properties using the Mojo interface to a particular CoordinationUnit, while a key-value approach was used locally. The latter is the preferred approach, making the mojom::Property unnecessary. 2. Remove CoordinationUnitImpl::ClearProperty (for now) A CoordinationUnitImpl::ClearProperty was added but never actually used for anything. It has been removed for now as its use is unclear. If a valid use case is found it can be added back. Bug: 691886 Change-Id: I2d8fa1478c1bf784b29d9783fca2acddab25062b Reviewed-on: https://chromium-review.googlesource.com/562917Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matthew Halpern <matthalp@google.com> Cr-Commit-Position: refs/heads/master@{#484994}
-
Sergey Ulanov authored
Removed SupportsWeakPtr from all classes under remoting. Also refactored HostStatusMonitor to make it ref-counted instead of an abstract interface. This allows it to outlive ChromotingHost, so the observers don't need to worry about monitor reference being valid. Change-Id: I5990145d99047466a51ef8fce0873c9a1cdd9cbe Reviewed-on: https://chromium-review.googlesource.com/551035 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#484993}
-
Kevin Bailey authored
This reverts commit 3dc51db9. Reason for revert: For some reason, this change causes a 25% increase in GL rendering for Windows. See crbug.com/739303 Original change's description: > [omnibox] Select all when we revert all > > If you look at all the times we call RevertAll(), they either also call > SelectAll(true), or wouldn't mind if we did. To simplify both > RevertAll() and the calling code, we now make this call unconditionally. > It happens to fix an issue also, where a stale cursor is produced when > tabbing into the Omnibox. > > Bug: 735802 > Change-Id: Ib70f3ffd88555ef6aa600e17f111f22442e94eb0 > Reviewed-on: https://chromium-review.googlesource.com/548985 > Commit-Queue: Kevin Bailey <krb@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#483362} TBR=pkasting@chromium.org,tapted@chromium.org,krb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 735802 Change-Id: I4d075e5c5a20707f74bd2d330d466f67a3241ce8 Reviewed-on: https://chromium-review.googlesource.com/563482Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#484992}
-
Theresa Wellington authored
Bug: 725015 Change-Id: I54b72b7dd0506aa64521aa43d6bd6614376b6437 Reviewed-on: https://chromium-review.googlesource.com/562538Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#484991}
-
Aaron Leventhal authored
Do not expose native radio mixed state as accessibility mixed state, because this confuses the JAWS screen reader, which reports a mixed radio as both checked and partially checked. A native mixed native radio button sinply means no radio buttons have been checked in the group yet. Bug: 739752 Change-Id: Icdfc404b6d50d1ecb25b5b3221c79ba0da2f7400 Reviewed-on: https://chromium-review.googlesource.com/561817 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#484990}
-
Alex Clarke authored
Bug: 739553 Change-Id: Ia505463664123245200fb94f37a7a1178df4fc18 Reviewed-on: https://chromium-review.googlesource.com/563385 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#484989}
-
Brett Wilson authored
The histogram text for the enum for History.InitializationFailureStep references another histogram to check for details on that error. The histogram to check is MigrateFailureFromVersion rather than MigrateFailureToVersion (which doesn't exist). TBR=isherman@chromium.org Change-Id: I7381dce19fb749d412e7a850de56db653e30a136 Reviewed-on: https://chromium-review.googlesource.com/563586Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#484988}
-
wychen authored
This is a preliminary change to enable the desired mode in the back end. BUG=736168 Review-Url: https://codereview.chromium.org/2961533002 Cr-Commit-Position: refs/heads/master@{#484987}
-
Nathan Bruer authored
Fixes a scaling regression when console drawer is shrinking and timeline overlays filmstrip. R=alph BUG=739143 Change-Id: Ice042964ed85d0cfad0ce59b67d982b04594217e Reviewed-on: https://chromium-review.googlesource.com/562038 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#484986}
-
vollick authored
Reland of [vr] Ensure that textured elements never draw with a dirty texture (patchset #1 id:1 of https://codereview.chromium.org/2972843002/ ) Reason for revert: Reverting this CL did fix errors on the FYI bot, but I cannot reproduce them on ToT. New fixes / issues may have been introduced. Since this is blocking progress, I'm going to resubmit and try and find a reproduction offline. Original issue's description: > Revert of [vr] Ensure that textured elements never draw with a dirty texture (patchset #2 id:20001 of https://codereview.chromium.org/2969023003/ ) > > Reason for revert: > Breaks some VR browser navigation tests due to failing DCHECK https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests?numbuilds=200 > > Original issue's description: > > [vr] Ensure that textured elements never draw with a dirty texture > > > > This should never be possible, so I've made UpdateTexture a part > > of OnBeginFrame. It will usually early out (because the texture won't > > be dirty), but will ensure that we never again draw with a dirty > > texture. I've also added a DCHECK to ensure that we don't change this. > > > > NB: this has no impact on the the update throttling done by the URL > > bar since it has its own overridden implementation of OnBeginFrame. > > > > BUG=None > > > > Review-Url: https://codereview.chromium.org/2969023003 > > Cr-Commit-Position: refs/heads/master@{#484142} > > Committed: https://chromium.googlesource.com/chromium/src/+/286a6b8e56a7bd0b7ac58d8b9ba933e0c3dc2405 > > TBR=cjgrant@chromium.org,vollick@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.chromium.org/2972843002 > Cr-Commit-Position: refs/heads/master@{#484300} > Committed: https://chromium.googlesource.com/chromium/src/+/de1d1d17c1eb00d0c618d43a477411d93a42c58e TBR=cjgrant@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.chromium.org/2965413002 Cr-Commit-Position: refs/heads/master@{#484985}
-
sebsg authored
Bug: 739932 Change-Id: I27595e85720cbe44ef8aa8e358105be0bf38a8f2 Reviewed-on: https://chromium-review.googlesource.com/562506Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#484984}
-
Dave Tapuska authored
The concept is that the InputHandler will be an interface exposed from the Widget interface via calling GetWidgetInputHandler. This is just plumbing passing a Widget interface across the creation of the Widget. This will be further implemented when the implementation of the WidgetInputHandler lands on the renderer side. BUG=722928 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ia3093832d822a5fc749ec7020bee6aee510e0e55 Reviewed-on: https://chromium-review.googlesource.com/543396 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
sczs authored
Creates Stub utils files for tab/navigation related tests. Bug: Change-Id: I42970c3ccfcb415e06ce66dc0e28a4fd52b1b940 Reviewed-on: https://chromium-review.googlesource.com/562631 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#484982}
-
Alexis Menard authored
This is a reland of 1bdb8833 without changes. Original CL was reverted due to a bug in how chromium generates JNI bindings with native functions. It is fixed by https://codereview.chromium.org/2966163006/. Original change's description: > Make Interaction Media Features MQ dynamic on Android > > With detachable form factors such as Asus Transformer > it is important to make sure the interaction media > features are updated whenever the keyboard/trackpad combo is > detached. This will allow content author to react to > media query changes to adapt the user interface to > better suit the new interaction method (often touch vs > trackpad). The patch also handles any input changes e.g. > USB connected mouse. > > The patch uses the facility landed in previous OSes and > add a bit of Java code to listen the changes of inputs > through the InputDeviceListener mechanism. > > BUG=442418 > > Change-Id: I5c18ce4df8e6da927eede5a24f40aac10ecf1974 > Reviewed-on: https://chromium-review.googlesource.com/553457 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Bo Liu <boliu@chromium.org> > Commit-Queue: Alexis Menard <alexis.menard@intel.com> > Cr-Commit-Position: refs/heads/master@{#484641} TBR=agrieve@chromium.org, alexis.menard@intel.com, boliu@chromium.org, sadrul@chromium.org Bug: 442418 Change-Id: I5dca047c566625fa2f976d3311899f9a3a23f44e Reviewed-on: https://chromium-review.googlesource.com/563478Reviewed-by:
Alexis Menard <alexis.menard@intel.com> Commit-Queue: Alexis Menard <alexis.menard@intel.com> Cr-Commit-Position: refs/heads/master@{#484981}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/740319850255..c3d3bb2a036b $ git log 740319850..c3d3bb2a0 --date=short --no-merges --format='%ad %ae %s' 2017-07-06 thestig Remove a static initializer introduced in commit 573b10a. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iecd1a43fbd74ee34b8bf406f1fced8978e57957f Reviewed-on: https://chromium-review.googlesource.com/563500 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#484980}
-
zhaobin authored
NOTE: those extensions header files and extensions::api:: namespace will go away when https://codereview.chromium.org/2913033003/ lands Discover process is similar to DialMediaSinkService: - CastMediaSinkService::Start() registers itself with DnsRegistry - CastMediaSinkService::OnDnsSdEvent() gets invoked when Dns services comes back and starts a 3s timer - Start opening channel for each service on IO thread - CastMediaSinkService::OnChannelOpenedOnIOThread() gets invoked when channel open finishes - Post task back to UI thread via CastMediaSinkService::OnChannelOpenOnUIThread() - Create MediaSinkInternal and store it in CastSinkService's sink map - Invoke MediaSinkBase::FetchCompleted() and send sinks to MRP when timer expires TODO: Unit test Implement CastSocketService::OpenChannel BUG=687377 Review-Url: https://codereview.chromium.org/2927833002 Cr-Commit-Position: refs/heads/master@{#484979}
-
Mike Baxley authored
This matcher has been replaced by [ChromeEarlGrey waitForWebViewContainingText:]. Bug: 707009 Change-Id: I660a44b6e802c6c5c3b6b835d7f69aa201453f29 Reviewed-on: https://chromium-review.googlesource.com/558975Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#484978}
-
Irmak Kavasoglu authored
In the current implementation, when user changes the username in the editable field and then loses focus on the field; the editable field is replaced by a label which still has the old username on it. This cl helps keeping the user's changes in the username field. This cl does NOT save the new username to the password manager. UI-wise everything looks okay, but save button will still save the old username. Bug: 734965 Change-Id: I61bef70894de4e2e71e9e314f30915d011795ccc Reviewed-on: https://chromium-review.googlesource.com/563657 Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#484977}
-
Peter Beverloo authored
These used to remain on-screen for respectively 25 and 20 seconds, the difference in which is a bit silly. Let's both keep them on-screen for 25 seconds. BUG=530697 Change-Id: I082ecfc69ec69e600818b113b02e161e058a830f Reviewed-on: https://chromium-review.googlesource.com/559102 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#484976}
-
Shanfeng Zhang authored
Bug: 734265 Change-Id: Ia341474fe1134b3105ab97067fbbbc6e61a93a58 Reviewed-on: https://chromium-review.googlesource.com/562096Reviewed-by:
-
John Budorick authored
Addressing e.g. https://chromium-swarm.appspot.com/task?id=3735890d42c3d610 Change-Id: Id1c73c66de3b6dad02f52dfb3d857b98c74a20fb Reviewed-on: https://chromium-review.googlesource.com/563437Reviewed-by:
Michael Case <mikecase@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#484974}
-
npm authored
BUG=chromium:705820 Review-Url: https://codereview.chromium.org/2953993003 Cr-Commit-Position: refs/heads/master@{#484973}
-
jzw authored
Crash is fixed by returning the given browser state in BrowserStateKeyedServiceFactory even if browser state is off the record. BUG=739986 Review-Url: https://codereview.chromium.org/2973173002 Cr-Commit-Position: refs/heads/master@{#484972}
-
bsheedy authored
Adds two swarming test triggers to the VR FYI bot to run the VR instrumentation tests on the swarmed Pixel XLs. This is to make sure that everything runs smoothly on them before going through the effort to set up a Pixel XL tester on the main waterfall. Bug: 739935 Change-Id: Ifdb9c6c24489a4883e7dff20566cbeb107c34ce1 Reviewed-on: https://chromium-review.googlesource.com/562896Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#484971}
-
Min Qin authored
This CL switches MediaResourceGetter to use TaskScheduler and BindOnce. BUG=689520 Change-Id: Icbc98cb32de3a3e7b2a91e2692446747794f62eb Reviewed-on: https://chromium-review.googlesource.com/559993Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#484970}
-
Kenneth Russell authored
These will now run on win_optional_gpu_tests_rel, linux_optional_gpu_tests_rel, and mac_optional_gpu_tests_rel, on physical hardware. Previously they'd only been running on the chromium.gpu.fyi waterfall. BUG=708917 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifc4e6ab582324d7217793f0137d5df57cd7f1a11 Reviewed-on: https://chromium-review.googlesource.com/563077Reviewed-by:
-
Jay Civelli authored
Changing a LOG from error to warning in ChildProcessLauncher as it is a case that can happen on Android and is not an error. Bug: 721713 Change-Id: Ie310f843143108b66965273e7b8b6d6f1c52f9db Reviewed-on: https://chromium-review.googlesource.com/563499Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#484968}
-
nicholss authored
Adding a reconnect button and generic error display for reconnection flow. Adding some logic around enabling the connect button based on pin length. Adding a red circle to the error state view in connection flow. Review-Url: https://codereview.chromium.org/2971903002 Cr-Commit-Position: refs/heads/master@{#484967}
-
bratell authored
There are two namespaces named testing used in Blink unit tests, one from gtest and one internal helper namespace. If both are visible then the gtest testing namespace won't be used unless prepended with ::, as is already done in large parts of the code. BUG=739121 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2967013002 Cr-Commit-Position: refs/heads/master@{#484966}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3e38417eedda..1e3b1949cdcd $ git log 3e38417ee..1e3b1949c --date=short --no-merges --format='%ad %ae %s' 2017-07-07 benjhayden Remove tr.b.arrayToDict. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7c601383728b4e15b287c75a04a54e26e858bf1c Reviewed-on: https://chromium-review.googlesource.com/563583 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#484965}
-
rbpotter authored
Add a plugin stub to trigger the load callback needed for print preview tests. BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2973743002 Cr-Commit-Position: refs/heads/master@{#484964}
-
Robert Sesek authored
This adds tests for three cases: - Timing how long it takes to Signal/Wait 1000x in a tight loop. - Timing how long it takes to Signal/Wait 1000x between threads. - Counting how many Signal/Waits can be done in 1s between threads. This also renames the existing WaitableEventPerfTest to WaitableEventThreadPerfTest, since it's part of thread_perftest.cc. Bug: 681167 Change-Id: I5180f69b5901da3d1ee808eac90f1b455b1e970d Reviewed-on: https://chromium-review.googlesource.com/560152 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#484963}
-
