- 22 Jun, 2020 40 commits
-
-
Alex Rudenko authored
Disabled in https://chromium-review.googlesource.com/c/chromium/src/+/2256199 for the DevTools change in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253898 Bug: 946975 Change-Id: I1d0e30004104bf12cb66f4b6e5b54e8f6b324e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257060 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#780852}
-
Andy Paicu authored
The script inside the page is not guaranteed to execute before the script injected via `runJavaScriptCodeInCurrentTab` which introduced a race condition causing the test to be flaky. I've updated the tests to use a function for clearing cookies that is manually called. Bug: 1090274 Change-Id: I1a714ac9053bec47aa4ad108f0493fd6ede607a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247763Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780851}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If3d7c78cbd245f775054038491ce2fe65cb346eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780850}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I161278f3bf0b77eef2d98b2819ba0c46676b94f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254125 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#780849}
-
Joel Einbinder authored
Key events emulated with DevTools can now use the commands option to send editing commands that will be executed if the event is not canceled. This is important for shortcuts like Meta+A = SelectAll to work on a Mac. See https://github.com/puppeteer/puppeteer/issues/1313 and https://github.com/microsoft/playwright/issues/1067 Change-Id: Id258668bfc71ef9f7f47477ef9de3422ada1d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211929 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#780848}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I95573a0dab0a5ae62f8f88004e198bd0a6ef5319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254760 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#780847}
-
Andrey Kosyakov authored
This reverts commit 26d83272. Reason for revert: suspected cause of build failure on linux (https://ci.chromium.org/p/chromium/builders/ci/linux-ozone-rel/124191) Original change's description: > Remove/replace unnecessary includes of logging.h (ipc/) > > If the file just needs the CHECK/CHECK_OP/NOTREACHED > macros, use the appropriate header for that instead. > Or if logging.h is not needed at all, remove it. > > This is both a nice cleanup (logging.h is a big header, > and including it unnecessarily has compile-time costs), > and part of the final step towards making logging.h no > longer include check.h and the others. > > Bug: 1031540 > Change-Id: Ic0d59407e28200355332852d290f18441d6f678e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253980 > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780828} TBR=hans@chromium.org,tsepez@chromium.org Change-Id: I780f92bca95aabcc845393ed4635e837e47aeb50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257738Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780846}
-
Andrew Grieve authored
Bug: 1095654 Change-Id: Iaf820c43e56f3f8680c34981b9d1bc3cb70b6284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257732 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#780845}
-
Gavin Williams authored
For USB printers,the printer status in print preview will reflect if the USB printer is currently connected or disconnected to the device. The IPP printer status request mechanism does not work for USB connected printers. A later enhancement will add ability to detect when printers are connected or disconnected to the device while print preview is open and update the status accordingly. Bug: 1059607 Change-Id: Ia3835dac5d080d98d3834c76a1ede5cb0397601b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249384Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#780844}
-
Findit authored
This reverts commit ce50ad19. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 780827 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NlNTBhZDE5ZWY2YzQ3ZDZmMjgzMmFkMDc5NjNiZDMxM2NmZTA3OGYM Sample Failed Build: https://ci.chromium.org/b/8876774719528263456 Sample Failed Step: compile Original change's description: > Move JSONParser-specific enums out of JSONReader > > JSONReader is the API. JSONParser is *an* implementation, and we would > like to experiment (in future commits) with different implementations > (crbug.com/1069271). Doing so is easier if they don't also have to match > exact error code values for invalid JSON input. In practice, API callers > don't care about the error code value (if less than 1000). > > Also swap the order of the JSON_SYNTAX_ERROR and JSON_INVALID_ESCAPE > enum values so that JSON_SYNTAX_ERROR takes the enum value 1, the same > as the new kErrorCodeInvalidFormat enum value. > > Also update a switch statement in > components/policy/core/common/config_dir_policy_loader.cc to also catch > JSON_TOO_LARGE, JSON_UNREPRESENTABLE_NUMBER and any future enums added. > > Bug: 1069271 > Bug: 1070409 > Change-Id: I786c5d7ffc77e4d7927614a133bf1e7aae7eda5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251561 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780827} Change-Id: I5bbe9bb80563dafd59bff48fdf61ab593f1ccc6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257457 Cr-Commit-Position: refs/heads/master@{#780843}
-
Adam Rice authored
Permit an "options" argument to be supplied to the QuicTransport constructor providing a list of certificate fingerprints that are permitted to be used for the handshake. Add a unit test and browser test for the new feature. BUG=1011392 Change-Id: Ia98ab05d0d5e6fc34ae57472119f1444dab7b330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251869 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#780842}
-
Steven Bennetts authored
This moves the ONC Import UI from chrome://net-internals#chromeos (which is a deprecated page) to chrome://network (with the rest of Chrome OS networking debug UI). This also fixes an issue where the ONC importer was being destroyed early, breaking ONC import in general. Bug: chromium:921726 Change-Id: Ideb4e6b037e9be249cbd3e7360ac6c25b143046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252849Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780841}
-
Clark DuVall authored
This creates a new "client_certificate" directory in components/browser_ui to hold the Android client certificate picker. This will be shared with WebLayer. Tested this in Clank manually after the changes. Bug: 1025606 Change-Id: Ib3189454e5b4ad556e04eecd7b0ccd3c0e78466b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253031Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#780840}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592808845-5ecd6c23d23a299e7b02af052540dc3d30072113.profdata to chrome-win32-master-1592830246-d0465e2a89f6ad20ad72129fb481528f24bd31c6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I93d83a77cc8781e6b85610b4bd392ae0926aa530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780839}
-
arthursonzogni authored
Add the optional "," at the end of the initializer_list to make clang-format align everything. This is easier to read. Bug: None Change-Id: Ifd1288b7d9b2eba2c3d335a99b884cde38d4867b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252012Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780838}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af0d5bca34b1..09867d37ed3c 2020-06-22 danilchap@webrtc.org Share constants for dependency descriptor rtp header extension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd55df054ff4e774f54def978e548673bfb6c582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780837}
-
Mike Wittman authored
The external storage root path is currently used as the location to write test runner output, but this path is no longer writable by apps on Android R. Update to use DeviceUtils' GetAppWritablePath() instead of GetExternalStoragePath() to support test execution on this version. Bug: 1094062 Change-Id: Ie90c46d4ed0c3e421d83c8d0ae8edee047f2dcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242845Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780836}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c72bf636e9e3..bf296fb827fe 2020-06-22 mmortensen@google.com cros_sdk.py: Set timeout for acquiring chroot lock to show debug info. 2020-06-21 sarthakkukreti@chromium.org image_test: add DBusServiceeTest.TestDelegationToUpstart 2020-06-20 pprabhu@chromium.org config: Drop redundant defaults 2020-06-19 jnchase@google.com endeavour: add factory branch builder 2020-06-19 tcwang@google.com toolchain_util: Add unittest for Bundle benchmark profiles 2020-06-19 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-19 mmortensen@google.com lib/locking.py: Wrap locking calls with a configurable timeout. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I23ee9a7b2947e4efd05253740ea1285faaf2a0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780835}
-
Mansi Awasthi authored
This CL moves all the private classes and structs to the top of private section in PDFiumPage. Bug: 1030242 Change-Id: I7450e69c27d2dcfa909ef32be80158919a60eb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257461Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780834}
-
Findit authored
This reverts commit 80b8a77a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 780795 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgwYjhhNzdhZTYzZGY1Nzk5Y2U3ZThhNDJmODRkODFiYTdmYjI5MmIM Sample Failed Build: https://ci.chromium.org/b/8876777224041482672 Sample Failed Step: compile Original change's description: > Reland "Remove/replace unnecessary includes of logging.h (base/)" > > This is a reland of a6e9e966 > > Original change's description: > > Remove/replace unnecessary includes of logging.h (base/) > > > > If the file just needs the CHECK/CHECK_OP/NOTREACHED > > macros, use the appropriate header for that instead. > > Or if logging.h is not needed at all, remove it. > > > > This is both a nice cleanup (logging.h is a big header, > > and including it unnecessarily has compile-time costs), > > and part of the final step towards making logging.h no > > longer include check.h and the others. > > > > TBR=thakis > > > > Bug: 1031540 > > Change-Id: Ib87efde411a3617fcebad6dae08313c20d63d0bd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254284 > > Commit-Queue: Hans Wennborg <hans@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780580} > > TBR=thakis > > Bug: 1031540 > Change-Id: I0ba8608458cf14c3e4bbc86eaef4c7ad136a9263 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256179 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780795} Change-Id: If4ea98e6078918d097faa1d464e9b27ec497766d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256844 Cr-Commit-Position: refs/heads/master@{#780833}
-
Winston Chen authored
Make the enable_extension and is_android flags independent, so (!android) would no longer imply (!extension). This change allows better separation of concerns and should benefit the overall Chromium project. Bug: 1074710 Signed-off-by:
Winston Chen <winston.c1@samsung.com> Change-Id: Ie136ce2be462bdfc7b2b40ca8ab1197ca5e35b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222773 Commit-Queue: Viatcheslav Ostapenko <sl.ostapenko@samsung.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780832}
-
Victor Costan authored
Bug: 1097230 Change-Id: Iaf1cd137500d3a5d9c96bc2ffaeb4a8ee1070c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256606 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#780831}
-
Domenic Denicola authored
The initial about:blank inheriting its origin from the parent is a rather special case, and deserves its own tests when origin isolation is involved. Bug: 1042415 Change-Id: I6c7d41e05b601bd1044f1c70f1ee7c75a44ffb14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255519 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#780830}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. CL also moves WebMediaPlayerMS away from using WebMediaStream directly, in favor of MediaStreamDescriptor. BUG=704136 R=guidou@chromium.org Change-Id: Ica4bbbf47b5754e2bdd92369e56b7143ebff4727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254584 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#780829}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Ic0d59407e28200355332852d290f18441d6f678e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253980 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780828}
-
Nigel Tao authored
JSONReader is the API. JSONParser is *an* implementation, and we would like to experiment (in future commits) with different implementations (crbug.com/1069271). Doing so is easier if they don't also have to match exact error code values for invalid JSON input. In practice, API callers don't care about the error code value (if less than 1000). Also swap the order of the JSON_SYNTAX_ERROR and JSON_INVALID_ESCAPE enum values so that JSON_SYNTAX_ERROR takes the enum value 1, the same as the new kErrorCodeInvalidFormat enum value. Also update a switch statement in components/policy/core/common/config_dir_policy_loader.cc to also catch JSON_TOO_LARGE, JSON_UNREPRESENTABLE_NUMBER and any future enums added. Bug: 1069271 Bug: 1070409 Change-Id: I786c5d7ffc77e4d7927614a133bf1e7aae7eda5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251561Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#780827}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592823242-c0a158a98eb51cc1e695f636e9edb128f03ff58d.profdata to chrome-win64-master-1592830246-afb27d0ab9d498e780360849bc14fecea8fdad6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia6a9e4ba57643a7cc77bd61671f6014e87dbb5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780826}
-
Ben Pastene authored
The two sets of pools should be identical now. So this moves all tests back to the old pools so we can delete the temporary *.template ones. Bug: 812428 Change-Id: I65109f627cad33d00cd0a26c6bd8368321d62e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250927Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#780825}
-
Corentin Wallez authored
It has been failing since the broader suppression has been removed. TBR=ynovikov@chromium.org Bug: chromium:1097752 Change-Id: I0e40fd5e3207987a56f0d1b4c990856aab4e8dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256227Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780824}
-
Corentin Wallez authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d385bf096f5d..f9ae06512ef7 $ git log d385bf096..f9ae06512 --date=short --no-merges --format='%ad %ae %s' 2020-06-22 dsinclair Roll deps and update tests. 2020-06-22 post MSL: Remove the old VertexAttr API. 2020-06-19 cwallez Fix placement of SPIRV_CROSS_DEPRECATED. 2020-06-19 post Fix duplicated initialization for loop variables with initializers. 2020-06-18 post MSL: Add test case for constructing struct with non-value-type array. 2020-06-18 post MSL: Deal with loading non-value-type arrays. 2020-06-18 post MSL: Add tests for array copies in and out of buffers. 2020-06-18 post MSL: Improve handling of array types in buffer objects. 2020-06-18 post Clean up some deprecation warnings when building with Makefile. 2020-06-18 post Remove unused member in MSLShaderInput. 2020-06-13 cdavis MSL: Fix up input variables' vector lengths in all stages. 2020-06-16 post HLSL: Fix texProj in legacy HLSL. 2020-06-12 git GLSL: Require GL_ARB_draw_instanced for gl_InstanceID in GLSL < 1.40 2020-06-08 post GLSL: Handle the rest of GL_ARB_sparse_texture_clamp. 2020-06-08 post GLSL: Support uint code for sparse residency query. 2020-06-05 post Refactor texture fetch function generation. 2020-06-06 AlexanderMeissner Fix missing switch cases in Y'CbCr conversion 2020-06-04 post GLSL: Implement sparse feedback. 2020-06-04 post MSL: Remove obsolete MSLVertexAttr members. 2020-06-04 post HLSL: Add native support for 16-bit types. TBR=dsinclair@google.com Created with: roll-dep src/third_party/spirv-cross/spirv-cross Bug: None Change-Id: I67856dbc40a6b4d78704c3def6ba0497282c89b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257420Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#780823}
-
James Cook authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn to use conditionals to include source files only on the platformn where they are used. Bug: 1018739 Test: compiles Change-Id: I59d91073a908f8312119302fff403d32b5f4d2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253214Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#780822}
-
Oleh Lamzin authored
Add battery info to probe interface. Request real cros healthd service interface. Mojo interfaces design doc (sorry, Google only): https://docs.google.com/document/d/1IolbGR2cZJYU0Lz4n6X8Qyxw7w6--4BH6G4NL3ltlSw/edit Bug: b:158658869 Test: existing browser test verifies that Telemetry Extension does not crash Change-Id: I6e50cd7d589a739fb768360d5870d2378fed1d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237985 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#780821}
-
Hans Wennborg authored
It was missing some includes, see https://ci.chromium.org/p/chrome/builders/ci/linux-chrome/10954 TBR=thakis Bug: 1031540 Change-Id: I259b7c577acac45ba50aef940ec2e20939dab555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257693Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780820}
-
Hans Wennborg authored
I'll push this upstream afterwards. TBR=mark Bug: 1031540 Change-Id: Ic160c18b46d099d552ba7362e10987e0bae89c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255613Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#780819}
-
Ben Mason authored
Bug: 1093993 Change-Id: I12aaaf7e26c401b3f2b8e77690d5a06ad615def7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257558Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#780818}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea3fc18261ac..4599eb7bc4fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC anthonyvd@google.com,apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:477479 Tbr: anthonyvd@google.com,apotapchuk@google.com Change-Id: I35bba06348afe9d9233ab6495a2b4504d8245348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257438Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780817}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: Idc9091bb275200a667827c520e289d084c6d30d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254758 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#780816}
-
Ioana Pandele authored
This reverts commit fea89df3. Reason for revert: This solution causes the sheet to require two clicks to close. Original change's description: > [ReEPwdSave] Add support for Keyboard Accessory v1 > > Clicking the toggle changes the tab icon by replacing all tabs. This > requires the tab to be re-marked as selected after its replacement. > > Bug: 1044930 > Change-Id: Ife8ef25cf6a7b081fba4dcabd9d81c9fa7dd0f94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250111 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780798} TBR=fhorschig@chromium.org,ioanap@chromium.org Change-Id: Ib68f58b1c4fcf774da5d4c1a903b4f4663cb0195 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256217Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#780815}
-
Liquan (Max) Gu authored
Before: When a merchant request a payment that involves a app store billing method but the merchant is not in a TWA, the browser reject the request with a generic error message. After: When that happens, the browser reject the request with a specific and actionable error message: ``` NotSupportedError: The payment method "https://play.google.com/billing" is not supported. Payment method https://play.google.com/billing is only supported in Trusted Web Activity. ``` Bug: 1095808 Change-Id: I40ae0896ac39f78ac63eae717faad733c73e8851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253129 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780814}
-
David Tseng authored
This change: - properly passes through AXActionData.request_id -> AXEvent.action_request_id - this id is used with the AutomationNode.hitTestWithReply(x, y, callback) action/function. When called, the action populates the action request id, which eventually makes its way to AutomationManagerAura. There, AutomationManagerAura::PostEvent dropped all fields of the action except for event to fire and the node id. - we resolve both paths were this was being dropped. Hit tests that land on a view, and hit tests that are directly on a window. R=dmazzoni@chromium.org, hirokisato@chromium.org Test: call hitTestWithReply on ARC++; verify receive a hit test result on the exo surface window in the reply callback. Change-Id: I177b255f4b3a1d0f3baf81d2c4ede23d370a8ed7 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254344Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#780813}
-