GitLab

Search key + single click will navigate to paragraph. In existing STS, Search key + single click while STS is active would exit STS, now it will navigate to the given paragraph.

When sentence navigation is implemented, we can navigate to the specific sentence rather than always starting from the beginning.

AX-Relnotes: N/A
Bug: 1143819
Change-Id: I5b5a73a20c8080922f7e9984af982c1ffc5bfc90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569785
Commit-Queue: Joel Riley <joelriley@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834292}

Bug: 997202
Change-Id: Ic14e10dfd0d4fbdc22c9b22289fb9a428eb3dbca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575453
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Auto-Submit: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834291}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //third_party/blink/web_tests/external.

Bug: 1113033
Change-Id: I57e5eaf69b7d9fbd8509d66b151da8abc33edcc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572683Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Cr-Commit-Position: refs/heads/master@{#834290}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a59f15a6efc..e79095f5335b

2020-12-07 tvanderlippe@chromium.org Update third_party/puppeteer to 5.5.0
2020-12-07 tvanderlippe@chromium.org Fold cm_modes into text_editor
2020-12-07 kimanh@chromium.org [wasm] Use wasm subtype for context menu item titles
2020-12-07 tvanderlippe@chromium.org Fix formatter_worker entrypoint inclusion for unit tests
2020-12-07 tvanderlippe@chromium.org Fix copying of property paths in object properties view
2020-12-07 wolfi@chromium.org Update frame tree when frames are written to via JS
2020-12-07 leese@chromium.org Support one-to-many mapping for breakpoints in inline functions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1024752,chromium:1127902,chromium:1140481,chromium:1140540,chromium:1150762,chromium:1155554
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iddc48373126c6dc4fb91e34b3793b08d1a317f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577531Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#834289}

- Updated WebContentsView and Exo to
set the sources of the dragged data with
the appropriate DataTransferEndpoint
object.

Bug: 1142406
Change-Id: I15924c0dd96b1bd39436036b3d4d0a78fd4f023f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563466
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834288}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //third_party/blink/web_tests/external.

Bug: 1113033
Change-Id: Iff4a92ecbf28578e32833f9fe03a9d93343e50ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573119Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Cr-Commit-Position: refs/heads/master@{#834287}

Make the ChromeVox hint dialog an oobe-modal-dialog in accordance with
the following change: http://crrev.com/c/2563481. This ensures that the
shelf buttons cannot be acted on while the dialog is open.

Bug: N/A
Change-Id: Ie08bfc44fdc6eb73e803c2ec10449cc461e455c2
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577545
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834286}

Center alignment is based on the margin-box. AlignmentOffset was
returning the offset to the margin-box instead of to the border-box.

This patch adds "margin_start" to the calculation correcting this
mistake. This was uncovered after:
https://chromium-review.googlesource.com/c/chromium/src/+/2569848
landed.

Bug: 1045599
Change-Id: If0c720ddae9a910ef2c08ee8efff22e8c2057982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575502Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834285}

Update the BuildInfo.java with the latest support library implementation
for feature development.

Bug: None
Change-Id: Id02f13a2f67a7bca8458a4f30b387291070d26c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570691Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834284}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/272ae5ee2ab1..505943a6a4cb

2020-12-07 wl@gnu.org * builds/unix/configure.raw: Don't set `FT_DEBUG_LOGGING`.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I3fc1c413a8c329c96b88040ccaa99f48824d0650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577526Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834283}

Space advances to the next page, and shift+space to the previous.

Note that this CL is also partially fixing (as a side-effect) a
bug where the space key was incorrectly not handled at all in
fit-to-page/fit-to-height modes, even outside Presentation mode.

Bug: 1148478,1155088
Change-Id: I390616b661c8de1f886c36469cff8776df183134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571152Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834282}

This CL converts base::Callbacks in CannedSyncableFileSystem to their
Once or Repeating equivalents.

Bug: 1152272
Change-Id: Id0890a8f8f9c6c2807a821913b82fb3f90bb6034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575420
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834281}

Account Consistency Mode Manager is enabled for ephemeral Guest
profiles.

Please see go/ephemeral-guest-profiles for more context.

Bug: 1125474
Change-Id: Id7ae0a844e6d582ad70ad12430af107048f40290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574747Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834280}

This CL makes the title field of web sign-in bottom sheet focusable
so that we can then send an a11y event from this field to announce the
title.

Bug: 1143259
Change-Id: I73f19a37dd5cf3a23454400149c4db2fc26db0f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577204Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834279}

This removes the experimental FeaturePolicyForSandbox feature, which
allowed a document to set sandbox flags via Permissions Policy (then
Feature Policy). This feature is not going to ship, and the mechanism
being discussed for it in the future is Document Policy, rather than
Permissions Policy.

This also removes the "opener feature state" for popup windows, which
was only used by these features. The Permissions Policy spec does not
support this any more, as all feature state is reset in new top-level
browsing contexts.

Change-Id: Ifc58ce6095892f8c4b968cfc0c02bbe8060d985c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564396
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#834278}

Define a setUp() method for ChromeVoxNextE2ETest. This allows us to
remove repeated statements in tests, namely window.doCmd = this.doCmd.

Bug: None
Change-Id: Idede486fc143e9c8fb74fa3d8d8f6058298d7ec6
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572536
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834277}

This class is now a proper "implementation detail", so we don't need to
expose it.

Bug: 1028063
Change-Id: I3a6769e2c6d3aa9a2c162f84aa2064526e040369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574853Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#834276}

https://chromium.googlesource.com/angle/angle.git/+log/cf023b3a8cd1..a10d694e914e

2020-12-07 jie.a.chen@intel.com Remove StateChangeRenderTest suppression

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: syoussefi@google.com
Change-Id: I15afadfd87d2c6ee4954b49b97cfec1c1bb73943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577527Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#834275}

Bug: 1115056
Change-Id: Icf028b3510dbc12507a5c89cc9177325bf4c86c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514424
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834274}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //third_party/blink/web_tests/external.

Bug: 1113033
Change-Id: I506ba1ae7f23c4b0f9d1d844f635e1c80f4fe489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573124Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Cr-Commit-Position: refs/heads/master@{#834273}

animation is per element without chaining as noted in the bug.

Bug: 1155674
Change-Id: I42cc7447c2552007a37ab01c0d22ab7a143a912b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575719Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834272}

This is probably because of <crbug.com/1152696>, where we call
|PositionForPoint| after running even handlers.

Bug: 1155733, 1150362, 1152696
Change-Id: I4ec0a685fa0507da2536d9cbff5d1e8da5076bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574557Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834271}

After 20 seconds of inactivity, a hint to activate ChromeVox
will be announced and shown on screen. Design docs can be found in
the crbug.

This change also adds a suite of tests for the feature.

Lastly, this change adds a Chrome OS feature which can be used to
enable/disable the behavior. This is added just in case we want to
toggle the behavior in the future.

ChromeVox will be announced and shown on screen.

Bug: 1124075
Change-Id: I35b82b3c76db89a7f30c2f31029f0d0e29ebd37d
AX-Relnotes: After 20 seconds of inactivity, a hint to activate
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488081
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834270}

This CL aligns the size of the WebUI back button with the mocks and thus
also with the size of the native UI back button.

Bug: 1126913
Change-Id: I72857d1a9cf870f75f0e0f16bd58f75544063c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577362
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834269}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682b3e2b91af..95a2d3216488

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC avi@google.com,grt@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: avi@google.com,grt@google.com
Change-Id: I59b81fc27bdb63672995c7dc4179c91c6cb7eb40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577523Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#834268}

This is needed in order to facilitate testing the feature.

Bug: 1138595,1155511
Change-Id: Ib01969e48e5686b3ffed963745c5e85a1d802221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573076
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834267}

Creates view controller to wrap Discover feed returned by Mulder. Will
be used as the primary NTP scroll view so that feed scroll actions could
be detected and to expose certain properties.

Bug: 1114792
Change-Id: I8ee9160b70234c1e25e9a5ea721d8982b84b5f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576416
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834266}

Previously, in BaseAudioContext::Clear() we called
GetDeferredTaskHandler().ClearHandlersToBeDeleted().  But this was
also called in DeferredTaskHandler::ContextWillBeDestroyed(), which is
called in BaseAudioContext::~BaseAudioContext().

There's no need to call this twice while handling the audio context
going away.

Manually verified that the tests from issue 1125635 and 1153658 work,
and the deadlock in issue 1136571 is gone.

Bug: 1150065, 1153658
Change-Id: Iee15c31dc637bf82d66bfd79d5238b1f80813153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575418
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834265}

Crash analysis suggests that items are being removed from the children_
vector while we are iterating over it. This can easily turn into an
infinite loop as the iter == end condition is never met, and calling
destructors on bad objects leads to confusing crashes. This checks for
that condition in order to validate the theory and get closer to
understanding these crashes.

Bug: 1152152
Change-Id: If30d7943e3f6d69ec000a82b656b5086e21bb7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576034
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834264}

Roll Chrome Win64 PGO profile from chrome-win64-master-1607331580-48b245bff1ba8e6eb069e7a15838de53304e6a37.profdata to chrome-win64-master-1607341806-af6783e2515ff922f8cbb2f88290f0ca953ce5b4.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I4d110c4b09cb1753ad3aa97fbc4494699f873a08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577517Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#834263}

https://android.googlesource.com/platform/external/perfetto.git/+log/c56ea91f6bd1..e1502e7972cb

2020-12-07 treehugger-gerrit@google.com Merge "metrics: Add test for combined_overall_rail_slices table"
2020-12-07 fmayer@google.com Merge "Update gen_bazel to set $(location CHANGELOG)"
2020-12-07 primiano@google.com Merge "MSVC + clang-cl: logging, VA_ARGS, popcount"
2020-12-07 lalitm@google.com Merge "docs: add docs with final expected state of checkpoint atoms"
2020-12-07 fmayer@google.com Merge "Return GetBuildId by reference."
2020-12-04 primiano@google.com Merge "Migrate comment to new proto_logging directory"
2020-12-04 primiano@google.com Merge "Use Soong to strip and dist trace_processor on host."
2020-12-04 treehugger-gerrit@google.com Merge "Small changes to make the codebase more Win friendly"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I2d9f027632ea012356d84b8a322f56261351f5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#834262}

No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and
BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in
/base/android/java/src/org/chromium/base.

The methods themselves will be removed in a follow-up CL once all call
sites have been removed.

This CL was uploaded by git cl split.

R=torne@chromium.org

Bug: 1106920
Test: autoninja -C out/Default monochrome_public_apk
Change-Id: I97b895b6d9065d2d040e07528d5e2f84b4fba5b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575371
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834261}

This test is flaky.

Bug: 1154612
Change-Id: Ic91eb710a08f57f6d51b192ede05371012436ac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574941Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834260}

TBR=govind@chromium.org

Change-Id: I6ec4b0985f592f78cc9c6ab995cec62159fed748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576428Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834259}

Context: Several worker_threads are woken up. Meanwhile progress is made
and the desired number of workers is reduced.
Problem: the first worker to wakeup will go back to sleep, even if
it could pick up work. This effectively increase latency before work
is picked up.
Expected: a worker that was just woken up should pick up pending work.

Fix: Avoid using GetDesiredNumAwakeWorkersLockRequired() to make
a decision of going back to sleep. |max_tasks_| is used instead.
If a worker is active and sees available work, it should *always* pick
it up, unless prevented by |max_tasks_|.

Drive by: call CanGetWorkLockRequired for early exit. There's no
point attempting to wake up additional workers if the current worker
was going back to sleep.


Change-Id: I7c7243046372ec99444320256f2df8d32e0d07a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568903
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834258}

Right now, this just caches the folded input string, but it's in
anticipation of a new algorithm that will want to hold on to scratch
space in between invocations.

Why not just make one and pass it to all of the command sources:
There's not *that* many sources, and it will complicate the interface.
I'd rather revisit it later if it ends up being a problem than take
on the extra complexity now. Doing it per source, OTOH, is a clear
savings since some sources can have many candidates.

Bug: 1014639
Change-Id: I85124976e50f0d0bcc33b307567738e97bee63d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575857Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834257}

With a flag, we can control which params we verify in which releases, so
we won't block releases if we found inconsistencies with certain params.

Bug: 1155414
Change-Id: I1fb608e20f1bc22025b12a5ec21d000151acb21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574649
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834256}

Roll Chrome Win32 PGO profile from chrome-win32-master-1607320769-266f8d6f8ffba3874a821f44f98b77515c76c883.profdata to chrome-win32-master-1607331580-9909f67f911bba407df7ff9d177d8d5f0f5ef14c.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia000e8e60ef016dd4a5ef3d8a90d430180370164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577434Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#834255}

Add the device type placeholders to IDS_RELAUNCH_REQUIRED_BODY,
IDS_RELAUNCH_RECOMMENDED_BODY and IDS_RELAUNCH_RECOMMENDED_OVERDUE_BODY,
replacing them with the actual device type in code. Additionally adjust
the domain placeholder names and descriptions and add screenshots to
make it easier for the translators to understand the usage of the texts.

The domain placeholder is already populated using
BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager, so no change
was needed there.

Bug: b:172682102, b:172682697, b:172682411
Test: Manual
Change-Id: I1eeaaa279d2f59b6b4a9c51367bdeaf29821f72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570574Reviewed-by: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Jana Grill <janagrill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834254}

Correct NSUserActivityTypeBrowsingWeb handling for default browser.

Bug: 1156134
Change-Id: I2595889731e71c8039f982122c64e044e5df64bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575151
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834253}