- 22 Oct, 2020 40 commits
-
-
Piotr Tworek authored
The code uses size_t, so it needs to include stddef.h. This works fine in default setup using libcxx, but fails with libstdc++. Bug: 957519 Change-Id: Id6bca0bbc911253a3be9a67b01dc348e467490ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489303Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#819742}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9606cffa66d0..c4af5cd3397d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I68cd6d1c00dbd0e979d3bf04bb7103101c13793a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819741}
-
Dave Tapuska authored
Last usage of WebFloatRect has been removed on the blink public API. BUG=738465 Change-Id: I83917a10a80dda63c735918969f37103f7877816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490255Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819740}
-
Hsin-Yu Chao authored
The flag was added in commit 771fcd50 and fully launched in M84. Remove the flag and callers. Bug: 1129107 Change-Id: I4be9840dc4ed13e9b3e4bc8cb8259c2997bba96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423667Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819739}
-
Michael Irani authored
If you navigate to "Change language and input settings" page and then back to "Keyboard" page, the arrow pointing back to "Change language and input settings" is not highlighted when in ChromeVox mode Steps (in ChromeVox mode): 1. Device 2. Keyboard 3. Change language and input settings 4. Back button Bug: 1029954 Test: Manual Change-Id: Ib6c15179f2d217d84365927e2371a83961286f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487866 Commit-Queue: Michael Irani <michaelirani@chromium.org> Auto-Submit: Michael Irani <michaelirani@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819738}
-
Sam Zackrisson authored
This updates all AEC3 metrics to a longer, uniform expiry date. Bug: chromium:1140068,chromium:1140069,chromium:1140070,chromium:1140072,chromium:1140073,chromium:1140076,chromium:1140077,chromium:1140078,chromium:1140083,chromium:1140074 Change-Id: Ia89e725870ba76c48ec6ea99989d8d0b48fdc77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485103 Commit-Queue: Sam Zackrisson <saza@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819737}
-
Kenichi Ishibashi authored
These validations are also done in ServiceWorkerStorage as of crrev.com/c/2473783. Remove checks in ServiceWorkerRegistry to simplify //content side. The previous CL didn't add validations in GetUserKeysAndDataByKeyPrefix(). This CL moves these validations to ServiceWorkerStorage. Bug: 1016064 Change-Id: I9396a3c4e6424ec1ba02f77932c2eb0fd6678465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491763Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819736}
-
Hitoshi Yoshida authored
RenderFrameHostImplBrowserTest.SameSiteNavigationResetsDocumentUsedWebOTP fails with segmentation fault if we enable pro-active same-site Browing-Instance swap. It is because the active main frame can be updated during a navigation, and a local variable |main_rfh| becomes invalid. This CL fixes the issue with accessing the frame dynamically. Bug: 1136383 Change-Id: I9707f846b384a195fc7cfa563f9165e486cae501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490972Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d56c381aa518..8462cfcb03a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hayato@google.com Change-Id: Ic44125b40fc0c3364adea623f3e3f70256f8dba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491196Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819734}
-
Sam Thorogood authored
This is internal cleanup work so that there are fewer inline types inside the Extension APIs. Change-Id: I332fb6dbb4d78c46c599e1ba83e27d361d1ba40a Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440721 Commit-Queue: Sam Thorogood <thorogood@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819733}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7e8ea22e4056..94384b5c685a $ git log 7e8ea22e4..94384b5c6 --date=short --no-merges --format='%ad %ae %s' 2020-10-18 marpan vp9-rtc: Fix to control for disabling loopfilter 2020-10-12 angiebird Add vp9_extrc_update_encodeframe_result() 2020-10-09 angiebird vp9_extrc_get_encodeframe_decision() 2020-10-15 jzern install vpx_ext_ratectrl.h 2020-10-09 angiebird Call vp9_extrc_send_firstpass_stats() properly 2020-10-09 angiebird Add vpx_rc_frame_stats_t 2020-10-08 angiebird Add vp9_extrc_send_firstpass_stats() 2020-10-07 angiebird Add vp9_extrc_init/create/delete 2020-10-07 angiebird Add callback functions for external_rate_control 2020-09-24 angiebird Add codec control for external rate control lib 2020-10-01 angiebird Add SetEncodeConfig and DumpEncodeConfigs Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: I49854d71e1f1b3dcd5f15e6214b81c6df40a04fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491682 Commit-Queue: Jerome Jiang <jianj@google.com> Commit-Queue: James Zern <jzern@google.com> Auto-Submit: Jerome Jiang <jianj@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#819732}
-
Hitoshi Yoshida authored
Code in Blink depends on some generated code in general. And its dependencies can be indirect. For example, t/b/r/bindings/modules/v8/properties_per_feature_installer_for_testing.cc includes t/b/r/bindings/core/v8/v8_origin_trials_test_dictionary.h through some other header files. But they have no dependency chain in GN file, and thus flaky compile errors can happen. This CL adds dependencies to connect a target to compile the .cc file and a target to generate the .h file. Bug: 1138802 Change-Id: I1f535475ffaaaa0373330dc66dc3ed3951a571e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477053Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819731}
-
Ian Struiksma authored
Test PrefillFormAndFill fails often on Mac, disabling now so we can enable the other Mac tests. Bug: 1141208 Change-Id: Ia4f9a09ced6484f4941f5683b4ae499c009d7452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490849 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#819730}
-
Luciano Pacheco authored
Add module for - list_test.js - context_menu_handler_test.js - command_test.js - array_data_model_test.js - cr_test.js - event_target_test.js Bug: 1133198 Change-Id: I839c440ea5072b3daacf21bfa69db5a0f7ce2e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486531 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819729}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9606cffa66d0..c4af5cd3397d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If75054824159c673a96a3378dd93c56cad4adff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819728}
-
Prashant Nevase authored
Pass dark mode bit set on PaintFlags to DrawImage to be used in cc::GpuImageDecodeCache. This is part of raster-side dark mode. In GpuImageDecodeCache, the dark mode bit on DrawImage would be used for deciding to apply dark mode filter on the image. Bug: 1094005 Change-Id: Ib14262c2111eb64f814ebc9682b307b3812b1e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467817 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819727}
-
Reilly Grant authored
It appears that in addition to returning "AccessDenied" when attempting to enumerate GATT characteristics Windows can also return "AccessDenied" when trying to open a service. This patch avoids failing service discovery entirely by simply ignoring such inaccessible services. Bug: 1058849 Change-Id: If4cf178bb30a12305cdadbc379922302c14671c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099762 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819726}
-
Hayato Ito authored
external/wpt/webdriver/tests/maximize_window/maximize.py>>test_fully_exit_fullscreen is flaky on linux. TBR=kyleju@chromium.org Bug: 1141282,977228 Change-Id: Ib331f9ddc12ffc82883d2aaee777d512817cdc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490911Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819725}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ice9c926c22a79d0f4ddf9d1f8fdeba64f67ebec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491602Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819724}
-
Hiroshige Hayashizaki authored
Path restriction check https://w3c.github.io/ServiceWorker/#path-restriction shouldn't be done for non-top-level module scripts. Bug: 1136775 Change-Id: Id75fd427aaceca189324335fae1efb37f5df7c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462947 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#819723}
-
Koji Ishii authored
r796465 crrev.com/c/2344431 changed |HandleOverflow| to call |HandleTrailingSpaces| only if |shape_result| is not nullptr. crbug.com/1139513 found that this change caused M86 to hang. M87 and later has a new trailing space code in r807457 crrev.com/c/2412307 and that the symptom is not observed. However, this indicates that we may hang if we go to the codepath in any other conditions. This patch: 1. Reverts the behavior to M85/86. 2. Change the function to take the pointer of |shape_result| instead of ref to indicate it can be nullptr. |HandleTrailingSpaces| needs |shape_result| only under certain condition, and the current assumption is that the combination will not occur. Change-Id: Ide9f48e14657c8e3c893fd506fee8412216df25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489730Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819722}
-
Hayato Ito authored
CrossPlatformAccessibilityBrowserTest.NonInteractiveChangesAreBatched is flaky on linux. TBR=dmazzoni@chromium.org,dtseng@chromium.org,kschmi@microsoft.com Bug: 1141280 Change-Id: I44cd6e694a99a51a8fea2103ce0345f65f282da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491571 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819721}
-
Minggang Wang authored
As a part of the Onion Soup project, this patch moves SyncLoadResponse from content/renderer/loader/ to third_party/blink/public/platform/. Besides, this patch moves `context_for_redirect` out SyncLoadResponse. SyncLoadResponse will be moved to blink/renderer/platform/loader/fetch/url_loader finally. Bug: 1110032 Change-Id: I258a23f5874ce72f2b962ce05a48ff272b718302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480703Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#819720}
-
Sam Zackrisson authored
The metrics are no longer in use. CL that removed the metrics: https://webrtc-review.googlesource.com/c/src/+/189783 Bug: chromium:1140067,chromium:1140071,chromium:1140073,chromium:1140076 Change-Id: Ieaa5a9aafc87b3d76e741f68a3d8d5ccbe90d647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485059Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#819719}
-
Peter Kotwicz authored
This CL switches fetch_all_androidx.py to use urllib.request.urlopen() instead of requests.get() because requests is not a built-in python module. BUG=1064277 Change-Id: I2b3d21f904a708283c3ccb1072460443d4e08e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490727 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819718}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d86ca92685bb..337086da0b11 2020-10-22 thestig@chromium.org Remove lots of unused CMYK code. 2020-10-21 thestig@chromium.org Remove `FXDIB_Format::kCmyk`. 2020-10-21 thestig@chromium.org Remove `FXDIB_Format::k8bppCmyk`. 2020-10-21 thestig@chromium.org Remove `FXDIB_Format::k1bppCmyk`. 2020-10-21 tsepez@chromium.org Use IsOpaqueImage() in CFX_DIBitmap::MultiplyAlpha(). 2020-10-21 thestig@chromium.org Remove parameter from CFX_WindowsDIB::LoadFromBuf(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I24e9cbfa39013d0012192d817f474c7154cdfd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819717}
-
Tal Pressman authored
The IPCs to create/destroy the Render* objects were already moved to AgentSchedulingGroup, but until now it delegated the implementation to RenderThreadImpl. This CL moves the actual implementation to AgentSchedulingGroup. Bug: 1111231 Change-Id: I5ade91a18c72882781eba159b9708aea7f857945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485659 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#819716}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/982bf51c4052..c3fb4c6d3915 2020-10-21 kmarshall@chromium.org Use "web_engine_with_webui" for Fuchsia telemetry testing. 2020-10-21 chonggu@google.com Move Fuchsia version into GetOSVersionDetailString If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092729 Tbr: skyostil@google.com Change-Id: Ib5b3845f4106889e6e4c5fb6b093303e3135f1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819715}
-
Adam Rice authored
If an HTTP/2 WebSocket server closed a stream with no error there it would trigger a DCHECK in WebSocketSpdyStreamAdapter::OnClose, due to an assumption that this method would not be called with an OK status. Accept the OK status and translate it into an ERR_CONNECTION_CLOSED. Also add a unit test for this condition. BUG=1139140 Change-Id: Iaa25ba45606f388d15b377154a6d2273d006fb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489104 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819714}
-
Nicholas Hollingum authored
crrev.com/c/2277694 introduced unadjusted mouse motion to cros, but this support is still experimental and should only be enabled behind a flag. We add a flag to the UI code s.t. the value will only be set if the flag is. Bug: 1131208 Change-Id: Idef231451bea0c8e718a3631ef46bb199f18e231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483982Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#819713}
-
Yu-Hsuan Hsu authored
Make linux-chrome able to qeury audio devices from libcras. BUG=b:167938737 Change-Id: Ic6452f8104f8c0e114d6eb990236eb6e18d2f4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483542 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819712}
-
Yuly Novikov authored
This reverts commit accbbb4f. Reason for revert: fixed in crrev.com/819493 Original change's description: > conformance/rendering/multisample-corruption.html flaky in WebGL1 and 2 > > TBR=kbr > > Bug: 1004581 > Change-Id: I027e384cea1233e7fcc948d7989c22b286d7b381 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473160 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817321} TBR=ynovikov@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1004581 Change-Id: Ibea2b7e4ed6c9f88ab21f58518ca3685046d828b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491002Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#819711}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I5f9b1acc0bdee2a8de592b9e185eb4244023a462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819710}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests and browser_tests. Change-Id: I4a302a38cf48060352477f48775aa5d2a0f27b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466004Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#819709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6029e464cf93..2e1091e0ef69 2020-10-22 cnorthrop@google.com Tests: Add FIFA Mobile trace 2020-10-21 cnorthrop@google.com Tests: Add KartRider Rush+ trace 2020-10-21 syoussefi@chromium.org Vulkan: Faster check for vertex attribute aliasing 2020-10-21 cnorthrop@google.com Tests: Add Marvel Contest of Champions trace 2020-10-21 sugoi@chromium.org Revert "Allow rendering to half float in ES2 contexts when possible" 2020-10-21 geofflang@google.com GL: Use ANGLE_GL_TRY when setting pixel pack and unpack state. 2020-10-21 sugoi@google.com Allow rendering to half float in ES2 contexts when possible 2020-10-21 geofflang@google.com Expose glGetTexLevelParameter{if}v before ES 3.1. 2020-10-21 jmadill@chromium.org Test Runner: Command line sharding args override env. 2020-10-21 jonahr@google.com Disable TransformFeedbackTest.NonExistentTransformFeedback* 2020-10-21 jonahr@google.com Add dlopen_fuchsia.h as exception in export_targets.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132514,chromium:1140113,chromium:1140531 Tbr: jonahr@google.com Test: Test: TransformFeedbackTest.NonExistentTransformFeedbackVaryingWithGLPrefix:/ES3_OpenGLTest: Test: angle_perftests --gtest_filter="*fifa_mobile*"Test: Test: angle_perftests --gtest_filter="*marvel_contest_of_champions*"Test: Test: angle_perftests --gtet_filter="*kartrider_rush*" Change-Id: I949ef152fd6a5ae20534c665f245272c618fdbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819708}
-
David Van Cleve authored
Currently, TrustTokenKeyCommitments has a bug where we compare an iterator from |additional_commitments_from_command_line_| to another iterator from |commitments_|, due to a typo when landing the original logic. This CL corrects that error. This undefined behavior could be part of the reason why we're seeing TrustTokenKeyCommitments.KeysFromCommandLine failing flakily on Android. Bug: 1140418 Change-Id: I3322104707cb62b1e53ec1ac22979dd647a8934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485784 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#819707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87996d2e7b98..d56c381aa518 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104817,chromium:1124054,chromium:1137566,chromium:1138495,chromium:1138536,chromium:1138554 Tbr: hayato@google.com Change-Id: I64c005eae5dfc51fc7547645f35a5a4d0125543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491660Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819706}
-
Matt Menke authored
Add NIK parameter to ReportingService::ProcessHeader(). TBR=msramek@chromium.org Bug: 993805 Change-Id: I04448b4da9bfad52f9ae0cd6863b19b0e572a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485172 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#819705}
-
Marc Treib authored
Bug: 1138277 Change-Id: Ie3114eca1654afd305fcd3bb260a181a07228085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484706 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#819704}
-
David Van Cleve authored
absl::variant was recently approved for general Chromium usage. This CL adds it to the Blink symbol allowlist. (I had a union I wanted to implement in the child CL and remembered `variant` had recently been approved. I'm not familiar with the criteria for permitting/forbidding symbols in Blink, so I wouldn't be too surprised if it turns out we don't want `variant` in Blink.) R=dcheng Bug: None Change-Id: I0885ef203472bcdb17481423d88eeb2add801766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442230 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819703}
-