- 17 Sep, 2019 40 commits
-
-
Peter Kotwicz authored
BUG=None Change-Id: I7348eb18a4c93b026222757e9a85503c538378d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808789Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697328}
-
danakj authored
The CreateRenderView IPC comes with a set of VisualProperties for the local main frame, and they should be set on the RenderWidget similar to how we do so for the CreateFrame IPC so that blink reads valid things off the RenderWidget while it exists and is not undead. However when the RenderWidget is undead, there is no local frame, so stop calling OnSynchronizeVisualProperties. The VisualProperties will be passed along in the future with CreateFrame in that case and set when the RenderWidget is reanimated. We must not call UpdateWebViewWithDeviceScaleFactor() after calling OnSynchronizeVisualProperties() as it dirties the compositor state, and Android WebView expects the compositor state to be clean when it sends an IPC to set the base background colour. The OnSynchronizeVisualProperties() does a Resize of the WebView which runs the document lifecycle and cleans the compositor state. So this also removes the call to that from RenderViewImpl, and places it with the OnSynchronizeVisualProperties call in RenderFrameImpl. The true purpose of UpdateWebViewWithDeviceScaleFactor() is to propagate the page zoom factor down to a new LocalFrame, and so it only needs to be called when the main frame is local as well. R=erikchen@chromium.org Change-Id: Idd06d7af65ebd01ceec03ec9591445eb7805f413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805873 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697327}
-
manuk authored
Bug: 1004857 Change-Id: I79c0507702ce816ea472943b72418273a468de62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808806 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#697326}
-
Chris Palmer authored
Use terminology consistent with the literature. Bug: None Change-Id: I3bcb1a747f23ad9418695926107b57eaa097ad41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808303Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697325}
-
Morten Stenshorne authored
NGPhysicalLineBoxFragment::ScrollableOverflow() compared the computed style passed as container_style to the computed style of each child, and it would calculate the child's relative offset only if they differed. All element nodes have their own computed style, so this only mattered for text nodes. However, if the container was an anonymous block, they'd always differ, since the computed style of a text node is the same as that of the parent DOM node. This is an implementation detail; we save some memory by letting text nodes share computed style objects with their containing DOM node. But that also means that extra care is required when working with ComputedStyle objects associated with text nodes: basically, treat all non-inherited-by-default properties (such as 'position', 'top' and 'left') as if they were set to their initial value. Bug: 1002485 Change-Id: If77d79e45c2aa55ac30dc239c738e2a40f8326f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807813Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#697324}
-
Xida Chen authored
The overflow regression tests was not moved because of this example: https://chromium-review.googlesource.com/c/chromium/src/+/1804695 Firefox falls partially for some cases in perspective interpolation, where the expectation is 'none' and Firefox produces 0px. The spec says the value must be either 'none' or positive values. Bug: 900581 Change-Id: I8562cd51476178919ecf9a393f0d169eb7244461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808585Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697323}
-
Tommy Nyquist authored
Discussed offline with pkasting@ regarding protobuf ownership. Long term owner of protobuf related projects, and we should share the load of protobuf rolls and reviews. BUG=None Change-Id: I36a636bcdb2c2db87e8d20b77524ce54177b813b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808794Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#697322}
-
Min Qin authored
These variables are now redefined in DownloadUtils Change-Id: Id5fe3a276c1ce5f8add8a9b1906ea3573b023565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808795Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697321}
-
Jenny Zhang authored
Since SearchResultTileItemView will not be destroyed but instead becoming invisible when user closes the suggestion window or launcher, we need to clean up the impression logging timer and other transient objects when the view becomes invisible. Bug: 1004553 Change-Id: I72ae20f8663b50b0bd6c1515c60c71c6f0411369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808791Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697320}
-
Tommy Nyquist authored
The experiment is only now slowly reaching stable channel, so we need to keep these metrics around for a bit longer. Since this is related to updates and users are only told when they are out of date, this experiment takes longer than usual to get numbers for. When the next expiry timeline approaches, we should take stock and figure out whether there are any of the metrics that should be kept for longer, or if they should all be removed. Bug: 1004477, 1004478, 1004481 Change-Id: I2a93d6a678186585adb0060c5370c26b7d73e2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807523 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697319}
-
Findit authored
This reverts commit 75273409. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 697311 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc1MjczNDA5MjdmNjdmYTM2NDg0ODU3MjZmMTc2ZGVmNWJlOWU1NjIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-archive-rel/9086 Sample Failed Step: compile Original change's description: > Remove DRP Pingbacks > > Removes all the pingback code. There's still some stale code left but > that's all related to v1 HTTPS Server Previews which will be removed > soon. > > Bug: 957753 > Change-Id: I4d5cccd5e402a786c49b8ea1c5b1d95a396f8850 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807962 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697311} Change-Id: I9ff1cc1eaa35fc63e0c4b5528b5d7d7ddbbaca27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 957753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809453 Cr-Commit-Position: refs/heads/master@{#697318}
-
Lucas Furukawa Gadani authored
This CL Converts the SimpleURLLoader to use the mojom URLResponseHead struct instead of the native ResourceResponseHead struct. Change-Id: I016b0731930b4589ba6169aa2e24ad45dc6675cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790273Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697317}
-
Zhenyao Mo authored
This reverts commit a4dd23fd. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1004879 Original change's description: > [base] Ensure that tests don't change the thread priority. > > This CL verifies that the thread priority is normal when a test process > is launched and before/after each test. The goal is to avoid having > tests that assume they run at normal priority be disabled because of > other misbehaving tests (e.g. https://crbug.com/931706). > > Bug: 931706 > Change-Id: I5ca18b87720b5305285be481f7b60ff5c941a324 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804786 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697261} TBR=sky@chromium.org,gab@chromium.org,thakis@chromium.org,fdoray@chromium.org,michaelpg@chromium.org,eseckler@chromium.org Change-Id: I900562585a34cd92a4f49a215d7c323706ce468d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931706,1004879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808814Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697316}
-
Xianzhu Wang authored
In layer list mode, we treat a mask layer as a normal layer, except that the masked layer is forced to create render surface, and the mask layer blend on the masked layer in kDstIn blending mode. Now we treat mask layer in layer tree mode in the same way. Bug: 1003414 Change-Id: Ieb67009f4f2ae8faf9b7adf8195499649413238c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799701 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#697315}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/818d963727de..142664633e0b git log 818d963727de..142664633e0b --date=short --no-merges --format='%ad %ae %s' 2019-09-17 seanabraham@chromium.org chromeos_config: mark samus-kernelnext as non critical 2019-09-17 saklein@chromium.org Build API: Cleanup compile script output. Created with: gclient setdep -r src/third_party/chromite@142664633e0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia6be428d1b274d6f7dc15f176a1abbb41e28113c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697314}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c210a490857..6f9a0238ce40 git log 2c210a490857..6f9a0238ce40 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6f9a0238ce40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I0bf84caff08c4a5031440ffbf4655d9387255934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809449Reviewed-by:
-
Matt Mueller authored
Bug: 973650 Change-Id: I44a49aa98ba3e35a5f4edff9e60fa16d7948d5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674443 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
-
Robert Ogden authored
Removes all the pingback code. There's still some stale code left but that's all related to v1 HTTPS Server Previews which will be removed soon. Bug: 957753 Change-Id: I4d5cccd5e402a786c49b8ea1c5b1d95a396f8850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807962Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#697311}
-
Henrique Nakashima authored
Clank HOA Lite specifies features should be in chrome/browser rather than chrome/lib. Bug: 995916 Change-Id: Ie2b91869a46d5fad8ea6daa92f479cacfeedb53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801803Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697310}
-
Dan Beam authored
R=mahmadi@chromium.org BUG=969062 Change-Id: Ib07f2a73193cd72f5703315a886c222b7ec7a56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808322 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#697309}
-
evliu authored
This CL contains the following changes to the a11y_page: * Updating the Captions button icon to use the external icon for MacOS and Windows. * Rearrange code so that there is only one default route path and place everything except for templates with their own route path in the default route. * Move the Captions button inside the settings-animated-pages. This fixes a focus glimpse when tapping on the Captions button using a touch screen device. * Move the Captions subpage template below all of the buttons. Bug: 971264 Change-Id: I354373f5715153fb3a89745dc88e12dedde80020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799304Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#697308}
-
Bo Liu authored
Allow WebLayer to switch between SurfaceView and TextureView at run time. Add a separate demo shell to host an apk with some fancy animations. Also add a smoke test that does not actually verify anything. Change-Id: I4544b675cec04d01fd60b3c27fac603a0b6a0f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807577Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697307}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e7a75776335a..0d73796b0f7d git log e7a75776335a..0d73796b0f7d --date=short --no-merges --format='%ad %ae %s' 2019-09-17 cferris@google.com Merge "Use bionic platform headers." Created with: gclient setdep -r src/third_party/perfetto@0d73796b0f7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ief9104d3429a19ad1c0b3670a62f810f06ec5709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809442Reviewed-by:
-
K Moon authored
This change adds a test that verifies the current behavior: When the PDF viewer tries to send a scripting message to an opaque origin (such as a "data:" URL), the postMessage() fails with a SyntaxError. We may want to make this case work, in which case, simply change the expected result of this test from "blocked" (false) to "allowed" (true). This leverages the existing TestGetSelectedTextReply() test (used to test same-origin and cross-origin requests). The existing test doesn't behave correctly if PDFViewer.sendScriptingMessage_() throws, so I've moved the postMessage("flush") call into a finally block to fix that. Bug: 1004425 Change-Id: I28ad56a21f634f42e20e3ca76fa4a02151b2560a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808580Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#697305}
-
Sergey Ulanov authored
Now FuchsiaVideoDecoder can integrate with FuchsiaCdm to handle protected video streams. Test: Play a Shaka Player demo stream that uses Widevine. Bug: 997853 Change-Id: I8fe2d0088d1ecd30ca3159dace17065fd276771a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799404Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697304}
-
Xianzhu Wang authored
It didn't mean what the name suggests because 1. the mask didn't apply to backdrop, but backdrop filter; 2. in software renderer and gl renderer, it meant the mask applies to backdrop filter *only*; while in skia renderer, it was ignored. The flag was never set in cc_unittests while mask on backdrop filter tests passed without setting the flag. Applying mask only on backdrop filter but not contents is not a case in real world, so we don't need to support it. With this CL alone, the mask will be applied on layer contents twice but the pixel result is the same because the second application has no effect (or the difference is below the fuzzy threshold of the pixel tests). https://chromium-review.googlesource.com/c/chromium/src/+/1799701 will fix the double mask issue by not issuing draw quads in PictureLayerImpl::AppendQuads() for backdrop filter masks. Test: All existing tests pass. Bug: 1003414 Change-Id: I8c19017a95308c60904cb98ba879709e11a29d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804321Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697303}
-
Avery Musbach authored
In transition between clamshell mode and tablet mode, overview windows shall be ignored when checking the topmost two windows to see if they should carry over to split view. In other words, the topmost two non- overview windows shall be considered for carrying over to split view. Test: ash_unittests SplitViewTabDraggingTestWithClamshellSupport.DragTabFromSnappedWindowToOverviewAndThenExitTablet Bug: 1004195, 1004426 Change-Id: I0a19891042678be4d80f74e3124b30bf54b0dc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808790Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#697302}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: I02145b2d2e0d228079d341fdbb64df18fbef3ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809398Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697301}
-
Fredrik Söderquist authored
With SMILTime now being integer-based we can simplify said method quite a bit. Bug: 998526 Change-Id: I2169fac72124b94c3c8830b6f411518dfd8015ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808859Reviewed-by:
-
Robert Ogden authored
This records the success state of the prober just before it goes inactive (by calling it instead of ResetState in most places) for sake of easier high level metrics. Bug: 1003145 Change-Id: I14a871549a4785be49be6543b7ff1a0882f355cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799321Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea5731baa00c..87be585106e6 Created with: gclient setdep -r src-internal@87be585106e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I544103a452e1168d4e7ca188d8412dd1a185bea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809445Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697298}
-
Elly Fong-Jones authored
Before this CL, MenuController's contract required that the provided MenuModel outlived a MenuController instance. As of 10.15, it's impossible to fulfill that contract: AppKit seems to like keeping MenuController instances (via [NSMenuItem target]) alive until the next autorelease pool drain, and there's no way for the C++ code that creates & manages a MenuModel to know when that will happen. See bug 998773 for more details about this change in 10.15. As such, this CL has MenuController hold a WeakPtr to its MenuModel, rather than a raw pointer, and handles the MenuModel being destroyed before the MenuController. One other possible approach would be to make MenuController own the MenuModel, but that would be a very large change to the ownership of MenuModel, and in particular would conflict with the fact that Views (in the //ui/views sense) are often used as MenuModels but are owned by their parent View. Bug: 998835 Change-Id: Ieb3b8928a40d07edf1b9a4d394fb4adc0410fde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804538Reviewed-by:
-
John Abd-El-Malek authored
Change-Id: I960dc5baa75a855cb25a05256be3fee0983b6369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808793 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: Iacac16cd532577f19b26bdea50396d58dcedcce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809334Reviewed-by:
-
Paul Moy authored
Now that cros_healthd is moving forward with a new mojo interface in ChromeOS, we need to update Chrome's mojom definitions as well. /var/log/chrome/chrome and make sure the correct sku_number is reported. Bug: b:128683357 Test: build and deploy Chrome for nami with crrev.com/c/1779132, check Change-Id: I1b75c418821c48c8f9bea01e915b5e8cd82d2e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704947Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Dan Harrington authored
The underlying problem was that RequestCoordinator was reporting that a request had been added, but in fact it was rejected. This led auto-fetch code to believe there was an outstanding request remaining. Bug: 1003053 Change-Id: I5f1554481405ca63a050c119ef624053e58f3acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801318Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#697293}
-
Nazerke authored
New colors, which are only used in tab grid, should be local colors instead of global. This CL is moving |kGridThemeSelectionTintColor| and |kGridThemeDarkSelectionTintColor| to ios/chrome/browser/ui/tab_grid/grid/resources/ from the common semantic colors folder. Bug: 995746 Change-Id: Ia7afebfc21add3466e7e8ad8e94ba9c49659fa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807193Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#697292}
-
Boris Sazonov authored
This CL modifies sign-in flow SigninManager to remove the code that shows error dialogs from Google Play services. Now these dialogs are redundant, as Google Play services availability is checked from SystemAccountManagerDelegate.checkCanUseGooglePlayServices, so if there is no usable Google Play services package on the device, then accounts won't be exposed from AccountManagerFacade at all. Bug: 997218 Change-Id: I0ada3b6165387677c33a82b75e23bc38757d2f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808861 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697291}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: I8da45e352eb54662a5debedbfb394fd7687ac1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808552 Commit-Queue: Sky Malice <skym@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697290}
-
Manas Verma authored
When a user, who is opted-in for FIDO auth, attempts to unmask a new card, there will be a CVC check followed by a WebAuthn verification flow. This requires passing along an authorization token received from the GetRealPan response from the CVC unmask. Bug: 949269 Change-Id: Ief8fc1e6e8ccd06622daa77377c5e396c6d2b3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761656Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#697289}
-
