- 19 Jun, 2019 40 commits
-
-
Tom Anderson authored
Wanted for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1654489/ BUG=419673 R=thestig Change-Id: I7a2ecd8e443929ff38b08c16558eb210ca2308d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666528 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#670336}
-
Alexey Baskakov authored
It disables BookmarkAppInstallManager code path (with BookmarkAppHelper inside). It enables unified WebAppInstallManager and InstallFinalizer infrastructure. Bug: 915043 Change-Id: Id77289a7b6b51681b8833d9c83d7a9657c1af624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627847 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#670335}
-
Ben Pastene authored
Forgot this bit in https://chromium-review.googlesource.com/c/chromium/src/+/1663023 R=dpranke, jbudorick Bug: 932269 Change-Id: I8f5df4581265fa55e57a3cbcfc2293518c4c3f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666330 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#670334}
-
Livvie Lin authored
References to this unused field were deleted in https://chromium.googlesource.com/chromium/src.git/+/84c5e49b65ef24c2c0acbc8b631138c2e7d41cb1. Bug: 960113 Change-Id: Ic72e8ad8da55bc98e6070002973a57400dae323c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665897Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670333}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b00478d5. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 3d4f72a8 "Worker: Add service worker interception tests for shared workers" 043af69d "WebSocket: stop removing an iframe in onerror from crashing" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I816cfb41c30a266e20368e2f5f8e943b18e005d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666368Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670332}
-
Tim Song authored
When ChromeVox is enabled, Search+Space simulates a mouse press, which was not being forwarded properly to the child contents in NotifierSettingsView. TEST=manually verified BUG=897974 Change-Id: I13a738034891ac7d073c30d86daa3a3e98e321ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666309Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#670331}
-
Lukasz Anforowicz authored
This CL replaces strict-equality comparisons like if (url == GURL(content::kAboutSrcDocURL)) ... with if (url.IsAboutSrcdoc()) ... Unlike the old code, the new code correctly handles about:srcdoc#ref and other corner-cases (see gurl_unittest.cc for more examples). Note that in the long-term URLs like about:srcdoc#ref should not be encountered in practice (see https://crbug.com/974300), but for now such navigations are still possible (e.g. frames can directly navigate to about:srcdoc#ref by setting window.location). Using IsAboutSrcdoc instead of strict-equality should correctly account for the current implementation state (and should remain correct in the long-term). To prevent reoccurence of strict-equality comparisons, the CL also removes the content::kAboutSrcDocURL constant. Bug: 973922 Change-Id: I2bd80c82c395a4659ccb50f4caf236baa5ad3c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659195 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#670330}
-
Dana Fried authored
Most of our Views class properties are of type ClassProperty<T*> where T is a value type, but we're forced to use pointers because T can be of any type and must therefore be allocated on the heap. This leads to a lot of code like: my_view->SetProperty(kMarginsKey, new Insets(kMyViewDefaultInsets)); ... *my_view->GetProperty(kMarginsKey) = new_insets; (The latter pattern is to prevent a second heap allocation - but only works if the initial allocation happens; otherwise it crashes.) This CL shortcuts this behavior so that it behaves in the way we actually want to use the system 90% of the time: // Allocates a copy of kMyViewDefaultInsets for the property. my_view->SetProperty(kMarginsKey, kMyViewDefaultInsets); // Updates the value of the existing property. my_view->SetProperty(kMarginsKey, new_insets); // De-allocates the existing property value. my_view->ClearProperty(kMarginsKey); In order to use this new functionality: - The property must be an owned property of pointer type. - The property type behind the pointer must be copy- or move-assignable. Change-Id: Idec1d5b9c104814f234270214b615774fa5a7084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657288Reviewed-by:
-
Piotr Bialecki authored
XRPlaneSet is a readonly setlike<XRPlane>. Change-Id: Ifefac1ff5f04a5d52dfb80828b2a2c769c62ebf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663456 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#670328}
-
John Budorick authored
Bug: 790202 Change-Id: Ibeec43f1c538754af0538dbf73173f0c52eb7e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666228Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#670327}
-
Sébastien Séguin-Gagnon authored
Those are fundamental histograms that will be used for the foreseeable future. Bug: 975368 Change-Id: Iad08b86e0d3b4738ff5562b3217808f7e0974dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662994Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#670326}
-
Peng Huang authored
Bug: 973413 Change-Id: I9edcc776485bbb21af5631b6db3c02bbb7723b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664204 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670325}
-
Kunihiko Sakamoto authored
These are still useful to have around. Bug: 975822,975867,975217,975462,975703 Change-Id: Ie355963173d7561e6b82fd0d26e7c6ed85b9b60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663481Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670324}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49131ca238de..764ec87e51cd git log 49131ca238de..764ec87e51cd --date=short --no-merges --format='%ad %ae %s' 2019-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@764ec87e51cd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I079f173d5881c22cebeee1c21136c07ebbf22921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670323}
-
Kunihiko Sakamoto authored
Bug: 975025 Change-Id: I8436aff3e4a9d4fd96ce42513a746cc1fbc71e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663880Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670322}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/40ee745abc3b..4e5c106f96c4 git log 40ee745abc3b..4e5c106f96c4 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jclinton@chromium.org Update reasons that moblab-generic-vm is experimental Created with: gclient setdep -r src/third_party/chromite@4e5c106f96c4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I2998b7bc14e8272f1fe8db33553274ff660ba3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666170Reviewed-by:
-
Tarun Bansal authored
flaky test Change-Id: Ie570dcde651f4f85530fa5c8cdd2b0cdf5b7ee75 Bug: 974895 TBR: rajendrant@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666550Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#670320}
-
Tom McKee authored
The Element Timing specification originally included a provision for reporting timings of elements that were automatically detected as 'important'. This would allow useful information from the Element Timing API to be reported through the Performance Timeline even if site authors neglected to mark their important elements with the 'elementtiming' attribute. The automatic detection of 'important' elements is, necessarily, a heuristic and, until consensus for the correct heuristic had been reached, we were treating any image that occupied greater than %15 of the viewport as 'automatically important'. As the Element Timing specification is still being refined, the exact threshold and heuristic is still being investigated. Until agreement on an appropriate heuristic is reached, implicit registration will be disabled. This CL removes our %15 threshold and disables implicit registration. There was also WPT coverage to test that all browsers would respect the %15 threshold so that test is being removed too. Change-Id: I14847533402f5a68bb3de63a8f9acbd004c5a8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643379Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#670319}
-
Robert Ogden authored
* Tab visibility * ECT * Bloom filter blacklisting Still remaining: * Preconnect to origin * Browser tests Bug: 971918 Change-Id: I00d265ae1e4f4a1aeca017edad9d6cacd9c0e018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665852Reviewed-by:
-
Kristi Park authored
Delete the CerseiFakeboxOnNtp fieldtrial and move the most likely to launch variant to OmniboxBundledExperimentV1. Bug: 958655 Change-Id: If9eec80b57454424344bea8930b132e6255bca91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664971 Auto-Submit: Kristi Park <kristipark@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#670317}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88825299a7d4..200c69540dc7 Created with: gclient setdep -r src-internal@200c69540dc7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:849505,chromium:790246 TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I1e516469551f6e709816eb1769e5570bf780ae1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666169Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670316}
-
Steve Anton authored
These histograms are useful to identify and monitor any critical SRTP-related regressions across the ecosystem. Bug: 975885 Change-Id: I9d2b37a9e5efd05c06daf50668a7d6cfd1c8dc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665652 Auto-Submit: Steve Anton <steveanton@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#670315}
-
Derek Schuff authored
Some of them had M77 and others had 2019-12-31. Update the M77 ones to match. Bug: 974960 Bug: 975400 Bug: 975351 Bug: 975348 Bug: 975079 Bug: 975049 Bug: 975001 Bug: 974990 Change-Id: Ic2a7a9b439244ebaeb495b3c504957ffc0949cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665850Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I3d0d3cf07659acf5659eb5a1a933cdd6904dc5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665771Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#670313}
-
Will Cassella authored
XRBoundedReferenceSpace returns a new XRBoundedReferenceSpace with modified boundsGeometry from getOffsetReferenceSpace. This behavior was not covered by the base XRReferenceSpace::getOffsetReferenceSpace test, so this CL adds a test with coverage for that. Additionally, this CL changes the implementation of XRReferenceSpace::TransformBaseInputPose to not return null for XRBoundedReferenceSpace. That behavior is not correct. Bug: 961880 Change-Id: Ibcb7af1e7ee95843f3d7d68a0bc7b7f3d07ab6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663552 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#670312}
-
Varun Khaneja authored
The list is currently not being requested because the backend doesn't support it yet. Bug: 966646, 963165 Change-Id: I8533d5da79c8e88a5d15285c3ee3610551d47bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650510 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#670311}
-
Trent Apted authored
These file manager apps have a shelf presence, but can only be launched when provided a filename to open. Pinning them creates an item that does nothing. Bug: 955396 Test: ChromeLauncherControllerTest.UnpinnableComponentApps Change-Id: Id157a74606c774c10afef97afe02cbca73026764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661315 Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#670310}
-
Jérôme Lebel authored
Changing the expiration date of Signin.AccountReconcilorState.OnGaiaResponse histograms to M87. Bug: 975868 Change-Id: I545ee977dff5648a7af18daeef73b39f1abb4f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665689 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Maggie Chen authored
Watch dog test functions SetAlternativeTerminateFunctionForTesting() and SetTimeoutForTesting() are not used. Delete them. Bug: 949839 Change-Id: I1bd01d02ac4fcac4297789b3aca2c8aa73f77510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662629Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670308}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f0f9a8f1fd94..84079432edd2 git log f0f9a8f1fd94..84079432edd2 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 thestig@chromium.org Add tests for the PostScript truncate operator. 2019-06-18 thestig@chromium.org Add a pixel test for /Range in PostScript functions. 2019-06-18 thestig@chromium.org Reuse CFX_FontMgr::GetFixedFace(). Created with: gclient setdep -r src/third_party/pdfium@84079432edd2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I0b6f6026607b0688fb8f01468f3a19056c1dbce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665968Reviewed-by:
-
Mark Pearson authored
Bug: 974933,974967,976026 Change-Id: Ief0a20ae0d119cf9361d0d7edfe936a385a8e95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663320Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#670306}
-
John Lee authored
Bug: 973674 Change-Id: I5549cc0a3995e450c04e6c34d379825cea4a873a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665288Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#670305}
-
Adrienne Walker authored
These are important indirect performance metrics that should be kept around roughly indefinitely. This is both to understand how content in the wild is changing and how changes to the codebase are affecting these metrics. Bug: 975186 Change-Id: I98eed0400682ff8155fb42123d6978368f5ad40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663082Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Darwin Huang authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/894 Failing bot: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak TBR=aboxhall@chromium.org Bug: 976438 Change-Id: Ib95fd2a98df825981f8fd8d87b04db66a802cf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666291Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670303}
-
Kenneth Russell authored
Upcoming CLs will change the heuristics for selecting the low-power vs. high-performance GPUs on dual-GPU systems, macOS in particular. The GPU tests in Chromium's hardware fleet expect to run on the high-power GPU, so maintain this behavior by default. Bug: 965842 Change-Id: I17707475a4505905ea95a8a57d06a1754fc101fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665910Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#670302}
-
Antoine Labour authored
When the context is lost during creation, on some drivers we may have had bogus values during initialization for the static queries, which means we might have constructed a ContextState that's inconsistent with other ContextStates for the same real context, which causes problems when doing virtualized context switches. So check reset state after initialization and fail if the context is lost. Bug: 946978 Change-Id: I38fb73d819dfcedf0565e6b4345c3700c49fbb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659644 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
Yuwei Huang authored
grpc_core::InlinedVector has a few (reinterpret|static)_casts that look benign but will trigger CFI bad cast check. I've tried to suppress the check by adding "-fno-sanitize=cfi-..." when building the gRPC lib (http://crrev.com/c/1660194), but it doesn't seem to have any effect on the canary ChromeOS build. As suggested by pcc@, this CL blacklists the whole inlined_vector.h file for CFI cast check. For longer term, we will need to fix InlinedVector to prevent it from casting the element before initializing it. This is tracked in github. Bug: 972108 Change-Id: Ic90631f9e66d15e1a3c8d073c99bfb69a6400103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665554Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#670300}
-
Koji Ishii authored
This patch removes following histograms: Hyphenation.Open Hyphenation.Open.File These are added to learn how long it will take to open hyphenation dictionary. A concern was raised when I implemented hyphenation on Android as the open operation is synchronous. We do not see the data indicating needs to invest in asynchronous hyphenation at this moment, and the data is steady that further recording does not seem to be necessary. Bug: 975142 Change-Id: I1d98eedf47a1afa5940f6e01b3c6fadcca4cbcdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664092Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Alexander Woolf authored
Creates and implements a QuarantineFile mojo interface. The implementation in QuarantineImpl calls existing quarantine::QuarantineFile(), converts the return value to a mojo type, And runs the callback. The service is invoked in BaseFile::AnnotateWithSourceInformation, where QuarantineFile() is now called. Since asynchronous quarantine should only be done when kPreventDownloadsWithSamePath is true, leave the non-service path in for now. Bug: 870998 Change-Id: I0f668e18b882893d1a8a736a2afe9912dc320b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625944Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Alexander Woolf <alewoolf@microsoft.com> Cr-Commit-Position: refs/heads/master@{#670298}
-
Eric Roman authored
Bug: 972125 Change-Id: Ieba22ac128dbb4c6e24e1ff417a84c5e4f775605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660966Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
