- 20 May, 2020 40 commits
-
-
Tarun Bansal authored
Record the data use repported by Android sliced by foreground vs. background Chrome state. Also, improve the accuracy of tracking the Chrome's app state (foreground vs. background) as well as the network state (metered vs. not) by checking for the initial values of these states in the constructor. Change-Id: I0544b33483666a332d35a8fc5b41eb4f2ddc0dea Bug: 1084218,1084220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191977 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#770501}
-
Koji Ishii authored
This patch chagnes |AsDisplayItemClient| to return |DisplayItemClient|. This is to prepare for making |NGFragmentItem| not a |DisplayItemClient|. There should be no behavior changes. Bug: 982194 Change-Id: I2361b0c316b3625ee85004b42480ca37e980d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208840 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770500}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/258d94f61ed1..d45b30b5a554 2020-05-20 rafael.cintron@microsoft.com Enable allowClearForRobustResourceInit for AMD drivers 2020-05-20 m.maiya@samsung.com Vulkan: Acquire a new BufferHelper from the pool based on a threshold If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ia34fc8ac543d6508298f236398a1898547be3172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770499}
-
Xiaocheng Hu authored
FontDescription may hold negative zero float members. In this case, it compares equal to positive zero, but the hash values are different. This patch converts negative zero to zero before hashing, so that the hash values are the same, and the common assumption that equal values have equal hash is ensured. Bug: 1081017 Change-Id: Ibc02993967d7638a065d045a138e4d966a20b2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194912Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770498}
-
Daniel Libby authored
The routed version of SimulateMouseClick and SimulateMouseEvent should be preferred, since it exercises the real codepath taken when handling input (and can target OOPIF). Remove the non-routed implementations and replace existing implementations with the routed version. Also remove a couple of 'Routed' methods that are not currently used. - RouteMouseEvent is the same (now) as SimulateMouseEvent - Taps are not aura specific, so new tests should use SimluateTap* APIs Bug: 708651 Change-Id: Ic1c5f3702a81ec6f65195d03cb08a38efa81ee01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200427Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770497}
-
Yoshifumi Inoue authored
This patch changes "move-selection-back-line-rtl.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ie55dea9237cb667460be97d706a9b838a718a7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208881 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770496}
-
Glen Robertson authored
Issue was the async origin-history check in daily_metrics_helper. Ensure this has time to complete by flushing the running thread. Bug: 1083813 Change-Id: Iae5fbb1475e1fb6f1cc447fdc4c11a827edb4b1c Fixed: 1083813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208326 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#770495}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of the (Shadow DOM v0 specific) ::content pseudo element. Bug: 937746 Change-Id: Ib588ddab29730c8356764dc51f71ac97065142c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209565 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#770494}
-
Andy Paicu authored
Bug: 935900 Change-Id: I7409f86b2fa5c53cec7d901cbfad85187463dff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203004Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770493}
-
Tomasz Śniatowski authored
Outputs newer than the stamp must have been modified outside of the build or in another configuration without CallAndWriteDepfileIfStale, and so should not be trusted. CallAndWriteDepfileIfStale records a stamp file with some metadata to avoid re-running a potentially expensive action if the invocation and dependencies did not change. Setting aside the question of why ninja knowledge of the build is not sufficient for that, one issue that can catch people by surprise is if a build output switches from a simple action to one based on CAWDIS, without changing the output filename. The problem can manifest as follows: The pre-CAWDIS build builds just the output. Incrementally switching to a CAWDIS action succeeds. Going back in history to before the change also succeeds to build incrementally. However, going forward again to after CAWDIS change can result in a build break or miscompile. Ninja correctly tries to re-run the action, but CAWDIS incorrectly treats an old output as up-to-date. That is because the pre-CAWDIS build does not use the stamp file, and so does not touch it at all when rebuilding the real action output. A stale stamp file, one that does not correspond to the output, can remain in the build directory. The post-CAWDIS action then sees the old stamp file, sees that the checksums match, and assumed the output next to the stamp file is therefore up to date. This is not theoretical: bisecting across https://crrev.com/c/2110431 and building Chromium for android can trigger a build break around lib.java/base/jni_java.interface.jar because interface jars switched to a CAWDIS turbine.py helper. A failure can be seen trying to build c7ac5f96 (a recent master), then 5cbd0735a05c (4068 branch), and then c7ac5f96 again (which will try to use a stale jar). The issue can be mitigated if we assume that whenever an output file is newer than the stamp file, it is stale and the whole action needs to be re-run. This should be a sane assumption, because CAWDIS always runs the actual build action first, and then records the depfile. The stamp should always therefore have mtime greater or equal to that of any outputs, unless the build outputs were modified outside the build or outside a CAWDIS action. That should trigger the action again. Change-Id: I62196a9428ebc075c613c8b91b313f67ad31944d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204775Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#770492}
-
Bo Majewski authored
Renames recordSharingAction to recordSharingActionUMA_ to keep it in line with other methods in FileTasks. Adds recording of UMA data for sharing files with Android apps. Adds a unit test. Tested: browser_tests --gtest_filter="FileManagerJsTest.FileTasks" Bug: 1063169 Change-Id: Ie4b2ceeb049a9a66f25b48c3afde2c92573af8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206296 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#770491}
-
Koji Ishii authored
It compiles without this because the superclass |DisplayItemClient| has the declarations. This is to prepare for making |NGFragmentItem| not a |DisplayItemClient|. There should be no behavior changes. Bug: 982194 Change-Id: I3f908131e9de418f2910591fb7d52984ee6dda27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208879 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/34eee0d9fc85..9d52ac1573f1 2020-05-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fabf74bda604 to d45b30b5a554 (10 revisions) 2020-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2d0aebd8 to 179a84ca (467 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058744 Tbr: lovisolo@google.com Change-Id: I07eab1715abdc803c1614adf3d8a9785d9679c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207667Reviewed-by:
-
Yao Xiao authored
Indicates whether the IP of this URL was publicly routable. It’s a property of the visit because it can change depending on the network situation at the visit time. A value of “false” can mean several things: the URL was not publicly routable; this was not a committed navigation; this runs on iOS (unimplemented for iOS at this point); or the visit was migrated. The FloC project (I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/DpZZG5K1PWs) will need this bit, as it wants to query the history and only select those URLs that had a publicly routable ip. Change-Id: I499be8f9398ab885c71fca8d04d1b997171fcef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101323 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#770488}
-
Hitoshi Yoshida authored
The dictionary in spec has a default value empty string on "referer" and "sample", but we did not have. This CL adds the default values, and updates some tests expectation. Updated tests expected an event SecurityPolicyViolationEvent returns null for "referer" and "sample" attributes, but their type are string and shouldn't be null. This CL updates to expect empty strings. Bug: 839389 Change-Id: If8c9a9c2c7b2882ecbd0ab63df467e2b1bafa047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208316Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#770487}
-
Yoshifumi Inoue authored
This patch changes "paste-noscript.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ie43ec799aa446932dcf532bd5688df32bcd6b0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210075 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces editing related tests such as: - empty condtent editable - placeholder <br> to VisiblePositionTest to help implementing EditingNG. Bug: 707656 Change-Id: I7500d07ef3c715421ad0efec44f3c60ee17e9e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208584 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Anupam Snigdha authored
This patch refactored code related to the VK show/hide API on Windows. It is also needed for implementing VirtualKeyboard API feature. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/ VirtualKeyboardPolicy/explainer.md Design Doc: https://docs.google.com/document/d/ 1I0LUNxK_gP5IaNQsbYN6gL6Zpm71XzduCKkublU5o5Q/edit?usp=sharing Bug: 856269, 1071499 Change-Id: Icf7cf86032758ba906ad8f7507a5468699f7f1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186191Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770484}
-
David Jean authored
Bug: 1066804 Change-Id: I9b16c33790d0a68305e2b6041d41ddda064f4c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209052 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#770483}
-
David Trainor authored
- Add tests for the variation that opens the omnibox instead of SRP. - Add a set of matchers to make testing easier. - Pull out a test provider. - Migrate other tests to the helpers. - Add JavaDocs - Rename ImageTileMatchers to QueryTileMatchers TODO: Change-Id: I877ffaa4d4c4b7456a8677055d25b37fc3d4db49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200379 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770482}
-
Colin Blundell authored
WebLayer currently does not support translate in incognito mode for the following reason: In //chrome, TranslateRankerFactory supplies the original Profile that is associated with the incognito Profile when the service is requested for a Profile in incognito mode. However, WebLayer doesn't have a concept of incognito profiles being associated with regular profiles. This CL adds support for translate in incognito mode in WebLayer by having TranslateRankerFactory just have its own instance in incognito mode. This seems reasonable based on the fact that in WebLayer incognito Profiles really are standalone Profiles just like regular Profiles. Bug: 1072334 Change-Id: Ibb5a6ae3823316a6ce966245fff146846f262280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198786Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#770481}
-
David Jean authored
Bug: 1076448 Change-Id: I25c5e913e85c6b8a4747eebbe6aaed6a710f9b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207383Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b17dbd4b. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I216347e3f9acf4b02f03f071838dda16049e0808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208300Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770479}
-
Anubha Mathur authored
This measures the time immediately before the service worker fetch event handler runs to the time when fetch handler's respondWith promise is settled. Note that this time does not include content download. This timeline was currently missing in the network panel, making it difficult for developers to understand how long respondWith promise of a serviceworker fetch event took to settle. Image: https://imgur.com/a/Mqe15Ab Explainer: https://docs.google.com/document/d/1L-dhKWYoVECdoqVQ0hOKqtyWbk5LtluFWbZE8PJZtnU/edit Test: https://chromium-review.googlesource.com/c/chromium/src/+/2178311 Goes alongside PR: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2142449 Bug: 1066579 Change-Id: Iefbd18c5442d70dc475a2fd1cba3080e52f3cfb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142145Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770478}
-
Jesse Schettler authored
Bug: chromium:1067677 Change-Id: Iedebea4ad7de64b3ece60388f706b40708a3423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208075Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#770477}
-
Eric Lawrence authored
Starting around Chrome 76, the browser started respecting CSP headers on PDF file responses. This broke display of PDFs because the MimeHandlerViewAttachHelper::OverrideBodyForInterceptedResponse function that generates a wrapper page around the PDF plugin embed uses inline styles to size the embed, and these inline styles may be forbidden by the server's CSP. To correct that, strip Content-Security-Policy headers from PDF responses, because the PDF plugin does not use the headers anyway. Bug: 271452 Change-Id: I58b2763e34b7d614e88059bf92b16e9cdf2d5fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176415Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3bcb7bb01b82..34eee0d9fc85 2020-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 949f1e45f1dc to 78f7e8640f14 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I5264a2d0db2f9010fcb44a34f619e07ec0d016ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209889Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1589932652-c0550eeb95369b6f28da16c4eb02523a268a6494.profdata to chrome-win32-master-1589947115-d59e956e9f0cd8de69b108c77019d85951a98a26.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I850ca2e54bf6015bed534ffa38385b91e57ff5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210112Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1abcef745172bda5522999f105c7bfa304c8558f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210050Reviewed-by:
-
Darren Shen authored
This reverts commit 6cba64bc. Reason for revert: Seems to be causing crash failures in NotificationMenuViewTest tests: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18756 CL landed in a previous build https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18755 but the error was obscured by a different compile failure. This CL looked most suspect, so apologies if this was a bad revert. Original change's description: > Removed use of set_owned_by_client(). > > NotificationMenuView > > Bug: 1044687 > Change-Id: Ie7b3c57bef5d55d306e5f083d709cc29a8bb0444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209493 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770303} TBR=kylixrd@chromium.org,newcomer@chromium.org Change-Id: I8b7c4193038da689a99ba77369b33ee1e3e65ef0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210170Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#770472}
-
Reilly Grant authored
Calling CoCreateInstance() in EnumerateDirectShowDevices() can cause DLLs to be loaded. Since this method is called on a background thread this can cause a priority inversion of the main thread is also trying to acquire the dynamic loader lock. This annotation temporarily boosts the priority of the thread to allow it to complete loading the library and drop the lock. Noticed in crash/8c42f60e46efa272. Bug: 973868 Change-Id: I4eef876860d712e639bcf404553b8d8d06b5864c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208649 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#770471}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e4319023a04..13322c0999a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:996088 Tbr: shend@google.com Change-Id: Ib1de538d504908ed04252479d8e943678f937a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770470}
-
Alex Gough authored
Updates DEPS to reflect change in location of use of buildflag. Does not change behavior. See linked bug for rationale. Tests: browser_tests ChromeSpeechRecognitionTest.* Bug: 1065087 Change-Id: If2f1c9188c0af4af67c7ac8c65585b221865b772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206918 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Evan Liu <evliu@google.com> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#770469}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589932652-c24183484ae9e96438156fa060cf45897a80967e.profdata to chrome-mac-master-1589947115-56f4011405e4eeb70dd293d8da98a761636dbc3e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If1ed52d6192bff6cb9153ac7222d2377043507e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210053Reviewed-by:
-
Jesse Schettler authored
Add BluetoothResult to cros_healthd_probe.mojom to keep it in sync with the Chrome OS copy. Bug: chromium:1067677 Change-Id: I84e42178c5c8c824d6bd1a252a3b91be805dad6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199731Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#770467}
-
Yoshifumi Inoue authored
This patch changes "delete-br-013.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ie11cb4972e96e5025e38f5c6f71461a6ec6e2e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208805 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit ba055028. Reason for revert: Relanding with an additional TestExpectations entry. Original change's description: > Revert "Reorganize COEP + reporting tests" > > This reverts commit a1ca8d21. > > Reason for revert: reporting-navigation.https.html fails on Linux > Bug: 1084593 > > Original change's description: > > Reorganize COEP + reporting tests > > > > The COEP reporting feature has two observable effects. User agents send > > reports to the network, and web developers can observe reports via > > ReportingObserver. We need to have *some* tests for each way, but we > > don't need to have all the test cases for both ways. > > > > As the ReportingObserver way is faster, easier to debug and less flaky, > > we would like to test more cases with ReportingObserver. This CL moves > > many test cases from reporting.https.html to > > reporting-navigation.https.html and > > reporting-subresource-corp.https.html, and rename reporting.https.html > > to reporting-to-endpoint.https.html. This CL also removes many > > duplicated tests (see reporting-subresource-corp.https.html). > > > > Bug: 1052764 > > Change-Id: I37a567d8cbb6aec79a8426f2f32630c70e4da112 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208154 > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#770058} > > TBR=yhirano@chromium.org,shimazu@chromium.org > > Change-Id: Ibf7ae594edc9950f389fec00ac0e4ede08b946ed > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1052764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208361 > Reviewed-by: sebsg <sebsg@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770138} TBR=yhirano@chromium.org,shimazu@chromium.org,sebsg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1084593, 1052764 Change-Id: Ib6ecf48c10b7d68c7b3d11199c2157417cabe337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208169Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#770465}
-
Jinsuk Kim authored
One of the flows destroying Overlay Panel's WebContents was not detaching its ContentView from view hierarchy, therefore caused crashes as it kept receiving UI events and forwarded them to WebContents already destroyed. This CL makes sure the ContentView is properly removed in such case. Bug: 915953 Change-Id: I1310f159ca302718c94e2c309a6e190927646933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208580 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770464}
-
Julian Watson authored
Bug: 1049453 Change-Id: I7c639bb0c4c517216b2b76551b578fd2420e13bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206866 Auto-Submit: Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770463}
-
Peng Huang authored
> vulkan: enable the possibility of using vulkan c++ binding > > The vulkan.hpp is included in the upstream Khronos vulkan headers > package. It is a vulkan c++ binding generated from vulkan registry. > It is implemented with c++ template in a single header file. > > This change updates gpu::VulkanFunctionPointers to make it compatible > with vulkan.hpp, and adds vulkan_cxx.h which setups several necessary > macros before including <vulkan/vulkan.hpp>. So any code wants to use > vulkan c++ binding just needs to include vulkan_cxx.h. > > This change also adds a test for the vulkan c++ binding. > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198140 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770361} > > Bug: None TBR=vasilyt@chromium.org Change-Id: I7cc5d85130ea5fa852b8a9e6b87c59fb30396075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209647Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770462}
-
