- 30 Sep, 2020 40 commits
-
-
Tomasz Wiszkowski authored
This event will allow the parent component to take an action when the user focuses the TileView using keyboard. Bug: 1106109 Change-Id: If34debc647637f0834db2bd34804c8e37a74320b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437708Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#812111}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f9788a96. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ic77dbcbf33c50d91d378ebe467860d0c810dd1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440236Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812110}
-
Fredrik Söderqvist authored
This should bring us closer to how other elements are handled. The filter bounds are now applied when needed (if needed). The primary change is removing SVGLayoutSupport::AdjustVisualRectWithResources calls in the various layout paths. This restores the tighter visual rects that was previously computed. Since the visual rects propagated during layout no longer includes clipping and masking, outlines are no longer clipped for containers. Since we now no longer need to do any reading of other LayoutObject's bounds during layout, it should be possible to clean up quite a bit of hairy code in future CLs. Bug: 109224, 1028061, 1131068, 1131105 Change-Id: I502d72a5bfb3aa9149306b6c4143c69781709792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050382Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#812109}
-
Matt Menke authored
This is a core net/ performance metric, and is needed to help investigate any significant change time URLRequests take to complete. Bug: 1088996 Change-Id: Ide5f2c0f3f592ce67ad1563fcacbea64fc8b5f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424256Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#812108}
-
Ian Kilpatrick authored
The creates a new struct "RecalcLayoutOverflowResult" as the result of RecalcLayoutOverflow. There are two booleans: - layout_overflow_changed indicating if the layout-overflow changed in such a way that the parent should recalculate *it's* layout-overflow. - rebuild_fragment_tree if the fragment for the parent should be regenerated (but not necessarily recalculate the layout-overflow). There should be no behaviour change. Bug: 1066616 Change-Id: Ib7bd754b710703c8f8257a43f1add405e855bd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429970 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#812107}
-
manukh authored
OmniboxEditModel::OnPopupDataChanged params include: - |text| representing either the temporary or suffix autocompletion texts. - |is_temporary_text| to distinguish the 2 cases. - |prefix_autocompletion| The overloaded use of |text| is confusing, especially now that autocompletion consists of more than 1 string field (prefix_autocompletion and we expect to add split_autocompletion in the future). This CL replaces |text| with |temporary_text| and |inline_autocompletion|. Bug: 1062446 Change-Id: I5aa4535db1f9d4a85dced041f920d2f90afe0bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427025 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812106}
-
Ramin Halavati authored
For better measurement of Incognito usage, "Profile.Incognito.MainFrameNavigationsPerSession" metric is added to record the activity length of Incognito sessions. This metric will be added for iOS in a different CL. Bug: 966747 Change-Id: I4d163f0ec603916949972d9dc290e4247a1125e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421821 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#812105}
-
Dan Harrington authored
* ntp_snippets code in src/chrome is obsolete, since src/chrome is not used in iOS. Much of the removal was from there. * Changed code to assume that the InterestFeedContentSuggestions feature is enabled (and therefore zine is not). Bug: 1069183, 678590 Change-Id: I3b31f85a26d8ac8ff3807eee392c1994a91d0f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414997 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812104}
-
Jeroen Dhollander authored
This means the prototype now works, and the bloom response can be seen in the Assistant UI (as a very unreadable JSON string). I changed the |BloomInteractionObserver| into a |BloomUiDelegate|, as that seemed a better approach to keep the Bloom code independent of ash. Bug: b/165356952 Test: Manually deployed Change-Id: I4e1fd1acd0644c97b3e5e91131d4e593353b1e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390944 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812103}
-
Chris Hamilton authored
This defines types and utility functions that will be used by the V8ContextTracker implementation. BUG=1085129 Change-Id: I6dec02d26191a60aa3545133bbe826998693a538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427849 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#812102}
-
Andrey Zaytsev authored
Bug: 1132805 Change-Id: I24b988384eb45c315e0d59cd330e27dafb938483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435226 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812101}
-
Aga Wronska authored
This policy allows adding Family Link accounts additionally to accounts listed in DeviceUserAllowlist policy and is dedicated for school use. New policy does not change how other existing device sign-in policies work. Bug: 1126155 Change-Id: I87625f370bafd0a66f1a9c0549a222f8c11e61db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438870Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#812100}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601445309-5e7aa0f006c9e9f4b3780b31870e3f024fdecce6.profdata to chrome-linux-master-1601451302-0fcd721072a85aa7cd1d6b997a82e6798fe72a84.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I35e0df034798cca2e620b848fa8d810a001bb284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440464Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812099}
-
Dylan Cutler authored
The instrumentation of GetIntParameter() was accidentally omitted from http://crrev.com/c/2364953. I also replaced the uses of IdentifiableTokenBuilder.AddToken() to the preferred method, AddValue(), where appropriate in the same file. Bug: 973801 Change-Id: I433e10fec8ad727fa57dbfb8ce5546d9fd96ab6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438750Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#812098}
-
Sadrul Habib Chowdhury authored
Set up a shared memory for the smoothness data, so that the renderer can keep updating the data (which can happen many times every second), without incurring cost of thread-hops from the compositor thread to the main-thread, or IPC costs from the renderer process to the browser process. https://docs.google.com/document/d/1E91V41tssxOhTjujaT7BoJ0A4TNabR7Vgd9k2eg7fMY/edit BUG=1115139 Change-Id: If4fe22035620faed3875f2026558cb5b03e62723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393531 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Ben Kelly authored
This CL clears our list of BlobDataHandle references after starting the put operation. This should reduce how long the references are held alive since we will no longer have to wait for the BarrierCallbackForPutResponse objects to be oilpan collected. Bug: 1133110,1035448 Change-Id: Ibb859da1d1ae31ae4ada588059fe2915058c97a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437911 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812096}
-
chrome://managementTina Wang authored
Reland https://chromium-review.googlesource.com/c/chromium/src/+/2432316 with fix. The third patchset is the reverted cl. The issue is caused because the link navigates to an external page, but the test can't always load a external page, so the trybot fails randomly. Fixed by only checking if the link can be tapped. Change-Id: I932e8976b6b99236003420cd87e21f6c339f2376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436774Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812095}
-
sandromaggi authored
If the state name cannot be resolved from the hardcoded list, use the state value itself. This guarantees a value in state name (if there is a value in state). For addresses created from Desktop, the state field can be free text, it is not guaranteed to map to a known state. The same goes for countries outside of the US, where the state name cannot be resolved in the first place. This also changes the expectation in the unit test, to not block the addition of new fields. Note that we still assert the minimum set of expected fields, essentially blocking the removal of previously available information. Bug: b/169562881 Bug: b/167491545 Change-Id: I1b392e7a7e8a21981d751d6b9ae982de4adfff3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438352 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#812094}
-
Wolfgang Beyer authored
We want to show which frame caused the opening of an additional window in the DevTools frontend. We cannot really use FrameTreeNode's 'opener', since this is reset if the opened window itself does not have access to its opener ('noopener' or COOP). We cannot use 'original_opener' either, because it tracks main frames only. Therefore a new field 'opener_frame_id' is introduced. This is a follow-up to https://crrev.com/c/2309698 Bug: chromium:1107766 Change-Id: Idf24776a234ec029736bb74920d80c8da3c4c98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340976Reviewed-by:Camille Lamy <clamy@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812093}
-
Arthur Eubanks authored
Bug: 1133353 Change-Id: I22eda82761975ec6ae36d28e83a40e3d5c3ef836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438485Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#812092}
-
Mark Mentovai authored
CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: I44846fc87f64808df1bf0baeb107f22c46b46771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439420 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#812091}
-
Caitlin Fischer authored
Added in https://codereview.chromium.org/1128123003 by jianli. Bug: 1126640 Change-Id: Ia2a3f8312942b5b9c638f0023c03949bfa1fcc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424667Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
A new web API called performance.measureMemory is implemented using PerformanceManager. Since web platform tests run in a content_shell, we need to add and enable PerformanceManager there. This CL is based on a patch by Joe Mason. Bug: 1085129 Change-Id: Iefeafbd7a12245d4ca246f3ee28dc3e5292d37e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426587 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#812089}
-
Xida Chen authored
TBR=arthursonzogni@chromium.org NOTRY=true Bug: 1131634 Change-Id: I09bba2e639aa0484fc34313cbc8b6209d496c670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439770 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812088}
-
Jan Wilken Dörrie authored
This change adds a public ResultType alias to base::Callback, specifying the return type of `Run()`. This is analogous to std::function's nested result_type. Bug: 554299 Change-Id: Ie478345b68051b03cd5b064b0833d528d47990b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436536 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#812087}
-
Randy Rossi authored
When a node with scopes_route flag is added, perform a depth first search for a child with names_route flag. If found, that node should receive focus and be spoken. Subsequent updates for a the node should not speak or refocus. When a scopes node is removed, refocus a names node under the last scopes node unless there is none. Refocused nodes after a removed node should not be spoken, only focused. If there is no scopes node found, focus on the first focusable node in the tree. This is used by flutter alert dialogs and drawers that require the user's attention if the screen reader is enabled. Bug: None Test: Local display assistant and unittest Change-Id: I69b0205d47269ec75265ca1af56400cc28faea56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436768Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812086}
-
David Black authored
This will enable the new Assistant timers experience by default which adds system notifications for the entire lifetime of a timer. Bug: b:149570650 Change-Id: Id3f6675bdc020b56d21f1cd7418ed287aa0d979f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439424 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Ali Juma authored
This CL fixes WebStateObserverTest.FailedSslConnection with committed interstitials. This also makes CRWWebControllerTest.SslCertError early-return when committed interstitials are enabled, since it tests behavior that is specific to the old interstitials workflow. Bug: 921916 Change-Id: I6bf4b0ff40ae0f7ee7f0ce91967aa3abc79ffb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438890Reviewed-by:
-
Yann Dago authored
Add the IPolicyStatus2 interface and both PolicyStatusUserClass and PolicyStatusMachineClass classes. Replace usages of the old PolicyStatusClass by PolicyStatusMachineClass Bug: 1119703, 1106637 Change-Id: Ie147e1c2d100fc5273fa9ee641078f96c7b8f91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380735 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812083}
-
Rohit Agarwal authored
The "Close incognito tabs" notification we show in Android also closes the incognito tabs opened in CCT. This CL: 1) Disallows the close incognito notification for tabs opened in incognito CCT. 2) For regular incognito "tabbed" Activity there's no change of behaviour when the user clicks on the notification i.e we will continue to close the incognito tabs opened by the Chrome "tabbed" Activity. 3) From Point 2) clicking on the notification wouldn't affect any incognito CCT tabs. This CL also adds instrumentation tests. Bug: 1131844 Change-Id: Ia375bb61b6f54940c1315c0512921b0407d27aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426433Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#812082}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dbb090f41f9b..fa082bb58ba7 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c6ca885c0b4a to fcb22ecf0f7e (1 revision) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from db992e60cc7a to e2b329a75b6a (1 revision) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44be0942f9a8 to b042f4e70879 (15 revisions) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 2bfd6a752dc6 to c5c6265c026e (3 revisions) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 8fdc21e4078d to 0c0ac2c6c458 (1 revision) 2020-09-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3049a95d to 18cdc317 (353 revisions) 2020-09-30 syoussefi@chromium.org Vulkan: Unresolve depth/stencil MSRTT attachments 2020-09-30 jdarpinian@chromium.org Support EXT_color_buffer_half_float on WebGL 2.0 contexts 2020-09-30 jmadill@chromium.org trigger.py: Add launching of Android tests. 2020-09-29 timvp@google.com Vulkan: Don't modify mReadOnlyDepthStencilMode in syncState() 2020-09-29 m.maiya@samsung.com Add Samsung to ANGLE vendor list 2020-09-29 timvp@google.com Check angle_enable_abseil in Abseil group and config 2020-09-29 jmadill@chromium.org Disable Mock ICD perf tests on Android. 2020-09-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b94db86cf9b3 to 44be0942f9a8 (2 revisions) 2020-09-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 4b07d50cd9a0 to c6ca885c0b4a (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1133459 Tbr: jonahr@google.com Test: Test: CQTest: Test: Manual verification of Skia 'gn gen' on Windows Change-Id: I9a44c78b2447dd28222b3c4f0a4e9e3e1c335ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440455Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1110069, 1130863 Change-Id: I74f43f32819ca55766dec170a017c2340d6a8226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437932 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#812080}
-
Ulan Degenbaev authored
This CL also makes V8DetailedMemoryReporterImplTest more robust by replacing array allocation with a typed array nested in an object. Bug: 1131491 Change-Id: If5fec7cc81aac0f33f068ecff3b928a1ceb7ede2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438372Reviewed-by:
-
Nohemi Fernandez authored
Currently Chrome stores whether it should show a sign-in promo on accounts.google.com in the CHROME_CONNECTED cookie. Once the promo is displayed it no longer requires this information and we should remove the cookie. This will not affect existing functionality since the CHROME_CONNECTED cookie is used for signed-in users and the promo will only be displayed to signed out users. Bug: 1125631 Change-Id: I504974aaebf8e7e71a596342726c5f5df0f189c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440596Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#812078}
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2438385 Bug: chromium:1133675 Change-Id: If6bfcfe09eb588671b7616bce9fd0528ceca1b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439071 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812077}
-
Josh Nohle authored
Background: We enroll with CryptAuth as long as at least one multi-device feature is allowed according to AreAnyMultiDeviceFeaturesAllowed(). Before this CL, this function only checked the "is-allowed" pref for each feature. For enterprise/EDU users, all features should be prohibited by default, so the function should return false and no enrollment should occur. However, the WIP features Phone Hub and Wi-Fi Sync have not yet been hooked up to the admin console, so their is-allowed bits are not false by default for enterprise/EDU users yet. Solution: In this CL, we do not consider a feature "allowed" if its feature flag is disabled. Bug: 1133334 Change-Id: I87e1c3d39ac0edd198329e856e44c6d094448abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436677 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#812076}
-
Yutaka Hirano authored
https://github.com/WICG/web-transport/pull/135 Bug: 1133613 Change-Id: I14911ebe519f7426d7ef4f98138a98629075b3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438081 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#812075}
-
Lukasz Anforowicz authored
Bug: 1128008 Change-Id: Ib98d031b7537caf3ba685d0911fb8b78b3c5be9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432446Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#812074}
-
arthursonzogni authored
From the patch: https://chromium-review.googlesource.com/c/chromium/src/+/2426465 Revert the changes to the file: chrome/android/java/src/org/chromium/.. ../chrome/browser/sync/AndroidSyncSettings.java This caused several tests to fail: ``` ClearBrowsingDataFragmentTest#testDialogAboutOtherFormsOfBrowsingHistory IdentityDiscControllerTest#testIdentityDiscWithSignInState IdentityDiscControllerTest#testIdentityDiscWithSwitchToIncognito RecentTabsPageTest#testPersonalizedSigninPromoInRecentTabsPage RecentTabsPageTest#testPersonalizedSigninPromoInRecentTabsPage RecentTabsPageTest#testPersonalizedSyncPromoInRecentTabsPage RecentTabsPageTest#testPersonalizedSyncPromoInRecentTabsPage SigninSignoutIntegrationTest#testSignIn SigninSignoutIntegrationTest#testSignOut SigninSignoutIntegrationTest#testSignOutNonManagedAccountWithDataW[..] SigninSignoutIntegrationTest#testSignOutNonManagedAccountWithoutWi[..] SigninSignoutIntegrationTest#testSignOutNonManagedAccountWithoutWi[..] SyncErrorCardPreferenceTest#testSyncErrorCardForAuthError__NightMo[..] ... ``` With the error: org.chromium.components.strictmode.StrictModePolicyViolation: DISK_READ from AndroidSyncSettings.setChromeSyncEnabled TBR=jkrcal@chromium.org Bug: 1133401 Change-Id: I15ddf7716356655f8480572f807d2e020c555964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438500 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Yi Gu authored
See bug for sample logs. TBR=rhalavati@chromium.org Bug: 1130131 Change-Id: I3b83ce92f6c9c2a8c1a7401c392bd4d76c56f720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438735Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
-
