- 30 Jul, 2019 40 commits
-
-
proberge authored
This allows better tracking of crashes coming from test environments. Change-Id: Ic9bdc9bced430a420cd3c984a4b186e29f4fd9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726955Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#682474}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95d8ceb955cc..6e86c1b05eee git log 95d8ceb955cc..6e86c1b05eee --date=short --no-merges --format='%ad %ae %s' 2019-07-30 michaelludwig@google.com Remove bad SK_API tag from internal class 2019-07-30 reed@google.com move all picture version crap into single header 2019-07-30 brianosman@google.com Explicitly fetch "main" in the runtime color filter 2019-07-30 mtklein@google.com test a (the) zero-arg program 2019-07-30 jvanverth@google.com Revert "Use shared mode for Metal texture upload buffers." 2019-07-30 bsalomon@google.com Always use sized internal formats when creating GL render buffers. 2019-07-30 egdaniel@google.com Dump GrGLCaps format table in json dump. 2019-07-30 mtklein@google.com add vmovdqa(ymm,ymm) 2019-07-30 michaelludwig@google.com Hide SkImageFilter subclasses in CPP files Created with: gclient setdep -r src/third_party/skia@6e86c1b05eee The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I5c1d011c88ec0fb7daa72ecd3c1a5fb1cd8571e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682473}
-
Shimi Zhang authored
- android.view.View#getRootWindowInsets requires API level 23 - android.view.WindowInsets requires API level 20 - android.view.View#setOnApplyWindowInsetsListener requires API level 20 I am adding @TargetApi(Build.VERSION_CODES.O) for these places, assuming that this file is added for Android Q and above, but our lint tool doesn't recognize Build.VERSION_CODES higher than O... Bug: None Change-Id: Ib276a793706a3e1bf2231a6aa451d4b1a2ff7180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725212Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#682472}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4402540. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I113dd7db935259751011d3b6dfd9ef53616cedec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726794Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682471}
-
Koji Ishii authored
This patch fixes hit-testing list markers to include when the marker content was hit. In legacy, markers are LayoutBox with special painters, but LayoutNG creates an anonymous box with an anonymous text or an anonymous image, and that hit-testing may find the content inside the marker. This patch checks parent of the object. Bug: 988414 Change-Id: Ifff61452a791e88f45d44bc45f00ead31070df0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726571Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682470}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I4b6acbe475ce6338cfc4510820a2a2703cc34416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700941Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#682469}
-
Rose Garcia authored
Added automated testing to text navigation manager test file. This tests the selection functions by themselves and their interaction with the navigation methods. These tests are currently disabled due to flakiness. Test: Use --gtest_filter="*SwitchAccessTextNavigationManagerTest*" --gtest_also_run_disabled_tests to run these tests. Bug: 982004 Change-Id: I21331d7173643a0a4c78323c7068da34b2aeb8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717568Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Rose Garcia <rosalindag@google.com> Cr-Commit-Position: refs/heads/master@{#682468}
-
Matthew Cary authored
This change the PPB_Buffer_Impl and associated buffer alloc to use base::UnsafeSharedMemoryRegion instead of the legacy SharedMemoryHandle. The affected IPCs are PpapiHostMsg_PPBBuffer_Create and PpapiPluginMsg_VideoCapture_OnDeviceInfo. Bug: 795291 Change-Id: Ia07e2d2e8c0eea43b898de6f8b33e706226c87b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724084Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#682467}
-
Kent Tamura authored
Now we have eslint 5.16.0 and babel-eslint 10.0.2 in third_party/node/node_modules. This CL also resolves existing eslint errors. Bug: 976575 Change-Id: Ifea782746f2ba9ce0a27c5bd5b76d2744f0737ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722270Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#682466}
-
Patrick Monette authored
Bug: 986926 Change-Id: I5e6c0880162a0f064fe0104d9ea4cc6a8c0c3d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715667 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#682465}
-
Bo Liu authored
where appropriate. GpuServiceWebView is split out of DeferredGpuCommandService to handle binding initialization and holding global GPU objects. Most call sites should now be using GpuServiceWebView directly instead of going through DeferredGpuCommandService. Bug: 987265 Change-Id: I1eb31a9f142d32bc2a4596a077c2bb2832d87891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724500Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682464}
-
Lei Zhang authored
Reduce the size of pdfium_engine.cc by moving a chunk of code into pdfium_font_linux.cc. Fix a couple of comments and make a small tweak along the way. Change-Id: I503ec6fbf6ebb312bcbd23c9f575ad72c95900d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725332Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#682463}
-
Glen Robertson authored
Bug: 931032 Change-Id: I2dfc5ee4e865b7ee1f71f2414ca6a317b6417067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716002 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#682462}
-
George Steel authored
Bug: 981900 Change-Id: I67cce1c95a32bc4f09bdd3dcc9e914ac0c36f4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719325 Auto-Submit: George Steel <gtsteel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682461}
-
Antonio Gomes authored
This is a preliminary step to Onion souping //content/renderer/media/video_capture. Given that it needed its own adaptations on unrelated code, it was decided to upload a CL of its own. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I5f0465e0747296980b072a68fe6070ccb0381aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718467 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#682460}
-
Raymond Toy authored
This test should not be flaky anymore now that we're sorting tracks by id, as required by the spec and as exposed by the test. Therefore, remove from TestExpectations. Bug: 983790 Test: mediastreamaudiosourcenode-routing.html Change-Id: I76733a7b5d60757bfca066b5eab0a62c6f90babd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726275Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#682459}
-
Steven Bennetts authored
CrosNetworkConfigTestHelper was intended as a convenience class for tests that require specific network configuration setup. It relies on running the message loop to ensure complete setup before tests run. For ShellBrowserMainParts, we just need a CorsNetworkConfig instance. The easiest way to provide this is to initialize the fake shill clients and NetworkHandler, then create an owned CrosNetworkConfig instance, without the additional complexity in the test helper. Bug: 980951 Change-Id: I4b4a72ec7258f5010e0e24750e2f37f6bd884138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726932 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#682458}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e858d1fb244d..12bc1c4dae87 git log e858d1fb244d..12bc1c4dae87 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 tsepez@chromium.org Use RetainableTreeNode for LayoutItems. 2019-07-30 vmiklos@collabora.co.uk Add FPDFPageObj_GetClipPath() API Created with: gclient setdep -r src/third_party/pdfium@12bc1c4dae87 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I2ecd3d39dcd0bca7bf9dd4e67e09da04cfee8a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726902Reviewed-by:
-
Luum Habtemariam authored
Mostly focused on some cups_util cleanups and expanded testing suite. Also the sequencing model for the main service handler, landing in following CL, has changed, forcing the internal managers to be both created and accessed from a sequenced context. This change updates their sequence_checkers to reflect that. Bug: chromium:945409 Test: updated tests pass Change-Id: I6f9b987a56ec18d07f907035476c4e2549fe66f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721850Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#682456}
-
Ken Rockot authored
Removes all dependences from patch service onto Service Manager in favor of the simplified service model and direct mojom interface acquisition. This CL mirrors what was done for the Unzipper service, providing a Content library in components/services/patch for launching a sandboxed process, and an in-process helper for tests and iOS. Bug: 977637 Change-Id: I54f3339551a374538902d94a6051f78c3778c08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721463Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682455}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b361d1e1281..019109290b69 git log 3b361d1e1281..019109290b69 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 mmortensen@google.com Refactor service/lib to use artifacts.BundleImageZip Created with: gclient setdep -r src/third_party/chromite@019109290b69 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I87a9059054152e0e2b86fcd71975ce61584a98be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727143Reviewed-by:
-
Rose Garcia authored
Adding the buttons and messages for the Switch Access cut, copy, and paste functionality. This includes adding the image files for the icons, added strings and translation screenshots, and adding the buttons into the menu manager so they appear in the menu. Bug: 982004 Change-Id: I35e9b3b3dfe48b1730c23317115ee96be89141bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719292Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cde7deb536fa..b63730a701a4 Created with: gclient setdep -r src-internal@b63730a701a4 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I2c32cf87f00ace93476ce15604192e0af99b07ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727250Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682452}
-
Luum Habtemariam authored
We no longer validate specific attribute groupings within operations. Instead we validate at the per-attribute level only, confirming the same information as before, and leaving any higher-logic validating to CUPS. Bug: chromium:945409 Test: manually confirmed valid attribute/opcode set Change-Id: I8c2541a8b7a1957239c2468526b75b2a77450646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704696Reviewed-by:
-
Justin Cohen authored
Avoid a namespace conflict with the CFNetwork framework. Change-Id: If596cfb14d118fc7bc08bf2ae732c6e347ab049e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724835 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#682450}
-
Klaus Weidner authored
This metric was intended to help identify potential issues in case the render path selection logic wasn't working as intended, for example a hypothetical Andoid O device that's expected to support AHardwareBuffer but where this wasn't working. So far, there haven't been reports of such issues, hence retiring the metric. Bug: 988691 Change-Id: I92d001fd17b2c5ef4d8a650be636ac7aecb4cb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725094 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#682449}
-
Guido Urdaneta authored
The MediaDeviceListener interface is no longer exposed by the renderer process. Long ago the approach for this interface was changed so that no interface is explicitly exposed. Bug: 987582 Change-Id: I429ce4b259c5a5c97c1bb08c16e0607da63acb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715077Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#682448}
-
Owen Min authored
ReportingScheduler now call real report generator and report uploader. Reporting will stop if we can't generate any report or report uploading returns a persistent error. There will be no future reports until Chrome relaunch or pref change notification is received. Bug: 956237 Change-Id: If19bb773ab0b29d810169c9454991e4947e4249e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721629 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#682447}
-
Charlie Andrews authored
There are existing POSIX implementations for these methods in stack_sampler_posix.cc. We now use stack_sampler_android.cc on Android and stack_sampler_posix.cc on all other POSIX platforms. Note that there's an existing StackSamplerAndroid that exists in the tracing namespace. However, that implementation is only used for the "cpu_profiler" tracing category, whereas this implementation will be used for stack sampled metrics. Once this new Android profiler is sufficiently complete, it will also be used for tracing. This stack_sampler_android.cc defers to StackSamplerImpl for its core logic (also used by the Windows and Mac sampling profiler implementations), whereas tracing's stack_sampler_android doesn't use StackSamplerImpl and implements its own core logic. R=wittman@chromium.org,gab@chromium.org Bug: 988574 Change-Id: Ia1f20a22ac1421ff02d4beecff4beb6b7a0e065f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727230Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#682446}
-
danakj authored
Without using this, the Platform object is not replaced when the test class shuts down. This makes the next test to run have a Platform pointer to a deleted object, and causes a crash if any future tests in the shard will try to use the Platform. R=avi@chromium.org, pdr@chromium.org Bug: 419087, 745091 Change-Id: I09145e6a6a8ad1b0b1f9d0d77f04dc147a90972a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726730Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#682445}
-
Kyle Milka authored
Remove the ability for a selected tile to be clicked again and deselected. When the picker is opened pre-select the tile corresponding to the current page background. http://go/scrcast/NjMxOTc2MzM0MzAxNTkzNnw1MTAyN2QxOC1iYg Bug: 984353 Change-Id: I02081460e1bdc2b7679a704b01a6e91ca531a939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719809Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#682444}
-
Andrei Polushin authored
When there are multiple switches having the same key within the argv array, CommandLine constructor only puts one of them within the parsed-out switches map. On the other hand, CommandLine::RemoveSwitch removes a switch from the switches map. It should also drop all the switches having the same key from the argv array. BUG=957138 TEST=base_unittests --gtest_filter="CommandLineTest.*" Change-Id: Ia4cf08bc497d4d53e0213879df71f85d945a4fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724079 Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Reviewed-by:
-
Ryan Sleevi authored
These three files were omitted from the move due to an out-of-date branch. Finish moving them so that the directory goes away. Bug: 987648 Change-Id: Ib4fb890d01dd9ad0ed5a85e68c0bfc6988394db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727089 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#682442}
-
Sean Gilhuly authored
Following a recent roll of the macOS SDK to 10.14, the tests FaceDetectionImplMacTest.ScanOneFace/3 and /4 are now detecting four faces in an image of the four Beatles, where they were previously detecting three. Update the test expectations if the macOS version is at least 10.14, otherwise use the old expectations. Bug: 988495 Change-Id: I3e5fc16d6f0639ad1fb86dae7189c6125e95f7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726309Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#682441}
-
Daniel Cheng authored
This reverts commit fb0f9e39. Reason for revert: breaks rendering on https://svelte.dev/tutorial/basics Original change's description: > location.hash = '' should always result in an empty fragment, not no-fragment > > So far in |setHash|, old fragment identifier and new fragment identifier are > compared ignoring nullity. > > When fragment has never been set, |old_fragment_identifier| is null. > In this situation, |location.hash = ''| is called, > |new_fragment_identifier| is not null empty value. > |EqualIgnoringNullity| treats these as the same, |setHash| does nothing. > > So, this patch compare old and new fragment by == operator > not |EqualIgnoringNullity|. > > Bug: 615300 > Change-Id: Id509bc5066eeee83236ecb4ee816ecb90540a260 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647298 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670795} TBR=dcheng@chromium.org,japhet@chromium.org,bluewhale.marc@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 615300 Change-Id: I6e47d0d1711b197c6e8e35af7dc43e67a6cb4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726953Reviewed-by:
-
Brandon Goddard authored
This change adds the headers for datagrids into the first filler row, which is empty, so that the column header information can be available to screen readers when navigating the datagrid. This data was previously unavailable since dataGrid headers are in a separate table from the data table. Before: https://imgur.com/aenXMyL After: https://imgur.com/XZliDFH Bug: 963183 Change-Id: I7ba1e47e26d821aad9da19b802c48d781a680532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663368 Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682439}
-
Chris Sharp authored
Change-Id: I71975e2b88bf5178febd03cc079fb549814b8091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727209 Commit-Queue: Chris Sharp <csharp@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Auto-Submit: Chris Sharp <csharp@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#682438}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d5acde64a3a5..6ce7935230e8 git log d5acde64a3a5..6ce7935230e8 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 treehugger-gerrit@google.com Merge "traced: Send empty OnTraceData response if tracing not started" Created with: gclient setdep -r src/third_party/perfetto@6ce7935230e8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ifc4696eef53eb546d992387e16865614b7f41034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726811Reviewed-by:
-
Gabriel Charette authored
This will make it possible to define a default move-assign/construct on classes that use a THREAD/SEQUENCE_CHECKER.. e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1693302 R=fdoray@chromium.org Bug: 946657 Change-Id: Ie2b40984b664fa1dcdcdd093ab546625db685430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696845 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#682436}
-
Henrik Grunell authored
Code using it was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1697624. Bug: 879133, 975502 Change-Id: I92c26ace2aa5b0f6c60982e8c7c2ee1bd34f4946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724681 Auto-Submit: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
-
