- 23 Oct, 2019 40 commits
-
-
deleplace authored
After exiting a profile having several windows, reopening the profile will now restore all of its browser windows instead of only one. Bug: 912852 Change-Id: I7267a3b4b4247263ac4fa24e9ff0b61d63994862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1367669 Commit-Queue: Valentin Deleplace <deleplace@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#708582}
-
Henrik Boström authored
Unblocks https://webrtc-review.googlesource.com/c/src/+/157444 which introduces an overload of SetLocalDescription(). Bug: chromium:980885 Change-Id: I9947240e9449cd39067361ab4ea3d2be54aebe30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871565Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708581}
-
Gauthier Ambard authored
This CL enables the feature by default. It also runs directly the closure instead of posting it to have the sequence_checker validated. It also removes the observation of the browsing data removal in the WebController. This is because disabling the WebUsage is supposed to be tied to the spinner displayed on browser. We should find a way of synchronizing both of them. Bug: 981375 Change-Id: Iac47974e0d34f6977b2879dc00cd049e3950e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847308 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#708580}
-
Torne (Richard Coles) authored
During WebView initialization we wrap the application context with ResourcesContextWrapperFactory before storing it in ContextUtils, but the original unwrapped context is still stored in a local variable of the init function. There isn't a bug here at present because the local is never used again (the later uses all call ContextUtils to get the wrapped one) but to avoid anyone introducing one in future, we can just update the local variable. This also means the later uses in the function can now just use the local which is less verbose than calling ContextUtils.getApplicationContext() repeatedly. Change-Id: I5e74c8e16283820fa670fad50812ec859071e5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862661Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708579}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6dc3a51e. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 707870e6 "CSS: WPT tests property values are supported." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ib0b9b15a1a40f8d74490cb6fdbd8514b332751b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875634Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708578}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ed680bea92a2..9c790bc02512 git log ed680bea92a2..9c790bc02512 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 ilkos@google.com Merge "Discard null oom scores for the score breakdown" Created with: gclient setdep -r src/third_party/perfetto@9c790bc02512 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I921936da0c18fafa88b179a728eb1b8302368a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876069Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708577}
-
Rune Lillesveen authored
In the presence of ::-webkit-scrollbar rules, author styling is applied to scrollbars, but only if they actually contain declarations. Before introducing lazy parsing of declaration blocks, we would not consider empty style rules for matching. With lazy parsing, we do not necessarily know if the rule is empty before we perform the actual parsing. That caused a discrepancy between sheets from <style> elements and external stylesheets for empty scrollbar rules because <style> element sheets do not do lazy parsing of declaration blocks. To make this consistent, check if a matched style rule is empty before we mark the ComputedStyle as having pseudo element style. Bug: 897100 Change-Id: I8b808271ca322f42b5ae5e5627a5d17a81658885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874467Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#708576}
-
Rune Lillesveen authored
https://drafts.css-houdini.org/css-properties-values-api/#extensions-to-css-rule-interface Bug: 1008886 Change-Id: Ie587ec75864b856b2c020ba28ce209718c772c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875256Reviewed-by:
-
Vasilii Sukhanov authored
There was a code that does it. However, it regressed at some point. In https://chromium-review.googlesource.com/c/chromium/src/+/1638126/4/ui/views/controls/editable_combobox/editable_combobox.cc#273 it was suggested to compare event->flags() == event->changed_button_flags(). It doesn't work anymore because changed_button_flags is EF_LEFT_MOUSE_BUTTON and flags is EF_LEFT_MOUSE_BUTTON | EF_NUM_LOCK_ON. Bug: 1016289 Change-Id: I463cdc5007161cf6a909c41bf8a96fd01ac841f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872578Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708574}
-
Jan Scheffler authored
This patch fixes the read-cached-response web_test to work with the latest protocol version. Fixed: chromium:778745 Change-Id: Ie91473bd7d04c0cf44687a817b0222cb44b5cc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875730Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#708573}
-
Peter Kasting authored
Bug: 82078 Change-Id: I9b6f6c5fcd9b8a7235033f7d4e48dc70f3274591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870416 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/261fc5197ea8..27c293665e3a git log 261fc5197ea8..27c293665e3a --date=short --no-merges --format='%ad %ae %s' 2019-10-23 hbos@webrtc.org Implement an OperationsChain, to be used by PeerConnection in follow-up. 2019-10-23 asapersson@webrtc.org Add estimatedPlayoutTimestamp to RTCInboundRTPStreamStats. Created with: gclient setdep -r src/third_party/webrtc@27c293665e3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I285eb5ea5f2bde9c417ca151b7fa0851877b1e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876070Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b307010280b7..a9f11bf14bce git log b307010280b7..a9f11bf14bce --date=short --no-merges --format='%ad %ae %s' 2019-10-23 jmadill@chromium.org GN: Separate out constructor/destructor warnings. 2019-10-23 lehoangq@gmail.com Move Vulkan GlslangWrapper code to a shared location. 2019-10-23 jmadill@chromium.org Vulkan: Roll validation layers. 2019-10-23 jmadill@chromium.org Vulkan: Fix sampler object lifetime. 2019-10-23 jie.a.chen@intel.com Remove forceNonZeroScissor workaround Created with: gclient setdep -r src/third_party/angle@a9f11bf14bce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Idc38de741248dc64cd3e02a83594d04a9f6099c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875372Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9d832da5228b..1f4478ca7839 git log 9d832da5228b..1f4478ca7839 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org clean up more dict iter warnings Created with: gclient setdep -r src/third_party/chromite@1f4478ca7839 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icc75ac29c79dae4f491b6e702f6389cebc8d5a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876067Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fad46eb..c4aff1dc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11bcdb34c82507f1c7cb3f94ebe441df3ee7e180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875643Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708568}
-
Olya Kalitova authored
Changes CrostiniAnsibleManagementService::Observer to reflect only start and finish of container configuration. In all mocks states installation and application are reflected as one - configuring so there is no need to disctint them yet. Also renames functions the way it is clearly reflected what happened so that classes that would implement CrostiniAnsibleManagementService::Observer would have more understandable methods (for example installer). Test: browser_tests --gtest_filter="Crostini*" Bug: 998097 Change-Id: I32ea22c96d8987c25dfc06557596ce43561bfa93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869416Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#708567}
-
Monica Basta authored
Currently we show the profile name as the concatenation of the GAIA name and the profile local name in this format |GAIA given name (local profile name)|. We decided to limit showing the local profile name unless it is necessary. We show the GAIA given name as the profile name except for the following cases: (1) The user has chosen a local profile name on purpose. In this case, it makes sense to make the local profile name visible hence we show the profile name in the format of the concatenation. One exception to that is when the local profile name is equal to the GAIA name. (2) There exist two or more profiles that has the same GAIA name which is causing confusion in identifying the profile. To clear ambiguity, we consider first making custom local profile names(even if it is equal to GAIA name) visible, if they exist. If the ambiguity remains, we show for these profiles the profile name as the concatenation of GAIA name and local profile name. Bug: 1012182 Change-Id: Ib02ee726cf7807d43201ae5991a8e49b92ad1a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872059 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708566}
-
Arthur Hemery authored
NavigationClient is on by default, removing support for FrameNavigationControl in existing test infrastructure. Bug: 784904 Change-Id: Ib6e6c6b10e12ef13014290acc8270c4e94d0fb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821918Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#708565}
-
Hajime Hoshi authored
For consistency, 'disable' should be used instaed of 'disallow' when a frame disables the back-forward cache. Bug: 1004676 Change-Id: I2df77b08fc6a44b3eda7e6ce6e232c17c639fb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871494Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708564}
-
Carlos Caballero authored
Basically ran sed -i '/base\/message_loop\/message_loop.h/d' for a bunch of files that no longer use MessageLoop. Came up with the file list by a combination of greps and trial and error compiles. It is still possible, but unlikely, that I had false positives but due to transitive dependencies the compiles succeed. Given that we will eventually get rid of message_loop.h entirely this should be fine. If any of the optional try jobs fails to build please consider just adding #include "base/message_loop/message_loop.h" to the files that fail to build instead of reverting the entire patch. This patch will be reviewed according to https: //chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes TBR=gab@chromium.org Bug: 891670 Change-Id: If56ad40631b3ce02931149cb754131c6a021d899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829080Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#708563}
-
Miyoung Shin authored
This CL converts AudioInputStream{Ptr, Request} in chrome, components, content, media and services to the new Mojo type, and uses pending_remote<AudioDecoderClient> in resource_provider.mojom and renderer_audio_input_stream_factory.mojom. Bug: 955171 Change-Id: I84dc6af48103eb289bb2db097037f99c17e0119c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864660Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Sean Harrison authored
We want a better understanding of how our users are interacting with the privacy settings on the privacy page. This first cl is just what is on the front card, depending on the results we may add more logging to the secondary and tertiary pages. Bug: 1014143 Change-Id: I8441e5011bd66405d89f1141e0fa8b918e0a2579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800871 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708561}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fccfaf11e1e..ed680bea92a2 git log 9fccfaf11e1e..ed680bea92a2 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 eseckler@google.com processor: Remove a left over TODO Created with: gclient setdep -r src/third_party/perfetto@ed680bea92a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie22ee9ebef5cd5c2bcff784bcdcf8d440702cc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875380Reviewed-by:
-
chrome://help-appPatti authored
Add a new WebUI at chrome://help-app for the new Chrome OS Help App. To enable, run Chrome with --enable-features=HelpAppV2. For now, it shows nothing but a blank page with "Help App" as the page title. Bug: 1012578 Change-Id: I0b3cd92e69497488528a38ad77c84903dd40d7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858546Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708559}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5aa803aa2d84..9d832da5228b git log 5aa803aa2d84..9d832da5228b --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org cros_build_lib: close more open files explicitly Created with: gclient setdep -r src/third_party/chromite@9d832da5228b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8010667c7db80469fdc580f84c1672b952376ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875378Reviewed-by:
-
Michael van Ouwerkerk authored
The launch bug has approval for M78: http://crbug.com/998912 Bug: 971725 Change-Id: I22f68b314fdba53848855357b0b4a46fc3eb26f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871551Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#708557}
-
Andy Paicu authored
Added hkamila@ and andypaicu@ to the PERMISSIONS_OWNERS file and then added said file to OWNERS permissions code. Bug: 1016730 Change-Id: Iadf1b101214044699222fa9bb6151597aeb54dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871600Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708556}
-
Christian Dullweber authored
Tbr: afakhry@chromium.org Bug: 1017110 Change-Id: I3c153b07a4d6c381b7c85684d0e59f09b71712b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875259Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708555}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I161e6f1c035eda84f61f79b01454b80a6bb08861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875377Reviewed-by:
-
Javier Ernesto Flores Robles authored
Change-Id: I2c40a4311ca8609c8a7461c42e9a770b8ebc5a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875255 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708553}
-
Andy Paicu authored
As requested in https://chromium-review.googlesource.com/c/chromium/src/+/1860015 I've added a test to ensure that when adding a quiet permission request, it will be killed by a loud one. Bug: 1014026 Change-Id: Ic966af5752356917d8a47929be67e8e189aeb642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873925 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This test fails on Linux build bots. TBR=avi@chromium.org Bug: 954217, 1017102 Change-Id: I5a96bb2fc33114668e5747b8b0996fe224ef403b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875855Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708551}
-
Robbie McElrath authored
variations::SeedResponse currently stores the seed date as a 'long' representing milliseconds since UNIX epoch, but in C++ that can be a 32 bit type, which results in the timestamp being truncated. This CL changes the type to int64_t. Test: Manually verify the timestamp isn't being converted to 32 bits. Bug: 1010625 Change-Id: I80481e5eecf456d52757f398ceaee0f97644534c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873226Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52f1f671..2fad46eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If8a4d4b4ae31900a5e89eee51fe73fb0599def85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875225Reviewed-by:
-
Andreas Haas authored
We are removing external uses of ArrayBufferContents::DataHandle so that eventually we can remove the whole class and change the implementation of WTF::ArrayBuffers. This CL is an intermediate step on the way which replaces the external use of DataHandle to make a later refactoring of ArrayBufferContents easier. Due to recent changes in V8 it is not necessary anymore to call {AdjustAmountOfExternalAllocatedMemory} for memory of ArrayBuffers. V8 get this information now from ArrayBuffer objects on the heap. R=jsbell@chromium.org Bug: chromium:1008840 Change-Id: I14497d44487eb5185968180b42bfdec6f60c228e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869414 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The tests where failing if the AddPayment flag is enabled. This CL makes sure that they are passing with the flag enabled and disabled. Bug: none Change-Id: Iad1c7c5e625b7e1e1549cd7288c8297310f44e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869001Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708547}
-
Gauthier Ambard authored
Bug: 987646 Change-Id: I5fd6d0828a2c22e613d97d34689f864c809d93a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871598 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Kent Tamura authored
No-Try: true Change-Id: I85ac17b8904034e844f22ba122b7f0c81e475d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875019Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#708545}
-
Christian Dullweber authored
This reverts commit c7d42e29. Reason for revert: Suspected to break AppListClientImplBrowserTest.UninstallApp https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8074 Original change's description: > Use AppService to uninstall apps on Chrome OS. > > BUG=1009248 > > Change-Id: I659067359fbdb5fb430f9dcb60a0dbee1fcf6184 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864496 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708514} TBR=xiyuan@chromium.org,nancylingwang@chromium.org Change-Id: I94e44362796779c94b75e37e6457288aef92ca55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1009248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875093Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0f707697f70a..9fccfaf11e1e git log 0f707697f70a..9fccfaf11e1e --date=short --no-merges --format='%ad %ae %s' 2019-10-23 eseckler@google.com Merge "processor: Move TrackEvent tokenizing & parsing into module" Created with: gclient setdep -r src/third_party/perfetto@9fccfaf11e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib5a2abc7f7104080bcabdd994daa31854b663f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875375Reviewed-by:
-
