- 11 May, 2018 40 commits
- 
- 
Sadrul Habib Chowdhury authoredAdd a speculative fix in SurfaceAggregator::Aggregate() to make sure it doesn't accumulate too many LatencyInfo objects. BUG=834421 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifd41d901050a954279b642cab972ca6ec6d560e2 Reviewed-on: https://chromium-review.googlesource.com/1053793Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557992} 
- 
Nico Weber authoredCurrently, generate_library_loader generates an #include line looking like: #include "out/Debug/gen/library_loaders/libudev1.h" Since this contains the (variable) name of the build dir, these files can't be cached by goma. Instead, rely on the header always being next to the cc file in practice (and add a check enforcing that), and use: #include "libudev1.h" Similarly, use LIBRARY_LOADER_LIBUDEV1_H_DLOPEN instead of LIBRARY_LOADER_OUT_DEBUG_GEN_LIBRARY_LOADERS_LIBUDEV1_H_DLOPEN as guard macro name. No intended behavior change. Bug: none Change-Id: I90dfe365e07ecc7df22d48f7ae05bc525d665dd5 Reviewed-on: https://chromium-review.googlesource.com/1054523Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557991} 
- 
https://webrtc.googlesource.com/src.git/+log/e72ea24d884b..739351d4760f $ git log e72ea24d8..739351d47 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2fe1d778182bed4ef5596876ff48e07f9c1f6756 Reviewed-on: https://chromium-review.googlesource.com/1055471Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557990} 
- 
Ella Ge authoredTurn blink runtime_enable_feature flags to stable; Removes content_feature flags used for finch trial; Makes related histogram as obselete. intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/l5PCVakcOCE Bug: 805650, 625198 Change-Id: I873a77f98670f5f293b20a1b3a4373ace93027db Reviewed-on: https://chromium-review.googlesource.com/978626Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#557989} 
- 
catapult-chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/b6e96e16f364..1d2e7600b0b4 $ git log b6e96e16f..1d2e7600b --date=short --no-merges --format='%ad %ae %s' 2018-05-11 eyaich Adding --smoke_test_mode to telemetry to not repeat stories Created with: roll-dep src/third_party/catapult BUG=chromium:840427 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iee4ae15aea0c7dc2e76c18f19f21cdcff03624c8 Reviewed-on: https://chromium-review.googlesource.com/1055800 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557988} 
- 
Nico Weber authoredThe nacl browser_test failures on Win7 that caused the last revert are fixed. There's a known bug about this regressing binary size (crbug.com/838449), but with in-progress patches binary size will soon be 200 kB smaller and these should all be rolled in by branch point, so let's reland this to find more unknown unknowns. Original change's description: > win: Link with lld instead of MSVC's link.exe by default > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > link.exe, but it's significantly faster and it can also handle LLVM's > internal representation, which will enable us to do link-time > optimization and control-flow integraty checks with Clang. > > While lld is much faster at linking, it doesn't support incremental > links, meaning builds that only touch a few files and re-link a large > executable may become slower. > > This is the first attempt at switching everything over, with the > purpose of gathering data and finding unknown unknowns. It's likely > temporary until something breaks. > > is_win_fastlink is implicitly ignored when using lld, as lld without > fastlink is faster than link.exe with it. > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > link.exe to make sure that configuration keeps working. > > Bug: 792131 Change-Id: I18aba7a66c54c87092a13745f0ca213171ec25db Reviewed-on: https://chromium-review.googlesource.com/1054521 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557987} 
- 
François Beaufort authoredIntent to Experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/xQiDYZEnwaA/MNGbYJnaBwAJ Bug: 806249 Change-Id: I0828e52221100f6b6ae576304650466bfdd79188 Reviewed-on: https://chromium-review.googlesource.com/1047671 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#557986} 
- 
Weiliang Chen authoredFor single tile mask layers |visible_rect| is only used as bool to check for non empty. For tiled mask layers correct |visible_rect| is needed to limit the amount of resource we generated for raster the tiled masks. This bug was discovered when we have a tiled mask layer with big scale and we try to create tiles to covered enlarged space and eventually OOM. Compute |visible_rect| correctly results in breaking the assumption that tiled mask layer's |to_target| is only a scale. This changes the computation in |RenderSurfaceImpl| of how to convert tile quads into tiled mask render pass quads. This CL is aimed to fix release blocking bug and thus has limited scoped. There are two potential follow-ups: check for scale of tiled mask layer, and adjust render surface rect. For scale check: ideally tiled mask layer should be in the same space as the render surface, this should simplify computation when converting from tiled quads to render pass quads. For render surface rect: it does not make sense for render surface to have different size than the mask layer's visible rect. Right now render surfaces are unclipped and bounded by maxium texture size, while tiled mask visible size is clipped. To make these two sizes match there needs more investigation into whether unit tests still make sense, and should be in another CL. R=danakj Bug: 820727 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I62c7c992d99088c1f8cdbe4ffbac520b0a7d1a53 Reviewed-on: https://chromium-review.googlesource.com/1037629 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#557985} 
- 
Andrii Shyshkalov authoredRational: if bad canary is pushed, causing build failures, CQ would false reject ~13% of CLs (and on retry, CL is highly likely to land). How is 13% figure obtained? Monte-carlo simulation of 1M CLs! def simulate_cl(builders=31, canary=0.1, max_retry_total=3): """True means OK, False means CQ falsely rejects CL.""" import random bad = sum(random.random() < canary for _ in xrange(builders)) if bad > max_retry_total: return False still_fail = sum(random.random() < canary for _ in xrange(bad)) return still_fail == 0 def monte_carlo_cq_false_rejection_rate(times=10**6, **kwargs): fp = float(sum(simulate_cl(**kwargs) is False for _ in xrange(times)) * 100.0) / times return '%0.1f%% false rejection rate' % fp monte_carlo_cq_false_rejection_rate(builders=31, canary=0.01, max_retry_total=3) # '0.3% false rejection rate' monte_carlo_cq_false_rejection_rate(builders=31, canary=0.05, max_retry_total=3) # '12.8% false rejection rate' monte_carlo_cq_false_rejection_rate(builders=31, canary=0.10, max_retry_total=3) # '49.5% false rejection rate' R=nodir@chromium.org No-Try: True Change-Id: I04bbdbb50bbeb0e9aea70fd5ca8aa89fd22d3fcf Reviewed-on: https://chromium-review.googlesource.com/1045501Reviewed-by:Nodir Turakulov <nodir@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557984} 
- 
James Cook authoredThe touch HUD mojo app is a new way to support the "Show taps" ash UI feature. Previously it only worked with out-of-process ash ("mash") but we're getting it working with in-process ash ("classic"). This CL adds support for the touch hud app to the ash_shell_with_content executable, which is used by developers to work on ash without building chrome. Introduce --show-taps-app so it can run without turning on ash's built-in touch hud impl. Make the app open its window on startup so it can run without the mash:launchable mojo interface, similar to quick launch. This avoids //mash dependencies. Introduce a constant for "touch_hud_app". TODO: Remove the launchable interface from touch_hud_app entirely Bug: 840380 Test: ash_shell_with_content --show-taps-app opens a window Change-Id: Ief7433e61916025c1dff349142ea9802a7238963 Reviewed-on: https://chromium-review.googlesource.com/1055208Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#557983} 
- 
Devlin Cronin authored[Sheriff] Update crashy test virtual/enable_wasm/external/wpt/wasm/wasm_indexeddb_test.https.html on MSAN Tbr: tmartino@chromium.org No-Try: True Bug: 842262 Change-Id: I92323428b9a035d7789711038454a97d6c8b90ad Reviewed-on: https://chromium-review.googlesource.com/1055847Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557982} 
- 
Nico Weber authoredNo intended behavior change. Bug: none Change-Id: I1191d7dd55108a4ae9fdab19ee299bf6c6c08ec2 Reviewed-on: https://chromium-review.googlesource.com/1055749Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557981} 
- 
Mike Dougherty authoredBug: 817810 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b8847322c6cae9d53421a7778b1852e8a1a0a43 Reviewed-on: https://chromium-review.googlesource.com/1055802 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557980} 
- 
Xiyuan Xia authoredBug: 817995 Change-Id: I305739b830ad9c628f6adc88ca930adccc4bfeea Reviewed-on: https://chromium-review.googlesource.com/1054219Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557979} 
- 
François Beaufort authoredThis makes sure enterpictureinpicture and leavepictureinpicture events are fired when user enters and leaves Picture-in-Picture from native video controls. Bug: 806249 Change-Id: I8d8717ce6fa97c3882913e73d8599cede6ec92dc Reviewed-on: https://chromium-review.googlesource.com/1029951 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#557978} 
- 
jonross authoredThere had ben a series of Mac testing failures tracked by issue 817827, 817830. These have been fixed, so re-enabling the tests. TBR=fsamuel@chromium.org TEST=viz_browser_tests, viz_content_browsertests Bug: 760181 Change-Id: I4df4a3cdb659a4226dcd9b2a3e174bf41e064052 Reviewed-on: https://chromium-review.googlesource.com/1055664Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#557977} 
- 
Christos Froussios authoredThe feature is now fully rolled out. Bug: 838789 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icdd315779899230fe78b7d90a17680736722a2ea Reviewed-on: https://chromium-review.googlesource.com/1047867 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#557976} 
- 
Bence Béky authoredThis change was made possible by https://crrev.com/c/1028984, which left chromium as the only directory in //net/spdy. This change is not git cl formatted, and presubmit checks are skipped (there are pre-existing presubmit errors), because this is only a move. NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I670e6e7204870a78d738b7e2fe18569b6c8f0264 Reviewed-on: https://chromium-review.googlesource.com/1054470Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557975} 
- 
bill.2714 authoredThis CL updates Daum related url to the newest. 'search_url' adds 'w' and 'DA' param to recognize this url is from chrome omnibox. This will be used for handling abuse control, redirect issues and serving extra options for users from chrome omnibox. 'search_url' deletes 'ie' param which no longer valid. The domain for 'suggest_url' has changed and older url no longer valid, updated to the newest. R=pkasting@chromium.org, vasilii@chromium.org Change-Id: Ib60e54b5e29c0d84493174fc43e4c4efb84f0363 Reviewed-on: https://chromium-review.googlesource.com/1025544 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557974} 
- 
mark a. foltz authoredReplaces usages of content::PresentationInfo with blink::mojom::PresentationInfo. There should be no change in behavior. The presentation ID length check in the typemap is moved to PresentationServiceImpl. Presentation IDs are always generated by the browser and a too-long ID is a bug. Bug: 817903 Change-Id: I6518abbab6d8b6f24925f1fb649a150b08221622 Reviewed-on: https://chromium-review.googlesource.com/1026987Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557973} 
- 
Weidong Guo authoredAppListPresenterDelegateHomeLauncherTest.BackgroundOpacity and BackgroundBlur are flaky because IsBackgroundBlurEnabled() saves feature flag in static variable. Changes: Remove static variable. BUG=842027 Change-Id: I26c056ee72bac8490ca8a7b0b2555b90594b4980 Reviewed-on: https://chromium-review.googlesource.com/1055793Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557972} 
- 
Luke Sorenson authoredMade a non-backwards non-forwards compatible change to the component by deploying the shim executable with the component, rather than as part of the CrOS image. Bug: b:78120236 Change-Id: I0e4cf4ab87cebd777549d0c1daaa29187b3b58b2 Reviewed-on: https://chromium-review.googlesource.com/1015703 Commit-Queue: Luke Sorenson <lasoren@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557971} 
- 
Min Qin authoredThis reverts commit 6682345b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Reland "Cancel parallel download request if server doesn't send partial response"" > > This reverts commit e127247e. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Reland "Cancel parallel download request if server doesn't send partial response"" > > > > This reverts commit 05267e5e. > > > > Reason for revert: <INSERT REASONING HERE> > > > > Original change's description: > > > Reland "Cancel parallel download request if server doesn't send partial response" > > > > > > This reverts commit 13077433. > > > > > > Reason for revert: <INSERT REASONING HERE> > > > > > > Original change's description: > > > > Revert "Cancel parallel download request if server doesn't send partial response" > > > > > > > > This reverts commit 189d1033. > > > > > > > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > > > > > > > Original change's description: > > > > > Cancel parallel download request if server doesn't send partial response > > > > > > > > > > If the server doesn't support partial responses, Chrome should cancel > > > > > parallel download requests. > > > > > These requests result in the wrong write offset and makes the file larger > > > > > than the original > > > > > > > > > > BUG=838627 > > > > > > > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > > > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#557252} > > > > > > > > TBR=qinmin@chromium.org,xingliu@chromium.org > > > > > > > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 838627, 841666 > > > > Reviewed-on: https://chromium-review.googlesource.com/1053470 > > > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#557489} > > > > > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > > > > > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 838627, 841666 > > > Reviewed-on: https://chromium-review.googlesource.com/1054887 > > > Reviewed-by: Min Qin <qinmin@chromium.org> > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#557734} > > > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > > > Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49 > > No-Try: true > > Bug: 838627, 841666 > > Reviewed-on: https://chromium-review.googlesource.com/1053729 > > Reviewed-by: Max Morin <maxmorin@chromium.org> > > Commit-Queue: Max Morin <maxmorin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557834} > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org,maxmorin@chromium.org > > Change-Id: I4a0d7eb869a61e38d01424427976121fe7f13384 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838627, 841666 > Reviewed-on: https://chromium-review.googlesource.com/1055710 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557969} TBR=qinmin@chromium.org,xingliu@chromium.org Change-Id: I6081079beaca50c3c9dc0fae53f665c68cd97eda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627, 841666 Reviewed-on: https://chromium-review.googlesource.com/1055482Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557970} 
- 
Min Qin authoredThis reverts commit e127247e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Reland "Cancel parallel download request if server doesn't send partial response"" > > This reverts commit 05267e5e. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reland "Cancel parallel download request if server doesn't send partial response" > > > > This reverts commit 13077433. > > > > Reason for revert: <INSERT REASONING HERE> > > > > Original change's description: > > > Revert "Cancel parallel download request if server doesn't send partial response" > > > > > > This reverts commit 189d1033. > > > > > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > > > > > Original change's description: > > > > Cancel parallel download request if server doesn't send partial response > > > > > > > > If the server doesn't support partial responses, Chrome should cancel > > > > parallel download requests. > > > > These requests result in the wrong write offset and makes the file larger > > > > than the original > > > > > > > > BUG=838627 > > > > > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#557252} > > > > > > TBR=qinmin@chromium.org,xingliu@chromium.org > > > > > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 838627, 841666 > > > Reviewed-on: https://chromium-review.googlesource.com/1053470 > > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#557489} > > > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > > > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 838627, 841666 > > Reviewed-on: https://chromium-review.googlesource.com/1054887 > > Reviewed-by: Min Qin <qinmin@chromium.org> > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557734} > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49 > No-Try: true > Bug: 838627, 841666 > Reviewed-on: https://chromium-review.googlesource.com/1053729 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557834} TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org,maxmorin@chromium.org Change-Id: I4a0d7eb869a61e38d01424427976121fe7f13384 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627, 841666 Reviewed-on: https://chromium-review.googlesource.com/1055710Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557969} 
- 
David Bertoni authoredMove kChromeVoxExtensionId from chrome/common/extensions/ to extensions/common/ so it's available there. The constant will be needed for https://chromium-review.googlesource.com/c/chromium/src/+/993753. Bug: 821858 Change-Id: I5caf0ee476c67c5fea276bcc92f7207a8fe24c18 Reviewed-on: https://chromium-review.googlesource.com/1050733Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#557968} 
- 
Nick Harper authoredThis is a revert of http://crrev.com/1e5757d just for the two files here. Bug: 841685 Change-Id: I4d6b211d45e2b2104b440daa8c8f6715fb6c5ab2 Reviewed-on: https://chromium-review.googlesource.com/1055678Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#557967} 
- 
Emily Stark authoredWhen a certificate error recurs multiple times within a browsing session, we add a special message to the interstitial. This CL adds a Finch-controlled mode where the count of certificate errors is stored in a pref instead of in memory, so that we can trigger the recurrent error message when an error recurs within a certain period of time (even spanning browsing sessions). We might want to roll out this pref mode on certain platforms (like Android) where browsing sessions might be significantly shorter than desktop. Bug: 839969 Change-Id: I04f1af1aa30043821859f4459602627b9ba7af77 Reviewed-on: https://chromium-review.googlesource.com/1053563 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557966} 
- 
https://pdfium.googlesource.com/pdfium.git/+log/5e0b271b6935..ddfa5177021f $ git log 5e0b271b6..ddfa51770 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 tsepez Use more smart pointer types in CPDF_DIBSource. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I384b93f8a78de43c7f16f9ecda2ba3c8eb981255 Reviewed-on: https://chromium-review.googlesource.com/1055671 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557965} 
- 
Tibor Goldschwendt authoredAdds a button to close tab and plumbing to send the close request to Java. Bug: 838937 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I45d6d8c3c66674bc472a17335a6e02195f8a23b8 Reviewed-on: https://chromium-review.googlesource.com/1050794 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557964} 
- 
Johannes Henkel authoredNot all constructors write this field, so defaulting to zero may some day help avoid grief from uninitialized values or undefined behavior. Change-Id: I478ecbc346a78d68721e3731f9cec9aad77919fa Reviewed-on: https://chromium-review.googlesource.com/1054611 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557963} 
- 
Gabriel Charette authoredto encompass in-progress API move to MessageLoopCurrent R=dpranke@chromium.org Bug: 825327 Change-Id: I962ba3c652fa0ca38e69e6bf830d3846b28a3f8f Reviewed-on: https://chromium-review.googlesource.com/1055729Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557962} 
- 
Bailey Forrest authoredBUG=internal b/79494936 TEST=cast_bluetooth_unittests. Manual Change-Id: I8b541dbbb8e9a20d72b5ec940a73827b5dbc51ef Reviewed-on: https://chromium-review.googlesource.com/1053589Reviewed-by: Stephen Lanham <slan@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#557961} 
- 
Varun Khaneja authoredIt is not required anymore since now we make the call to GmsCore in the SBUtilThread now. See: https://crrev.com/i/604955 TODO(vakh): Remove the Finch config. See http://cl/196164835 Bug: 839190 Change-Id: I51b24395e647f4c1063f2e16c28202270464fe8b Reviewed-on: https://chromium-review.googlesource.com/1050804 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#557960} 
- 
Niels Möller authoredSee https://webrtc-review.googlesource.com/74020 Bug: None Change-Id: I9f785c3ea49f744d75cd6d931d95240f1c0abf78 Reviewed-on: https://chromium-review.googlesource.com/1054293Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557959} 
- 
Sahel Sharify authoredShowpress should get forwarded after a GFC followed by Tap down suppression. Bug: 842221 Change-Id: I60beaf3296557ec8c3d3d25b627f272b82114eed Reviewed-on: https://chromium-review.googlesource.com/1055653Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557958} 
- 
https://chromium.googlesource.com/angle/angle.git/+log/8073a9511a1e..586620825ed1 $ git log 8073a9511..586620825 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 geofflang Pass a gl::Context to ShaderImpl methods. 2018-05-07 geofflang GL: Refactor TextureGL to not hold renderer objects. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ie86209d62e2fb9cf8f3e134dcc5532c67f262afe Reviewed-on: https://chromium-review.googlesource.com/1055667Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557957} 
- 
Tommy Martino authoredTests: SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone SitePerProcessHitTestBrowserTest.CreateContextMenuTest SitePerProcessHighDPIHitTestBrowserTest.HitTestWatermark SitePerProcessHitTestBrowserTest.InputEventRouterWheelCoalesceTest Bug: 833380 Change-Id: Ifb7a45569f1be2636dc3f7d79bffa4bfdaf2dce8 TBR=kenrb@chromium.org Change-Id: Ifb7a45569f1be2636dc3f7d79bffa4bfdaf2dce8 Reviewed-on: https://chromium-review.googlesource.com/1055663Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557956} 
- 
Yuly Novikov authoredBug: 839893 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8861024bb7cadc741ca8f1b366a95472d125ed90 Reviewed-on: https://chromium-review.googlesource.com/1055107Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557955} 
- 
Ken Buchanan authoredIntersectionGeometry::ClipToRoot() incorrectly clips elements with position:fixed when the element is in an iframe and root layer scrolling is enabled. This patch corrects the problem by mapping the intersection_rect_ all the way to the out-of-process root viewport. Bug: 840821 Change-Id: Ia418f3da3950b6ed29a0ecd85601c2cd358456fe Reviewed-on: https://chromium-review.googlesource.com/1053840 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#557954} 
- 
Amirhossein Simjour authoredWhen the View is partially outside of the Window, the rectangle bounds should be recalculated with the assumption that the View is started from the edges. This will make sure that Autofill popup shows up on top/bottom of the correct input field, when input fields doesn't fit inside the Window. Bug: 828759 Change-Id: I253fc9febe93e90058f95923a18cdfe5363d2186 Reviewed-on: https://chromium-review.googlesource.com/1044529Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#557953} 
 
-