GitLab

This was added accidentally in the original CDM, not initialized, and
not used. Then in a late CL it's used assuming it's initialized, which
was wrong.

This CL removes |weak_this_| from MojoCdmService to fix the issue.

Bug: 432998
Change-Id: Ifcda68e79c7ca5f2203cad9e77765b7f8c3d1971
Reviewed-on: https://chromium-review.googlesource.com/1255464Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595568}

This CL is the first of 3 for this bug. This CL adds a boolean pref to
the lite page decider which tracks whether or not the user needs to see
a new UI for privacy reasons when this preview is enabled.

The user only needs to be notified if they are an existing DataSaver
user. Non-users will never be notified. Once a notification is
triggered on a page load finish, the decider will never again require
it to be shown.

Bug: 889124
Change-Id: Ice3fc9344bc50a2633e09e011c313a192b742c5f
Reviewed-on: https://chromium-review.googlesource.com/1248182
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595567}

I created a syncable pref in crrev.com/c/1213521 to check if a user has
gone through OOBE before. Now that the server side will conduct the
check so the syncable pref is no longer necessary.

Please see b/114134918 for more details.

Bug: 835029
Change-Id: Iab53007458ecd4f42915571fba96c91b894625a5
Reviewed-on: https://chromium-review.googlesource.com/1252851
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595566}

https://skia.googlesource.com/skia.git/+log/3ad86d0c8bc4..8ef78eae9311


git log 3ad86d0c8bc4..8ef78eae9311 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 halcanary@google.com SkPDF: encode all bitmap images as Type3
2018-10-01 brianosman@google.com Towards removing GrColor4f
2018-10-01 michaelludwig@google.com Add input/output image logging to processor tests
2018-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a78092cb2557..996628a4a1fd (2 commits)
2018-10-01 reed@google.com delete textonpath code -- not used anywhere
2018-10-01 allanmac@google.com SKC group improvements
2018-10-01 halcanary@google.com SkPDF: Device methods setGraphicState and drawFormXObject
2018-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 876760bb27d0..810f3db8264a (1 commits)
2018-10-01 kjlubick@google.com Open non-perf Quadro bots to rack 2


Created with:
  gclient setdep -r src/third_party/skia@8ef78eae9311

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:784662
TBR=mtklein@chromium.org

Change-Id: Ifef165d4c20ddce1c71e32c10613186f301b2724
Reviewed-on: https://chromium-review.googlesource.com/1255504Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595565}

This CL replaces ffmpeg/libvpx video decoders implemented in ClearKeyCdm
with media::FFmpegVideoDecoder and media::VpxVideoDecoder. This removes
duplicate code which is hard to maintain, and make it a lot easier to
support new features like VP9 profile 2, HDR, AV1 etc.

Since media VideoDecoder operations are asynchronous while CDM video
decoder operations are synchronous, we need to do async -> sync
conversion. This is done by running the RunLoop manually after each
VideoDecoder call.

Currently we still have FFmpegCdmAudioDecoder in ClearKeyCdm, which
should also be replaced in the future.

Bug: 169203
Test: Existing tests still pass.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I10808c03b6e802c3e18f3b70cdd0413d5204009c
Reviewed-on: https://chromium-review.googlesource.com/1247228Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595564}

Ctrl+Shift+H to trigger. Requires --enable-viz-hit-test-debug flag and logging level of 1 on hit_test_debug_key_event_observer.

Adds observer to render_widget_host_impl to act on OnInputEventAck.

Example: https://pastebin.com/pcxrZv6A

R=riajiang@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1c9a0867debe5b4aa670a51f85fe24909073374c
Reviewed-on: https://chromium-review.googlesource.com/1226099
Commit-Queue: Alexander Shah <zandershah@google.com>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595563}

This entity manages the blink::mojom::DevToolsAgent pointer exposed
by the renderer, it's process id and frame host for different
DevToolsAgentHostImpl subclasses.

Putting it into a single entity simplifies the lifetime management,
and will also aid with blink::mojom::DevToolsAgentHost
when we'll add one.

Bug: 775132
Change-Id: Ifc8e55995bff2eac813bb694ddc55ed7d0c9400c
Reviewed-on: https://chromium-review.googlesource.com/1247702
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595562}

https://webrtc.googlesource.com/src.git/+log/3ff52ffa22ae..5f45e6651864


git log 3ff52ffa22ae..5f45e6651864 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 ilnik@webrtc.org Fix temporal layers pattern checker for VP8 video
2018-10-01 phensman@webrtc.org Tidy up and increase exception handling in compare_videos
2018-10-01 terelius@webrtc.org Prepare RtcEventLog parser for new wire format.


Created with:
  gclient setdep -r src/third_party/webrtc@5f45e6651864

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If7b1aec511353d46cbad2823ed304b81798c47e4
Reviewed-on: https://chromium-review.googlesource.com/1254684Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595561}

This cl calls stopFling after navigation to make sure that flinging does
not continue after navigation when the new page is using the same renderer.

Bug: 835289
Test: BrowserSideFlingBrowserTest.FlingingStopsAfterNavigation
Change-Id: I9f43689ec375605ab1c3ba38adf1df9d46b3efa5
Reviewed-on: https://chromium-review.googlesource.com/1244374Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595560}

(1) Fixing attached bug
(2) Fixing issue reported by namratakannan@ that system dialog link
should be enabled in an error state on non-Windows platforms
(3) Fixing issue discovered while testing, that setting an invalid
value while fit to page is checked should un-check fit to page, but
not result in the preview regenerating with the last valid value.
Similarly clearing this invalid value should also not result in a
preview regeneration (unless the user blurs the input).

Bug: 889386
Change-Id: I1afaafe1f9a13b6ed00be712ae7966ce37d62222
Reviewed-on: https://chromium-review.googlesource.com/1250161Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595559}

This CL introduces the Blink.ImageDecoders.Jpeg.ColorSpace which tracks
the color space of JPEG images. When the color space is YCbCr, we also
record the chroma subsampling (e.g., 4:2:0).

Bug: 886914
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1d5c9cbc893907c1352fa7c845d58aa9116c4f6a
Reviewed-on: https://chromium-review.googlesource.com/1235214
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595558}

BUG=890947
TBR=huayinz@chromium.org

Change-Id: I4cb9f74c57e016f237ae530c4e68bab525b8ce0d
Reviewed-on: https://chromium-review.googlesource.com/1255593Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595557}

Update windows.json docs for minor language and formatting

Bug: none
Change-Id: Ia22eb397f79adfced7ba807dcb9243702b8a3935
Reviewed-on: https://chromium-review.googlesource.com/1214162Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Gash <dgash@google.com>
Cr-Commit-Position: refs/heads/master@{#595556}

Bug: 888556
Change-Id: Ia330d9eade0513738ae7b9f5f81574a57489b14f
Reviewed-on: https://chromium-review.googlesource.com/1232575
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595555}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe90a1d2dcbe..146eb3bdcf5b


git log fe90a1d2dcbe..146eb3bdcf5b --date=short --no-merges --format='%ad %ae %s'
2018-10-01 stevenperron@google.com Fix erroneous uses of the type manager in copy-prop-arrays. (#1942)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@146eb3bdcf5b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6a9e38ec383018998fcaf1fb75d28e7d3f7070b6
Reviewed-on: https://chromium-review.googlesource.com/1255503Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595554}

This allows Google Docs opened before Select-to-Speak was
enabled to still be read.

Bug: 882968
Change-Id: I723fcab46766983a8fe26477d2e9611e5bde1e9f
Reviewed-on: https://chromium-review.googlesource.com/1250601
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595553}

These tests are now failing on the bots due to the same reason
as other SpokenFeedbackTests.

BUG=889093
TEST=none

Change-Id: I1d3ac92f103e5aaf087fa0cb63ac88ceb5b8f631
Reviewed-on: https://chromium-review.googlesource.com/1252337Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595552}

In some cases we have a gesture on a previous navigation
but the `has_received_user_gesture` flag is not set so
we should also check the `has_received_user_gesture_before_nav`
flag too and allow propagation on the same eTLD+1.

BUG=884777

Change-Id: Iaabf03816bc4638f534321b1e9236bfa41d29938
Reviewed-on: https://chromium-review.googlesource.com/1255150Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595551}

Update browseraction.json docs for minor language and formatting

Bug: none
Change-Id: Id7f5f33bbd4193ed107d2e10da612d32f13a701b
Reviewed-on: https://chromium-review.googlesource.com/1217703
Commit-Queue: David Gash <dgash@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595550}

Bug: 850125
Change-Id: Ia8463b5edf15d2bf94a00ceab6286e8e20fc40ed
Reviewed-on: https://chromium-review.googlesource.com/1252861
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595549}

This is similar to https://crrev.com/c/1178977

Bug: 882513
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie3806648288b1da1f900f3ceb6385bd25a652f38
Reviewed-on: https://chromium-review.googlesource.com/1234320
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595548}

This will guard https://skia-review.googlesource.com/c/skia/+/158344
It introduces a few pixel_test diffs due to the test framework's
processing of images after read-back.

Bug: skia:8382
Change-Id: Id0ca8c4205a5537665610086db348145855dd8c4
Reviewed-on: https://chromium-review.googlesource.com/1255206
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595547}

This patch removes an unused function.

R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib726be4ee83ce3032e1b1d44faac93d11086e879
Reviewed-on: https://chromium-review.googlesource.com/1255463Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595546}

This will prevent keyboard navigation from reaching tiles that are not
visible.
Screencast: https://screencast.googleplex.com/cast/NTQ4MTM0NjE3MjQ1Mjg2NHxkYjlmMjExNy0zOQ

Bug: 889792
Change-Id: Id4c327417d97d9fa0b28f94fd3f98ddf97c4fc1d
Reviewed-on: https://chromium-review.googlesource.com/1252377
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595545}

Change-Id: Ib80fa764ccfddd7f1643448c7d529d3fad2d7aeb
Reviewed-on: https://chromium-review.googlesource.com/1255043Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595544}

Change-Id: I4c70b035c7be332633e5b238c8cd63ac220fef72
Reviewed-on: https://chromium-review.googlesource.com/1254758Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595543}

TwoClientAutofillProfileSyncTest.DeleteAndUpdate can only expect a
deterministic outcome if the server operates with a strong consistency
model.

In order to prove that, we introduce a second test that enables such
mode and is correspondingly more strict about the final outcome (update
should override deletion).

Bug: 870333
Change-Id: Ie4e6f5ebd604c837103237168391ba05595d1b22
Reviewed-on: https://chromium-review.googlesource.com/1249206Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595542}

Was missing from https://chromium-review.googlesource.com/c/chromium/src/+/1221687.

Change-Id: Ia2b53df370ebdcf33fccf1e6ccf080905403d369
Reviewed-on: https://chromium-review.googlesource.com/1255204Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595541}

This CL uses ScopedBlockingCall to mark blocking calls in /chromecast/browser/metrics.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=bcwhite@chromium.org

Bug: 874080
Change-Id: If065cdbaa716f646caa8c4258053a2f4a089bc21
Reviewed-on: https://chromium-review.googlesource.com/1191198
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595540}

Bug: b/115843337
Test: Update test case in unit_tests
Change-Id: I29bb87c4a138e4a14f99f4a28b1be54afeb1dedb
Reviewed-on: https://chromium-review.googlesource.com/1244441
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595539}

Not all GoogleServiceAuthErrors are possible on iOS.
See //ios/chrome/browser/sync/sync_setup_service.cc for comparison.

Bug: 867548
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3eab6314ddb10e9d3f68b018494846b1257226aa
Reviewed-on: https://chromium-review.googlesource.com/1252378Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595538}

This filed is unused and should not be used by embedder.
NavigationManager provides enough methods to get last committed, pending
or visible URLs.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I44bece041b41a784512cb9a738dcd346ba71ddbd
Reviewed-on: https://chromium-review.googlesource.com/1251982Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595537}

BUG=890467

Change-Id: Ie0e7fc413c068a83c9e225c63bc3e3abdebf3120
Reviewed-on: https://chromium-review.googlesource.com/1252636
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595536}

This fixes an issue, where we didn't copy across any shape exclusion
data when inserting a new shelf between two other shelves.

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib26359ab8ac677034ec4e51f2adf1987dadbd91c
Reviewed-on: https://chromium-review.googlesource.com/1255145Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595535}

The bug they were meant to help track down is now fixed, so no
reason to keep them around.

(Previously added in https://chromium-review.googlesource.com/c/chromium/src/+/1224670)

Bug: 882246
Change-Id: I4ada70dd810e07f6fc7ecaaf873fa99d4cf6263b
Reviewed-on: https://chromium-review.googlesource.com/1254464Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595534}

TBR=haraken@chromium.org

Bug: 885297
Change-Id: Ic7a6df89b771062e3327736fec64aff3d124286f
Reviewed-on: https://chromium-review.googlesource.com/1254322Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595533}

We don't want to require the feature to be on when *forcing*
dark mode.

Bug: 850098

Change-Id: Ie6a7f8e7a34e1436136664cf08db2015e69a790e
Reviewed-on: https://chromium-review.googlesource.com/1254862Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595532}

Currently extensions can intercept browser initiated requests using the web
request API which potentially allows them to interfere with browser
functionality in various ways. This CL makes the following changes:
  - All browser initiated non-navigation requests are now hidden from
    extensions.
  - All webui requests are now hidden from extensions. (WebUI shouldn't be
    making network requests anyway).
  - Restructure code in WebRequestPermissions::HideRequest for better
    efficiency.

BUG=884932

Change-Id: I90f37a46e851c04fa949a1427665ecf8286210af
Reviewed-on: https://chromium-review.googlesource.com/1242296
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595531}

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=rohitrao@chromium.org

Bug: 874080
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id297ebc108dc8f8915402602ae12a63e5a3131d0
Reviewed-on: https://chromium-review.googlesource.com/1191186
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595530}

The lifecycle API is the interaction point for Chrome-side application
lifecycle events that the Feed Library cares about for the purposes
of maintaining its internal state.

Dummy files have been added so that compilation succeeds when the
Feed is disabled via buildflag.
This CL also adds a presubmit whitelist for all android/feed/dummy files.

(Google-internal design doc:
http://doc/1NyFLrqEAOoZe7MU2qy7bHYB6Rlp7c6lz22Zqzh-Cbo4)

Bug: 866950
Change-Id: Ie118c991aabb906e88344b5c96ab3b09e77c620f
Reviewed-on: https://chromium-review.googlesource.com/1231992
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595529}