GitLab

Today there are three different ways we hit-test for scrollbars:
1) for frame scrollbars, explicitly call FrameView::scrollbarAtPoint
2) for subframe scrollbars, use HitTestRequest::AllowFrameScrollbars
3) for DIV scrollbars, rely just on the normal HitTestResult

There's apparently no good reason not to be consistent here.  This patch
updates hit-testing to always consider all 3 types of scrollbars, and
removes the AllowFrameScrollbars mode entirely.

This also fixes a bug where we weren't properly hit-testing for
subframe scrollbars on tap, and so not sending mouse events through
to the frame behind (as we do for touch).

I also split ScrollView::scrollbarAtPoint into two variants for window
and view co-ordinates (since we weren't being consistent previously,
passing view co-ordinates as if they were window co-ordinates in
RenderPart::nodeAtPoint.

BUG=410661

Review URL: https://codereview.chromium.org/527263002

git-svn-id: svn://svn.chromium.org/blink/trunk@181935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds the following behavior:
1. If input is a Request object, run these substeps:
  1. If input's used flag is set, throw a TypeError.
  2. Set input's used flag.

Outlined in this change:
https://github.com/whatwg/fetch/commit/a898f9a2941350aa625aa79b24673628ac2b2a8e#diff-1feda49b40370635faef8b655f144f64R2681

Spec:
http://fetch.spec.whatwg.org/#dom-request

BUG=413072

Review URL: https://codereview.chromium.org/562413003

git-svn-id: svn://svn.chromium.org/blink/trunk@181934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch add a new trace event InspectorLayerInvalidationTrackingEvent for invalidation reason tracking. The event tracks when compositor invalidates the whole RenderLayer including its descendents, along with its reason.

BUG=410701

Review URL: https://codereview.chromium.org/565793003

git-svn-id: svn://svn.chromium.org/blink/trunk@181933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebRemoteFrameClient only inherits from WebFrameClient as a temporary measure, separate them.

willCheckAndDispatchMessageEvent() is used to give the embedder a chance to postMessage() externally. Move it from FrameLoaderClient to FrameClient and implement it in RemoteFrame and WebRemoteFrameImpl.

This is step 3 of 3 in getting WebRemoteFrameClient up and running.


BUG=411066

Review URL: https://codereview.chromium.org/543913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/564973002

git-svn-id: svn://svn.chromium.org/blink/trunk@181930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Most of the code wasn't touching |this| or the renderers but
they were not marked as const.

This is needed for another change that I have.

Review URL: https://codereview.chromium.org/566973002

git-svn-id: svn://svn.chromium.org/blink/trunk@181929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jianli@chromium.org
BUG=413454

Review URL: https://codereview.chromium.org/544173005

git-svn-id: svn://svn.chromium.org/blink/trunk@181928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181873

BUG=412516
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/564183002

git-svn-id: svn://svn.chromium.org/blink/trunk@181927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After https://codereview.chromium.org/476113004 CC depends on the
tree structure of scroll/clip layers to determine the viewport size, so
detaching them breaks fullscreen mode.  Switch to the other
approach of changing the scroll layer bounds.

BUG=410452

Review URL: https://codereview.chromium.org/558813003

git-svn-id: svn://svn.chromium.org/blink/trunk@181926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding Vector<char> to a String results in one (or more) temporary
copies of that Vector<char> since Vector isn't a pointer/smart pointer
like the types usually used.

Luckily there are many other ways to solve the problem. With StringBuilder
or using a String.

BUG=389085 (related to, not necessarily fixing it)

Review URL: https://codereview.chromium.org/559103002

git-svn-id: svn://svn.chromium.org/blink/trunk@181925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/565813002

git-svn-id: svn://svn.chromium.org/blink/trunk@181924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

InspectorInstrumentation::didReceiveResourceResponse should  be called whenever it comes clear that request won't be finished normally.

BUG=409739

Review URL: https://codereview.chromium.org/538473002

git-svn-id: svn://svn.chromium.org/blink/trunk@181923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderFlexibleBox has several methods that take pointers to RenderBox instances
but those methods assumes that the objects will never be NULL. We should replace
them by references. This makes the caller code safer.

This is in continuation to the CL https://codereview.chromium.org/555213002/

Review URL: https://codereview.chromium.org/560583003

git-svn-id: svn://svn.chromium.org/blink/trunk@181922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ForceHorriblySlowRectMapping was needed in RenderInline::
clippedOverflowRectForPaintInvalidation() to avoid errors when calling
containingBlock->mapRectToPaintInvalidationBacking() with the provided
paintInvalidationState.

Now call RenderInline's own mapRectToPaintInvalidationBacking() instead
of containingBlock's to make paintInvalidationState applicable and
reduce duplicate code.

BUG=402994
TEST=exsiting tests

Review URL: https://codereview.chromium.org/555933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was fixed in V8 in r23858.

BUG=411196
TBR=loislo, yangguo

Review URL: https://codereview.chromium.org/558333003

git-svn-id: svn://svn.chromium.org/blink/trunk@181920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The async scripts execute in non-deterministic order so I removed their
debug output.  The only thing we really care about testing in the
script-priorities layout test is the request priority which is
determined and logged deterministically at parse time (and still
captured).

BUG=413604

Review URL: https://codereview.chromium.org/555463006

git-svn-id: svn://svn.chromium.org/blink/trunk@181919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
The ensure-valid-python script seems to be unused,
and additionally in webkitpy there is already another
version checker implementation.

BUG=none

Review URL: https://codereview.chromium.org/559993002

git-svn-id: svn://svn.chromium.org/blink/trunk@181918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. 

Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.

Part 1: https://codereview.chromium.org/436843004/
Part 2: https://codereview.chromium.org/422023008
Part 2 Unit Test support: https://codereview.chromium.org/456413002/

BUG=312586

Review URL: https://codereview.chromium.org/438843004

git-svn-id: svn://svn.chromium.org/blink/trunk@181917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method is called a lot during browser launch. Instead of
reconstructing the same AtomicString every time (without even
ConstructFromLiteral) pass in a local static AtomicString.

Review URL: https://codereview.chromium.org/554933003

git-svn-id: svn://svn.chromium.org/blink/trunk@181916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

An empty list of grid line names (represented by "()") does not add anything to
the list of parsed values. That's why trying to concatenate an adjacent list of
grid line names was failing, because we were trying to concatenate a list with
the last parsed CSSValue which was not the expected grid line names list.

BUG=402004

Review URL: https://codereview.chromium.org/569563002

git-svn-id: svn://svn.chromium.org/blink/trunk@181915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-methods/test-004.html
imported/web-platform-tests/shadow-dom/user-interaction/ranges-and-selections/test-001.html
imported/web-platform-tests/shadow-dom/user-interaction/ranges-and-selections/test-002.html

NOTRY=true
BUG=413731
TBR= dpranke@chromium.org, jianli@chromium.org

Review URL: https://codereview.chromium.org/569673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove all the embedded resources from blink and migrate to using grd generated
pak files

BUG=312586

R=haraken@chromium.org, jochen@chromium.org

Part 1: https://codereview.chromium.org/558933002
Part 2: https://codereview.chromium.org/561653002

Review URL: https://codereview.chromium.org/560763002

git-svn-id: svn://svn.chromium.org/blink/trunk@181913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec says that 'vertical-align' has no effect on a grid item.
Currently there are no tests for this, so added a new test case
for verifying the same.

BUG=395788

Review URL: https://codereview.chromium.org/543493004

git-svn-id: svn://svn.chromium.org/blink/trunk@181912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of HTMLSelectElement does not include selected index/indices while saving state (patchset #8 id:160001 of https://codereview.chromium.org/541693003/)

Reason for revert:
Looks like this test crashes consistently on Android Tests (dbg) starting at this build:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/21459


Original issue's description:
> HTMLSelectElement does not include selected index/indices while saving state
> 
> Since index is not part of the FormControl state for select, there is no
> way to restore it to proper index if there are duplicate values. This
> patch includes the index in the FormControl state for select.
> 
> BUG=401506
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181883

TBR=tkent@chromium.org,keishi@chromium.org,sudarshan.p@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=401506

Review URL: https://codereview.chromium.org/566913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't have an ExecutionContext when dealing with 'frame-ancestors'
violations. This patch uses the LocalFrame which we pass into
allowAncestors in order to provide hooks for both PingLoader and
ConsoleMessages.

It also fiddles a bit with the reporting data, as we'd otherwise suggest
that 'about:blank' failed to load (as that's the initial contents of a
frame before we navigate to a document).

BUG=412725

Review URL: https://codereview.chromium.org/553423002

git-svn-id: svn://svn.chromium.org/blink/trunk@181910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/570583002

git-svn-id: svn://svn.chromium.org/blink/trunk@181909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=391005

Review URL: https://codereview.chromium.org/490913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Factor the fill/stroke code out of the various paint-server
RenderSVGResource subclasses and move it to SVGRenderSupport.

Review URL: https://codereview.chromium.org/571463002

git-svn-id: svn://svn.chromium.org/blink/trunk@181907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method is large, and the gain that propagating the constant mode from
its caller is relatively small. Make {fill,stroke}PaintingResource default
inline instead, and un-inline requestPaintingResource and move it into the
class.

Review URL: https://codereview.chromium.org/563973003

git-svn-id: svn://svn.chromium.org/blink/trunk@181906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On windows we receive longer script because \r\n

BUG=30536
TBR= vsevik@chromium.org

Review URL: https://codereview.chromium.org/569543002

git-svn-id: svn://svn.chromium.org/blink/trunk@181905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The SVGInlineTextBox member variable |m_paintingResource| is only set
temporarily within paintTextWithShadows and paintDecorationWithStyle, and
is only accessed from the methods that do setup and teardown of it. This
makes it possible to remove it from SVGInlineTextBox and instead manage it
in through a variable on the stack.
The lifetime management is kept manual/the same as previously. The
interaction with TextRun::RenderingContext is changed to be passed as a
parameter to the added "scope" object in order to simplify the interface
a bit.

Review URL: https://codereview.chromium.org/568723002

git-svn-id: svn://svn.chromium.org/blink/trunk@181904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=391593

Review URL: https://codereview.chromium.org/559423004

git-svn-id: svn://svn.chromium.org/blink/trunk@181903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=413067
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/559843006

git-svn-id: svn://svn.chromium.org/blink/trunk@181902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=391593

Review URL: https://codereview.chromium.org/539353004

git-svn-id: svn://svn.chromium.org/blink/trunk@181901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: mark large-inlined-script.html as Skip because it is really long, may fail, pass and timeout.

TBR= eustas@chromium.org, jianli@chromium.org
BUG=413249
NOTRY=true

Review URL: https://codereview.chromium.org/565923002

git-svn-id: svn://svn.chromium.org/blink/trunk@181900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add setDeviceColorProfile() to allow a render widget to set the
screen color profile of its blink::Page.

Also add a resetDeviceColorProfile() method used to restore the
blink::Page to default color profile state.

Implementation of each in Page are FIXME.

BUG=368663

Review URL: https://codereview.chromium.org/261633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A trivial conversion is defined as one that cannot throw an exception,
and thus need no v8::TryCatch or ExceptionState, and no "did it succeed?"
check after the conversion.

For such conversions, generate the code

  Type variable = convertedValue()

instead of

  TONATIVE_VOID(Type, variable, convertedValue())

Also include all such conversions in the set of argument conversions that
don't require a v8::TryCatch, since they then no longer do.

BUG=413257

Review URL: https://codereview.chromium.org/564063002

git-svn-id: svn://svn.chromium.org/blink/trunk@181897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

String concatenation is used a lot to build error and exception
messages and it was larger than intended because of over eager
inlining.

Outlining template code saves 90 KB with clang and 65 KB with
gcc (lin64 content_shell). After this there is roughly 60 KB of
concatenation code left (clang).

clang:
Total change: -91866 bytes
==========================
  47 added, totalling +6264 bytes across 3 sources
  38 removed, totalling -18354 bytes across 2 sources
  79 grown, for a net change of +4604 bytes (98534 bytes before, 103138 bytes after) across 50 sources
  405 shrunk, for a net change of -84380 bytes (370130 bytes before, 285750 bytes after) across 134 sources

gcc:
Total change: -66849 bytes
==========================
  333 added, totalling +81561 bytes across 69 sources
  203 removed, totalling -65785 bytes across 76 sources
  211 grown, for a net change of +18666 bytes (228381 bytes before, 247047 bytes after) across 85 sources
  406 shrunk, for a net change of -101291 bytes (568083 bytes before, 466792 bytes after) across 160 sources

BUG=

Review URL: https://codereview.chromium.org/559133002

git-svn-id: svn://svn.chromium.org/blink/trunk@181896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Resources which were already loaded and then revalidated were skewing the data:
load time was coming from the already loaded resource, compile time was the new
compilation time.

R=jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/562653005

git-svn-id: svn://svn.chromium.org/blink/trunk@181895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After removing the temporary SCM directory change back to the
original cwd. This will avoid errors on future os.cwd() calls.

BUG=412774
TEST=test-webkitpy --all

Review URL: https://codereview.chromium.org/558103003

git-svn-id: svn://svn.chromium.org/blink/trunk@181894 bbb929c8-8fbe-4397-9dbb-9b2b20218538