- 20 Jan, 2020 40 commits
-
-
Swapnil authored
If the force installed extension fails to install after 5 minutes, report the session type using UMA histogram. A new histogram is created: Extensions.ForceInstalledSessionType Existing user manager returns the session type for sessions like: guest, kiosks, regular etc. using the GetType() method. Additional check is required in case of new regular users to differentiate sign-ins into existing profiles and new ones. Unit tests are added in InstallationTracker for checking Managed Guest Session and Guest Session. Bug: 981891 Change-Id: I27e1a30e450de09ddf534d3d2383ec53e45caede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970992 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733306}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20775957bc71..3903ed28c1bc Created with: gclient setdep -r src-internal@3903ed28c1bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If6f48af779d0455340a08e3a7cff3cecf578a99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010210Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733305}
-
Eriko Kurimoto authored
This CL implements static import for module script. The feature is still behind the flag. This CL also adds SharedWorker with type 'module' Web Platform Tests. Dynamic import is not yet supported, so WPTs which include dyamic import is expected to fail. Bug: 824646 Change-Id: I3b4a239f392736d226a736c011e3f5eb0a3e0d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006995 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#733304}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/89e4a3082402..5029dac177fc git log 89e4a3082402..5029dac177fc --date=short --first-parent --format='%ad %ae %s' 2020-01-20 sigurds@chromium.org Provide frameId getter on Script 2020-01-20 sigurds@chromium.org [karma-tests] Add more tests for TextRange Created with: gclient setdep -r src/third_party/devtools-frontend/src@5029dac177fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032561,chromium:1043120 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I475e2c1c94ee301cf25687c250dd11334ec2452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733303}
-
Gauthier Ambard authored
This CL reloads the SearchEngine TableView if it has changed while the user was editing it. This can happen because when the user select a Search Engine as default it is updated in the TemplateURLService. But as the table view is being edited, for now this change is ignored. With this CL, when the TemplateURLService is updated while the user is editing the TableView, a comparison with the current TemplateURLService state and the state of the TableView is done. If it is different, the TableView is reloaded. It also re-enable TestChangeProvider which was disabled because of that. A visible UI change introduced by this CL is that when a custom search engine is selected, it should be displayed in the first section. Because we weren't updating the TableView when selecting a search engine, previously this was only visible if the user left the search engine screen then re-enter it. Now this is happening instantaneously. Bug: 1036445 Change-Id: I2a28c030a443663d9ea4dbd5c5dcfe0c5c805dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002585 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733302}
-
Sean Harrison authored
Bug: 1007223 Change-Id: Ib232ced2a0d7f987e108afa24a8f31b9631a0182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005208Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#733301}
-
Ulan Degenbaev authored
This uses a new v8::Isolate::MeasureMemory API to compute the JS memory footprint of each v8::Context that has the same security origin and the same JS agent as the calling context does. The V8 API takes a delegate with two methods that are implemented here: 1) ShouldMeasure(context) for selecting the contexts to measure. It fetches the security origin and the JS agent of a context by going through Context => ExecutionContext. 2) MeasurementComplete(context_sizes, unattributed_size) is called by V8 when the measurement is done. The function constructs an object representing the result and resolves the promise with it. # Disable audit_non_blink_usage std::vector check per reviewer's comment NOPRESUBMIT=True Bug: 973627 Change-Id: Ibd0fb3463978184f1d467be306063d1f40105fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986795 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#733300}
-
Gauthier Ambard authored
This CL adds the HTML to display an error page. It also adds the class to be able to load and display it. Based on crrev.com/c/1959041. Bug: 991608 Change-Id: I06aad97bc2d1cde54162d16d8518780de998ce92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984300 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#733299}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c6d670ac06ee..5546abd6b001 git log c6d670ac06ee..5546abd6b001 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 phoglund@google.com Fix bugs where I assume some optional fields were required. Created with: gclient setdep -r src/third_party/catapult@5546abd6b001 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: sadrul@google.com Change-Id: Ic2ee58303b4b87ea370a4772d1790cad1516abc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010570Reviewed-by:
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: I281da0afc27ea6e9ac676986655d9807dec3395e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009591Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#733297}
-
Yoshifumi Inoue authored
This patch intorudces |NGInlineItemsBuilder::DidFinishCollectInlines()| to populate collected inline data to |NGInlineNodeData| at one place to ensure valid |NGInlineNodeData|, e.g. valid value of |is_bidi_enabled_|. Background: Before this patch, we processed RTL text as LTR text when text is modified with |LayoutText::SetTextWithOffset()| by Text.{append,replace}Data() and chunked append at loading. Bug: 1038254 Change-Id: I645f78f853e89704120d50b9db3234806f65c1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010590 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#733296}
-
Friedrich Horschig authored
This CL extends flags for a few smaller autofill experiments that aren't launched yet but still on our list. It extends the keyboard accessory flag since more experimentation time will be needed. Lastly, removing izuzic@ as flag owner from editing. Bug: None. Change-Id: I7c6141ecac2b21c1fbc0213612a6f09520ab3411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007284Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#733295}
-
Clemens Backes authored
Lazy compilation might become one candidate configuration for Liftoff on mobile. Hence we add the flag now so it will be available in the next beta release for finching. R=rmcilroy@chromium.org, jochen@chromium.org Bug: 1040030, 1040061 Change-Id: Icb86a4d3c075afc111978f6797634aabd5b98020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002568Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL adds PRESUMBIT check for blink's mojom namespaces rule. When mojom interfaces of Blink are using in Blink, we should use blink::mojom::blink::T or mojom::blink::T in Blink. Bug: 1043557 Change-Id: I7009c6fbe04a7b937889d97ca69ec92d505b6941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010448Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to remove unused - DEFINE_SVG_PROPERTY_TYPE_CASTS from t_p/b/renderer/core/svg - DEFINE_AX_OBJECT_TYPE_CASTS from t_p/b/renderer/modules/accessibility Bug: 891908 Change-Id: I4a6164f88da586f19f748696b294276384cb4da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010450Reviewed-by:
-
Roman Sorokin authored
Bug: 1012502 Change-Id: If4df2204899acb6c6757fcb6ca8272ded58b9284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002917 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#733291}
-
Roman Sorokin authored
Follow-up for CL:1972837 Bug: 1021297 Change-Id: Ieb8d7f33fb525297436a6c0c32cd96c4c47ec2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002613Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733290}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f89c1760. With Chromium commits locally applied on WPT: 62f8d5f0 "Enable Scroll To Text by default" 363313c0 "Sort the registrations returned by getRegistrations() by registration ID." 8a985066 "[Trusted Types] Implement require-trusted-types-for" 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie7985258879dfbbe91a5dd2fdaaacb4cf3073fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008154Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733289}
-
Hirokazu Honda authored
This is a reland of 93395999 CHROMEOS_LKGM becomes new enough to pass the tests running on waterfall. Original change's description: > media/gpu/vaapiVEA: Call NotifyEncoderInfoChange() at the end of initialization > > This notifies VEA client VideoEncoderInfo of > VaapiVideoEncodeAccelerator (VaapiVEA) at the end of the > initialization. > Since VaapiVEA doesn't update fps allocation and qp values, > NotifyEncoderInfoChange() is not called except the end of the > initialization. > > Bug: 1031965 > Test: webrtc.RTCPeerConnection* > Test: webrtc.DecodePerf.* > Change-Id: If2a8b7ff16644d55b20e273502a5f20078c96121 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978458 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731147} TBR=mcasas@chromium.org Bug: 1031965 Change-Id: I2b5f5afc6f1cc87299d1daf969b8b8cce9637062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010241Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a8dfb9c2acd..20775957bc71 Created with: gclient setdep -r src-internal@20775957bc71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ieba138cc2e0a900988d445ebbf1abb79d0fde37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010499Reviewed-by:
-
Monica Basta authored
As part of friendly settings, this CL implements changing |sync everything| from check box to radio button. The motivation behind this work is to clarify to users the difference between |Sync everything| checked and |Sync everything| unchecked but all single data types checked. Bug: 1043122 Change-Id: I579b8173a7b32f1416a3b1eda999196d177a2b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007730 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#733286}
-
Mathias Carlen authored
This patch extends the expiration release of the "direct-actions" flag. Filed b/147972543 to revisit AA and direct actions related flags in that file and clean them up if they are no longer required. Bug: b/147972543 Change-Id: I4f96d166c802b1e20bf12131534547f206910823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007722Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#733285}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/102e7878e940..89e4a3082402 git log 102e7878e940..89e4a3082402 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 szuend@chromium.org Eager console evaluation that builds the preview must use REPL mode Created with: gclient setdep -r src/third_party/devtools-frontend/src@89e4a3082402 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043151 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib6022de9f629c00233e0d7dc9f9147efd551e5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010504Reviewed-by:
-
David Roger authored
Fixed: 777774 Change-Id: I6e31976e04431b847597b3d3ef73a20fd8b4fbe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007691Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#733283}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/579c59400f86..0aba975494ce git log 579c59400f86..0aba975494ce --date=short --first-parent --format='%ad %ae %s' 2020-01-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2cb1db08e5f1..11cb891a01a2 (4 commits) Created with: gclient setdep -r src/third_party/angle@0aba975494ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I864f4d243fece1fb7eae63d6637c26cdde4851cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010497Reviewed-by:
-
Koji Ishii authored
Following r733251 <crrev.com/c/2007327>, this patch supports |PositionForPoint| in an inline formatting context. The logic is based on |NGPaintFragment:: PositionForPointInInlineFormattingContext|. Fixes ~40 failures. Bug: 982194 Change-Id: I52564e5001570d3a60af35c85393d0e74649699b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950734Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#733281}
-
Colin Blundell authored
In the interests of componentizing //chrome's SSLErrorHandler for sharing with WebLayer, this CL eliminates that class' reliance on //chrome's BrowserProcess for obtaining the NetworkTimeTracker instance. Instead, that instance is passed in to SSLErrorHandler on creation. This change also has the nice side effect that the unittest's mocking out of the NetworkTimeTracker instance becomes IMO more straightforward. One thing to note there is that several tests now pass nullptr in for the NetworkTimeTracker object when constructing the SSLErrorHandler instance (i.e., all the tests that previously did not explicitly mock out the tracker instance). This is because the NetworkTimeTracker instance is never accessed in these tests. This fact was already an implicit assumption of the tests; by not mocking out SSLErrorHandler's NetworkTimeTracker instance, they were leaving it in its default configuration of being obtained via g_browser_process->network_time_tracker(), but accessing TestingBrowserProcess::network_time_tracker() causes a DCHECK to fire. The change here turns that implicit assumption into an explicit one. Relatedly, we also change that DCHECK into a return of nullptr, as many unrelated unittests (those deriving from ChromeRenderViewHostTestHarness) now harmlessly invoke g_browser_process->network_time_tracker() due to ChromeContentBrowserClient now invoking that method. Bug: 1030692 Change-Id: I640b6304ecaa59a85cc67086af555264d5076364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000623 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#733280}
-
Colin Blundell authored
We will shortly be componentizing //chrome's detection of captive portals as part of componentizing SSLErrorHandler for sharing with WebLayer. This CL takes a first step by componentizing the enable_captive_portal_detection feature and buildflag. The (internal-only, apologies) design doc showing how the componentization of captive portal detection fits into the larger effort is here: https://docs.google.com/document/d/1ab_zZ6TF6tMZE54IJ2dz8LSwsIp6XEwky9yzH7WPFqk/edit#heading=h.llthcowp07o0 Bug: 1030692 Change-Id: If71557f5c67516a2be13319d589f9bbb622710af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991626Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#733279}
-
Colin Blundell authored
In preparation for componentizing this blocking page, this CL moves it to be created via ChromeSecurityBlockingPageFactory and thereby cleaned of its //chrome-level dependencies. Bug: 1030692 Change-Id: Icb2693512d04fa504e4ac059b06761b287212502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000743 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#733278}
-
Oriol Brufau authored
::marker pseudo-elements are originated by elements whose computed 'display' is 'list-item'. This usually means that they are list items, that is, they are laid out as LayoutNGListItem (or LayoutListItem). However, this is not always the case. E.g. a <fieldset> is laid out as LayoutNGFieldset (or LayoutFieldset) even with 'display: list-item'. This was the only problematic case in LayoutNG that I found in r731964, so I just prevented <fieldset> from originating a ::marker. But this was a fragile approach since there could be other cases. Actually I have noticed other cases in legacy when working on implemententing markers as pseudo-elements in legacy. This patch adds a condition in PseudoElement::AttachLayoutTree to prevent a ::marker from being laid out if it's originated by an element which isn't laid out as a list item. BUG=457718 Change-Id: I60fd774d6de79189b2871c98594d8bee397e4064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007457Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#733277}
-
Takashi Sakamoto authored
Change-Id: Ia29e88514bf46733cb730098620e705df59d1f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000450 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL uses new downcast helpers for DocumentAllNameCollection, DocumentNameCollection and DocumentResource classes. Bug: 891908 Change-Id: I1e10bc7fa908090cf13e4c271bac010b43d42bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999964Reviewed-by:
-
Behdad Bakhshinategh authored
This reverts commit e094969c. Reason for revert: crbug.com/1043279 Original change's description: > Manually roll perfetto 11c11a1a891c..d092437b81ea > > Also includes manual modification to switch to perfetto's EventContext. > > https://android.googlesource.com/platform/external/perfetto.git/+log/11c11a1a891c..d092437b81ea > > 2020-01-17 fmayer@google.com Merge "Cleanup of profile related trackers." > 2020-01-17 eseckler@google.com Merge "client lib: Add an EventContext constructor for Chrome" > 2020-01-17 lalitm@google.com Merge "bazel: Disable warning about unused system_header pragma" > 2020-01-17 lalitm@google.com Merge "trace_processor: fix overflow in bitvector" > 2020-01-17 taylori@google.com Merge "Make selection default behaviour" > 2020-01-17 treehugger-gerrit@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." > 2020-01-17 eseckler@google.com Merge "processor: Only fall back to legacy tracks for legacy events" > 2020-01-17 treehugger-gerrit@google.com Merge "TrackEvent: Add initial legacy macro support" > 2020-01-17 fmayer@google.com Merge "Function for on-demand flamegraph for heap graph." > 2020-01-17 treehugger-gerrit@google.com Merge "Turn ingestion DFATALs into DLOG." > 2020-01-17 khokhlov@google.com Merge "Exclude targets depending on sqlite from embedder builds" > 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated" > 2020-01-16 eseckler@google.com Merge "processor: Export pid/tid as signed integers into JSON" > 2020-01-16 lalitm@google.com Merge "trace_processor: fix compile and build on fuzzer" > 2020-01-16 joelaf@google.com Merge "Fix precision errors by explicit casting" > 2020-01-16 lalitm@google.com Merge "Revert "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."" > 2020-01-16 chiur@google.com Merge "Add VulkanApiEvent.VkQueueSubmit message" > 2020-01-16 khokhlov@google.com Merge "trace_processor: Run metrics on Windows" > 2020-01-16 primiano@google.com Merge "gn: Fix issue with finding llvm when using python3" > 2020-01-16 hjd@google.com Merge changes Ic6800bd0,I29636316 > 2020-01-16 treehugger-gerrit@google.com Merge "processor: Fix handling of 0 timestamp in TrackEventTokenizer." > 2020-01-16 rsavitski@google.com Merge "heapprofd producer: use sigqueue(si_value: 0) instead of kill" > 2020-01-16 taylori@google.com Merge "perfetto-ui: Toggle sidebar on ctrl/cmd + b" > 2020-01-16 eseckler@google.com Merge "client lib: Support building in Chrome using a fake platform" > 2020-01-16 eseckler@google.com Merge "processor: Translate duplicate pids/tids during json export" > 2020-01-16 buss@google.com Merge changes I1bb0e215,I498ed990 > 2020-01-16 treehugger-gerrit@google.com Merge "processor: Support pid reuse in ProcessTracker without Start/EndThread" > 2020-01-16 primiano@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." > > Created with: > gclient setdep -r src/third_party/perfetto@d092437b81ea > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: 1043059 > Change-Id: I37e4964f76d212bcfef69c8715ac7521521e82a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007750 > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: ssid <ssid@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732907} TBR=skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org,nuskos@chromium.org Change-Id: I8c7dba484b81bdd85b67443956808722e44a7c5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043059, chromium:1043279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008421 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#733274}
-
Eric Seckler authored
This reverts commit 7832cb0b. Reason for revert: crbug.com/1043279 Original change's description: > Roll src/third_party/perfetto d092437b81ea..2e5c7edf368f (3 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/d092437b81ea..2e5c7edf368f > > git log d092437b81ea..2e5c7edf368f --date=short --first-parent --format='%ad %ae %s' > 2020-01-17 lalitm@google.com Merge "trace_processor: allow selecting rowmaps with smaller rowmaps" > 2020-01-17 buss@google.com Merge "Fix compilation on Windows/VSC." > 2020-01-17 hjd@google.com Merge "ui: Remove small gap in pinned track container" > > Created with: > gclient setdep -r src/third_party/perfetto@2e5c7edf368f > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: Ib8ceb5de792d61f42929d30e6f411fb3435d8238 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008168 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#732942} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: Ia82d45f04e13ad0ff1face565633d1b65ded43b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007459 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#733273}
-
Simon Que authored
This reverts commit 728991c5. These settings are now set in builder.star. R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org Bug: 1040754 Change-Id: I4e3bb46fd65705c09a6cc02fa62749b1a274e7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010510Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#733272}
-
Rune Lillesveen authored
We used to stop propagation of text-decoration into elements rendered with UA shadow trees in general. Instead we should list the specific cases where we need to do this. This is currently for media elements which has a special rendering where the media controls do not use a proper containing block model. This fixes text-decoration propagation for elements like, summary, details, object, and marquee. TEST=fast/table/backgr_layers-opacity.html TEST=fast/table/backgr_layers-opacity-collapsed-border.html TEST=media/controls-styling.html Bug: 1042760 Change-Id: Ice2681e4ac93b1a96ec598bcb614b6a8f57e0b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007629 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#733271}
-
Renato Silva authored
Changes ShelfConfig and LoginShelfView so that the correct colors are set for the buttons during the OOBE session state. Fixed: 1023788 Change-Id: If4150449354575a648417f9aecfdb74a1d2bbfa2 Bug: 1023788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003316 Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
-
Jochen Eisinger authored
Bug: 873178 Change-Id: I3896e14dbbc63667a7b4fbba3737ea66ba07eb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002876 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#733269}
-
Simon Zünd authored
This CL disables a test so a hotfix CL (https://crrev.com/c/2009107) can land. The hotfix fixes DevTools console so we prioritize landing it in favor of investigating one failing web test. Bug: chromium:1043151 Change-Id: Id1e8cded7bcc847e08886a59df2ce27613bb73f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007579Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#733268}
-
Alexander Dunaev authored
This CL continues the refactor of drag'n'drop on Linux. Here the most part of code that doesn't depend on Aura and views is moved. Bug: 1014860 Change-Id: I47380c8ab0291485b2de544ba12342c09163e2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007573Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#733267}
-
