- 26 Mar, 2020 40 commits
-
-
Etienne Bergeron authored
This CL is adding a sampling profiler track for the compositor thread to slow-reports. The TracingSamplerProfiler is responsible to take CPU sampling profiler and put them into tracing iff slow-reports is activated. The class destructor is responsible to stop CPU sampling if needed. The sampling profiler will be working for the whole tracing session. The TracingSamplerProfiler is able to manage turning on and off tracing at any point in time. For users not part of the control population, this should not affect the performance at all. Bug: 1064662 Change-Id: I658e97fcc6585918b6762878ade3a1ddb31f3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119220Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753779}
-
Ahmed Mehfooz authored
This was added previously to make sure focus navigation worked if notifications were cleared. We only need to activate the quick settings widget and not focus an element in it. Bug: 1062219 Change-Id: I7a4ae2ebb007872306e712dcc91a269f990ebbe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117151Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753778}
-
Jon Mann authored
Wi-Fi sync needs to know the ssid and security type of a network in order to remove it from sync. Once a network has been removed this information is no longer available. This observer method allows us to cache the required metadata for use once we know that the removal was successful. Bug: 966270 Change-Id: Ic850ae8fc75fe600ce70ca2a161bb4281be4119e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110392 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#753777}
-
Etienne Bergeron authored
This CL is removing the old tracing system in net::disk_cache. The tracing is only active in debug build, or if manually toggle an ifdef in trace.cc (see #define ENABLE_TRACING 0) R=gab@chromium.org, morlovich@chromium.org Bug: 1065004 Change-Id: I8d0b85975b15896078d9275fd9ab6ac6174338e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122449Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753776}
-
Adam Ettenberger authored
With the Narrator setting "Sync the Narrator cursor and system focus" enabled, and the user navigates from the browser UI into the document frame, the root Document should be focused. If IFrame content had focus before it was moved to the browser UI, when returning to the document frame the last focused item within the IFrame regains focus. This happens either when using the Tab key or Narrator Item Navigation. With Narrator Item Navigation however, the focus should be moved to the root Document upon entering the document frame. This is because Narrator explicitly requests focus on the item via IRawElementProviderFragment::SetFocus (AXPlatformNodeWin::SetFocus). This ends up calling BrowserAccessibilityManager::SetFocus which attempts to do 2 things in this scenario : (1) Return focus to the Accessibility View (AccessibilityViewSetFocus) (2) Focus the target Element (AccessibilityPerformAction) AccessibilityViewSetFocus ends up focusing the IFrame content with this approximate stack : AccessibilityViewSetFocus BrowserAccessibilityManager::OnWindowFocused BrowserAccessibilityManager::FireFocusEventsIfNeeded BrowserAccessibilityManager::GetFocus BrowserAccessibilityManager::GetFocusFromThisOrDescendantFrame BrowserAccessibilityManager::FireFocusEvent After focus has been returned to the IFrame content, the call to AccessibilityPerformAction should now focus the targeted element. However this does not happen because it ends up calling AXNodeObject::OnNativeFocusAction which only calls ClearFocusedElement for the root document. This call does not affect the nested Frame, and focus remains within the IFrame. This change aims to fix this corner case, and allow focus to be set on the requested Document. Bug: 1064339 Change-Id: I5648483a4463ecd8e4105624c84293e0be68f8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116541Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753775}
-
Julie Jeongeun Kim authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I6bbe8dfdf8a20049114b498e2bc4c0695526cd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120998 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#753774}
-
Matt Jones authored
The usages in this class were in an unused method. Bug: 952703 Change-Id: Icb36d4205dee45374323d2b4d009caed1cae8ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122612Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#753773}
-
Justin Miron authored
This re-lands the blink/content renderer changes of https://crrev.com/c/2108343 fixed for the chromeos build with --thintlo. The fix adds a clang annotation to the FrameView class which crashed due to a compiler customization of the vtables. Annotating the class with clang::lto_visibility_public prevents this automatic optimization. Change-Id: I849f07fb2cd3a5afde861589ca0a55a13ca84e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112233 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753772}
-
David Tseng authored
TBR=dtseng@chromium.org Fixed: 1064947 Change-Id: Ica62f840395880fce96bc73cb1e7eb8e948d23cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122464Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753771}
-
Wenjie Shi authored
There is a rare access violation bug in the Windows sensor WinRT API that causes the client code crash on Windows RS5. The Chromium sensor backend on Windows is using these WinRT APIs if the build is on Windows 10 (RS5 is a build of Win10) so Chromium is crashing due to this issue. The WinRT bug was fixed in Windows 19H1. This CL updates the Chromium sensor backend to only use the WinRT APIs if the system is on build 19H1 or above to avoid the AV. Bug: 1063124 Change-Id: I6c9eb02170e5d62a75ea6ee511369254e27a9652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122616 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753770}
-
Sammie Quon authored
According to [1], a sequence of gesture events is generated by the gesture recognizer. These events currently all share the same event target so if the target gets invalidated by the first event, the next event would crash when we try coordinate conversion using the dangling pointer. This can happen if the backdrop is visible with a non-resizable app. On swipe/fling we'll get a sequence of SCROLL_END -> GESTURE_END. The SCROLL_END event will get processed and Hide the non-resizable app, which will trigger the backdrop to destroy. Then the GESTURE_END will crash when it tries to do coordinate conversion. To fix this, move coordinate conversion outside the loop as the results should be the same. [1] https://docs.google.com/document/d/1mQFx99xz5jVUHQk2jZTjHPgMjRQd4EUDfdLG0XKOlWI/edit Test: added test Bug: 1064618 Change-Id: I91c9e0955d01a651a779a800149a73f6c545a767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119632Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753769}
-
rbpotter authored
Migrate these 3 smaller elements in site_settings/ to Polymer 3. These elements don't have corresponding unit tests. Bug: 1026426 Change-Id: I8fde01cfc2cf94b5710c5fe70df7ad91fc393927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121501 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#753768}
-
Avi Drissman authored
This reverts commit e334b16e. Reason for revert: Breaks win-asan https://ci.chromium.org/p/chromium/builders/ci/win-asan/11193 ../../sandbox/win/src/process_mitigations_dyncode_unittest.cc(414,31): error: code will never be executed [-Werror,-Wunreachable-code] std::wstring test_command = L"CheckPolicy "; ^~~~~~~~~~~~~~~ ../../sandbox/win/src/process_mitigations_dyncode_unittest.cc(490,31): error: code will never be executed [-Werror,-Wunreachable-code] std::wstring test_command = L"CheckPolicy "; ^~~~~~~~~~~~~~~ Original change's description: > Enable -Wunreachable-code on Windows. > > TBR=reillyg > > Bug: 346399 > Change-Id: I7f52d34dd3be08485c1aace38f2f61d1d4f14176 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122428 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753741} TBR=thakis@chromium.org,reillyg@chromium.org,rsesek@chromium.org Change-Id: I289e69d3147aa774a5637fffa850f55015ea5d67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 346399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122434Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753767}
-
Lukasz Anforowicz authored
The CorbAllowlistAlsoAppliesToOorCors feature allows to enable extra test assertions in the CrossOriginReadBlockingExtensionAllowlistingTest, CorsFromContentScript testcase. Bug: 1061567 Change-Id: Ia9e7c77d48086c68b7c641ff988f21f25da52370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116935Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#753766}
-
rbpotter authored
Bug: 1026426 Change-Id: I5a9f2b9146dfc53b6487e4084111802976cf09d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121438 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#753765}
-
Filip Gorski authored
Looks like on some devices it is possible that shared preference of type string set contains null. This patch adds code to sanitize such set (both when reading and writing) to make sure users of the read set cannot hit a null value. Bug: 1064881 Change-Id: I7cc833c3f9e1eb104783341892b23808593a557a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122465Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#753764}
-
Juanmi Huertas authored
This reverts commit 2c2f5494. Reason for revert: Potential culprit of bots failing in linux trusty rel, https://bugs.chromium.org/p/chromium/issues/detail?id=1065074 Original change's description: > Remove GTK scale factor workarounds > > The workarounds were initially added to fix rendering issues > when the scale factor was an odd value like 1.01. Hopefully > the fractional scale factor support in Chrome is now good > enough to handle these cases. > > This change prevents unexpected scale factor behavior like > 1.25 remapping to 1.0. > > BUG=1033552 > R=oshima > > Change-Id: I1d22c1ddcf463fed12061ef265d2a6b4a4bcbeb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121179 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753653} TBR=oshima@chromium.org,thomasanderson@chromium.org Change-Id: I8094718a8ddc3b041fddfe194260d0503ce61d43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122688Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#753763}
-
Peng Huang authored
The EGL fence cannot be created successfully on Android emulator. The EGL fence is need by Android surface control, so disable the Android surface control for emulator. Bug: 1064665 Change-Id: Ib6624e40d772eeabcb9918250164644db8c79a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121472Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753762}
-
Michael Chang authored
Instead of having a separate executable to install the updater, have the main executable take --install to install the updater. Bug: 1063435 Change-Id: Idddf816ebce2e788a29617acd5728776b85c092a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121032Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Michael Chang <donchan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753761}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/7379c493206b..2542cb728 $ git log 7379c4932..2542cb728 --date=short --no-merges --format='%ad %ae %s' 2020-03-26 fayang Change all QuicOneBlockArena<1024> to QuicOneBlockArena<1200> to fix link issue on Windows. 2020-03-26 bnc Do not allow push until MAX_PUSH_ID is received. 2020-03-26 fayang Split QUIC session type to two: SECURE_SPDY4_OVER_QUIC only for QUIC crypto, and QUIC_WITH_TLS1_3 for QUIC with TLS. 2020-03-26 fayang gfe-relnote: In QUIC, use IdleNetworkDetector to detect handshake and idle network timeout. Protected by gfe2_reloadable_flag_quic_use_idle_network_detector. 2020-03-25 renjietang Add CompleteHandshake() in QuicSpdySessionTest to save duplicated code. 2020-03-25 wub gfe-relnote: (n/a) Make Http2FrameDecoderNoOpListener compile with -Wunused-parameter. No behavior change. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: Ifef6c3e66de4c2aa9da086aa487c2d7666325fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121661 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753760}
-
Becca Hughes authored
Deflake the browser test by using wait for db. BUG=1052605,1058563 Change-Id: Iba71c6a5b6c1145f777d028ded4638b404434b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122614Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#753759}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5e04fbf9..319db212 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1eddf2a3c478dba0592b23efbcbeed8e819507c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122747Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753758}
-
Robin Lewis authored
Failed HTTP calls in BuildRequestAndFetchResultFromHttpService are re-tried specified number of times before failing. Bug: 1064502 Change-Id: Id7f89ea42ee8f6076052b9a9f3bd2d84f9ca57e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119668Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#753757}
-
Elly Fong-Jones authored
This change re-enables NormalKeyEvents and EditorKeyBindings on Mac. Both have repeatedly passed locally. AccessKeys is still disabled; it has some Mac-specific codepaths which I don't yet understand and which seem not to work. Bug: 222296,81451 Change-Id: I021d7f6765393975221b1cdd3e8768715e36bd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122807Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#753756}
-
Sasha McIntosh authored
Small quads may be part of a larger shared quad state. We continue to limit culling by maintaining a maximum occluding region complexity. This change may increase the frequency of completely occluded quads. We can reduce the impact of removing more quads by reducing their visible rect to 0 rather than removing them completely in a follow up cl. DisplayTest.*SkipRect tests are removed. New tests don't appear to be necessary, as many existing tests reduced the kMinimumDrawOcclusionSize to zero (now removed). Bug: 1022544 Change-Id: I639fdb294e5328567d5b18dbddbcc117ac3ef7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080679 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#753755}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ec568841384..a169b00a54f6 git log 6ec568841384..a169b00a54f6 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 jlavrova@google.com Respect grapheme clusters when wrapping text 2020-03-26 csmartdalton@google.com Add glDraw*BaseInstance functions to GrGLInterface 2020-03-26 bungeman@google.com Include system headers last. Created with: gclient setdep -r src/third_party/skia@a169b00a54f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ie113692692be630dc9f95787f393a8b5e98370c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753754}
-
Wez authored
Bug: 1063919 Change-Id: Iaa5133969190da9c234925576c07b487df3c5ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116173 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753753}
-
Oriol Brufau authored
As resolved in https://github.com/w3c/csswg-drafts/issues/4814, allow ::marker to have animations or transitions. But only for the properties that apply to ::marker. TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html TEST=external/wpt/css/css-animations/event-order.tentative.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html BUG=1054509 Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753752}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/658779b63e6b..edcb5301a064 git log 658779b63e6b..edcb5301a064 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 treehugger-gerrit@google.com Merge "Remove redundant NOTICE copied from LICENSE." Created with: gclient setdep -r src/third_party/perfetto@edcb5301a064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5ad9add80c7fea62aa15dec25dff3caa7580d036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753751}
-
Abigail Klein authored
if(toolkit_views) in chrome/browser/ui/BUILD. Change-Id: Idad8060c67379d4404683313863f4c7a731c81cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122468Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#753750}
-
S. Ganesh authored
Using --install without using --appid={appid} will now install the updater without installing any application. Bug: 1014298 Change-Id: I4f6be0f5188261e75293abb6c939dd759fd01000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121455 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#753749}
-
Henry Jian authored
This CL uses D8 and R8 to enable assertions and removes AssertionEnablerClassAdapter.java used by bytecode rewriter. Bug: 1024346 Change-Id: I3a448162fce5ebb7f40287d96f9046d6c7cb1568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109813 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#753748}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/17aaea21d40d..0dd5482c5254 git log 17aaea21d40d..0dd5482c5254 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 ehmaldonado@google.com depot_tools: Restore appending title before change description. 2020-03-26 sokcevic@google.com Fix git_number windows unit tests Created with: gclient setdep -r src/third_party/depot_tools@0dd5482c5254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1064905 Tbr: agable@chromium.org Change-Id: I77ab91086375477fb5eab59299a3108dc33112f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753747}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cafff78f665b..37457d5e1826 git log cafff78f665b..37457d5e1826 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 bclayton@google.com Regres: Add support for generating collated coverage info 2020-03-26 bclayton@google.com CMake: Emit coverage-toolchain.txt file next to ICD json 2020-03-26 bclayton@google.com CMake: Add SWIFTSHADER_EMIT_COVERAGE option Created with: gclient setdep -r src/third_party/swiftshader@37457d5e1826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0643d077fb6f3f205be1dd4b5517262e8cf7a23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122519Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753746}
-
Jon Mann authored
This is a reland of 3014d931 with fix for a use after free of the NetworkMetadataStore held by wifi sync classes. Original change's description: > Inject NetworkMetadataStore in wifi sync classes which depend on it. > > The instance of NetworkMetadataStore for a user profile is created > after the sync service is already initialized. This change does > the necessary plumbing to get the metadata store instance to > the wifi sync classes. > > Bug: 966270 > Change-Id: Icd235cd780df97a367f09f281f3e957893baa93b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110079 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752273} TBR=stevenjb@chromium.org,treib@chromium.org Bug: 966270 Change-Id: Ib4327a1a953ebee8d49775890eec2e6c353c4e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114586 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#753745}
-
Peng Huang authored
Bug: None Change-Id: I34640da23483581c91c56fef4344afce106a0a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122450 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#753744}
-
Aya ElAttar authored
Changed base::ListValue to base::Value according to the new design. Change-Id: Iadabd65d527eea187ed6f7ecfb767bb8011a0538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120574 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753743}
-
Daniel Rubery authored
This CL adds a fixture that can be used for integration tests when deep scanning downloads. Future CLs will use this fixture for testing the core user journeys in download deep scanning. Bug: 1060367 Change-Id: I1aea7d4821e9abe6230038419de7061bee88e5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117294Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#753742}
-
Nico Weber authored
TBR=reillyg Bug: 346399 Change-Id: I7f52d34dd3be08485c1aace38f2f61d1d4f14176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122428 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#753741}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/3d915b280266..9472e3eec085 git log 3d915b280266..9472e3eec085 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 rharrison@google.com Convert compile options to require explicit environments (#1019) 2020-03-26 dgkoch@users.noreply.github.com Roll glslang dependency (#1018) Created with: gclient setdep -r src/third_party/shaderc/src@9472e3eec085 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Iaee0904b8bc8e0da0a65151ebd6afe1b117798df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122520Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753740}
-