- 13 Jan, 2017 40 commits
-
-
fdoray authored
In a real browser process, threads are started as BrowserThreadImpl objects are created. TestBrowserThreadBundle should do the same. This is a pre-requisite to add the option to create a real TaskScheduler in TestBrowserThreadBundle, because TaskScheduler has to be created and started at the same time. BUG=659191 Review-Url: https://codereview.chromium.org/2628903002 Cr-Commit-Position: refs/heads/master@{#443536}
-
VladimirTechMan authored
This patch adds flag "enable_ios_bitcode" to the build configuration for iOS applications, frameworks, and libraries. It triggers adding the "-fembed-bitcode" option when compiling and linking parts of the projects for production builds (is_debug = false), and it triggers adding the "-fembed-bitcode-marker" option in the case of debug builds. That is along the lines of how Xcode does it, since the introduction of the bitcode support and corresponding options. The option only makes sense for Xcode build tools now and for iOS SDK compatible builds (iOS, watchOS, tvOS). Thus, it the options is only applicable when building for iOS with use_xcode_clang = true. And only when building for real devices (with ARM CPUs). The latter limitation is due to the usage of Intel assembly syntax and the Yasm tool when building for iOS simulator (Yasm cannot emit bitcode sections now). But it does not affect the workflow for the generated applications, frameworks and libraries at the moment of submitting this patch: For now, Xcode only cares about the availability of bitcode sections in _all_ the pre-compiled parts of bitcode-enabled projects when building those projects for ARM-based devices. Building for iOS simulator, it handles the projects just fine, with or without bitcode sections available in the linked libraries. That may change in the future, of course, but currently it should be fine. BUG=680711 Review-Url: https://codereview.chromium.org/2631573002 Cr-Commit-Position: refs/heads/master@{#443535}
-
philipp.hancke authored
extracts the ice candidate type (host, srflx or relay) from the onicecandidate event and addIceCandidate call and shows it as part of the type. BUG=678292 Review-Url: https://codereview.chromium.org/2612063002 Cr-Commit-Position: refs/heads/master@{#443534}
-
tfarina authored
This is the first step to get rid of deprecated CryptoModule methods in NSSCertDatabase class and then later get rid of CryptoModule abstraction. BUG=None TEST=net_unittests R=mattm@chromium.org,jochen@chromium.org,armansito@chromium.org TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2600053002 Cr-Commit-Position: refs/heads/master@{#443533}
-
benwells authored
This code is mostly permissions related, and most changes related to the handling of permissions and content settings. BUG=None Review-Url: https://codereview.chromium.org/2627323004 Cr-Commit-Position: refs/heads/master@{#443532}
-
harkness authored
The original implementation of GCM Connection tracking had a DCHECK in ConnectionLoginFailed to validate that ConnectionAttemptSucceeded had been called first to validate the expected ordering of the calls. That was removed as a result of crbug.com/673706 because it was failing. After investigating, the reason for the failures is that the entry check for calling ConnectionLoginFailed was checking the logging_in_ member on the ConnectionFactoryImpl. However, that member tracks whether the initial connection is established, not whether the login handshake has been completed. The correct check for when to call ConnectionLoginFailed is if the result passed to SignalConnectionReset is LOGIN_FAILURE, since that indicates that the MCSClient was unable to complete the login. BUG=673706 Review-Url: https://codereview.chromium.org/2624653003 Cr-Commit-Position: refs/heads/master@{#443531}
-
tnagel authored
Upon initialization, have {Device,User}ActiveDirectoryPolicyManager request a policy fetch. BUG=677511 Review-Url: https://codereview.chromium.org/2623203005 Cr-Commit-Position: refs/heads/master@{#443530} -
haraken authored
It looks strange that NavigatorContentUtils is a supplement of LocalFrame. It should be a supplement of Navigator. BUG=610176 Review-Url: https://codereview.chromium.org/2627413003 Cr-Commit-Position: refs/heads/master@{#443529}
-
haraken authored
Supplement::host() is confusing with FrameHost since it's sometimes used as host()->frame() etc. Hence this CL renames it to something clearer. BUG=610176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2630703002 Cr-Commit-Position: refs/heads/master@{#443528}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad889a60..e638a5a6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2630593003 Cr-Commit-Position: refs/heads/master@{#443527}
-
dvadym authored
In recent discussion about adding a password generation setting in Password Manager settings it was mentioned that Auto sign-in text should have the same capitalization as on passwords.google.com. This CL fixes that. BUG=400674 Review-Url: https://codereview.chromium.org/2632453002 Cr-Commit-Position: refs/heads/master@{#443526}
-
jochen authored
R=adamk@chromium.org,littledan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2626003002 Cr-Commit-Position: refs/heads/master@{#443525}
-
sczs authored
BUG=671559 Review-Url: https://codereview.chromium.org/2625423003 Cr-Commit-Position: refs/heads/master@{#443524}
-
philipp.hancke authored
Highlights both ICE failure (iceconnectionstatechange -> failed) and any error callbacks (indicated by ...OnFailure) so that they are more visible. BUG=678292 Review-Url: https://codereview.chromium.org/2621493002 Cr-Commit-Position: refs/heads/master@{#443523}
-
tkent authored
This CL improves the performance of the test by converting it to testharness.js. With macOS debug: 7.3 sec -> 2.4 sec BUG=658318 Review-Url: https://codereview.chromium.org/2631483002 Cr-Commit-Position: refs/heads/master@{#443522}
-
alexilin authored
Predictor needs time to learn about user favorites pages. Special age metric is introduced to show that the predictor database is large enough. Metric is "large" when most users have learned about most of their pages, and "small" otherwise. BUG=680049 Review-Url: https://codereview.chromium.org/2625063002 Cr-Commit-Position: refs/heads/master@{#443521}
-
haraken authored
WindowPaintWorklet doesn't need to inherit from DOMWindowProperty since it can retrieve a window object via Supplement<>. BUG=610176 Review-Url: https://codereview.chromium.org/2628323002 Cr-Commit-Position: refs/heads/master@{#443520}
-
grunell authored
The class is generic and will be used also for output recording. Also rename its implementation AudioInputDebugWriter -> AudioDebugFileWriter. BUG=531883 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2620373005 Cr-Commit-Position: refs/heads/master@{#443519}
-
toyoshim authored
To use FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE consistently instead of FrameMsg_Navigate_Type::RELOAD in content, rename RELOAD_MAIN_RESOURCE to RELOAD and override old behavior. This change introduces two functional changes: 1. RELOAD_ORIGINAL_REQUEST_URL is changed to revalidate only main resource instead of revalidating all. (in render_frame_impl.cc ReloadFrameLoadTypeFor) 2. In LoadDataURL(), replace flag is set for usual reload operations. This was the original behavior, but unexpectedly changed in newly introduced ReloadMainResource cases. BUG=670232 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2583123002 Cr-Commit-Position: refs/heads/master@{#443518} -
pdyson authored
Changing to a method that works even when the app permission is not "allowed". For KitKat and later using getInt with LOCATION_MODE to get the location mode. Versions pre KitKat do not have this. So for those versions using getString with LOCATION_PROVIDER_ALLOWED to get the same information. BUG=668923 Review-Url: https://codereview.chromium.org/2621223002 Cr-Commit-Position: refs/heads/master@{#443517}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#443516} -
yukishiino authored
Since V8 now supports internal fields for the global proxy objects, let's change the mappings among global proxy object / global object / C++ instance in Blink. With this CL, a global proxy object and C++ instance point to each other, and a global object points to the C++ instance (without reverse pointer). BUG=675872 Review-Url: https://codereview.chromium.org/2620493002 Cr-Commit-Position: refs/heads/master@{#443515}
-
haraken authored
Now that we've shipped a per-thread heap, a Dead state should not happen. This CL adds an assert to check the fact. BUG= Review-Url: https://codereview.chromium.org/2629853002 Cr-Commit-Position: refs/heads/master@{#443514}
-
alexclarke authored
For pages where there was a FrameOwnerElement with a null ContentDocument CSS.getLayoutTreeAndStyles would crash. This patch fixes that. BUG=680497, 546953 Review-Url: https://codereview.chromium.org/2623273006 Cr-Commit-Position: refs/heads/master@{#443513}
-
alancutter authored
This change is a small refactor that pushes the details of whether custom property values are stored in StyleInheritedVariables or StyleNonInheritedVariables down into ComputedStyle. This is in preparation for animations on registered custom properties and avoids duplicated logic. BUG=671904 Review-Url: https://codereview.chromium.org/2630683002 Cr-Commit-Position: refs/heads/master@{#443512}
-
haraken authored
These objects should be a per-DOMWindow thing instead of a per-ExecutionContext thing. They should DOMWindowClient instead of ContextClient. BUG=610176 Review-Url: https://codereview.chromium.org/2626423003 Cr-Commit-Position: refs/heads/master@{#443511}
-
constantina authored
Currently only shares to a demo Share Target App hosted at https://wicg.github.io/web-share-target/demos/sharetarget.html; follow-up CL will have more share options. BUG=668389 Review-Url: https://codereview.chromium.org/2564483003 Cr-Commit-Position: refs/heads/master@{#443510}
-
toyoshim authored
ScrollbarTestSuite registers Platform::current()->compositorSupport() to TestingPlatformSupportWithMockScheduler, but TestingPlatformSupportWithMockScheduler does the same thing internally. So we can just remove ScrollbarTestSuite without any behavior change. BUG=n/a TEST=blink_platform_unittests Review-Url: https://codereview.chromium.org/2621393003 Cr-Commit-Position: refs/heads/master@{#443509}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fe8a3c8a5cdb..4bd198f6a85c $ git log fe8a3c8a5..4bd198f6a --date=short --no-merges --format='%ad %ae %s' 2017-01-12 bpastene devil: Push devil onto the path when running reset_usb.py manually. 2017-01-12 rnephew [BattOr] Update BattOr Agent binary in cloud storage. BUG=679375 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2631643002 Cr-Commit-Position: refs/heads/master@{#443508}
-
qinmin authored
mStarted is set on UI thread, so we shouldn't check it on other threads. And there is no point to check it at the beginning of the test since it is always false. BUG=680533 Review-Url: https://codereview.chromium.org/2629703002 Cr-Commit-Position: refs/heads/master@{#443507}
-
yhirano authored
A ThreadableLoader must be completed before it's destructed. We need to forbid to create ThreadableLoader multiple times in some classes to ensure that. This CL adds CHECKs to make sure that. BUG=667254 Review-Url: https://codereview.chromium.org/2629823002 Cr-Commit-Position: refs/heads/master@{#443506}
-
pfeldman authored
Review-Url: https://codereview.chromium.org/2623423004 Cr-Commit-Position: refs/heads/master@{#443505}
-
tbarzic authored
BUG=629223 Review-Url: https://codereview.chromium.org/2614663005 Cr-Commit-Position: refs/heads/master@{#443504}
-
wangxianzhu authored
Now move first paint notification code from GraphicsLayer CompositedLayerMapping into FrameView. BUG=657825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2623043002 Cr-Commit-Position: refs/heads/master@{#443503}
-
pfeldman authored
Review-Url: https://codereview.chromium.org/2626313002 Cr-Commit-Position: refs/heads/master@{#443502}
-
dcheng authored
BUG=none Review-Url: https://codereview.chromium.org/2626403002 Cr-Commit-Position: refs/heads/master@{#443501}
-
benwells authored
These tests are flaky because there is a delay between infobars being removed in the native InfobarManager, and this flowing through the the Java side of things. This change introduces a polling loop whenever an infobar is removed to account for this. BUG=678210 Review-Url: https://codereview.chromium.org/2621983003 Cr-Commit-Position: refs/heads/master@{#443500}
-
angelayang authored
This CL implements search by sending a query to the existing backend search and then updating the ui to reflect the search result. The bookmarks list will now either display the contents of a folder or the search results. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2614703003 Cr-Commit-Position: refs/heads/master@{#443499}
-
dcheng authored
Presumably this was used in the past, but it isn't used anymore except in the ScriptContextSet classifier. However, the classifier can use the world ID to accomplish the same thing, so just remove this and clean up a bunch of dead code. BUG=481699 R=haraken@chromium.org,peria@chromium.org,yukishiino@chromium.org TBR=jochen@chromium.org,rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2628053003 Cr-Commit-Position: refs/heads/master@{#443498}
-
rajendrant authored
Data reduction proxy is always allowed with primary and fallback mechanism. BUG=654438 Review-Url: https://codereview.chromium.org/2626963003 Cr-Commit-Position: refs/heads/master@{#443497}
-