GitLab

Bring some consistency to the CompilerVersion.xcconfig files.  They all now include REAL_PLATFORM_NAME in the relevant setting names.

Rubber-stamped by Sam Weinig.

git-svn-id: svn://svn.chromium.org/blink/trunk@93248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Regression:  On Lion, redirects lose HTTP authentication headers

Source/WebCore: 

Reviewed by Alexey Proskuryakov and Darin Adler.

This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,
assuming the redirected URL did not contain credentials directly.

Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
       http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
       http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

* platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

LayoutTests: 

These have to be in different paths to prevent credentials from leaking over from test to test.
Sad sad sad...
        
Reviewed by Alexey Proskuryakov.

* http/tests/misc/authentication-redirect-1: Added.
* http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect-expected.txt.
* http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect.html.
* http/tests/misc/authentication-redirect-1/resources: Added.
* http/tests/misc/authentication-redirect-1/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
* http/tests/misc/authentication-redirect-1/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
* http/tests/misc/authentication-redirect-2: Added.
* http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
* http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html: Added.
* http/tests/misc/authentication-redirect-2/resources: Added.
* http/tests/misc/authentication-redirect-2/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
* http/tests/misc/authentication-redirect-2/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
* http/tests/misc/authentication-redirect-3: Added.
* http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.
* http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html: Added.
* http/tests/misc/authentication-redirect-3/resources: Added.
* http/tests/misc/authentication-redirect-3/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
* http/tests/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php: Added.
* http/tests/misc/authentication-redirect-3/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
* http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
* http/tests/misc/authentication-sent-to-redirect.html: Removed.
* http/tests/misc/resources/auth-echo.php: Removed.
* http/tests/misc/resources/auth-then-redirect.php: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@93247 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=65174

Reviewed by Darin Adler.

Forgot to commit review comments.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):



git-svn-id: svn://svn.chromium.org/blink/trunk@93246 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66396

Reviewed by Chang Shu.

Converted the test.

* editing/inserting/insert-3786362-fix-expected.txt: Added.
* editing/inserting/insert-3786362-fix.html:
* platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/chromium-win/editing/inserting/insert-3786362-fix-expected.txt: Removed.
* platform/gtk/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/gtk/editing/inserting/insert-3786362-fix-expected.txt: Removed.
* platform/mac-leopard/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/mac/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/mac/editing/inserting/insert-3786362-fix-expected.txt: Removed.
* platform/qt/editing/inserting/insert-3786362-fix-expected.txt: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=65174

Source/WebCore: 

Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject
creation flow. That can lead to loops.
   
Reviewed by Darin Adler.

Tests: accessibility/crash-determining-aria-role-when-label-present.html

* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
* accessibility/AccessibilityRenderObject.h:

LayoutTests: 

Reviewed by Darin Adler.

* accessibility/crash-determining-aria-role-when-label-present-expected.txt: Added.
* accessibility/crash-determining-aria-role-when-label-present.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@93243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66410

Reviewed by Adam Barth.

Some of these names will change back once we turn on Skia bots.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:


git-svn-id: svn://svn.chromium.org/blink/trunk@93242 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66343

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.

git-svn-id: svn://svn.chromium.org/blink/trunk@93241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order

Reviewed by David Kilzer.

* Scripts/run-api-tests:
(runAllTests):
(runAllTestsInSuite):
Sort the lists of tests and suites before iterating over them.

git-svn-id: svn://svn.chromium.org/blink/trunk@93240 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66353

Reviewed by Kenneth Russell.

If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.
Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,
drawLayers() has to return without doing anything if the root layer is null.

Crash fixed based on crash reports.  No known reliably repro case, unfortunately.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):

git-svn-id: svn://svn.chromium.org/blink/trunk@93239 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66107

Reviewed by Gavin Barraclough.

Hardened the CodeBlock::dump() code so that it no longer crashes.  Improved
the DFG verbose code so that it prints slightly more useful information.

* assembler/LinkBuffer.h:
(JSC::LinkBuffer::debugSize):
* bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfRegExps):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):


git-svn-id: svn://svn.chromium.org/blink/trunk@93238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66402

Reviewed by Dave Hyatt.

Source/WebCore: 

Test: fast/text/midword-break-before-surrogate-pair-2.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word
break before a trailing surrogate.

LayoutTests: 

* fast/text/midword-break-before-surrogate-pair-2.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@93237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66204

Reviewed by Dimitri Glazkov.

This patch introduces a new view for displaying expect, actual, and
differences between results.  The new view also has a fledgling
controller that handles some basic operations.  The new view is
exercised by rebaseline.html, which lets you rebaselines expected
failures, but the new view is not fully integrated into
garden-o-matic.html

More patches will be required to make this stuff fully working, but
this patch was already somewhat spiraling out of control.  Hopefully
this patch will serve as a good starting point for further development.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93236 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        New tests will be added when function reset is implemented.

        Added framework code in WebCoreTestSupport. The real implementation of
        Internals::reset() depends on the need from the settings that require a reset.

        * testing/Internals.cpp:
        (WebCore::Internals::reset):
        * testing/Internals.h:
        * testing/js/WebCoreTestSupport.cpp:
        (WebCoreTestSupport::resetInternalsObject):
        * testing/js/WebCoreTestSupport.h:
        * testing/v8/WebCoreTestSupport.cpp:
        (WebCoreTestSupport::resetInternalsObject):
        * testing/v8/WebCoreTestSupport.h:

2011-08-16  Chang Shu  <cshu@webkit.org>

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        Added framework code in WebKit.

        * public/WebTestingSupport.h:
        * src/WebTestingSupport.cpp:
        (WebKit::WebTestingSupport::resetInternalsObject):

2011-08-16  Chang Shu  <cshu@webkit.org>

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        Added framework code in WebKit.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::resetInternalsObject):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-08-16  Chang Shu  <cshu@webkit.org>

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        Added call to resetInternalsObject in DRT.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):



git-svn-id: svn://svn.chromium.org/blink/trunk@93235 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93234 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66393

Reviewed by Darin Adler.

* Shared/mac/CoreAnimationRenderer.h: Removed.
* Shared/mac/CoreAnimationRenderer.mm: Removed.
* Shared/mac/ShareableSurface.cpp: Removed.
* Shared/mac/ShareableSurface.h: Removed.
* WebKit2.xcodeproj/project.pbxproj:


git-svn-id: svn://svn.chromium.org/blink/trunk@93233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
* platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.

These results were checked in to platform/win but were really XP-specific.

* platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
Updated these results for Windows 7.

git-svn-id: svn://svn.chromium.org/blink/trunk@93232 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66392

Modify the config file to include the new build slave.

Reviewed by Adam Roben.

* BuildSlaveSupport/build.webkit.org-config/config.json:


git-svn-id: svn://svn.chromium.org/blink/trunk@93231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

on linux debug.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93230 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and the WebCore.gypi file wasn't updated.

* WebCore.gypi:

git-svn-id: svn://svn.chromium.org/blink/trunk@93229 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

* public/WebFrameClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

git-svn-id: svn://svn.chromium.org/blink/trunk@93228 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

When node is getting destroyed and its removedFromDocument
is not called due to entire document structure torn down(using
removeAllChildren), make sure to clear out the stylesheet
candidate node from document's structures in its destructor.

Test: svg/dom/stylesheet-candidate-node-crash-main.html

* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::~HTMLStyleElement):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::~SVGStyleElement):

LayoutTests: Tests that we do not crash when iterating through stylesheet
candidate list hashset.
https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

* svg/dom/resources/stylesheet-candidate-node-crash.svg: Added.
* svg/dom/stylesheet-candidate-node-crash-main-expected.txt: Added.
* svg/dom/stylesheet-candidate-node-crash-main.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93227 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66180

Updated accessibilityTable to return level values consistent with other accessibilityObjects that
return level values. This means a value of 0 is now only returned when tableLevel() is called on a
non-table element.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/element-level.html

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableLevel):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

Added the ability to get numeric attribute values using numberAttributeValue. This
function complements the existing stringAttributeValue and boolAttributeValue functions.
The addition of numberAttributeValue was necessary because the stringAttributeValue
function does a type check and will only return strings. This limitation made it
impossible to get values for attributes that returned an NSNumber.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

* DumpRenderTree/AccessibilityUIElement.cpp:
(numberAttributeValueCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::numberAttributeValue):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::numberAttributeValue):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::numberAttributeValue):

LayoutTests: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

This test ensures that all AccessibilityObjects that return a level value return consistent results.
For example, a level of 0 should only be returned by a level function when it is called on an
AccessibilityObject of the wrong type. It's especially important that we enforce this consistency
using layout tests because these level values are not defined by the W3C but are still used by
popular screen readers such as VoiceOver.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

* platform/mac/accessibility/element-level-expected.txt: Added.
* platform/mac/accessibility/element-level.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93226 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

* public/WebFrameClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

git-svn-id: svn://svn.chromium.org/blink/trunk@93225 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
revisions than that.

Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
relevant revisions

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
a single page.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
Updated tests for the above.

git-svn-id: svn://svn.chromium.org/blink/trunk@93224 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
bug about itself is broken

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
the host from the path.

git-svn-id: svn://svn.chromium.org/blink/trunk@93223 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
that caused it not to run any tests at all (as happened for a while due to
<http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Test for the above.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.

git-svn-id: svn://svn.chromium.org/blink/trunk@93222 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=64626

Reviewed by Darin Adler.

Source/WebCore: 

The bug was caused by willBeModified's always using block direction to determine
the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
in willBeModified, which will return the text direction of the surrounding context when
the start and the end have the same direction. When the text directions at the start and at the end
of selection do not match, it uses the block's text direction.

Test: editing/selection/collapse-selection-in-bidi.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::directionOfSelection): Added.
(WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.
* editing/FrameSelection.h:

LayoutTests: 

Added a test to ensure collapsing directionless selection respects the direction of text around
the selection's end points.

* editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* editing/selection/collapse-selection-in-bidi.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@93221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66326

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Chang.

* public/WebIDBTransactionCallbacks.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@93220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66352
        
Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
        
While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.
        
Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
I just re-sorted the project in r93215.

Reviewed by Eric Carlson.

No new tests; no functional change.

* WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.

* WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.

* WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.

* platform/graphics/avfoundation/cf: Added.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.

* platform/graphics/avfoundation/objc: Added.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.


git-svn-id: svn://svn.chromium.org/blink/trunk@93219 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66022

Reviewed by Darin Adler.

No new tests. Refactoring only.

Reduces instances where the font information is dirtied to save recalculation where it is not necessary.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Call new setTextSizeAdjust function.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setTextSizeAdjust):
Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setTextSizeAdjust):
Make setTextSizeAdjust return true if the unlderlying value was changed.


git-svn-id: svn://svn.chromium.org/blink/trunk@93218 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://trac.webkit.org/changeset/93204
https://bugs.webkit.org/show_bug.cgi?id=66375

Test no longer crashing since r93171

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93217 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=66211

Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.

Reviewed by Tony Chang.

No new tests; no functional change.

* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::releaseCachedHarfbuzzFace): Changed the argument.
(WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.
* platform/graphics/chromium/HarfbuzzSkia.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@93216 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

* WebCore.vcproj/WebCore.vcproj:



git-svn-id: svn://svn.chromium.org/blink/trunk@93215 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
* platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

media/media-blocked-by-beforeload.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93213 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@93212 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/win/Skipped: Added fast/dom/shadow/tree-scope-crash.html.

git-svn-id: svn://svn.chromium.org/blink/trunk@93211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=65558

Add TIMEOUT expectation.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Failure is tracked by <http://webkit.org/b/66376>.

* platform/win/fast/text/international/text-combine-image-test-expected.png:
* platform/win/fast/text/international/text-combine-image-test-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Failure is tracked by <http://webkit.org/b/66374>.

* platform/win/editing/deleting/regional-indicators-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@93208 bbb929c8-8fbe-4397-9dbb-9b2b20218538