- 03 Mar, 2015 40 commits
-
-
zhenw authored
CL https://crrev.com/902763002/ enables parallel telemetry unit tests. This CL will test how it works on FYI bot "Android Tests (K N5, user build)(dbg)" http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20(K%20N5%2C%20user%20build)(dbg) BUG=379378 Review URL: https://codereview.chromium.org/941793002 Cr-Commit-Position: refs/heads/master@{#318953}
-
dpranke authored
This picks up: Roll the GN binaries to #318791. Roll the GN binaries from 317120:318791 (from git 74add9fc to 3d7a60db). This fixes 'gn clean' and picks up some new features for introspections (see #317159). TBR=brettw@chromium.org BUG=430215 Review URL: https://codereview.chromium.org/965963002 Cr-Commit-Position: refs/heads/master@{#318952}
-
tommycli authored
Enhances accessibility of throttled plugins. This enables these steps: 1. Using ChromeVox, focus throttled plugin using Alt+Shift+Arrow Keys. 2. Press ENTER or SPACE. BUG=458285 Review URL: https://codereview.chromium.org/977653002 Cr-Commit-Position: refs/heads/master@{#318951}
-
oshima authored
BUG=450711 Review URL: https://codereview.chromium.org/967403005 Cr-Commit-Position: refs/heads/master@{#318950}
-
Daniel Xie authored
this may be casuing an increase in rendererexit code. BUG=463646 This reverts commit 0197d5df. Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src This is causing a huge amounts of renderer crashes because of RESULT_CODE_KILLED_BAD_MESSAGE. Reverting this from master. Revert "<webview>: Removed ResolveURL" This reverts commit c2fc6144. Cr-Commit-Position: refs/heads/master@{#318949}
-
paulmeyer authored
Fix for MIME handler bug. The bug resulted from a previous bugfix (https://codereview.chromium.org/939443002/) that added a conversion from logical to physical units to fix a similar sizing bug with other guestviews. However, MIME handler guests never use logical pixels, so this conversion broke their sizing when they are created in a zoomed embedder. This patch adds a more robust method of checking whether sizes are provided in logical or physical units, and all cases are handled appropriately. BUG=462194 Review URL: https://codereview.chromium.org/972193003 Cr-Commit-Position: refs/heads/master@{#318948}
-
thakis authored
Revert of Temporarily move android_rel_tests_recipe to 100% experiment to unblock CQ (patchset #1 id:1 of https://codereview.chromium.org/973063002/) Reason for revert: clang roll got reverted, this should no longer be needed Original issue's description: > Temporarily move android_rel_tests_recipe to 100% experiment to unblock CQ > > TBR=machenbach > > BUG=463436 > > Committed: https://chromium.googlesource.com/chromium/src/+/064e04615cf8557e63c10aa7917ea23341116fa0 TBR=machenbach@chromium.org,phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463436 Review URL: https://codereview.chromium.org/975093002 Cr-Commit-Position: refs/heads/master@{#318947}
-
lof84 authored
This patch is just a small refactor from https://codereview.chromium.org/959283004/ R=danakj, enne Review URL: https://codereview.chromium.org/977533002 Cr-Commit-Position: refs/heads/master@{#318946}
-
wesleylancel authored
- Submit on tab - Do nothing when field is empty BUG=457585 Review URL: https://codereview.chromium.org/960863002 Cr-Commit-Position: refs/heads/master@{#318945}
-
dnicoara authored
The name of the file for OzoneGpuTestHelper was incorrect. BUG=none TEST=Built Ozone with a GN build Review URL: https://codereview.chromium.org/978473002 Cr-Commit-Position: refs/heads/master@{#318944}
-
nednguyen authored
After https://codereview.chromium.org/966283002, https://codereview.chromium.org/926213002, https://codereview.chromium.org/927763002, all the pages used with raterize_and_record_micro do not issue any interactions in RunPageInteractions method, should this change should not cause any functional changes to how the pages get run. BUG=418375 Review URL: https://codereview.chromium.org/973173002 Cr-Commit-Position: refs/heads/master@{#318943}
-
Newton Allen authored
The NewApi warning complains when we use APIs added to Android after ICS because these will causes crashes on older versions of Android. This reenables this helpful warning and whitelists the files that currently trigger the warning. Follow-up CLs will fix these whitelisted warnings (i.e. by fixing the code if it's broken, or adding the @TargetApi annotation) BUG=266140 R=aurimas@chromium.org Review URL: https://codereview.chromium.org/969213002 Cr-Commit-Position: refs/heads/master@{#318942}
-
servolk authored
For Chromecast we want to choose which media renderer to use based on the types of input content streams. We will use CMA media renderer for media types that are supported by our hardware (H264, AAC, etc) and will use the default media renderer for audio streams other than AAC or Vorbis. This will allow us support software decoding of FLAC and Opus via the default Chrome audio path. BUG=457959 Review URL: https://codereview.chromium.org/973633002 Cr-Commit-Position: refs/heads/master@{#318941}
-
hans authored
It seems the roll broke Android tests, see crbug.com/463436. Also, fix common.gypi to add a dependency on the Clang version when host_clang is set. We think this might be the reason the breakage didn't show on trybots when the roll landed: the host binaries weren't recompiled with the new Clang version. BUG=444089, 463436 NOTRY=true NOPRESUBMIT=true TBR=jln, jbauman Review URL: https://codereview.chromium.org/976833002 Cr-Commit-Position: refs/heads/master@{#318940}
-
rvargas authored
BUG=417532 Review URL: https://codereview.chromium.org/957183002 Cr-Commit-Position: refs/heads/master@{#318939}
-
joaoe authored
The extensions::Dispatcher::is_extension_process flag is set for both the standalone extensions renderer and single process mode. This caused ChromeContentRendererClient to act differently in single process mode, like returning true from ShouldFork for any navigation started by blink, which would cause a new WebView to be created for each navigation. BUG=462210 Review URL: https://codereview.chromium.org/956313002 Cr-Commit-Position: refs/heads/master@{#318938}
-
aurimas authored
BUG=428842 Review URL: https://codereview.chromium.org/976493003 Cr-Commit-Position: refs/heads/master@{#318937}
-
tommycli authored
BUG=458541 Review URL: https://codereview.chromium.org/974633002 Cr-Commit-Position: refs/heads/master@{#318936}
-
mednik authored
BUG=463552 Review URL: https://codereview.chromium.org/977583003 Cr-Commit-Position: refs/heads/master@{#318935}
-
spang authored
Update LED state in kernel in InputControllerEvdev::SetCapsLockEnabled. This is currently the only way to toggle caps lock. BUG=463242 TEST=plug in external keyboard on link_freon & press caps lock. Light on keyboard should turn on. Review URL: https://codereview.chromium.org/971753006 Cr-Commit-Position: refs/heads/master@{#318934}
-
aurimas authored
CL https://codereview.chromium.org/950223002 did not move all the densities of ic_warning.png to components/ BUG=458328 TBR=tedchoc@chromium.org Review URL: https://codereview.chromium.org/970113003 Cr-Commit-Position: refs/heads/master@{#318933}
-
sbc authored
This file is not supposed to be part of libgtest but in its own library called libgtest_main.a. Its also fairly useless right now in the context of PPAPI (all our gtest examples currently use ppapi_simple and define their own entry point). In the long run we could re-enable this if it becomes useful, but really we should probably just remove the gtest libraries from the SDK completely since shipping gtest in library form is not recommended practice. Review URL: https://codereview.chromium.org/958233004 Cr-Commit-Position: refs/heads/master@{#318932}
-
vmpstr authored
This patch is just a small refactor with a few more comments explaining what this function is meant to do. I've been confused in the past when trying to remember what this function does, so hopefully this helps... R=danakj, enne Review URL: https://codereview.chromium.org/973713002 Cr-Commit-Position: refs/heads/master@{#318931}
-
wnwen authored
BUG=450050 Review URL: https://codereview.chromium.org/975453003 Cr-Commit-Position: refs/heads/master@{#318930}
-
derekjchow authored
BUG=internal b/19212285 R=lcwu@chromium.org Review URL: https://codereview.chromium.org/961993006 Cr-Commit-Position: refs/heads/master@{#318929}
-
rohitrao authored
This CL reduces unnecessary work in StatusBubbleMac and replaces it with some DCHECKs to verify invariants. (The invariant here is that we set kWindowSizeDeterminedLater once, when state is set to kBubbleHidden, and the size stays that way until the bubble transitions to a different state. If that invariant holds, then we don't need to constantly re-set the size for a hidden bubble.) BUG=None TEST=No visible impact. Status bubble should continue to show, expand, and hide properly. Review URL: https://codereview.chromium.org/968263005 Cr-Commit-Position: refs/heads/master@{#318928}
-
shrike authored
The code in [DownloadItemController showDangerousWarning:] calls [GTMUILocalizerAndLayoutTweaker sizeToFitFixedHeightTextField:minWidth:] to wrap the warning string within the DownloadItemController's dangerousDownloadLabel_ textField. Within the nib this textField is 22 points tall and holds two lines of text. Under Yosemite, however, the font metrics have changed and the two lines are now 24 points tall. This cl insets the dangerousDownloadLabel_'s frame height by -2 points when running on Yosemite. dangerousDownloadLabel_ is not as tall as its superview, so the new frame still fits comfortably within the superview's frame. BUG=454782 TEST=Follow instructions in bug 454782 and confirm that text is wrapping properly on Yosemite. Review URL: https://codereview.chromium.org/911303002 Cr-Commit-Position: refs/heads/master@{#318927}
-
megjablon authored
A telemetry test that checks for "q=low" in the Chrome-Proxy request header and verifies that the image received was less than 100 bytes. BUG=449665 Review URL: https://codereview.chromium.org/942863004 Cr-Commit-Position: refs/heads/master@{#318926}
-
jamuraa authored
Have BluetoothAdapterProfileChromeOS remove itself from adapters when it is deleted via it's deconstructor, to avoid references being left behind after deletion. BUG=457978 Review URL: https://codereview.chromium.org/935383003 Cr-Commit-Position: refs/heads/master@{#318925}
-
tfarina authored
This is necessary because GN's exec_script only runs Python scripts. This was requested by Nico in https://codereview.chromium.org/971593003/. BUG=462972 TEST=run ./tools/clang/scripts/plugin_flags.py and compare the output with the bash version. They should be exactly the same. R=thakis@chromium.org Review URL: https://codereview.chromium.org/966723003 Cr-Commit-Position: refs/heads/master@{#318924}
-
sclittle authored
The flag for specifying the URL for the Data Saver secure proxy check was changed in https://codereview.chromium.org/961983002/. This change makes the relevant integration test use the new flag value, and also makes the test restart after each page. BUG=463210 Review URL: https://codereview.chromium.org/971073002 Cr-Commit-Position: refs/heads/master@{#318923}
-
servolk authored
Since DefaultRendererFactory uses GPU factories, code that instantiates the default factory need to include GPU factories headers and need to be able to instantiate them as well, so moving the GPU factories (both the mock and the real one) to media/renderers/ to make deps easier. BUG=457959 Review URL: https://codereview.chromium.org/970023002 Cr-Commit-Position: refs/heads/master@{#318922}
-
dcaiafa authored
BUG=462072 Review URL: https://codereview.chromium.org/964723003 Cr-Commit-Position: refs/heads/master@{#318921}
-
alemate authored
BUG=463150 TEST=manual Committed: https://crrev.com/ae10a9150af37a77ed8e9a71b19ad441d48f1cc7 Cr-Commit-Position: refs/heads/master@{#318866} Review URL: https://codereview.chromium.org/973003002 Cr-Commit-Position: refs/heads/master@{#318920}
-
edwardjung authored
BUG=462299 Review URL: https://codereview.chromium.org/972143002 Cr-Commit-Position: refs/heads/master@{#318919}
-
nednguyen authored
BUG=444697 Review URL: https://codereview.chromium.org/965953002 Cr-Commit-Position: refs/heads/master@{#318918}
-
jeremyim authored
The current mechanism is to create an instance of DataReductionProxyParams inside of page_load_histogram, and to then check the proxy server inside of DocumentState against DataReductionProxyParams. However, the plan is to make the configuration dynamic, so we can no longer use DataReductionProxyParams. BUG=452773 Review URL: https://codereview.chromium.org/966443002 Cr-Commit-Position: refs/heads/master@{#318917}
-
sullivan authored
BUG= Review URL: https://codereview.chromium.org/976673002 Cr-Commit-Position: refs/heads/master@{#318916}
-
arv authored
ES6 makes the function name property configurable, which means that __defineGetter__ will add a getter and not silently fail like before. This change is in preparation of landing this feature in V8. BUG=463526 R=kalman@chromium.org Review URL: https://codereview.chromium.org/971343003 Cr-Commit-Position: refs/heads/master@{#318915}
-
rpaquay authored
BUG=358315 Review URL: https://codereview.chromium.org/926703002 Cr-Commit-Position: refs/heads/master@{#318914}
-