- 27 Jun, 2018 40 commits
-
-
Sahel Sharify authored
With wheel scroll latching enabled, wheel dom events in a scroll sequence are sent to the target which was under the cursor at the beginning of the scroll and retargeting happens either on the beginning of the next scroll sequence or when the target gets deleted in the middle of the current scroll sequence. With this cl if an event gets prevented by default, the wheel target gets reset to make sure that a new targeting happens for the next wheel event. Bug: 829662 Test: AsyncWheelEventsBrowserTest.WheelEventRetargetOnPreventDefault Change-Id: Id60476ae0772a53e938cf8738283576a8083f6a4 Reviewed-on: https://chromium-review.googlesource.com/1113666 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570768}
-
Hwanseung Lee authored
should throw an InvalidStateError when buffer has been already set in ConvolverNode Bug: 709656 Change-Id: Ia0826f9ffa2e180da1311f4cded8ff7fe5461147 Reviewed-on: https://chromium-review.googlesource.com/1077713Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#570767}
-
Koji Ishii authored
fast/text/emphasis-overlap.html fails in LayoutNG because what it is testing works correctly, but LayoutNG fixed crbug.com/40634 and that difference caused pixels to fail. This patch removes dependency to crbug.com/40634 behavior from the test, and hence it passes in LayoutNG. The behavior of crbug.com/40634 is now split to wpt/css/css-text/white-space/trailing-space-before-br-001.html in r570744 (CL:1116622). TBR=eae@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8acfa36f83bac02ae71bd8907e733f05ecf359fe Reviewed-on: https://chromium-review.googlesource.com/1116511Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570766}
-
Jan Krcal authored
This CL creates the bridge for the autofill_profile sync type. It only implements reacting to local changes, applying sync changes will be implemented in a follow-up CL. The CL only converts relevant unit-tests from AutofillProfileSyncableServiceTest. Tests corresponding to ProfileSyncServiceAutofillTest will come in later CLs. Bug: 836718 Change-Id: Ic91fad53a0623be416ceb4c1f96451c732cf5ac3 Reviewed-on: https://chromium-review.googlesource.com/1113187Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570765}
-
Vaclav Brozek authored
This CL teached the FormData -> PasswordForm parser to prevent the conclusion that there is a confirmation password field on a form which has no new password field. This state does not correspond to reality. Therefore this CL adds a DCHECK to verify this and also a sanitization step for processing the server data. Bug: 845426 Change-Id: I6ffffb31766f9271f0f8021f3aa249d1ee163730 Reviewed-on: https://chromium-review.googlesource.com/1116920Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570764}
-
codeimpl authored
The spec[1] says that the boundingBox attribute should be DOMRectReadOnly instead of DOMRect. [1] https://github.com/WICG/shape-detection-api/pull/41 Bug: 852838 Change-Id: I8666d56fcaf4ac77c29b497827b410ec0aeaa916 Reviewed-on: https://chromium-review.googlesource.com/1102838Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#570763}
-
Tiger Oakes authored
supersize html_report (in //tools/binary_size) is being redesigned to use a tree view to make it easier to navigate. Tree views are more familiar to users and open up additional features we plan to add, such as rendering size diffs by showing negative values. Symbols and files in the tree are organized by size, with larger items on top. You can preview an example report at: https://notwoods.github.io/chrome-supersize-reports/ Alternatively, compile your own report by running: ``` tools/binary_size/supersize html_report chrome.size --tree-view-ui --report-dir size-report -v xdg-open size-report/index.html ``` Design Doc: go/supersize-tree-view-ui Bug: 847599 Change-Id: I78add67bbc759903b1717585a9463dfd08dacceb Reviewed-on: https://chromium-review.googlesource.com/1113848 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570762}
-
Raphael Kubo da Costa authored
Back in early 2016, some tests were marked flaky and whatever was causing the flakiness has since been fixed -- they are currently failing because the existing expectations no longer match the results that are produced. Rebaseline the tests and remove them from TestExpectations as per the discussion in the bug, while also adjusting some of the tests in the process: * fast/events/scale-and-scroll-iframe-body.html: Explicitly disable scrollbars in the iframe after http://crrev.com/398951, otherwise we end up with platform-specific PNG expectations due to the differences in the scrollbars. * fast/events/updateLayoutForHitTest.html: Avoid confusion by removing some style assignments that had been causing console errors ever since the test was added more than 10 years ago. Bug: 594672 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I24264f86ce1dcebdac2a6a9f912d3b292d39bdc0 Reviewed-on: https://chromium-review.googlesource.com/1113310Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#570761}
-
Adithya Srinivasan authored
Makes the tests simpler in many cases and also removes the -expected files. Bug: 781655 Change-Id: I15957ca318c56f4904bb68bc085880e70823d202 Reviewed-on: https://chromium-review.googlesource.com/1111910 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570760}
-
Juan Antonio Navarro Perez authored
Test flaky in: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-marshmallow-arm64-rel TBR=ntfschr@chromium.org,changwan@chromium.org,boliu@chromium.org Bug: 855732 Change-Id: If4fe61aa767bd92229692bddb4659901fa5b2da5 Reviewed-on: https://chromium-review.googlesource.com/1117065Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#570759}
-
edchin authored
This CL implements these metrics in tab grid: MobileStackViewCloseTab when a tab is closed via the X MobileToolbarStackViewNewTab when a new tab is created (only through the + button.) MobileTabReturnedToCurrentTab when users exit the tab switcher to return to the current foreground tab MobileStackViewNormalMode when user switches between regular & incognito MobileStackViewIncognitoMode when user switches between regular & incognito Bug: 818452 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I570a31af65bc929f646d005789cecb1a0afca442 Reviewed-on: https://chromium-review.googlesource.com/1116284Reviewed-by:edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570758}
-
A Olsen authored
Certain policies contain JSON - that is, for the admin to use them properly, they should set them to a JSON string that conforms to a particular schema. Until this change, that JSON was not being validated, and errors were not getting reported to the user. This CL enables validation for two JSON policies - DefaultPrinterSelection and AutoSelectCertificateForUrls. It uses a histogram to track how often these policies contain any errors, and it reports any errors encountered to the user in chrome://policy. However, it does not actually reject any policies unless they have the wrong root type. This is by design since the code that reads these policies is already robust. Didn't work on Android at first since these policies don't exist there - this is fixed by guarding these handlers with an #ifdef. Bug: 834804 Change-Id: I64100ab3bcab07c6f4c2c53117cc4e9225a609e8 Reviewed-on: https://chromium-review.googlesource.com/1106158 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#570757}
-
Juan Antonio Navarro Perez authored
Test has been flaky on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester TBR=klausw@chromium.org,mthiesse@chromium.org Bug: 856546 Change-Id: I25d4a94ea0e5a535dd960574432ad2ade882c0df Reviewed-on: https://chromium-review.googlesource.com/1117062Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#570756}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77083c1d94991640839f1d3e820359dc3088f070 Reviewed-on: https://chromium-review.googlesource.com/1116978 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570755}
-
Arthur Sonzogni authored
When the FrameLoader start a new load. It replaces the current provisional DocumentLoader by a new one. Removing the first one can leave the frame without any loading DocumentLoader and triggers the 'load' event, which can detach the frame. The bug was caused by: https://chromium-review.googlesource.com/c/chromium/src/+/1107808 where the line checking whether the frame was detached or not was removed. It is now clear why this line was useful, so this CL adds it back. Bug: 856396 Change-Id: I1bdeb47e546dbb1805659bc986d590e9900c51d1 Reviewed-on: https://chromium-review.googlesource.com/1114975Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570754}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97cb0ea3..b0de1093 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I48feb17d11ff526f8c82109c6834ac48df343dda Reviewed-on: https://chromium-review.googlesource.com/1116859Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570753}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f989b62823cb..484f9f764dc5 git log f989b62823cb..484f9f764dc5 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 sarath.singapati@huawei.com Corrected the traffic settings to reflect the settings by devtool. Created with: gclient setdep -r src/third_party/catapult@484f9f764dc5 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7fd748d18e27b813ac3018107ff3aafcba82f34c Reviewed-on: https://chromium-review.googlesource.com/1116820Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570752}
-
Greg Thompson authored
One ctor was leaving the hovering_ member in a non-deterministic state. BUG=855979 TBR=nzolghadr@chromium.org Change-Id: I4b49426d08940cd24bb31039bfa5a75b14aadb6d Reviewed-on: https://chromium-review.googlesource.com/1116788Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570751}
-
Miguel Casas authored
This reverts commit c1ee5625. Reason for revert: The necessary predecessor crrev.com/c/1104394 has been reverted (for other reasons, see crbug.com/822346#c33) Original change's description: > vaapi: decode on client NativePixmaps > > This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving > a buffer copy and removing a costly blit (DownloadFromSurface) on the > GPU Main thread. Three groups of changes: > > 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a > VaapiPicture with a VASurfaceID, we use those to decode onto and set a new > flag: |decode_using_client_picture_buffers_| > > 2. When the decoder calls CreateVASurface(), instead of giving it the first > |available_va_surfaces_|, we need to figure out the first VASurfaceID in > this |available_va_surfaces_| such that the corresponding VaapiPicture in > |pictures_| is available (i.e. in |available_picture_buffers_|). > Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one > correspondence like on ToT. > > 3. When we're ready to OutputPicture() to |client_|, instead of using the first > |available_picture_buffers_|, we find the corresponding one for the > passed |va_surface_id| (we could search all over |pictures_| but there's > always less |available_picture_buffers_|. > > Some other notable developments: > > - s/output_buffers_/available_picture_buffers_/ > - OutputPicture() loses a parameter. > - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2 > or the ImportBufferForPicture() path. > - Pictures is made a base::small_map. (Originally from crrev.com/c/988512). > > Bug: 822346, 717265 > Test: v_d_a_unittest vp8/vp9/h264 passing on eve, running crosvideo changing > resolutions for a long time. No hickups, no dropped frames. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I3d5a4d3c83002c8d0977702c9b97ffec52b1db23 > Reviewed-on: https://chromium-review.googlesource.com/1021675 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568880} TBR=mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822346, 717265 Change-Id: I5e8cb9431f72a65f67782e59cb5ce52f7e1d4ce7 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1116938Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#570750}
-
W. James MacLean authored
Since the context menu can be dispatched an arbitrary time after the mouse event that sets last_mouse_move_target_, we should verify the pointer is still valid by making sure it's still in the owner's map. Bug: 856976 Change-Id: I928935b74d6fa99ba7769fa170a9c817f98d5a46 Reviewed-on: https://chromium-review.googlesource.com/1116862Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#570749}
-
Rohit Rao authored
The card style is now disabled behind a new IsSettingsUIRebootEnabled() experimental flag. These changes were inadvertently landed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1114605. BUG=805213 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7c22b635199810bab3332443e8a9251c073ca245 Reviewed-on: https://chromium-review.googlesource.com/1116919Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#570748}
-
chrome://translate-internalsNicolas Ouellet-payeur authored
This should make it easier to debug Translate internals. UI changes: 1. Add 'translate_recent_target' to the Preferences dump in the translate-internals page. 2. Add a box for the user to enter a new value for 'translate_recent_target', and an 'update' button. When the user clicks the button, the preference is updated. Bug: 855176 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I97437c792c8b6efb73bdb6d1c21f05c5ffff7d8a Reviewed-on: https://chromium-review.googlesource.com/1110739Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#570747}
-
Sam Maier authored
Bug: 749239 Change-Id: Id7b49e187deb91d8201d45029f58ef84f97fae3e Reviewed-on: https://chromium-review.googlesource.com/1115515Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#570746}
-
Noel Gordon authored
Flakes in RELEASE on linux-chromeos-rel CQ bot. Tbr: tapted Bug: 850372,857021 Change-Id: I548307fa8a93689a348f2e96504815e3fe27cf44 Reviewed-on: https://chromium-review.googlesource.com/1116879Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570745}
-
Koji Ishii authored
Blink and WebKit fails to remove trailing spaces preceding `<br>`. This patch adds a test for that case. Gecko, Edge, and the current build of LayoutNG passes this test. This was originally reported at http://crbug.com/40634. It turns out that fast/text/emphasis-overlap.html relies on this behavior. Before removing the reliance, adding this test to ensure this case is covered and to prevent regressions in LayoutNG. TBR=eae@chromium.org Bug: 40634 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iff877bac1c27c8689bdbc6949d01a9ea380463bd Reviewed-on: https://chromium-review.googlesource.com/1116622 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570744}
-
stkhapugin@chromium.org authored
Uses new icons, adds a background for the icons, changes the icon offset to match the new omnibox layout. Bug: 821817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibdd074891eb1f4b0853c28b9117d1e84f05e070c Reviewed-on: https://chromium-review.googlesource.com/1114744Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570743}
-
Alexander Timin authored
Support temporarily increased priority for compositor tasks for input: - Explicit OnMainFrameRequestedForInput signal (new) - Implicit presence of input tasks. This patch does not change default behaviour, but add Finch hooks for enabling these options and controlling the number of tasks N. R=skyostil@chromium.org,alexclarke@chromium.org BUG=853771 Change-Id: Id82b712e46108c51a948a66cfd31556e04eb457a Reviewed-on: https://chromium-review.googlesource.com/1104677Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570742}
-
Kent Tamura authored
local_frame.h is used in 1,900+ compilation units, and this CL reduces its pre-processed size from 7.53MB to 4.48MB. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4f833b9994c8a5f4e950f446665135e23c92dc92 Reviewed-on: https://chromium-review.googlesource.com/1116408 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570741}
-
Marc Treib authored
The hope is that https://crrev.com/c/1116549 has resolved the flakiness. Let's see if it worked :) Bug: 850980 Change-Id: I12c8832aba6b735179abdeaa220c4634625be326 Reviewed-on: https://chromium-review.googlesource.com/1116780Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570740}
-
Greg Thompson authored
BUG=855800 TBR=lazyboy@chromium.org NOTRY=true Change-Id: I5eb0663724303fd7f7f2eb4b0feac36c82cc4421 Reviewed-on: https://chromium-review.googlesource.com/1116796Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570739}
-
Justin Cohen authored
Bug: 828002 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id9f533ff3ec912a20535cdda17de9eb61d28b946 Reviewed-on: https://chromium-review.googlesource.com/1114746 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570738}
-
Paul Jensen authored
Attempt to ping device via host network interfaces and see if device's RNDIS network interface's MAC address appears in host's ARP cache. This gets this script working on my laptop. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ieace3bbd424804824ca5ce5f36e8137598d922b4 Reviewed-on: https://chromium-review.googlesource.com/1112460Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570737}
-
Yuichiro Hanada authored
This layout manager makes kArcVirtualKeyboardContainer follow size changes of kArcImeWindowParentContainer. This CL puts the new class into ash/keyboard/arc and adds new separate build target for this directory. It's needed because I'm going to add more classes used from ash/wayland in this directory soon. Bug: 845079 Change-Id: I521369a99bf0f4ce7d85db18df8f2ce78c2509fe Reviewed-on: https://chromium-review.googlesource.com/1109451Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#570736}
-
Greg Thompson authored
BUG=855874 TBR=fdoray@chromium.org NOTRY=true Change-Id: I882e8d1a848e0f7d86ddbac4bc47b92715d94da0 Reviewed-on: https://chromium-review.googlesource.com/1116791 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570735}
-
Antonio Gomes authored
CL makes use of the sub-surface functionality to implement support for tooltips in Ozone/Wayland. A sub-surface has one parent surface, but its size and position are not limited to that of the parent. This means that, the content of a sub-surface is not automatically clipped to its parent's area. Additionally, by default, the input region of a sub-surface is empty. This causes all input events to be reported on the main surface, instead. TEST=Very basic UI feature: simply hover over any item that shows a tooltip. TBR=sadrul@chromium.org BUG=578890 Change-Id: I09a0eb7c79516a995cc3a4994f4959cf15b37736 Reviewed-on: https://chromium-review.googlesource.com/1110098 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570734}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3f5aed4332b..2c74d85c16af git log b3f5aed4332b..2c74d85c16af --date=short --no-merges --format='%ad %ae %s' 2018-06-27 srte@webrtc.org Adds enum field trial parser. Created with: gclient setdep -r src/third_party/webrtc@2c74d85c16af The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icebb7075253d5daf3dbab063fca78e7d87e9b7d9 Reviewed-on: https://chromium-review.googlesource.com/1116679Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570733}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 335608`. Bug: 855772 Change-Id: Idb1947be31a99371cbddaa7f214d64858ef15d9c Reviewed-on: https://chromium-review.googlesource.com/1114922Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570732}
-
Greg Thompson authored
BUG=856720 TBR=skyostil@chromium.org Change-Id: If7de573f6c64d4f04ff08e1a82793fc3fc021ed7 Reviewed-on: https://chromium-review.googlesource.com/1116786Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570731}
-
Maksim Sisov authored
This is a reland of 8f2591ae Original change's description: > [ozone/wayland] Manually handle fullscreen states. > > In order to ensure media files can enter fullscreen mode, manually > handle fullscreen states. Basically, a compositor sends configuration > events on each request for state changes from clients asynchronously, > which is unefficient for media files when they enter a fullscreen mode. > > For example, when a youtube video file is being set to fullscreen, a > WaylandWindow is also set to a fullscreen mode, but the return value from > the WaylandWindow::GetPlatformWindowState still contains an old value until > the compositor calls with a configuration event. This short race is > enough for a media content to be placed in a forever "entering fullscreen" > state, which never results in a fullscreen state for media files. > > Bug: 843018 > TEST: XdgVersionV5Test/WaylandWindowTest.SetFullscreenAndRestore/0 > XdgVersionV6Test/WaylandWindowTest.SetFullscreenAndRestore/0 > > Change-Id: Ib9bc8c0ce09412c36437d165efc6a0cad60c4d17 > Reviewed-on: https://chromium-review.googlesource.com/1107636 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#569172} Bug: 843018 Change-Id: I63866a785f5dca088aba70e500d85748b86e8a8c Reviewed-on: https://chromium-review.googlesource.com/1113238 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570730}
-
Alexander Timin authored
Do not save base::Thread reference in the CompositorThreadScheduler and post tasks to the scheduler default queue instead of using Thread::task_runner. R=alexclarke@chromium.org Change-Id: Idc05e3547316a5aaf6de487ec62e1be430b2499b Reviewed-on: https://chromium-review.googlesource.com/1115120Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570729}
-