- 06 Aug, 2018 19 commits
-
-
Kunihiko Sakamoto authored
This reverts commit 94558b66. Reason for revert: Findit thinks this made the following tests flaky: TabRestoreTest.RestoreWindowBounds (crbug.com/870945) BrowserNavigatorTest.Disposition_NewPopupFromAppPopup (crbug.com/871010) Original change's description: > [NTP] Adds an experiment for M69 NTP features. > > Only the first experiment entry gets covered by perf waterfall, so adding > this item ensures better test coverage. Also, the existing experiment, > NewTabPageAllBirthday_Enabled, could not be re-used since > go/revising-finch-configs recommends creating a new experiment when > changing size or behavior of existing groups. > > Bug: 831910 > Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5 > Reviewed-on: https://chromium-review.googlesource.com/1160925 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580314} TBR=holte@chromium.org,ramyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831910,870945,871010 Change-Id: Ifb86fbc322d939eba40f84b1ee32a21d76361f86 Reviewed-on: https://chromium-review.googlesource.com/1163361Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580806}
-
Takashi Toyoshima authored
Bug: none Change-Id: Ia12fd5e686b2642a37ac30a372d0a54394310e47 Reviewed-on: https://chromium-review.googlesource.com/1157962Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580805}
-
Dominic Farolino authored
There is no observable result of this change. Before this CL, ModuleScriptFetchRequest stored a blink::Referrer and a blink::ScriptFetchOptions. This effectively stored two blink::ReferrerPolicy members under ModuleScriptFetchRequest. We also generated ModuleScriptFetchRequest's Referrer in two different places in ModuleTreeLinker. Finally ModuleScriptFetchRequest's Referrer member was used in ModuleScriptLoader::FetchInternal to set ResourceRequest's referrer header. After this CL, we store only a referrer string in ModuleScriptFetchRequest, as the spec indicates, and do not generate a blink::Referrer in ModuleTreeLinker. Then in ModuleScriptLoader::FetchInternal, we generate and set ResourceRequest's final referrer. This also leaves a TODO, to stop storing ResourceRequest's referrer as a header value. R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org Bug: 863769 Change-Id: Id22467f5c93e59b33ca01571addeceb1a505a1af Reviewed-on: https://chromium-review.googlesource.com/1157237 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580804}
-
Yoichi Osato authored
Since "rendered position" is ambiguous, this patch renames it to simply the function name implemented in the file. Bug: 789870 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I98d310b092edc0983ec03012f32c81f60224d2e0 Reviewed-on: https://chromium-review.googlesource.com/1160070Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#580803}
-
Eric Willigers authored
Keywords for the following properties now serialize in lower case: - color-rendering - image-rendering - shape-rendering - text-rendering https://drafts.csswg.org/cssom/#serializing-css-values "To serialize a CSS component value depends on the component, as follows: keyword The keyword converted to ASCII lowercase." Firefox and Edge already serialize such properties in lower case. BUG=863741 Change-Id: Idca31224b0f0186d76ddca814ffb913d46c8a4f9 Reviewed-on: https://chromium-review.googlesource.com/1163047Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#580802}
-
Takashi Sakamoto authored
Bug: 810293 Change-Id: I0fdbb07ef9ebf78c964f9ffeb68dc21f9675bdb7 Reviewed-on: https://chromium-review.googlesource.com/1158112 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580801}
-
Andrew Moylan authored
ML Service is being configured to launch automatically via D-Bus service activation (crrev.com/c/1163227 and crrev.com/c/1163228), instead of launching at boot time. Therefore, we won't need to WaitForServiceToBeAvailable any more. Tested by: Test build with CrOS CLs above & a modified Chrome that calls ML Service a few times. Bug: 863781 Change-Id: I508ee505705de14332b1cdf4e5b0b29c04937c7b Reviewed-on: https://chromium-review.googlesource.com/1163229Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580800}
-
Devlin Cronin authored
Extract C++ type generation from the json_schema_api gni template into a separate generate_types gni template. This has the advantage of cleaning up which arguments are necessary and used for the template, as well as being able to isolate the different generation steps (which may have different dependencies or dependents). As part of this, introduce separate "bulk" `api` targets in each of the API directories, which each dependent can depend on. This obviates the need to depend on e.g. `api` and `api_registration`. A follow up will break up the JSON string generation bundle and the extension function registration bundle. Bug: 864576 Change-Id: I50a1fbe059ec5b7d73c405b230a221c1c6ce3af1 Reviewed-on: https://chromium-review.googlesource.com/1150930 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580799}
-
Jia authored
We will need the same bucketization during inference. Hence move common code to the helper file to avoid code duplication and also to ensure consistency. Bug: 862461 Change-Id: I75e53c6a409ce7f61383637b783158abd7f59e32 Reviewed-on: https://chromium-review.googlesource.com/1154607 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580798}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If380e8785994c0c0108909f029ab0d048c38a941 Reviewed-on: https://chromium-review.googlesource.com/1163291 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580797}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I89ed1b22333f20f9d54100dbfb043dc0127f228f Reviewed-on: https://chromium-review.googlesource.com/1163303Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#580796}
-
Shu Chen authored
Bug: 733825 Change-Id: I4232ab3e2d55a03d1522971a544374a3aae2c7ed Reviewed-on: https://chromium-review.googlesource.com/1128780 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580795}
-
Jakub Pawlowski authored
If libbase is compiled with -Wmissing-field-initializers this is causing warning to be generated. Change-Id: I446160d4c94bb59dd23f2f151004a8bfaeae832d Reviewed-on: https://chromium-review.googlesource.com/1161927Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580794}
-
Kunihiko Sakamoto authored
This reverts commit dc7c0730. Reason for revert: suspected of breakage in 'browser_tests' on Mac: crbug.com/871106 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761 Original change's description: > [Mac] Bring up the audio service sandbox. > > This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox > > Bug: 850878 > Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198 > Reviewed-on: https://chromium-review.googlesource.com/1152080 > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580672} TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 850878,871106 Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89 Reviewed-on: https://chromium-review.googlesource.com/1163230Reviewed-by:
-
Alexey Baskakov authored
Erase web_app_extension_helpers.h in favor of web_app_helpers.h Rename legacy helpers. TBR=lazyboy@chromium.org Bug: 860581 Change-Id: I67799d5d8ef79ce55e3d8f8b5acb51c59afc662b Reviewed-on: https://chromium-review.googlesource.com/1161707 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#580792}
-
Kunihiko Sakamoto authored
Mark virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCDTMFSender-ontonechange.https.html as Failure on Linux Failing on Linux (dbg) too. TBR=hbos@chromium.org No-Try: true Bug: 832842 Change-Id: I6eaa6c2814046a5452ab0a2d63524b6650f6803b Reviewed-on: https://chromium-review.googlesource.com/1163236Reviewed-by:
-
Devlin Cronin authored
Event argument massagers are passed a function to dispatch the event. We need to ensure the arguments are returned to the caller, similar to how calling dispatch() on the event itself would be treated. This is necessary for the input IME custom bindings. Wire this up, and add a unit test for the same. Bug: 867310 Change-Id: I48841d60cb4940a15cd439ce6c4ea156eeeeaab6 Reviewed-on: https://chromium-review.googlesource.com/1150410 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580790}
-
Giovanni Ortuño Urquidi authored
Adds a function to start the installation of an app and implements it for PendingBookmarkAppManager. If there is an app being installed the installation is delayed until the current installation finishes. Bug: 864904 Change-Id: I2397b243dd8065eb67edd055536305e8da0201a1 Reviewed-on: https://chromium-review.googlesource.com/1157948 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580789}
-
Gabriel Charette authored
(and a few minor git-cl-formats-du-jour + spot fixes to make new presubmit checks happy) (and make thread_restrictions.h presubmits only warnings -- I've been realizing that making migration presubmits error is a bit too aggressive specifically because it hinders migrations like these and have been dialing them down, this one was left behind) This finalizes the structure for base/task as planned @ https://docs.google.com/document/d/1h-FlOeO-27g__JnuRvdJ8KG9G-bmG_zn6zuw7GerFkc/edit which makes even more sense in a world where post_task.h and task_traits.h may be used outside the TaskScheduler (ref. crbug.com/867421). There is a low-activity time this week in base/task_scheduler per OOOs so this is as good a time as ever to make this move (and it must happen before eseckler's work to use TaskTraits outside TaskScheduler). The move strategy outlined @ https://chromium-review.googlesource.com/c/chromium/src/+/1161179 makes this CL a simple file move from git's point of view without requiring all users of public headers to be updated in the same large CL Also removed a per-file *task_scheduler* rule from base/test/OWNERS as there are no such files anymore. Bug: 867421 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I48b219b9f781deab606e2c6349bc03a0c5b701d8 Reviewed-on: https://chromium-review.googlesource.com/1161088 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#580788}
-
- 05 Aug, 2018 20 commits
-
-
Christopher Cameron authored
This reverts https://crrev.com/580656 because it re-introduced driver crashes on macOS. This don't re-introduce the logging that had been added (yet) because this patch is to target merging for M69. TBR=kbr Bug: 863817 Change-Id: I5912f25416d11606fa335d3955a70478a5edf6fb Reviewed-on: https://chromium-review.googlesource.com/1163180Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#580787}
-
Gabriel Charette authored
This is https://crrev.com/c/1161179 applied further up the tree while trying to land https://crrev.com/c/1161088 TBR=skyostil@chromium.org Bug: 867421 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3d9830332e9c7331faa2576e92677274bfa06273 Reviewed-on: https://chromium-review.googlesource.com/1163285 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
And fix one more missing migration. TBR=skyostil@chromium.org Bug: 867421 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0e7ff198c8fef8ac223025c93df08cdaedc79164 Reviewed-on: https://chromium-review.googlesource.com/1163282 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This is the //third_party equivalent to https://chromium-review.googlesource.com/c/chromium/src/+/1161179 (DEPS tweak will soon be recovered to moved header in https://chromium-review.googlesource.com/c/chromium/src/+/1161116) TBR=skyostil@chromium.org Bug: 867421 Change-Id: I607bf6caa71dda52e3290d59daaac568c2cba626 Reviewed-on: https://chromium-review.googlesource.com/1162639 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Many blink layout tests take this path, resulting in lots of console spam. TBR=sunnyps Bug: 871031, 654631 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I683c42de3c9d956c3ea97f18027e4e1fbe3e5e8e Reviewed-on: https://chromium-review.googlesource.com/1163179Reviewed-by:
-
Vikas Soni authored
Create an AImageReader based implementation to be used for running videos via MediaPlayer. This new implementation will be used for android O+ whereas SurfaceTexture based implementation will continue to be used for older android versions. Added a feature flag to enable/disable this feature and to allow rollout using Finch experiment. Bug: 838725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5047b162b6d1729cc4a5c4c8dd31507252a5a389 Reviewed-on: https://chromium-review.googlesource.com/1133966Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580782}
-
David Black authored
The previous response should fade out before the next response is added to the view hierarchy. Once finished, the next response should be faded in. Known issue: The spec states that the new response should also translate up into position while fading in. The layer for the WebView does not seem to be responding to attempts to transform it, so that aspect of the spec has been omitted from this CL. See bug for spec/demo. Bug: b:112208728 Change-Id: I53ce44b4e89aa727935624c19c408810e62f3ad6 Reviewed-on: https://chromium-review.googlesource.com/1162990 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580781}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like these callsites can use the THREAD_POOL_EXECUTOR instead, since these usages don't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: Iaf227dc516d1b2c850b9b17ce5d43302ab6532b2 Reviewed-on: https://chromium-review.googlesource.com/1161968Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
-
David Black authored
First, we needed to remove the greeting label and progress indicator from the AssistantHeaderView, because these were affecting the layout position of other views (because they were indirect children of UiElementContainerView). Now, greeting label and progress indicator are children of an overlay layout container that sits atop all other views in AssistantMainStage. This being the case, they do not affect the layout positions of other UI elements as they appear/disappear. Finally, the motion spec was implemented. See bug for spec/demo. Bug: b:112207875 Change-Id: If1394f566d350b5aa678b2aebc2d1e009b6f9564 Reviewed-on: https://chromium-review.googlesource.com/1162936 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Mohamed Heikal authored
junit_binary used to ignore resources if package_name was not passed to the template instantiation. This cl fixes this bug by defining a default package name of "org.chromium.test" so that targets that do not care about a specific package name are still able to use resources. Change-Id: Ifc46f2a468bd9998d6d11ca5445b147e2ff29570 Reviewed-on: https://chromium-review.googlesource.com/1162654Reviewed-by:
-
Mohamed Amir Yosef authored
This CL adds the functionaloty of checking recevied update_entity for sanity in BookmarkRemoteUpdateHandler. Deletions and permanent node updates don't require valid specifics. Other types of remote updates are required to have valid specifics together with valid unique_position field. Bug: 516866 Change-Id: Ib3c89379a3e7f0919cb41865e858ab59d2982a10 Reviewed-on: https://chromium-review.googlesource.com/1162336 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580777}
-
Eric Willigers authored
transform-box shipped in M64 https://chromium-review.googlesource.com/759040 https://www.chromestatus.com/feature/6643927633362944 BUG=595829 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9e9d6a14dfef08332eaaec0e5bb6fe222282f8bb Reviewed-on: https://chromium-review.googlesource.com/1163055Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#580776}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59aabbcf3b0d..2e77f54f46e8 git log 59aabbcf3b0d..2e77f54f46e8 --date=short --no-merges --format='%ad %ae %s' 2018-08-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@2e77f54f46e8 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Icdb1a018b93cfe523eafe6d9ffd26e863bb3a45c Reviewed-on: https://chromium-review.googlesource.com/1163103Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580775}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 28e6e2b2. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22424 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I4bb5fe22fee8e3e87f72012ed6a7fa503b9ebda2 Reviewed-on: https://chromium-review.googlesource.com/1163213 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580774}
-
Mohamed Amir Yosef authored
This CL introduces a new API FaviconServiceImpl::AddPageNoVisitForBookmark() Similar to other APIs in FaviconService, it acts as a proxy to the underlying HistoryService. This comes with the following benefits: 1- Reduces number of dependencies for the calling sites. They now depend only on FaviconService. 2- There exist a mock for FaviconServiceImpl which isn't the case for HistoryService. Tests inject null HistoryService, but instead they could directly use the MockFaviconService and no need to checks for null history service in production code. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I641bf257c1e24c4b3663bcd3cf7210e8d1363002 Reviewed-on: https://chromium-review.googlesource.com/1161932 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9f470261e593..dcad4e0851e4 git log 9f470261e593..dcad4e0851e4 --date=short --no-merges --format='%ad %ae %s' 2018-08-05 vapier@chromium.org convert to https URIs everywhere 2018-08-05 vapier@chromium.org lint: fix old style octal constants 2018-08-05 vapier@chromium.org third_party: drop dpkt Created with: gclient setdep -r src/third_party/chromite@dcad4e0851e4 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I258563c6bd3faba33960b4c68b15595d0ca28e72 Reviewed-on: https://chromium-review.googlesource.com/1163102Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580772}
-
Jia authored
This new dir will contain generated tf native code. Keeping them in a separate dir allows us to control dependencies on the code (i.e dependent targets should not include tf native code directly.) Bug: 862461 Change-Id: I24fc010d09f0571e52fdbebc08c3c66055a3deab Reviewed-on: https://chromium-review.googlesource.com/1154244 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Ivan Krasin authored
build/build_config.h defines one of two macros: https://cs.chromium.org/chromium/src/build/build_config.h // Compiler detection. #if defined(__GNUC__) #define COMPILER_GCC 1 #elif defined(_MSC_VER) #define COMPILER_MSVC 1 #else #error Please add support for your compiler in build/build_config.h #endif And in the most of the case, the following checks are performed: #if defined(COMPILER_GCC) // Do something. #elif defined(COMPILER_MSVC) // Do something else. #else // Do something completely else. #endif There's one use in base/compiler_specific.h that violates this convention, as it tests: #if COMPILER_GCC && defined(NDEBUG) #define ALWAYS_INLINE inline __attribute__((__always_inline__)) #elif COMPILER_MSVC && defined(NDEBUG) #define ALWAYS_INLINE __forceinline #else #define ALWAYS_INLINE inline #endif That leads to a preprocessor error on Windows. While this error is not triggered in Chromium, it can be reproduced, if link WebRTC Native Code with //base shipped as a part of their checkout. BUG=chromium:871039 Change-Id: I868b4a47a574fba48e7d2743cd64ace99ea64940 Reviewed-on: https://chromium-review.googlesource.com/1162343Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ivan Krasin <krasin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580770}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I8752bc781eea3f608aee8ff6356e3cc350d0d9b2 Reviewed-on: https://chromium-review.googlesource.com/1163133Reviewed-by:
-
Ned Nguyen authored
Sample usage: ./tools/perf/core/retrieve_story_timing.py analyze-benchmark-runtime -c 'Android One Perf' -o benchmark_runtime_android_one.json Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I9b7e42a1c8a74093c5dcb311f5ee11d5875a8946 Reviewed-on: https://chromium-review.googlesource.com/1160762 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#580768}
-
- 04 Aug, 2018 1 commit
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 88ba9d16. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22377 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I329ce5e5cc214ae37b74caa4a1f025219d185ce4 Reviewed-on: https://chromium-review.googlesource.com/1163068 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
