- 18 Oct, 2018 13 commits
-
-
dpapad authored
The test was failing because it was asserting on a DOM subtree that was behind a <dom-if> that is false. In Polymer 2, a new optimization prevents those parts of the DOM to receive any updates. Bug: 896208 Change-Id: I268b6732ccf75f5544b3ce3011a73fbc8d11f55b Reviewed-on: https://chromium-review.googlesource.com/c/1287199Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600622}
-
Carlos Knippschild authored
TBR=edwardjung@chromium.org Bug: 852872 Change-Id: I6a48dca2ccb00fcac5f4ad2420694478d93639b7 Reviewed-on: https://chromium-review.googlesource.com/c/1285693Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#600621}
-
Mike Dougherty authored
When a WKWebView is displaying a PDF, the first responder is not in the view hierarchy (but a class adhering to UIResponder). Bug: 882470 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6f9e993e740541b7cf009b1d11e16183b409fdae Reviewed-on: https://chromium-review.googlesource.com/c/1284438 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600620}
-
Michael Giuffrida authored
When localizing an extension, prioritize the user's preferred language over the application locale. Normally, these are the same. In some cases, they differ. For example, the user may choose to display Chrome in "en-CA" (the intl.app_locale pref), but because we don't have translations for that, the actual UI locale is "en-GB". This CL makes extensions try to use the user's preferred locale for i18n ("en_CA"), falling back to the UI locale ("en_GB") if no locale directory is found for the preferred locale. This change also updates the "current_locale" manifest key to reflect the user's preferred locale, or the UI locale if intl.app_locale is unset. Note: Like the application locale, the preferred locale is only set at startup (and in certain situations in CrOS). If the user changes their intl.app_locale pref, they have to restart Chrome before extensions are re-localized, just like before. Bug: 874225 Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d Reviewed-on: https://chromium-review.googlesource.com/c/1244666 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600619}
-
Rahul Chaturvedi authored
Add a new PSD to Feedback reports specifying the account type of the primary user logged in. R=afakhry@chromium.org Bug: 891113 Change-Id: I6b46d65b0fb32fec0ef651d89dd06afcc3c58b25 Reviewed-on: https://chromium-review.googlesource.com/c/1277990 Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#600618}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /media/cast. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=miu@chromium.org Bug: 890902 Change-Id: I1f11e8871d5dab6298edd8829b852cd1907ee2b3 Reviewed-on: https://chromium-review.googlesource.com/c/1257904Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600617}
-
Alexander Alekseev authored
This disables Welcome App on selected devices. Bug: 894095 Change-Id: I3a96e271f669eb2ac6d63d817d49be2838231170 Reviewed-on: https://chromium-review.googlesource.com/c/1287184 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#600616}
-
Min Qin authored
Once a download becomes active, it should be shown on shelf. BUG=895597 Change-Id: I307c64d2111a903ce0bc22b2bd0ae6ff1776c658 Reviewed-on: https://chromium-review.googlesource.com/c/1282023Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600615}
-
Peter K. Lee authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0651ad924a0cf050850cc5298b247c44abd355a4 Reviewed-on: https://chromium-review.googlesource.com/c/1287298Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#600614}
-
Ben Pastene authored
See the retries on something like: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/110795 Failing due to the unknown args. This will just ignore them. Bug: 876587 Change-Id: Ibfe012d74af2dff8ee9b35c3dc921ba53c671b83 Reviewed-on: https://chromium-review.googlesource.com/c/1284443Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#600613}
-
Yuki Awano authored
- Touch event comes with coordinate where its origin is its root window host. Hardware. Confirm that ChromeVox works well on it, e.g. you can activate an element on the screen, etc. Bug: 887222 Test: Enable spoken feedback on touch controller of Hangout Meet Change-Id: I6bd6b50f13405c493659ad91f24d35974d5c72ce Reviewed-on: https://chromium-review.googlesource.com/c/1282688Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#600612}
-
Kevin Strohbehn authored
These events were being sent up to AppListView, then back to AppsGridView. In reality, these events can all be handled before letting them pass through, just based on the nearest tile. Bug: 893216 Change-Id: I9fee2bd9be03efb54a90b07d87bcf9f1a772d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1286129 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600611}
-
Eric Aleshire authored
I accidentally modify cmd (which is unused, but passed in due to inherited function definition), instead of recipe_cmd (which is used, and generated by this function). This is not caught by tests as we mock subprocess. Bug: 892381 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8960fce63b98f68d2cf65792d4bd6e8bc971dcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1287196Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#600610}
-
- 17 Oct, 2018 27 commits
-
-
Findit authored
This reverts commit ac77d3be. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 600408 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWM3N2QzYmU5ZGIyYWJhMWMxZWUxNGI3Y2VmYTQwMGI2YmZkYzBlMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29624 Sample Failed Step: viz_browser_tests Sample Flaky Test: TopControlsSlideControllerTest.TestToggleChromeVox Original change's description: > top-chrome-slide: Disable the behavior when Chromevox is enabled. > > Users of Chromevox may need to touch explore the webpage, and for > things to remain consistent, we should disable hiding top-chrome > with gesture scrolls as long as Chromevox is enabled. > > BUG=857331 > TEST=Added a new browser test. > > Change-Id: Ic70ebcad475ea7885ea3b6bd826b9b1f08f03e1b > Reviewed-on: https://chromium-review.googlesource.com/c/1284289 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600408} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=857331, 896514 Change-Id: If1640bcc475ecbf869dd26dc11b35e6f9bc4fc75 Reviewed-on: https://chromium-review.googlesource.com/c/1287429 Cr-Commit-Position: refs/heads/master@{#600609}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I68f34a70ebe0e044092cc1abd25d48e9cfb28bd4 Reviewed-on: https://chromium-review.googlesource.com/c/1286863Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#600608}
-
Christian Biesinger authored
Avoids a pointless virtual call R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie3048af3bc77c1f2dfea7293d823dd2fa5bbdde5 Reviewed-on: https://chromium-review.googlesource.com/c/1287203 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#600607}
-
Jun Mukai authored
The reason of OmniboxViewViews test failures are basically on touches, and that's because EventInjector is not used. This CL sets nullptr for EventGenerator to use EventInjector. BUG=883523 TEST=interactive_ui_tests Change-Id: I394b9b11d6efc6826a45da407b79cee328224dcf Reviewed-on: https://chromium-review.googlesource.com/c/1283929Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600606}
-
Sam McNally authored
Bug: 870004 Tbr: nhiroki@chromium.org Change-Id: I49b60914dfe719e50941b18d7b96116d98ada86b Reviewed-on: https://chromium-review.googlesource.com/c/1282513 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#600605}
-
Mike Wasserman authored
These files are not mentioned in BUILD.gn files. The cc and mm files also mention headers that do not exist. Bug: None Change-Id: Ifb459ff2e515efa857e1e48748b3cfab9a4151c6 Reviewed-on: https://chromium-review.googlesource.com/c/1287301 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600604}
-
Alan Cutter authored
This CL tidies up some verbose callsites to extensions::HostedAppBrowserController::IsForExperimentalHostedAppBrowser() by hiding it behind a BrowserView::IsBrowserTypeHostedApp() helper function. Bug: 895690 Change-Id: I0cbced2882e4be5dde9107961f3b5a443810869e Reviewed-on: https://chromium-review.googlesource.com/c/1286236 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#600603}
-
Noel Gordon authored
Add SelectFileDialogExtensionBrowserTests for the fix for issue 453634 using the new test API added in CL:1282623 which returns the extension dialog's CanResize() behavior. SelectFileDialogExtensionBrowserTest/CanResize - the dialog should be resizable. SelectFileDialogExtensionBrowserTest/CanResize_TabletMode - the dialog should not be resizable. Bug: 453634 Change-Id: I111462857193d337f5cb81715ed509321ae32293 Reviewed-on: https://chromium-review.googlesource.com/c/1286244Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600602}
-
Ken Rockot authored
Fixes the behavior of some of these tests with https://chromium-review.googlesource.com/c/chromium/src/+/1145692 applied. That CL changes how Mojo bindings dispatch messages, but only timing (not ordering) is changed. This can break subtle test expecations, as is the case here. This change replaces use of deprecated RunAllPendingInMessageLoop with either RunLoop usage or TestBrowserThreadBundle::RunIOThreadUntilIdle. In the latter case, in order to achieve synchronization parity with the code before this change, note that it is also necessary to have WAIT_FOR_DEVICE_TASKS wait for the UI thread to idle after the IO thread has idled, due to the way RunAllPendingInMessageLoop worked. Bug: 895693 Change-Id: I15552766245eda0bdce141c40643ee4b44cc90a8 Reviewed-on: https://chromium-review.googlesource.com/c/1286432 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600601}
-
Rune Lillesveen authored
We do have a LayoutObject for the spinner which means we have a ComputedStyle already. Also added some documentation to EnsureComputedStyle for <area>. Bug: 895894 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie0ee5c75fae0f699721a30f3072eec526c50083e Reviewed-on: https://chromium-review.googlesource.com/c/1286412 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#600600}
-
Nico Weber authored
/pdbsourcepath: before this change here was used to tell lld-link about the build directory. The setup was that the compiler can produce debug info with relative paths in its output (to make them build-dir independent, which helps goma cache obj files), and then at link time those relative paths were made absolute. In symbol_level=1 builds, the obj files don't contain any debug info, the linker just adds enough debug info at link time to get symbolized stacks (without line numbers). So we don't need to pass a real build directory in that case and can pass a fake fixed path. (sanitizer builds do pass -gline-tables-only and hence have some debug info in the obj files even with symbol_level=1, do don't do this there). After http://reviews.llvm.org/rL344061, /pdbsourcepath: is also used as the base path in all other places that contain absolute paths: - The "cwd" stored in the env block in the pdb is /pdbsourcepath: if present - The "exe" stored in the env block in the pdb is made absolute relative to /pdbsourcepath: instead of the cwd - The "pdb" stored in the env block in the pdb is made absolute relative to /pdbsourcepath: instead of the cwd - For making absolute paths to .obj files referenced from the pdb This makes PDBs independent of the build dir in symbol_level=1 builds, and since the hash of the PDB contents are copied as PDB UUID into the executable, it makes executables reproducibe in symbol_level=1 builds too. Bug: 330260 Change-Id: Iaf0bd9f8259b3c97b5c6cff497d31d6043faa807 Reviewed-on: https://chromium-review.googlesource.com/c/1273479Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#600599}
-
James Cook authored
This fixes several shelf browser_tests under SingleProcessMash. It also makes the window bounce animations include the window frame, not just the content area. Bug: 855767 Test: browser_tests ShelfApp* Change-Id: I2d09d7162104bfb65c7a51507304f71a92d87377 Reviewed-on: https://chromium-review.googlesource.com/c/1287183Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600598}
-
Adam Langley authored
Balazs will be focusing elsewhere in the future, but was a cornerstone of the OWNERS for Webauthn code. This change uses //device/fido/OWNERS to define a Webauthn “group” and references that file in several places. Change-Id: I8cc4d203a519669253fce0f5c82537e44ec331af Reviewed-on: https://chromium-review.googlesource.com/c/1284437Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#600597}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/949d82edba6b..709540d7b2c2 Created with: gclient setdep -r src-internal@709540d7b2c2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8d40c62d69d8fe79e47fbb7ba1bbf26f900296a4 Reviewed-on: https://chromium-review.googlesource.com/c/1286635Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600596}
-
Jaeyong Bae authored
platform_screen.h is included in wayland_screen.h. It would be duplicated and we can remove it. Change-Id: I14cb3c03e28c7ebc79c579eaac238325c670448d Reviewed-on: https://chromium-review.googlesource.com/c/1280643Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#600595}
-
Jacob Dufault authored
Bug: 896458 Change-Id: I774285cd49260e227a57cd8d786ba2b31efd08ad Reviewed-on: https://chromium-review.googlesource.com/c/1286666Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#600594}
-
Darren Shen authored
No longer working on CSS. Change-Id: I19305cdece49cce61f56225bc3e4774eb114d590 Reviewed-on: https://chromium-review.googlesource.com/c/1287269Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#600593}
-
Eric Roman authored
Bug: 894801 Change-Id: Ieb17a626284296b6f86f4cf9add2fca4359f7d8a Reviewed-on: https://chromium-review.googlesource.com/c/1285649 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600592}
-
Jun Mukai authored
Set shards to 3, as normal interactive_ui_tests does. BUG=883523 TEST=none Change-Id: Ia1fe3ec5e109b9d4b619c015525805e504e92d37 Reviewed-on: https://chromium-review.googlesource.com/c/1287197Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600591}
-
Prashant Malani authored
The bug associated with the delay is no longer valid (the issue hasn't been observed, and indeed the FP H/W architecture has since changed). Additionally, there have been sporadic instances of "missed" StartAuth sessions, where the FP H/W receives the call to put the sensor into match mode, but the AP fails to acknowledge this the successful receipt. A race b/w sensor microcontrollers and AP suspend could lead to this failed acknolwedgement. Thus, we should remove the delay to at least ensure that the StartAuth call gets synchronously handled. BUG=b:113926492 TEST=Flash chrome on nocturne with this change, and suspend + unlock multiple times. Unlock works every time. Change-Id: Ifd41822d6f48ea4a8e162b3bfa30641ed0b5c367 Reviewed-on: https://chromium-review.googlesource.com/c/1285110 Commit-Queue: Prashant Malani <pmalani@chromium.org> Reviewed-by:Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#600590}
-
Robert Sesek authored
This should hopefully make browser_tests stable on Mac. Tbr: ellyjones@chromium.org Bug: 828031 Change-Id: If72e7e6692f48971e88acfb5bd069e1c83c88aaf Reviewed-on: https://chromium-review.googlesource.com/c/1287310Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#600589}
-
Dmitry Titov authored
Bug: 896481 Change-Id: I6e7d05e5673971d2b132e75dcaf1dfe7a858357a Reviewed-on: https://chromium-review.googlesource.com/c/1287290Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600588}
-
Tim Volodine authored
As was observed in https://crbug.com/891722 by jam@ the user_gesture is not being set in the network service code path, resulting in failing user_gesture related instrumentation tests. This patch fixes the issue. Fixes tests: -org.chromium.android_webview.test.ClientOnReceivedHttpErrorTest.testForUserGesture BUG=891722,841556 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I25be23261c178cd43b1e46440dd96dce89f70bf7 Reviewed-on: https://chromium-review.googlesource.com/c/1286821 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#600587}
-
David Tseng authored
This reverts commit 697307bb. TBR=dmazzoni,chrishall Bug: 885244,893396 Change-Id: I54ea0a3a8e71e7da39078245318608cc66c28c93 Reviewed-on: https://chromium-review.googlesource.com/c/1286815 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#600586}
-
Sunny Sachanandani authored
This reverts commit 90b4fddc. Reason for revert: Causing DC test failures on WinServer2008 bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20x64%20Release%20%28NVIDIA%29/2903 Original change's description: > Use DirectComposition only if hardware overlays are supported > > Before this change, we were using DirectCompositionSurfaceWin on most > newer systems, but it's not needed unless hardware overlays are > supported. > > The disable_direct_composition workaround increases crash rates because > it's applied before GLSurfaceEGL decides to use direct composition with > ANGLE native EGL surfaces. > > This change moves all direct composition logic from GLSurfaceEGL to > DirectCompositionSurfaceWin, and removes use of direct composition with > ANGLE surfaces. > > Bug: 894675 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I2e9c7c8a7ff36fe7b24868544c03aad0e0b7dad6 > Reviewed-on: https://chromium-review.googlesource.com/c/1278529 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600529} TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: Ic8ff38dddc037934dbf19267c3d027fd81c078eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894675 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1287299Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#600585}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cabd5a9c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26373 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I8a70bb40cdc791740f77b3f2f130a10e75c7c3ed Reviewed-on: https://chromium-review.googlesource.com/c/1287193 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600584}
-
Findit authored
This reverts commit d82a26bd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 600490 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDgyYTI2YmQwMGM0NmQ1NGUwNzUyMWFmNmZiNTZhOTM0OGVkYWU5MAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44415 Sample Failed Step: browser_tests Sample Flaky Test: SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Local_AddStrikeIfBubbleIgnored Original change's description: > [Autofill] Add strikes when credit card save ignored/denied/fails > > (When a card accrues 3 strikes, future offers to save for that card > should show the omnibox save icon, but NOT pop up the bubble. > On Android, no offer to save is shown at all.) > > Bug: 884817 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: I0d6ad27a4e03d0128970af6e22d2a40a62d0601b > Reviewed-on: https://chromium-review.googlesource.com/c/1269524 > Commit-Queue: Jared Saul <jsaul@google.com> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600490} Change-Id: I7d0536b919212228db19f87c6cc09358928ffd35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884817, 896493 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1287252 Cr-Commit-Position: refs/heads/master@{#600583}
-