- 29 Jan, 2018 40 commits
-
-
Josh Karlin authored
Bug: 793025 Change-Id: I9707ded8397c178ab3cdd65c2c71851c64b00c00 Reviewed-on: https://chromium-review.googlesource.com/889791 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#532592}
-
Mathieu Perreault authored
Bug: 678689 Change-Id: I9f47f8f59f86621327d5ace0b2431b1fc48ff900 Reviewed-on: https://chromium-review.googlesource.com/889823Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#532591}
-
Dominic Mazzoni authored
The idl file should be removed, and a couple of comments got missed. TBR=dcheng@chromium.org Bug: 650275 Change-Id: Ic36c71da5234bd9f0808f005c967147a11e45e27 Reviewed-on: https://chromium-review.googlesource.com/889043Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#532590}
-
Sandra Sun authored
According to the spec, https://www.w3.org/TR/css-scroll-snap-1/, :target/scrollIntoView()/etc should take scroll-margin, into account. Currently in ContainerNode, BoundingBox() is calculated from its UpperLeftCorner and LowerRightCorner. This patch move the logic to LayoutObject and keeps the wrapper in ContainerNode. When the rect is needed for ScrollIntoView, these two points might be generated from different LayoutBoxes, and we should apply the scroll-margin accordingly. We put these together into a new method - LayoutObject::AbsoluteBoundingBoxRectForScrollIntoView() and wrap it as Node::BoundingBoxForScrollIntoView(). Bug: 803606 Change-Id: I9002d6148fe8ed8f0851fa213431bd6260b993bb Reviewed-on: https://chromium-review.googlesource.com/877444 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532589}
-
James Cook authored
The underlying accessibility code has been refactored recently and I cannot reproduce flake locally. Also, the flakiness dashboard shows that the other tests in the suite are not flaky anymore. I suspect the issue is fixed. Also add a RunLoop spin in one place that changes a pref that ash may need to observe. I don't think that affects this test, but I noticed it while investigating. Bug: 787024 Test: browser_tests Change-Id: I65175c4e87c09c2cc172174c9b0595e4372ad652 Reviewed-on: https://chromium-review.googlesource.com/889645Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#532588}
-
Ran Ji authored
Free the jobjects inside the loop. Previously selecting >= 512 files at same time will cause a crash because the jobjects are not freed. Bug: 726426 Change-Id: Ie71af5965b76653fa52b8745268aab66db5eff48 Reviewed-on: https://chromium-review.googlesource.com/889498Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#532587}
-
Mohsen Izadi authored
There are two versions of this method available, one inherited from mojom::CompositorFrameSink interface and one that actually implements the functionality. Both are public and a bit confusing as to which should be used. After this change, callers should prefer to use the one that is inherited from mojom::CompositorFrameSink and call the other one only when they want to see if the call was successful or not. The first version DCHECK's on the success of the call. BUG=776154 TEST=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I26a0a23f8e2ee807c3a2ea8a5ce7004ac2801c85 Reviewed-on: https://chromium-review.googlesource.com/865475Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532586}
-
Menglu Huang authored
Change-Id: I7feb448f100fdd0f3cab0ade9f2f6b804dc3caeb Reviewed-on: https://chromium-review.googlesource.com/881558Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#532585}
-
Vladimir Levin authored
This patch adds WPT tests for testing whether transformed table parts contain fixed position elements as specced in: https://www.w3.org/TR/css-transforms-1/#transformable-element https://www.w3.org/TR/css-transforms-1/#transform-rendering R=chrishtr@chromium.org Bug: 804952, 805996 Change-Id: I2701e7abffddc67ad4ee206948361acfb28cecd1 Reviewed-on: https://chromium-review.googlesource.com/887364Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532584}
-
Matt Reynolds authored
The Standard Gamepad spec lays out a standard configuration for gamepad buttons and axes. The browser attempts to remap the buttons and axes reported by connected devices to more closely match the standard. In most cases, a suitable mapping function can be chosen from the vendor and product IDs reported by the device. In some cases this is not sufficient; for instance, some devices are supported over both USB and Bluetooth and require different mapping functions in either case. To help select a mapping function in these cases, a |bus_type| parameter is added to GetGamepadStandardMappingFunction to specify whether the device is connected over USB or Bluetooth. BUG=749295 Change-Id: I566e06f5d34eeac269a0a70e912f74a64ccd19f5 Reviewed-on: https://chromium-review.googlesource.com/887231Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#532583}
-
Steven Holte authored
e.g. navigation_and_load_inttest.mm Change-Id: I70fd08b18e49afbbcd060957bf76ef1e5db1bc20 Reviewed-on: https://chromium-review.googlesource.com/891675Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#532582}
-
Nico Weber authored
This CL was uploaded by git cl split. R=rockot@chromium.org Bug: 177475 Change-Id: I805b6d3c2e4c97d65839bf7f1edaf30ac9804946 Reviewed-on: https://chromium-review.googlesource.com/889943Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#532581}
-
Yoland Yan authored
Merge TestCommon into TestRule since there is no long need for sharing the implementation with other classes Bug: 711517 Change-Id: I40f53f07d734112fb85fb2bf8d1efe1ad4752097 Reviewed-on: https://chromium-review.googlesource.com/887747Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532580}
-
Aaron Schulman authored
In preparation for the frame retransmission fix we need to bring out the BattOr connection's Flush() out into it's own function so it can be called directly by the BattOr agent. In order to achieve this we had to rework many BattOr agent test cases which did not pass after this change. It turns out they never should have passed because they did not advance the clock to complete the command retry timeout after a command failed. Bug: 735434 Change-Id: Ie376c91ba47c6e466f57c6acde8a377bd96c209e Reviewed-on: https://chromium-review.googlesource.com/836850 Commit-Queue: Aaron Schulman <aschulman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#532579}
-
Isha Bobra authored
There might be cases where unregistering broadcast receiver can throw IllegalArgumentException if the context is not handled in an appropriate manner. This CL avoids the crash. Change-Id: I9d7888dcbde518caa6e7e426a215953e9c3ba672 Bug: 780261 Reviewed-on: https://chromium-review.googlesource.com/891458Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Isha Bobra <ibobra@google.com> Cr-Commit-Position: refs/heads/master@{#532578}
-
Nico Weber authored
R=martis@chromium.org Change-Id: I70d2846efc7bc0b9511b4429d59c7ae7e492aac9 Reviewed-on: https://chromium-review.googlesource.com/889858Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532577}
-
Justin Carlson authored
When converting from the mDNS service information to a DetectedPrinter struct, we fail with an IPP-E service name because we forgot to check for them. This fixes that. Bug: 806390 Change-Id: Iad2853f458ac3880f9d62f45e135ecb16ee942b8 Reviewed-on: https://chromium-review.googlesource.com/890046Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#532576}
-
Ryan Daum authored
Background: Implementation of the side swipe system gesture handling is present only in the CastWindowManagerAura implementation, but actual users will only have a handle to the base CastWindowManager interface. This CL pulls the methods up to the interface and leaves them as stubs in the CastWindowManagerDefault. Bug: b/71541742 Tested: Manual testing Change-Id: Ib83e42b046153a0e680f8d76eda6d9c0e7bb655d Reviewed-on: https://chromium-review.googlesource.com/891478Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#532575}
-
sebsg authored
The case statement was missing a break. Bug: 806934 Change-Id: I7e51f35a1e418439e7577e757fd5daf182d6c6a7 Reviewed-on: https://chromium-review.googlesource.com/891690Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#532574}
-
Peter Wen authored
No longer enforce full deprecation and unchecked warnings by commandline flags to javac. Greatly reduce verbosity of build output. BUG=805906 Change-Id: I20ac2f56d9bfa5ed946789373eae536089e7506e Reviewed-on: https://chromium-review.googlesource.com/887001 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#532573}
-
Vladimir Levin authored
This patch updates several places in the code that assume that LayoutInlines can only contain absolute position elements (and not fixed). This is a step towards making filtered elements be able to contain both absolute and fixed positioned elements. R=chrishtr@chromium.org Bug: 795549 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idf970e4343646574bd9c53d064f7578a2f09f3a3 Reviewed-on: https://chromium-review.googlesource.com/882187Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532572}
-
Hongchan Choi authored
AudioWorklet::IsReady() checks the state of the worklet object and must be accessed from the main thread. OfflineAudioDestinationHandler::DoOfflineRendering() violates the rule and this CL fixes GetRenderingThread() method to check the assigned worklet thread instead. Bug: 804908 Change-Id: I1ff1f779a3bb75d1715f521a2656a7c6c8c51a9f Reviewed-on: https://chromium-review.googlesource.com/882121Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532571}
-
https://skia.googlesource.com/skia.git/+log/11e5bff1594c..58acd74f55f2 $ git log 11e5bff15..58acd74f5 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 reed validate that contours begin with moveTo Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I0981a56b442e8722d60b9d88b95c0c9c9e5f02c6 Reviewed-on: https://chromium-review.googlesource.com/891685Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532570}
-
James Cook authored
Previously it was only allowed in developer builds and dev channel builds. I think canary was an oversight. Bug: none Test: option appears in about:flags Change-Id: I3611b0d23f43f53628e03bf1245ca056a1456c0f Reviewed-on: https://chromium-review.googlesource.com/891693Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#532569}
-
Jialiu Lin authored
Move LogSyncPasswordHashChange call into password store class, such that "PasswordManager.SyncPasswordHashChange" will only be logged if there is actual change. Bug: 657041 Change-Id: I3afbea76ee9a31376f7a6752b3933cf278328378 Reviewed-on: https://chromium-review.googlesource.com/885243 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#532568}
-
Lambros Lambrou authored
When receiving a bandwidth estimate of 0 from WebRTC, the host should pause the video stream without crashing. This CL is a simple fix which sets the bucket-emptying time to 1 minute if the rate is set to 0. This is similar to what we already do in FrameProcessingTimeEstimator::EstimatedTransitTime(). Bug: 806918 Change-Id: I43bf24cf54250cc3856adeb4c49809733320d46b Reviewed-on: https://chromium-review.googlesource.com/891671Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#532567}
-
danakj authored
Instead of the ResourcePool making a ResourceId, which the RasterBufferProvider implementation actualizes into a backing via a write lock, we have the ResourcePool give out a metadata object, and the RasterBufferProvider allocates a backing for it directly. Then, TileManager puts a ResourceId by explicitly asking the ResourcePool to do so, in order to allow the backing to be exported to the display compositor. R=vmpstr@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Idc3b127f819e7154414cb7de9897e5309a22b7bc Reviewed-on: https://chromium-review.googlesource.com/882101 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#532566}
-
Nico Weber authored
Bug: 177475 R=dalecurtis@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5536e4854edf66a0838fe0a89f37bdedfc6bfc7e Reviewed-on: https://chromium-review.googlesource.com/889721Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#532565}
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I92e07bca0041ed84a9b45339c89b61d05e8158de Reviewed-on: https://chromium-review.googlesource.com/887779 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532564}
-
Avi Drissman authored
This modernizes the WebContentsObserver interface. BUG=767526 Change-Id: I55b92fabf7a62cc932124822a91da1ffe2230549 Reviewed-on: https://chromium-review.googlesource.com/889939Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532563}
-
Eric Lawrence authored
Preload for Strict-Transport-Security several .gov domains that were manually requested. TBR=palmer@chromium.org Change-Id: I9b23ab1c5c10cc2f295ebd33ec24cfbc6a5512ca Reviewed-on: https://chromium-review.googlesource.com/889717Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#532562}
-
Raymond Toy authored
There's no reason to have a limit on the number of concurrent AudioContexts. If the user creates too many, we'll just run out of resources and stop. Bug: 777342 Test: audiocontext-max-contexts.html removed Change-Id: I55ac01e42cc1ffc313db5b93e49db1c4a36a585b Reviewed-on: https://chromium-review.googlesource.com/875192Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#532561}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/e99634797bd6..831d51715a13 $ git log e99634797..831d51715 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 perezju [Devil] Rewrite surface_stats_collector.GetSurfaceFlingerPid 2018-01-29 perezju [Telemetry] Fix up IsApplicationRunning for Android platform 2018-01-29 erikchen Change assert to instead log a warning. 2018-01-29 perezju [Telemetry] Simplify GetDevtoolsRemotePort for WebView Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iaa73a0c657b69535d95b09c3d621b5af3201aebf Reviewed-on: https://chromium-review.googlesource.com/890823 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532560}
-
Bret Sepulveda authored
Versions of the dialog with long titles, like the "re-enable with new permissions" or the "extension installed externally" dialogs, are affected by this change. Instead of wrapping, their titles would all be on one big line, making the dialog extremely wide. This is fixed. This patch also adds interactive browser tests for "withheld" permissions and for the "re-enable" version of the dialog. Bug: 654124 Change-Id: Iaffdede6a9977952f83a4393425a4df58007d05e Reviewed-on: https://chromium-review.googlesource.com/885104Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#532559}
-
Wez authored
Bug: 750756, 806451 Change-Id: I60ab7ca8a99bd1845492d7486e811f68105116f2 Reviewed-on: https://chromium-review.googlesource.com/890109Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#532558}
-
Ahmed Fakhry authored
BUG=709824 TEST=unit_tests --gtest_filter=AboutFlagsHistogramTest.*' Change-Id: If17ed24b23f68e5bb3720d25240209f16a707480 Reviewed-on: https://chromium-review.googlesource.com/887562Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#532557}
-
Raphael Kubo da Costa authored
We were previously using an std::set<std::string> to filter out mime type duplicates, optionally adding the "application/octet-stream" mime type to the set before joining all items as a single string to pass to the kdialog invocation. This used to work fine with the KDE4-based kdialog, whose underlying KFileDialog ended up creating a custom file type filter with all entries and suggesting the proper file extension. The KDE Frameworks 5-based kdialog that was released a few months ago uses a simple QFileDialog, and the filter's entries are added in the order they are passed to kdialog. In practice, this means that downloading a PDF file (or any file whose mime type ended up coming after "application/octet-stream" when iterating our std::set) causes kdialog to be invoked like this: kdialog [...] --getsavefilename /path/to/Downloads/foo.pdf \ application/octet-stream application/pdf KDE4 kdialog suggests "foo.pdf" as the name and adds "unknown, PDF document", "unknown" and "PDF document" to the filter list. KF5 kdialog suggests "foo.bin" as the name and adds "unknown" and "PDF document" to the filter list. We now make sure that "application/octet-stream" is the last mime type we pass to kdialog so that any other more specific mime type is chosen as the default and we do not always try to add the ".bin" extension to the files we are saving. Bug: 752375 Change-Id: I56a458042823c52beada9c1819c2ee4b8b8e5e30 Reviewed-on: https://chromium-review.googlesource.com/891160 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532556}
-
Daniel Cheng authored
Going forward, this is the preferred naming for modules containing EnumTraits, StructTraits, and UnionTraits. Change-Id: I4e363a9c74cd3f43d071cd4cdc4cb6c0a72be722 Bug: 806965 Reviewed-on: https://chromium-review.googlesource.com/891673 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#532555}
-
Christian Fremerey authored
* Move base::Feature for enabling video capture service to content_features.h/cc. * Added base::Feature "RunVideoCaptureServiceInBrowserProcess" to allow forcing the service to run in the browser process * Add logic for determining if and where service should run. * In file device_factory_media_to_mojo_adapter.cc, allow devices that report zero supported formats, since this appears to be a valid case on Android. This CL does not yet register the service factory as an embedded service in the Browser process. This needs to be done in a follow-up step as soon as questions regarding EmbeddedInstanceManager have been resolved, see [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/817646 Design Doc: https://docs.google.com/document/d/1Kg5S6K8rwIqMVzo4lbipy_rxjxO9zqKdYrnxSvLJZkg/edit?usp=sharing Bug: 792621 Change-Id: I5b3c4a79e2f267238e3b726a736852d6a4205e0d Reviewed-on: https://chromium-review.googlesource.com/759412 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#532554}
-
Samuel Huang authored
Recent refactoring in Zucchini Trunk replaced explicit "separator" (archive content outside matched elements) computation with "gap" handling that occurs close to element handling. This CL removes the now-obsolete explicit separator computation code from Zucchini Chromium, to prepare for merging in ensemble matching code from Trunk. Bug: 729154 Change-Id: I7c917df058e104d8f1d518d37a673edaf0a2918c Reviewed-on: https://chromium-review.googlesource.com/891443Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#532553}
-