GitLab

Going forward the default API for interacting with authentication error
should be the token service rather than the SigninErrorController.
This CL updates tests to use the token service instead of
AuthErrorProvider to set authentication errors.

TBR=ellyjones

Bug: 836212
Change-Id: I694068a1d037b1f2314d389328b9ccbea5f2bcf3
Reviewed-on: https://chromium-review.googlesource.com/1016642
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553509}

This CL introduces an overload GetChangeList method in JobScheduler that accepts
a team_drive_id and a start_page_token as parameters to retrieve the changes.

This is the next step in being able to use start tokens to retrieve changes
rather then the deprecated largest change id, which does not work for team
drives.

In DriveServiceInterface I did not overload GetChangeList but rather
introduced a new method name that accepts team_drive_id and start_page_token as
parameters. This is because base::Bind cannot resolve overloads and I would
have had to add static_casts throughout the code to tell base::Bind which method
to resolve to, and it's just not worth it.

Bug: 833690
Change-Id: I5598cfe9d5a53a47ae8e8482585ae617f0851765
Reviewed-on: https://chromium-review.googlesource.com/1016181
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553508}

This reverts commit 008759aa.

Reason for revert: Breaks MSan Tests

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 553428 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAwODc1OWFhNWJjOGNkMDVjNTI5NjkwOGVmYmY3NGRjYjA0M2Q2NmUM

Example:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6869%2F%2B%2Frecipes%2Fsteps%2Fmus_browser_tests%2F0%2Flogs%2FOutOfProcessPPAPITest.Printing%2F0

Uninitialized bytes in __msan_check_mem_is_initialized at offset 0 inside [0x7f914c1f9524, 4)
==9854==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x12c35d8e in WriteBytesCommon ./../../base/pickle.cc:430:3
    #1 0x12c35d8e in void base::Pickle::WriteBytesStatic<4ul>(void const*) ./../../base/pickle.cc:395:0
    #2 0xb00ffa1 in WritePOD<int> ./../../base/pickle.h:327:5
    #3 0xb00ffa1 in WriteInt ./../../base/pickle.h:190:0
    #4 0xb00ffa1 in Write ./../../ipc/ipc_message_utils.h:186:0
    #5 0xb00ffa1 in WriteParam<unsigned int> ./../../ipc/ipc_message_utils.h:110:0
    #6 0xb00ffa1 in IPC::ParamTraits<PP_PrintSettings_Dev>::Write(base::Pickle*, PP_PrintSettings_Dev const&) ./../../ppapi/proxy/ppapi_messages.h:223:0
    #7 0xd1e82ee in MessageT<true, false> ./../../ipc/ipc_message_templates.h:124:33
...

 Uninitialized value was stored to memory at
    #0 0xb010122 in IPC::ParamTraits<PP_PrintSettings_Dev>::Write(base::Pickle*, PP_PrintSettings_Dev const&) ./../../ppapi/proxy/ppapi_messages.h:0:1
    #1 0xd1e82ee in MessageT<true, false> ./../../ipc/ipc_message_templates.h:124:33
    #2 0xd1e82ee in content::PepperPrintingHost::PrintSettingsCallback(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>) ./../../content/browser/renderer_host/pepper/pepper_printing_host.cc:55:0
    #3 0xd1e87e2 in Invoke<const base::WeakPtr<content::PepperPrintingHost> &, const ppapi::host::ReplyMessageContext &, std::__1::pair<PP_PrintSettings_Dev, int> > ./../../base/bind_internal.h:447:12
    #4 0xd1e87e2 in MakeItSo<void (content::PepperPrintingHost::*const &)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), const base::WeakPtr<content::PepperPrintingHost> &, const ppapi::host::ReplyMessageContext &, std::__1::pair<PP_PrintSettings_Dev, int> > ./../../base/bind_internal.h:550:0
    #5 0xd1e87e2 in RunImpl<void (content::PepperPrintingHost::*const &)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), const std::__1::tuple<base::WeakPtr<content::PepperPrintingHost>, ppapi::host::ReplyMessageContext> &, 0, 1> ./../../base/bind_internal.h:604:0
    #6 0xd1e87e2 in base::internal::Invoker<base::internal::BindState<void (content::PepperPrintingHost::*)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), base::WeakPtr<content::PepperPrintingHost>, ppapi::host::ReplyMessageContext>, void (std::__1::pair<PP_PrintSettings_Dev, int>)>::Run(base::internal::BindStateBase*, std::__1::pair<PP_PrintSettings_Dev, int>&&) ./../../base/bind_internal.h:586:0
    #7 0xd1e7292 in Run ./../../base/callback.h:96:12
...

Original change's description:
> Add N-up feature support to pdfium_engine.
> 
> In printing, 2-up, 3-up, or more generally N-up refers to a page
> layout strategy in which multiple pages are composited onto a
> single page.
> 
> 1. Added ability to pass the N-up feature UI settings (which will be
>    added in the next CL) to the print preview workflow, so that the
>    PDF plugin can take action based on user's input.
> 2. Added N-up feature support to pdfium_engine, so that when the
>    source is PDF, pdf plugin will generate the N-up output doc based
>    on user's input.
> 
> Bug: 775999
> Change-Id: I27933d1a7da65376e70bdcb538393bb8bb3ec688
> Reviewed-on: https://chromium-review.googlesource.com/1014628
> Commit-Queue: Shirleen Lou <xlou@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553428}

TBR=raymes@chromium.org,palmer@chromium.org,dcheng@chromium.org,thestig@chromium.org,skau@chromium.org,jochen@chromium.org,xlou@chromium.org

Change-Id: I017a6dd2527c843ebb365bf5ec2da19696860898
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775999
Reviewed-on: https://chromium-review.googlesource.com/1027770Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553507}

Using wpt-import in Chromium a4bd4e9a.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16247

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding

TBR=markdittmer

No-Export: true
Change-Id: Icdd8a31def9fa28dca027343a6ce3e21c40b2d0d
Reviewed-on: https://chromium-review.googlesource.com/1027315
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553506}

HttpRawRequestResponseInfo in ResourceResponseInfo is not thread safe.
So if the shared ResourceResponseInfo is deleted on the UI thread,
DCHECK(CalledOnValidSequence()) in RefCountedBase::Release() fails.

To avoid this, this CL makes a deep copy of ResourceResponseHead before passing
it cross-thread.

This CL also introduces |devtools_enabled_| in DelegatingURLLoaderClient to avoid
unnecessary operations.

Bug: 836680
Change-Id: I5cee9b2da8b6183b660e8fc6375d9ee7ab2da343
Reviewed-on: https://chromium-review.googlesource.com/1027390Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553505}

https://skia.googlesource.com/skia.git/+log/56610207ead6..9f63153a03c7

$ git log 56610207e..9f63153a0 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 angle-skia-autoroll Roll third_party/externals/angle2/ f2807385c..023371b3a (2 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: Icc5728a970de3bb3f10c4cdbb3058cc87508f62a
Reviewed-on: https://chromium-review.googlesource.com/1027439Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553504}

The following strings in the user menu
are updated:
 - "Guest" -> "Open Guest window"
 - "Close all your windows" -> "Exit <Profile>",
   in case there are multiple profiles
 - "Close all your windows": titlecase added

Bug: 836066, 130656
Change-Id: I526db685f3efd0c7b8623ab8a0081b9414ceed94
Reviewed-on: https://chromium-review.googlesource.com/1025758
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553503}

It turned out that PROBABLY_ACCOUNT_CREATION_PASSWORD is not so helpful
for server-side classification and wasn't used. Let's remove it
in order to keep our code clean.

Bug: None
Change-Id: If53a48f1d8121ac3bb2efaecc291cd6370de9e1c
Reviewed-on: https://chromium-review.googlesource.com/1007234Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553502}

https://chromium.googlesource.com/angle/angle.git/+log/2565d48b47aa..023371b3af90

$ git log 2565d48b4..023371b3a --date=short --no-merges --format='%ad %ae %s'
2018-04-24 oetuaho Fix setting mip level metadata on GL backend

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I9c211d86c5b3dfae99338e2b590802a4f2430c9e
Reviewed-on: https://chromium-review.googlesource.com/1027434Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553501}

The 'shell' feature removal CL was reverted after the sandbox policy
files had been split into production and test versions, so the revert
did not apply to the new test process policy.

TBR: kmarshall
Bug: 823927, 836341
Change-Id: I9a4c75cb01c255887a4928c31ab199e039d53397
Reviewed-on: https://chromium-review.googlesource.com/1027441Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553500}

Bug: chromium:672469
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1e24e99df4a6d9dc0480aeb460115bafdceeafd5
Reviewed-on: https://chromium-review.googlesource.com/1018475
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553499}

The old V8 API is being deprecated.

R=haraken@chromium.org

Change-Id: Iaa5af927df5522ad78ce2b3db2b663568855193e
Reviewed-on: https://chromium-review.googlesource.com/1026676Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553498}

This CL imports all attribute tests from
https://github.com/abarth/http-state/tree/master/tests/data/parser.

There are small changes that ensure the tests also clean up when they are run via the debug path.


Change-Id: I5cf30824091471e7f65aceb19ad03bd07cfb91d1
Reviewed-on: https://chromium-review.googlesource.com/977923
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553497}

Just skip it for now.

TBR=atotic@chromium.org

Bug: 829804
Change-Id: I279e565e5e26d0355cbba2d3aa7945c73c61b5e1
Reviewed-on: https://chromium-review.googlesource.com/1026678Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553496}

This CL implements the actual sign-in for the streamlined sign-in
screen. The main sign-in flow is similar to the one implemented in
AccountSigninView, but account seeding in SigninFragmentBase is
triggered by the accept button, not by the account selection.
Code to disable controls in the sign-in screen while sign-in is ongoing
will be added by subsequent CLs.

Bug: 814728
Change-Id: I57d146641e3a4a9e75093550dc9e033159a83d78
Reviewed-on: https://chromium-review.googlesource.com/1024410Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553495}

By the recent visual refresh on ext4 migration dialog, the header icon was
changed from chrome logo to warning icon, and the illustration was modified.

Bug: 835461
Test: Manually confirmed on Pixelbook.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I639b7b22f21d73396f33e41af3dc8bfa084ad2de
Reviewed-on: https://chromium-review.googlesource.com/1025851Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553494}

This patch changes the field study default configurations to be
aligned with parameters that are planned for launch.

Bug: 729954
Change-Id: Idf4cb1097efee62d20a8bd1b2fa67dc872967517
Reviewed-on: https://chromium-review.googlesource.com/1016142
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553493}

We set writing-mode based on parent layout objects, but now modify the
ComputedStyle before SetStyle to avoid non-const access to LayoutObject
ComputedStyle member.

This is part of the work to make the ComputedStyle member of
LayoutObject const.

Bug: 813068
Change-Id: Id1128c036e05532067a87a33f8b5f8b4b75ab8da
Reviewed-on: https://chromium-review.googlesource.com/1024838
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553492}

TBR=wychen@chromium.org

Bug: 836700
Change-Id: I6c72f9404a3373030a65a4acb31597fb70cb0974
Reviewed-on: https://chromium-review.googlesource.com/1027550Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553491}

Once we can land the IncrementalShadowDOM (and remove Shadow DOM V0), we no
longer need to call UpdateDistribution, however, some usages of
UpdateDistribution are unclear at this point.

Thus, except the cases where we can tell its intent cearly, we call
RecalcAssignments too for IncrementalShadowDOM there.

UpdateDistribution is now divided into the followings:

1. UpdateDistributionForFlatTreeTraversal: This should be used in most cases.
2. UpdateDistributionForLegacyDistributedNodes: This should be used only by the
   implementation of V0 shadow trees, where they need to access
   distributed_nodes directly.
3. UpdateDistributionForUnknownReasons: This is a tentative workaround for the
   sake of safety. In addition to calling (old) UpdateDistribution, we call
   RecalcAssignments for IncrementalShadowDOM too.

The future plan is:
3 can be replaced with 1, however, that needs a careful investigation, so that
should be done on a case-by-base basis after this CL lands.

TBR=aboxhall

Bug: 776656
Change-Id: I826850e04093d2278a2f0aedf8e06f85f2fe8485
Reviewed-on: https://chromium-review.googlesource.com/1025155
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553490}

Bug: 801985
Change-Id: I1783db374cf4bcdeda6e5bb6a8a85ce9a8fbc03e

TBR=carlosk@chromium.org, rdevlin.cronin@chromium.org,jkrcal@chromium.org

Change-Id: I81f3d958715fb2a33fb7269c655912e5bc2db036
Reviewed-on: https://chromium-review.googlesource.com/1023404Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553489}

This reverts commit 59692b72.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 553433 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU5NjkyYjcyYmMzNGNiYmM5ZGM3ZmY0NDE0ZjNjODQ2YTU4NzMyOWYM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27188

Sample Failed Step: mus_ash_unittests

Original change's description:
> Observe ClockModel directly from DateView/TimeView
> 
> This CL changes DateView and TimeView to directly observe ClockModel.
> It removes unrelated logic from SystemTrayItem and makes embeding these
> views easier.
> 
> TEST=ash_unittests
> BUG=none
> 
> Change-Id: I70b3a873c0ac259a05597d3f93b77fd7519dd462
> Reviewed-on: https://chromium-review.googlesource.com/1025615
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553433}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=none

Change-Id: Ife07647a589f9caa276788bae5dccff68bcf41a0
Reviewed-on: https://chromium-review.googlesource.com/1027272
Cr-Commit-Position: refs/heads/master@{#553488}

Any roots from V8 into Blink need to be cleared before running the termination
garbage collection to ensure that all objects die and finalizers are called.

Bug: chromium:831117
Change-Id: I09042623ceafe141819f4e9b52b15e784dd623a9
Reviewed-on: https://chromium-review.googlesource.com/1025032
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553487}

assertEquals accepts an expected value as the first argument and an
actual value as the second. This CL fixes some tests that were using
the reversed order.

Bug: None
Change-Id: I158277a01d6146ef46b1b2fc97af04c7dcd7a563
Reviewed-on: https://chromium-review.googlesource.com/1008002Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553486}

This is just a cleanup and doesn't change behavior.

Bug: 825740
Change-Id: I36c4002ca29bd3ad5af1a8f63ef2b33e6b977981
Reviewed-on: https://chromium-review.googlesource.com/1027370Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553485}

This is preparation for fixing Issue 834675, where we will be changing
execution paths for these procedures based on input file locations.

Test: manually tested by zipping files on My Drive
Bug: 834675
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac3637d46760066b18c36e799448af5d7f6cd705
Reviewed-on: https://chromium-review.googlesource.com/1027332
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553484}

We were only doing this check at registration time previously, which is
sketchy since the browser or content settings could change in the
meantime after registration.

Actually the motivating example was if you register
an extension service worker once and then run Chrome with
--disable-extensions and then try to start the worker via
chrome://serviceworker-internals. It turns out the checks for
JavaScript and cookies in
ChromeContentBrowserClient::AllowServiceWorker were disallowing
start worker in that case, but it seems fragile to rely on those.

Change-Id: Iea3706ccf08ec72ed9e2306b01a6ddfd0fa3b9eb
Reviewed-on: https://chromium-review.googlesource.com/1027171Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553483}

Now that Document leak bug (crbug.com/734427) is fixed, leak detector must no more skip any tests. This CL updates the expectation file.

Change-Id: Ieaa29267952d259c1a7911f566a25257b7f29a63
Reviewed-on: https://chromium-review.googlesource.com/1025537
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553482}

This reverts commit 0ad90c2f.

Reason for revert: Found the issue with the broken tests.

Original change's description:
> Revert "WebXR: Do not provide poses to frames without focus"
>
> This reverts commit 666960b1.
>
> Reason for revert: Causing a test bug.  Reverting while I investigate that bug (crbug.com/835047).
>
>
>
> Original change's description:
> > WebXR: Do not provide poses to frames without focus
> >
> > This change plumbs through focus (both blink/frame and device) to XRSessions, so we
> > only call raf callbacks when focused.
> >
> > BUG=813230
> >
> > Change-Id: I0aefdce989f6dd60b4cd0acf1a1477fdb2e845b8
> > Reviewed-on: https://chromium-review.googlesource.com/1011288
> > Reviewed-by: Brandon Jones <bajones@chromium.org>
> > Reviewed-by: David Dorwin <ddorwin@chromium.org>
> > Commit-Queue: Bill Orr <billorr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#551842}
>
> TBR=ddorwin@chromium.org,bajones@chromium.org,billorr@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 813230
> Change-Id: I5c1e1dcb9aaef3fe46c085d6572cea81673e4789
> Reviewed-on: https://chromium-review.googlesource.com/1020800
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552268}

Change-Id: I065ccb0972a33e553aa73140bd649a939a6547f8
Bug: 813230
Reviewed-on: https://chromium-review.googlesource.com/1022560Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553481}

We don't need it for keepalive requests any more, and
DetachableResourceHandler ignores cancel requests from renderer, which
is bad.

Change-Id: Iada35d44e2290760ed7b293cdd3dd7280e69edea
Bug: 836641
Reviewed-on: https://chromium-review.googlesource.com/1026333Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553480}

It's unfortunate that composited animation with subpixels is
incompatible with pixel snapping. We have to accept some imperfection
of pixel snapping to achieve high performance composited animation
with subpixels, otherwise each step of the animation might cause
full layer raster invalidation.

SPv175 lost the imperfect optimization and this CL brings it back by
- excluding the subpixel accumulation of the composited layer from
  the visual rects of composted layer contents, if there is no non-
  translation transform between the composited layer and the object.
- adding the subpixel accumulation back to the final visual rects
  when generating raster invalidations and convert to cc display
  item list.

Bug: 833083
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie8cfb3712bf7839a60b2a3187fd792b0fa4fe4d2
Reviewed-on: https://chromium-review.googlesource.com/1023606
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553479}

SignedExchangeDevToolsProxy lives on the IO thread and sends messages to
DevTools via the UI thread to show signed exchange related information.
Currently it is used only to send error messages.

When Network Service is not enabled, the frame tree node ID is not available
while handling prefetch requests on the IO thread. So this CL introduces
|frame_tree_node_id_getter| callback.
For non-NetworkService prefetch requests, the callback is GetFrameTreeNodeId()
in resource_message_filter.cc. For other cases (non-NetworkService navigation
requests, NetworkService navigation requests, NetworkService prefetch requests)
the callback is the lambda which just returns frame_tree_node_id.

Bug: 830505
Change-Id: I22777225b8b678f406fc35dacf963b935236c0ab
Reviewed-on: https://chromium-review.googlesource.com/1025492Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553478}

Having a non-zero keep alive refcount prevents the task queue throttling
even when the page is in background. This CL avoids that with calling
RenderProcessHost::DecrementKeepAliveRefCount eagerly.

Bug: 831853
Change-Id: I79562153286aee08d65520de0bf48eb8087db961
Reviewed-on: https://chromium-review.googlesource.com/1023628Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553477}

Third parties would construct toolchain packages on their own,
with the best of their abilities, based on the instructions
provided.

They could then accumulate <canonical hash> -> <their own hash> pairs
in their environment to support historical builds.

Example mapping:
set GYP_MSVS_HASH_1180cb75833ea365097e279efb2d5d7a42dee4b0=4181fce548fece344a85cb6898cf996692998531

Bug: 836225
Change-Id: I4a46e51b09049340344c9717481b141a2a7c296b
Reviewed-on: https://chromium-review.googlesource.com/1025896Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
Cr-Commit-Position: refs/heads/master@{#553476}

r553437 added one for dedicated-inheritance.html, but shared is also
flaky:
external/wpt/content-security-policy/inside-worker/shared-inheritance.html

Bug: 836627
Change-Id: I84be5f95c0b1a2aa267ed76c849bb98f4b4b5dcd
TBR: robertma
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1027213
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553475}

It doesn't use any active unctionality from it. This would let us merge
ResourceProvider into DisplayResourceProvider.

Bug: 738190
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie08c7c75e8586e239f706cd03ad632b0c4ac1c47
Reviewed-on: https://chromium-review.googlesource.com/1023378
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553474}

ServiceWorkerResponse type doesn't provide move constructor nor
assignment, thus when moving to vector it creates a copy, so we need
unique_ptr to delete the memory used by its value, otherwise it leaks.

Bug: 835611
Change-Id: I1276b5e3935f9759b8d9dd84df3a958b1dd9d25e
Reviewed-on: https://chromium-review.googlesource.com/1023731Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553473}

Bug: 826213
Change-Id: Ifa1d7e3fd3625ef0161073d594f3f48aada7b7c8
Reviewed-on: https://chromium-review.googlesource.com/1019448Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553472}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/355b11a31f0d..2f2142eff8c0

$ git log 355b11a31..2f2142eff --date=short --no-merges --format='%ad %ae %s'
2018-04-24 tandrii CQ: switch to 100% LUCI builders.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:830992


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ica524f17eec27192e7821c9f13652d540f1b8a0e
Reviewed-on: https://chromium-review.googlesource.com/1027204Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553471}

Bug: 706466
Change-Id: I418253ffc3cb314466beb3cad6eb0f36b099f28c
Reviewed-on: https://chromium-review.googlesource.com/1027117Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553470}