- 03 Feb, 2020 40 commits
-
-
Charlie Hu authored
This CL filters out features that are disabled by origin trial when initializing document policy in SecurityContextInit and when parsing from policy attribute on iframe element. Bug: 993790 Change-Id: I5b6a9f9e4b19275cb483c23c8d3cefa9e74af29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019925 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#737861}
-
Muhamed Parić authored
Bug: 988059 Change-Id: Ibd28b8060aa1efff383e689ffa3ee5437d0faf4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035950 Commit-Queue: Muhamed Parić <muhamedp@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#737860}
-
Henrik Lundin authored
The UMA metric is not monitored anymore. Bug: none Change-Id: I8e3b333558502bc5d7cb0be3144ad0b0ceefaba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030169 Auto-Submit: Henrik Lundin <hlundin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#737859}
-
Avery Musbach authored
There is a comment that speaks of handling "when there is a window being dragged" but only checks if the active window is being dragged. It seems based on a mistaken assumption that a dragged window must be active. The behavior is actually reasonable because the purpose is to avoid stealing activation from a dragged window, which is not a concern if the dragged window is already inactive. Only the comment needs to be fixed. Bug: None Change-Id: I390eccc6370ad4ed7d15f2d32212fe43b0233633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031641Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#737858}
-
Sammie Quon authored
This is a common case in tablet because users frequently press the home button which minimizes all windows. It also is slightly different from other overview animations - it animates the wallpaper blur and opacity while fading in the mirror views and slides up the hotseat. Also, UX wants to remove delay on wallpaper blur when exited, so these metrics will catch a regression. A tast test will be added shortly. Test: ash_unittests *Overview* Bug: 1045185 Change-Id: I3ae72d876857415b11d1a3a5870b404b3e997660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018448Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Bug: 1009579 Change-Id: I05870155fdba4e6c4fb2053661efebd3418017ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031555 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
Add these metrics: Media.Notification.Cast.UserAction Media.Notification.Cast.Count Their non-Cast counterparts still include counts for Cast sessions. Bug: 1042832 Change-Id: Ifb4b808be1ea2e266f2fdbd849d1646678c016d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032722Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#737855}
-
Kevin McNee authored
A portal WebContents has TabHelpers even when embedded. When the helpers are added, the portal WebContents is assigned a distinct tab ID. This is an issue when attempting to load the PDF viewer as ExtensionTabUtil::GetTabById cannot find the specified tab ID in the TabStripModel. Until we have a more thorough plan to deal with issue 1042323, we have the PDF viewer load without a tab id when created in a portal. Bug: 932691 Change-Id: Idbde43efcc1c0453abcea9b507cf01e9ef81f5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033325Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#737854}
-
Kelvin Jiang authored
This CL adds documentation for the feedback API as well as the declarativeNetRequestFeedback permission. The getMatchedRules has also been made available for beta. Bug: 1044702 Change-Id: I9752110fce82b56efe5666fc811c018b1cf2e895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032415Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737853}
-
Evan Stade authored
Bug: 1038415 Change-Id: I799c77bb441d34c68cd425e34e841ecd2c167a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031711Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#737852}
-
Becca Hughes authored
For playback sessions (the continue watching table) we actually just want the most recent playback for a URL so we can make it unique. BUG=1041662 Change-Id: Ib7ad1d9f276ffe1b669fff36aa3154daf6b23ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033908 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb3951000894..5ddc34ca3de6 git log fb3951000894..5ddc34ca3de6 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 herb@google.com Remove 565 mask data from GrStrikeCache to constexpr varialbe 2020-02-03 bsalomon@google.com Use GrTextureEffect::MakeTexelSubset instead of MakeSubset in SkGpuBlurUtils Created with: gclient setdep -r src/third_party/skia@5ddc34ca3de6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ibc66f3cb616edd4d18fff5af348b2f592d2ef3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737850}
-
Nohemi Fernandez authored
This CL is part of a series of refactors to move the existing sign-in architecture to the Coordinator-Mediator design paradigm. Fore more information, see go/chrome-ios-signin-migration. Bug: 971989 Change-Id: Iba4a27f8b763697348cbd3f7c5a670fecbabf624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033145 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#737849}
-
Daniel Rubery authored
Download that are prompting the user for an Advanced Protection scan can be kept from the chrome://downloads page. Previously, these did not complete, since the Safe Browsing scan had not finished yet. Allow these to complete. Bug: 1048197 Change-Id: I774ed755fd170579027cb60165e12743f87baad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031716 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737848}
-
Ovidio Henriquez authored
This change refreshes histograms that help determine the health of the Web Bluetooth API by another year. Bug: 1036974, 1036972, 1036971, 1036967, 1036968, 1036969, 1036966 Change-Id: I95afe1886b1ca0fc3104a8d92e39ff79838c76fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008285 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Andrew Grieve authored
It was not filtering out changed symbols. Bug: 1040165 Change-Id: I85c0898788708defda595ccb1f25a5a97d94aa46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032806 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737846}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I792f8fd240f72ca0a6cf643fe9174962f90bd569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018250 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#737845}
-
Clemens Backes authored
The finch runs on all mobile platforms, so also the field trial should run on both android and ios. R=bcwhite@chromium.org Bug: 1040061, 1040030 Change-Id: Ie4f46f66f3357f85fe8c771db3c5bf7392042353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030951Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#737844}
-
dalyk authored
These captive portal checks may occur on either HTTP or HTTPS navigations. The CaptivePortalTabHelper no longer tracks navigations that are renderer-initiated to avoid interference from link doctor and renderer-initiated reload attempts (these navigations, which can be triggered by DNS failures, may otherwise reset the tab state before a captive portal probe result is received). Bug: 10161646 Change-Id: Ia2ac3715d43e9b1be71df1dea7a1882f98033888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870013Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#737843}
-
Alex Moshchuk authored
When the fuzzer runs, it generates calls to create AppCacheHosts with a renderer process ID of 1 (passed via a call to CreateBackend()). After r736660, AppCacheHost's constructor creates a ChildProcessSecurityPolicyImpl::Handle for that process ID, but the handle ends up being invalid because there's no SecurityState registered for that process ID in the fuzzer's environment. That triggers DCHECKs when the fuzzer runs because the handle isn't valid. Fix this by registering the test process ID with ChildProcessSecurityPolicy during fuzzer initialization. Bug: 1047638 Change-Id: I72154b46e89ffa8fceea18757b966593a5452aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034085Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737842}
-
Frank Tang authored
Add a "timezonechange" event and add ontimezonechange event handler to WindowEventHandlers and WorkerGlobalScope interface. Design Doc https://docs.google.com/document/d/1gu-HAVIjVxfPQEE0uQg9Y4tJwYl33Y54DKTA9hfDyic/edit# I2I: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/timezonechange%7Csort:date/blink-dev/4BUSE2aTQEc/bahW7wniCAAJ Behind the blink feature flag TimeZoneChangeEvent Bug: 908550 Change-Id: I582d43ac2c1335cb5443979b3f1019a715dc35fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994529 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737841}
-
Patrick Monette authored
This is a reland of 57213418 The GN dependency error was fixed Original change's description: > [3P blocking] Fix tests accessing the ModuleDatabase on the UI thread > > The ModuleDatabase was moved to its own sequence but both the > IncompatibleApplicationsBrowserTest and ThirdPartyBlockingBrowserTest > test fixtures were not updated. > > This CL moves the accesses to the ModuleDatabase instance to the right > sequence. > > Also added an override for the OutOfProcessQuarantine feature to allow > local testing. This was not an issue on the bots because they respect > the fieldtrial_testing_config.json file. > > Bug: 850517 > Change-Id: I2e8955b33cd7ffc75f74dd56b01df9dec96fc604 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031742 > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737448} Bug: 850517 Change-Id: Ibe99a6d359ec1afe7282b76fc3ad9491c7dee70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035719Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#737840}
-
Colin Blundell authored
This CL introduces an implementation of the //components/security_interstitials SecurityBlockingPageFactory interface in //weblayer in preparation for //weblayer using the component's SSLErrorHandler. In this CL we simply move the creation of interstitial pages that is currently done in //weblayer's ssl_error_handler.cc into the factory. We do not yet introduce creation of interstitial pages that WebLayer does not currently create; that will occur in a followup. Bug: 1030692 Change-Id: I8fd776e29e502fab99c5b4966ed3ca5bebd2e5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028129Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#737839}
-
Ian Kilpatrick authored
Previously a LayoutBox could only store one layout result. Some layout algorithms have multiple passes, e.g. flex, grid, and table layout. This patch allows an additional cache-slot so that we can also cache this (typically only) measure pass. In legacy this was handled by the intrinsic_size_along_main_axis_ cache. This works well, but additional logic needs to be added to keep this cache in sync. For FlexNG we can add a simple 2-way cache to handle this cache. The downside of this approach is that it might end up consuming more memory, as we could potentially have two separate layout trees. This might not be a large of a problem as one would think - as it might be common for the trees to "join-up" a few levels down. We should measure this. If this is a problem, and we want to keep this style of API, we could "hollow" out a NGLayoutResult, (e.g. destroy the children of the physical_fragment) if we set a "layout" result. This would mean we couldn't use the fragment for layout purposes but would keep memory down. This optimization is typically only used for column flexboxes. Bug: 845235 Change-Id: I021bd3b815e150598aca5eb94d061ea4a143ad9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031547 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#737838}
-
Gauthier Ambard authored
This CL fixes the ErrorPageHelper detection of the original URL in an error page URL. It used to not used the same keyword as the creation method. Bug: 991608 Change-Id: Ib826b879e539b5d21ccde2d6e92dbba7adccff49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027334Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737837}
-
Jacques Newman authored
Pixel to point conversion was already being done in ComputeTextAttributes, logic has been factored out into new function on AXPlatformNodeBase Change-Id: I0b219c7bc6318053eeef4673345dec164a0fa5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028759 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737836}
-
arthursonzogni authored
Instead of sending this using this path: blink internal -> blink public -> content/renderer -> content/browser Use: blink internal -> content/browser This avoid crossing many layers and converting in between all the required structs. There were two APIs using WebContentSecurityPolicy. One is left: BeginNavigation. Once BeginNavigation is moved to blink, all the blink::WebContentSecurityPolicy (+5 classes) can be removed. Bug: 1043182 Change-Id: I61625cc189ba85b1e953b1ad88b3a28da9928d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014453Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737835}
-
Lukasz Anforowicz authored
An earlier CL (https://crrev.com/c/1970834) realized that IME tests depend on focus/activation state of the browser window, and to fix test failures moved OutOfProcessPPAPITest.ImeInputEvent test from browser_tests to interactive_ui_tests. In this CL we speculate that the flakiness tracked in https://crbug.com/135403 was caused by running focus-dependent tests in browser_tests + that the flakiness is gone now and the tests can be re-enabled on Linux and Windows. Fixed: 135403 Change-Id: I2b650b213fea722d82cb8e45b792f7c2d0da576f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995500 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#737834}
-
Roman Sorokin authored
This CL fixes system tray still shows "Sign in to another user..." button when all the available users are deleted. Fixed: 955395 Change-Id: I19b6812a27a7c0a0855354bfdd5bed211b934228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034529Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737833}
-
Łukasz Anforowicz authored
This reverts commit ad44950e. Reason for revert: Test flakiness reported in https://crbug.com/1047941 Original change's description: > Relax request_initiator_site_lock checks for PDF plugin. > > In some scenarios (e.g. http range requests for linearized PDFs) the PDF > plugin may need to initiate requests on behalf of the PDF's origin. > Such requests are currently proxied by the renderer process hosting the > plugin (i.e. the renderer hosting the PDF extension - > mhjfbmdgcfjbbpaeojofohoefgiehjai) and therefore go through > URLLoaderFactory that is locked via request_initiator_site_lock to a > different origin (i.e. the origin of the PDF extension, rather than the > origin of the website that hosts the PDF file). > > Before this CL, such requests would be classified by > CorsURLLoaderFactory::IsSane and > VerifyRequestInitiatorLockWithPluginCheck as incorrect and possibly > malicious. After this CL, the request_initiator checks are relaxed by > PluginServiceImpl::FindOrStartPpapiPluginProcess using a new mechanism > similar to AddCorbExceptionForPlugin exemption available for Flash. > > We don't want to relax request_initiator_site_lock checks for renderer > processes hosting arbitrary origins from the web, so as a > defense-in-depth the CL adds a CHECK to FindOrStartPpapiPluginProcess > that verifies the origin lock of the renderer process that is granted > the extra capabilities. > > Relevant tests: > - ChromeFindRequestManagerTest.FindInChunkedPDF (tests that range > request do not result in a request initiator lock mismatch) > - PDFExtensionTest.EnsureInternalPluginDisabled (tests that the PDF > plugin may only be embedded in trustworthy contexts) > - PDFExtensionTest.RedirectsFailInPlugin (the 'noRedirectsSucceed' testcase > tests non-range requests initiated by the PDF plugin) > > Bug: 1027173b > Change-Id: Ib5111fd7a5d5b31727a9754c46c316e75def5143 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986923 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737503} TBR=creis@chromium.org,nasko@chromium.org,yhirano@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027173b Change-Id: Icc030c676025c042b7647f5ac265511bbb6f25cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035857Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737832}
-
Andrew Grieve authored
Bug: 1039421 Change-Id: I236accef33d27ff801c362fa6b46a7ddb61a0d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032805 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Mila Green authored
This adds a new function to mount an updater DMG and run its installer script, as well as a test to verify that functionality. Bug: 1031552 Change-Id: Ica62c90f2a613ed3bd6f1a0dd215dd431fdec58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018150 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#737830}
-
Daniel Rubery authored
Upon feedback from UX, we should be using GetErrorIconSize() in the APP deep scanning prompts. Bug: 1048199 Screenshot: https://screenshot.googleplex.com/CxJwRFQ66UQ.png Change-Id: I9eba847f297520b1f3c5879bf8f748c0c69ad9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033753 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The feature has been launched, no need to explicitly enable it. Bug: none Change-Id: Id73b232d7df9c9726966f74dcedfbe0cfd4cc383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034528 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737828}
-
John Budorick authored
Created by https://ci.chromium.org/b/8889586384407014320 Bug: 922145 Change-Id: Icc08f6d01c001ddaae52e62389d80ffe68f678cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035304 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#737827}
-
Xiaoqian Dai authored
Bug: None Change-Id: I0204923c6fc55f3318471041a68515c4fe391954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035859Reviewed-by:
-
Sammie Quon authored
Also change some ui codes to use new AddChildView. Ran overview enter exit tast test and did not see a noticeable increase in smoothness. But removing layers means we'll likely have less renderpasses in other scenarios, so I think it's still good to do. Also, reduces GPU memory when alt tab is shown. Test: manual Change-Id: Icb1ab23a41adc8f5ecd15c5301f2d041da463ae4 Fixed: 1047020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030047 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#737825}
-
gogerald authored
The issue this CL solves should happen very rarely. Screenshot without feed in single pane: https://drive.google.com/a/google.com/file/d/10BPinS2HA0ciF6TbAJILNoYK9M-8WHAo/view?usp=sharing When there is no Tabs: https://drive.google.com/a/google.com/file/d/1r5_NJO-e1osd2bajyOM24B9ePR_QJI1F/view?usp=sharing Bug: 1047488 Change-Id: I3844a162e1e3e4206738bc8ca60cffbb01093489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031441 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737824}
-
Henrique Nakashima authored
Instead of runNowOrAfterNativeInitialization(), the method should enqueue tasks to run when full browser starts, and not when native is started. There is a distinction - reduced mode means native is started but full browser, which includes Profiles, isn't. This fixes a crash when transitioning from reduced mode to full browser if a task that uses Profile was scheduled with runNowOrAfterNativeInitialization(). Now, it will only run after the transition, rather than immediately. Also change hasNativeInitializationCompleted() to isFullBrowserInitialized() and update clients. All but DownloadMetrics are meant to run in full browser, so that should actually revert their behavior back to what it was before reduced mode was introduced. DownloadMetrics still checks if native was loaded, which includes in reduced mode. Bug: 1045945, 1014098 Change-Id: Icdeed1ad6a1999fe518c551c404285170a7118e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032049Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#737823}
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: I25e94ff9fafb9aaca4d1b8f933ef472f58cd2c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031664Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737822}
-
