GitLab

This patch adds a UseCounter for only synchronous XMLHttpRequests.
This will count exactly once per per page using sync XHR requests.

Review URL: https://codereview.chromium.org/337283003

git-svn-id: svn://svn.chromium.org/blink/trunk@176351 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/340563002

git-svn-id: svn://svn.chromium.org/blink/trunk@176350 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* Add m_closed flag and allow gc after close().
* Assert that no calls from the client comes after close().
* Ensure no callbacks from async operation after close() is called, except getStats.
* Call stop() in the destructor.
* Add tests for garbage collected after close(), but not gc if close() is not called.
* Add tests for getStats() called after close().

BUG=373690

Review URL: https://codereview.chromium.org/329093002

git-svn-id: svn://svn.chromium.org/blink/trunk@176349 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/338383002

git-svn-id: svn://svn.chromium.org/blink/trunk@176348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change add a mutex locker which enters a safepoint while trying to acquire the mutex lock. This means that threads waiting to acquire a lock would be parked allowing a GC.
In addition to entering a safepoint the locker will also ensure that if we block while leaving the safepoint, due to another thread having scheduled a GC, the lock will be released and the safepoint reentered. This allows for the lock to be acquired during sweeping, specifically in weak processing and finalization which could otherwise deadlock and cause the other scheduled GC to time out.

This change does however not fix the issue where the lock has been acquired and another safepoint is entered while having the lock. This could still cause a timeout. There is an instance of this scenario in the webdatabase's DatabaseBackendBase.cpp::performOpenAndVerify where we get the guidMutex and while commiting the transaction enter a safepoint in the SQLiteStatement::prepare and SQLiteStatement::step calls.
To fix the above we have to restructure the webdatabase code to not hold the global guidMutex lock while doing sync operations.

This change does make it less likely that we hit the empty assert in the terminate-during-sync-websql.html test, but due to the above issue it can still happen. We should consider still doing the restructuring in https://codereview.chromium.org/335823002/ to completely get rid of the flakiness.


R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=375671

Review URL: https://codereview.chromium.org/332393002

git-svn-id: svn://svn.chromium.org/blink/trunk@176347 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The make_file_arrays template should probably go in Source/build/ since it
is also used in modules and on mac I'm getting override errors in clang,
but this is a start. Most things compile.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/337703003

git-svn-id: svn://svn.chromium.org/blink/trunk@176346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Scott admits he is not really familiar with what is going on here, so I am
taking the opportunity to step up. Brandon also knows this code well and it's
better to share the responsibility.

NOTRY=true

Review URL: https://codereview.chromium.org/340573003

git-svn-id: svn://svn.chromium.org/blink/trunk@176345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Explicitly introduce the "effective playback rate" concept
in the HTML5 spec and use it to make sure the MediaController's
playback rate is always used when a controller is attached.


BUG=385408
TEST=LayoutTests/media/media-controller-effective-playback-rate.html

Review URL: https://codereview.chromium.org/336303002

git-svn-id: svn://svn.chromium.org/blink/trunk@176344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/338173003

git-svn-id: svn://svn.chromium.org/blink/trunk@176343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow-up to r176130. Ojan noted that the Frame might not have an
ownerRenderer, this patch adds a check for that scenario.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/339873003

git-svn-id: svn://svn.chromium.org/blink/trunk@176341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/341543003

git-svn-id: svn://svn.chromium.org/blink/trunk@176340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

need to apply the string manipulations to strings obtained in a more
general manner.

The function cannonicalize() now becomes a method of XSSAuditor, and 
is the main entry point for performing all such operations. Other methods are
renamed to refer to canconicalized strings.

In order to apply this everywhere, canonicalize() needs to know whether any
truncation is to be applied at all (e.g. we're processing the request URL
or post body and must use it all), so introduce a new enum constant for this
case.  Rename the enum while we're at it to indicate its close relationship
to truncation.

Having done this, several methods can now become functions for truncating strings.

I also removed some indentation from eraseAttributeIfInjected().

Review URL: https://codereview.chromium.org/338193002

git-svn-id: svn://svn.chromium.org/blink/trunk@176339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/330293002

git-svn-id: svn://svn.chromium.org/blink/trunk@176336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL de-flakes the http/tests/navigation/ping-* suite by ensuring
that each test generates its own ping file dump, and that the temp
directory is consistently used.

Review URL: https://codereview.chromium.org/334113003

git-svn-id: svn://svn.chromium.org/blink/trunk@176335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=385549
TBR=pfeldman

Review URL: https://codereview.chromium.org/338253007

git-svn-id: svn://svn.chromium.org/blink/trunk@176333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch also cleans up and fixes a bunch of codemirror-related externs

R=lushnikov
NOTRY=true

Review URL: https://codereview.chromium.org/334393004

git-svn-id: svn://svn.chromium.org/blink/trunk@176332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A V8 parser fix now correctly causes invalid JS
to throw syntax errors.

https://code.google.com/p/v8/issues/detail?id=3371

I assumed the tests would Fail and didn't anticipate them timing out.

BUG=383596
TBR=ojan

Review URL: https://codereview.chromium.org/334393005

git-svn-id: svn://svn.chromium.org/blink/trunk@176331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/342443002

git-svn-id: svn://svn.chromium.org/blink/trunk@176330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reflects recent spec update.

spec: http://dev.w3.org/csswg/css-font-loading/#fontface-interface

BUG=
TEST=fast/css/font*

Review URL: https://codereview.chromium.org/335333002

git-svn-id: svn://svn.chromium.org/blink/trunk@176329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/335383004

git-svn-id: svn://svn.chromium.org/blink/trunk@176328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381612
TEST=fast/text/update-sans-serif-and-recalc-style.html

Review URL: https://codereview.chromium.org/335393002

git-svn-id: svn://svn.chromium.org/blink/trunk@176327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376194

Review URL: https://codereview.chromium.org/337353002

git-svn-id: svn://svn.chromium.org/blink/trunk@176326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds JSDoc for "WebInspector.Foo.bar" methods and fixes
induced errors:
- adds typecasts where required;
- removes unused code violating JSDoc, which was not checked previously;
- adds missing "useCapture" addEventListener() arguments (they are
  required by the current compiler and will be fixed after the
  compiler roll).

R=yurys@chromium.org, vsevik, yurys

Review URL: https://codereview.chromium.org/340513003

git-svn-id: svn://svn.chromium.org/blink/trunk@176325 bbb929c8-8fbe-4397-9dbb-9b2b20218538

this is the first patch. It does only disable debugger if an experiment settings is on.
In the following patches will block panel from switching.


BUG=

Review URL: https://codereview.chromium.org/335403003

git-svn-id: svn://svn.chromium.org/blink/trunk@176324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The isInt variable of CSSParserValue was often not initialized in CSSGrammar.y.
This CL fixes that.

BUG=385386

Review URL: https://codereview.chromium.org/340503002

git-svn-id: svn://svn.chromium.org/blink/trunk@176323 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381910
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/339173002

git-svn-id: svn://svn.chromium.org/blink/trunk@176322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With the Speech API now using Oilpan by default, follow up and also
heap allocate the platform-level intermediary objects.

R=tkent@chromium.org,haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/339823003

git-svn-id: svn://svn.chromium.org/blink/trunk@176321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/342463002

git-svn-id: svn://svn.chromium.org/blink/trunk@176320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381470
R=yurys@chromium.org, pfeldman@chromium.org, vsevik, yurys

Review URL: https://codereview.chromium.org/321113005

git-svn-id: svn://svn.chromium.org/blink/trunk@176318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey@chromium.org, yurys@chromium.org, aandrey

Review URL: https://codereview.chromium.org/332173004

git-svn-id: svn://svn.chromium.org/blink/trunk@176317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Recently protocol was changed, but invocation remained unchanged.

BUG=245436
TBR=vsevik@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/336393002

git-svn-id: svn://svn.chromium.org/blink/trunk@176316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method allows to avoid direct access to implementation specific RecordType enum.

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/342473003

git-svn-id: svn://svn.chromium.org/blink/trunk@176314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/341493002

git-svn-id: svn://svn.chromium.org/blink/trunk@176312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL broke browser_tests (WebSocket2):
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/8151

> [WebSocket] bufferedAmount should not decrease inside a task.
> 
> The spec says that bufferedAmount must not decrease in the task that
> send() is called.
> Fixed both the new and the old implementation although the old implementaion
> is at any rate broken (bufferedAmount in the old implementation includes
> the protocol overhead).
> 
> BUG=159563
> 
> Review URL: https://codereview.chromium.org/311993006

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/338243006

git-svn-id: svn://svn.chromium.org/blink/trunk@176311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This broke browser_tests (WebSocket2):
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/8151

> ThreadableWebSocketChannelClientWrapper don't need suspend / resume code.
> 
> As the WebSocket class handles suspend / resume, we can remove the suspend /
> resume code from ThreadableWebSocketChannelClientWrapper.
> 
> BUG=384238
> R=tyoshino
> 
> Review URL: https://codereview.chromium.org/333223002

TBR=yhirano@chromium.org

Review URL: https://codereview.chromium.org/338343002

git-svn-id: svn://svn.chromium.org/blink/trunk@176310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This broke webkit_unit_tests in Android bots:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14135


> Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled.
> 
> The content should take total window width while overlay-scrollbar is enabled. 
> 
> BUG=382900
> 
> Review URL: https://codereview.chromium.org/333633003

TBR=sanjoy.pal@samsung.com

Review URL: https://codereview.chromium.org/338993005

git-svn-id: svn://svn.chromium.org/blink/trunk@176309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov

Review URL: https://codereview.chromium.org/339853003

git-svn-id: svn://svn.chromium.org/blink/trunk@176308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
When doing tracing across threads I hit an assert due to tracing the SMILTimeContainer's hashmap from a different thread than the one it was allocated on. Basically in HashTable's trace method we call isEmptyOrDeletedBucket which ends up calling PairHashTraits::emptyValue which makes a pair<WeakMember<SVGElement>, QualifiedName> initialized with the individual empty values. This causes the nullQName to be copied to the new pair which causes a ref() in RefCountedBase hitting ASSERT(m_verifier.isSafeToUse()).

With this change all global or static local QualifiedNames are ignoring ref counting. This is similar to the way StringImpl works.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/311803003

git-svn-id: svn://svn.chromium.org/blink/trunk@176307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes dependency on WebInspector.TimelineModel.RecordType as underlying implementation may use tracing events in which case coalescable types should be from  WebInspector.TracingTimelineModel.

BUG=361045

Review URL: https://codereview.chromium.org/336373002

git-svn-id: svn://svn.chromium.org/blink/trunk@176306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1) fix inlined DataGrid columns widths
2) fix left border
3) do not show corner column

BUG=

Review URL: https://codereview.chromium.org/334183003

git-svn-id: svn://svn.chromium.org/blink/trunk@176305 bbb929c8-8fbe-4397-9dbb-9b2b20218538