- 27 Mar, 2018 40 commits
-
-
John Budorick authored
Should fix webrtc's use of generate_jni after https://chromium-review.googlesource.com/c/chromium/src/+/979610 Bug: 799759 Change-Id: I838af362d81036afb8bc493a90c4faa3c4c9b467 Reviewed-on: https://chromium-review.googlesource.com/982010Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#546170}
-
John Budorick authored
Bug: 776495,776496,783000,783001 Change-Id: Ia69e1b225fc4ff6133316921e139ad60a8a92d6a Reviewed-on: https://chromium-review.googlesource.com/982247Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#546169}
-
Brian Anderson authored
This adds the StreamAnalyzer class, which is responsible for calculating the mean, rms, smr, standard deviation, variance of roots, and threshold percentiles of a continuous stream of values. It owns a Histogram and a WindowedAnalyzer, which it uses to delegate percentile estimates and to track regions of time where metrics are worst. Bug: 807463 Change-Id: I718b06778582d0628b964747f61352ae291452f0 Reviewed-on: https://chromium-review.googlesource.com/972568 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#546168}
-
Robert Flack authored
Both are in cc/OWNERS for animation but these often touch ui/compositor as well. Bug: None Change-Id: I7f22b0c27113c1a3ddada05bb69cbde19c8aa619 Reviewed-on: https://chromium-review.googlesource.com/982265Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546167}
-
Josh Karlin authored
Requests served from memory cache don't have the is_ad bit in their newly minted ResourceRequests. The bit is needed by the AdTracker class that receives a probe on WillSendRequest. This CL copies the bit over to the new request and tests it. Bug: 807640 Change-Id: I9656446be52eb19159a84c26cbdf47905a0e1989 Reviewed-on: https://chromium-review.googlesource.com/980700Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546166}
-
Adithya Srinivasan authored
Most of the overloads could be directly converted to const. The only exception was HTMLEmbedElement that needed some refactoring in HTMLPluginElement in order to be const. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64ea48d7580977d394f927b0653b48f71f496521 Reviewed-on: https://chromium-review.googlesource.com/980591Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#546165}
-
Matthew Jones authored
This change removes the ability to directly change the bottom sheet's state from explore-on-content. The feature now requests that its content be shown through the BottomSheetController. Bug: 822949 Change-Id: Ib551c7fe391f7e62ea06a15eafd645e5cff3ab28 Reviewed-on: https://chromium-review.googlesource.com/981453 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#546164}
-
Luna Lu authored
Bug: 818684 Change-Id: I6358926667c913988fab0ca4a39f25cbc4f04734 Reviewed-on: https://chromium-review.googlesource.com/969076 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#546163}
-
Daniel Park authored
> Creates flags for home page button > Logs preference changes in new histogram > Sets home page default as NTP if home page was displayed by flag Bug: 822469 Change-Id: I2c0a00f11de254f663e453f32aaab7d43ad7e761 Reviewed-on: https://chromium-review.googlesource.com/972461 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#546162}
-
Samuel Huang authored
This CL modifies linker_map_filter.py to add a filter for object filenames. This enables Supersize to run for LTO (under LLD) without crashing -- although some data are missing (to be fixed in follow-ups). Bug: 723798 Change-Id: I90b7439368cca96921d688b0c9db95a599fa2bca Reviewed-on: https://chromium-review.googlesource.com/982254Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#546161}
-
Tom Anderson authored
R=dpranke Change-Id: I9f93686d2bab2d3625363142bb05349817e1c5b5 Reviewed-on: https://chromium-review.googlesource.com/982250Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#546160}
-
Matt Wolenetz authored
Since FFmpeg decode of 0-byte audio and video buffers is now disallowed, and FFmpegDemuxer skips enqueuing such packets into its DemuxerStream, this change does similar for MSE: Any 0-byte |data| audio or video buffers are dropped during initial processing in FrameProcessor::ProcessFrames(). No 0-byte |data| text buffers are dropped, because: * We don't use FFmpeg to decode in-band MSE text, and * In-band MSE text buffers' |side_data| may contain meaningful information. (This assumption isn't asserted by this change). Note, this change takes the simpler route of dropping 0-byte AV buffers before they're buffered by the coded frame processing algorithm. A more complex alternative to skip them when reading from SourceBufferStream was rejected in hopes this simpler change is sufficient. Includes ability in ChunkDemuxerTest to vary |block_size_| instead of always using |kBlockSize|. While the product change is closer to FrameProcessor, FrameProcessorTests always encode the coded frame's timestamp as the coded frame contents to enable precise verification of processing results, so the test of this change is done via ChunkDemuxerTest instead. BUG=823375,663438 TEST=ChunkDemuxerTest.ZeroLengthFramesDropped Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie6a802ba64a576f0219ca7c400fc7dec3a45fbf6 Reviewed-on: https://chromium-review.googlesource.com/974427 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#546159}
-
Bo Liu authored
Two reasons. One is that these callbacks should not happen if renderer process crashed. Looks like this (and a few others) are missed because they are synchronous and called from AwContentsClient instead of AwContentsClientCallbackHelper. Second reason which is relevant to the bug is that we should not callback to the app if webview is already destroyed. This can happen when a native->java jni call uses a jweak which can resurrect objects that are effectively destroyed already. Bug: 824156 Change-Id: I0a8d59e2f36070d7a4c53242ce077bda3c9bfe73 Reviewed-on: https://chromium-review.googlesource.com/981433Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#546158}
-
Devlin Cronin authored
The 'schemaUtils' and 'json_schema' JS bindings files are no longer needed with native bindings. Don't include them as resources in the dispatcher's source map. Bug: 810487 Change-Id: I7476069311b7ba7d0ffc0a2e37a01dcd43808c66 Reviewed-on: https://chromium-review.googlesource.com/981261Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546157}
-
Adam Langley authored
git cl format reformats this file, causing superfluous changes in CLs. To avoid noise, this change makes clang-format happy. Change-Id: I9b7f0b310be18aadccec5b19870ad8c05df0af4d Reviewed-on: https://chromium-review.googlesource.com/974295Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#546156}
-
Jiaquan He authored
Cover more failing cases in ArcPlayStoreSearchProvider. Bug: 765757 Change-Id: Idb04ffc4a2b7fbeb40df183b6cefb0a00a0f2841 Reviewed-on: https://chromium-review.googlesource.com/736677 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#546155}
-
sczs authored
Bug: 822987 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7aa275e08846b1ea9b067de343f6a631a56db566 Reviewed-on: https://chromium-review.googlesource.com/972163 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#546154}
-
Gustav Sennton authored
android_webview/support_library/ contains 1. boundary interfaces (mirrored into the Android support library). 2 the support library glue (gluing the boundary interfaces together with the rest of chromium). Bug: 781754 Change-Id: I903c2165ece5192364ab2d257074304317692114 Reviewed-on: https://chromium-review.googlesource.com/980973Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#546153}
-
Weiyong Yao authored
URL.createObjectURL with media streams is deprecated and will be removed in M68, around July 2018. Please use HTMLMediaElement.srcObject instead. Bug: 826088 Change-Id: Ic1793ce689b0dad667ba80065b13bfafb1b84c79 Reviewed-on: https://chromium-review.googlesource.com/981601Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#546152}
-
Elly Fong-Jones authored
This utility function makes the bubble stay anchored when fullscreening the window. Most other chrome bubbles inherit from one of the extension or location decoration bubble classes and therefore already have this behavior, but SessionCrashedBubbleView is unusual. Bug: 825904 Change-Id: Ibc482f9f3f29de9e049b26770463f7e1d2a19c96 Reviewed-on: https://chromium-review.googlesource.com/981234 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#546151}
-
Alexei Svitkine authored
The old UMA hw class API is kept behind a base::Feature in case we need to revert. Also updates some comments where we were using ChromeOS instead of Chrome OS, which is preferred. Bug: 810872 Change-Id: I6ca101432da58ca36ec0d4a85cca745e7700257b Reviewed-on: https://chromium-review.googlesource.com/978518Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#546150}
-
Kyle Lund authored
This CL allows the chromecast BLE API to be called from a sequenced context instead of only from a single-threaded context. This CL also adds the helper function BindToCurrentSequence, which is very similar to the existing BindToCurrentThread. BUG=internal b/76227019 TEST=Build. Also built and ran in eureka-internal to confirm this allows calls from a sequenced context. Change-Id: I748b14d2910ff683ad3450adc9783d313eb0486b Reviewed-on: https://chromium-review.googlesource.com/981612Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Kyle Lund <kylelund@google.com> Cr-Commit-Position: refs/heads/master@{#546149}
-
Ioana Pandele authored
Re-enable password export when the activity view disappears, instead of when completionWithItemsHandler is called. This has the potential to be a premature re-enabling, if the user decides to background the app launched from the activity view and come back to Chrome’s password settings. Re-triggering the export in this case might cause a conflict between multiple exported files. To mitigate this issue, each exported file is stored in its own uniquely identified folder in tmp/passwords/. If completionWithItemsHandler is called, the file and its folder are removed. For the cases in which the completion handler is not called, the rest of the files are deleted at startup. Bug: 820053 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5683acfe8483876c0aeb81ce25ba83b24f109676 Reviewed-on: https://chromium-review.googlesource.com/974181 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#546148}
-
Roger McFarlane authored
There's a leak being detected by the Chromium OS ASan LSan bot when loading the test pdf files. Adding tracing of the filenames to see which one(s). Bug: 826055 Change-Id: I9ad1c6a3d67c906e2713492271b68139803d59c4 R: battre@chromium.org TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/980962Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#546147}
-
Evan Stade authored
This reverts commit cb950738. Reason for revert: suspected of performance regression: crbug.com/825005 Original change's description: > Fixed more Document leaks in Autofill > > Some Autofill-related code can hold persistent reference to last > changed or focused <input> element that cause leak of whole Documents > containing such element after navigation to other page. > > Some leaks fixed in https://chromium-review.googlesource.com/939224 > This CL fixes other related leaks. > > Bug: 734427 > Change-Id: Ic084d0670cccb9d11595d0bde8cf0d605bfa8911 > Reviewed-on: https://chromium-review.googlesource.com/970582 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544404} TBR=estade@chromium.org,dvadym@chromium.org,atimoxin@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 734427 Change-Id: I57bd57e50af5d8e4f4d97b731a354fd7b0957966 Reviewed-on: https://chromium-review.googlesource.com/981292Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#546146}
-
Stephen McGruer authored
Previously nullable values in the animations code were tracked by storing nulls as quiet_NaN() and using std::isnan as a null-detector. It is much more explicit to store such values using WTF::Optional, which forces code to consider whether or not the offset exists. Bug: 791086 Change-Id: Ice80a1d3d686b0ff1f0bc2a1f3eac2eff51a8e38 Reviewed-on: https://chromium-review.googlesource.com/981076Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#546145}
-
Alexei Filippov authored
Change-Id: I1c1b22016f0f5830c619471b9a2f0081ccb58511 Reviewed-on: https://chromium-review.googlesource.com/981446Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#546144}
-
Ross McIlroy authored
Change-Id: I7ff3a987d132d4ca8e0f350e851020b53d4fb009 Reviewed-on: https://chromium-review.googlesource.com/980947 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#546143}
-
Mounir Lamouri authored
Some tests were failing because of mock methods expectations and non-expectation to be called. The tests are passing locally with the flag on. The flag is not currently enabled on trunk. Bug: 826284 Change-Id: I41d40e5bd85737dde2aa97b778d8c66080a04a2c Reviewed-on: https://chromium-review.googlesource.com/980995Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#546142}
-
Nate Chapin authored
This reverts commit 16fdb6c5. Reason for revert: this was disabled just before the M66 branch point, reenabling on trunk. Original change's description: > Disable framebusting intervention for M66. > > Will reenable on trunk after the M66 branch point passes. M67 is the new target. > > Bug: 624061 > Change-Id: Ied8563bbc21d3df3182a80aa5f5d1706ed0224d4 > > TBR=nasko@chromium.org,ojan@chromium.org,japhet@chromium.org > > Change-Id: Ied8563bbc21d3df3182a80aa5f5d1706ed0224d4 > Reviewed-on: https://chromium-review.googlesource.com/941615 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539998} TBR=nasko@chromium.org,ojan@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 624061 Change-Id: I2db91d03d134cb8aa2febcd5f7d923d45bf41814 Reviewed-on: https://chromium-review.googlesource.com/980896Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#546141}
-
Mounir Lamouri authored
While in VR mode, the Cast button should be hidden as the user can't really use the feature. Bug: 683352 Change-Id: I0402d9adb29521449a65152a486f73313f2d93ab Reviewed-on: https://chromium-review.googlesource.com/980878Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#546140}
-
Alexei Filippov authored
- Make UI.ToolbarInput control to not grab focus on text change. - Make sure revealTreeNode always resolves. BUG=825274 Change-Id: Ibb4439ecc131cc74d51546c0d2247c4579735f9f Reviewed-on: https://chromium-review.googlesource.com/978858 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#546139}
-
Andrey Kosyakov authored
This removes SSLInfo in URLLoaderClient::OnReceiveResposne(), since SSLInfo is now available as part of ResourceResponseHead (AKA network.mojom.URLResponseHead) that this method already receives. TBR=dcheng@chromium.org (for security review of url_loader.mojom, where a parameter is being removed) See also: https://chromium-review.googlesource.com/c/chromium/src/+/978623 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I15d744b85fbb0055f70397527ab82421c61713bf Reviewed-on: https://chromium-review.googlesource.com/979263 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#546138}
-
Peter E Conn authored
Use the Origin class a bit more thoroughly. Basically after verifying a CustomTabSession with an origin, a Trusted Web Activity would succeed navigating to the origin but fail (fall back to a Custom Tab UI) navigating to a subpath under the origin. Bug: 800422 Change-Id: I1877477bcf307b00cf87386ed7787b217a734512 Reviewed-on: https://chromium-review.googlesource.com/978006 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546137}
-
Simon La Macchia authored
Problem: Setting switches::kReportVp9AsAnUnsupportedMimeType command line flag on the Main process has no affect, as it is not white-listed to be propagated to the render process in: RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer() Solution: Add switches::kReportVp9AsAnUnsupportedMimeType to white-list Bug: None Change-Id: I037edfd0457d7ae87743854b8fd7d2d92e7f5107 Reviewed-on: https://chromium-review.googlesource.com/981392Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546136}
-
bsheedy authored
Adds bsheedy to chrome/browser/vr/OWNERS for the VR browser test-related code in chrome/browser/vr/ and chrome/browser/vr/test. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9ac6b819f9551c40b37e559184ea9bf9dab85df8 Reviewed-on: https://chromium-review.googlesource.com/981513Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#546135}
-
Andrey Kosyakov authored
Bug: 721408 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I037a0c3e5f91b284700cddfd5c5253f01aa7fde2 Reviewed-on: https://chromium-review.googlesource.com/978623Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#546134}
-
Andrii Shyshkalov authored
TBR=nodir@chromium.org Bug: 731360, 826308 Change-Id: Ic083772c8e0ce8f5ff5fb441074d39836155b418 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/980926Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#546133}
-
Lily Houghton authored
NotifyProxyServiceOfChange -> NotifyProxyResolutionService ProxyServiceTest -> ProxyResolutionServiceTest CreateProxyService and related functions -> CreateProxyResolutionService This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/857421 TBR=stevenjb@chromium.org,sky@chromium.org,sdefresne@chromium.org,sdefresne@chromium.org,mmenke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I25d80931839ba8c71e2863a0b275419ba9ec5368 Reviewed-on: https://chromium-review.googlesource.com/944005 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#546132}
-
Sergey Berezin authored
This reverts commit a28ac453. Reason for revert: The bug is fixed, the original config should work again. Original change's description: > ios-simulator*: specify dimensions directly > > This is to mitigate the immediate fire (see the bug). > > PLEASE REVERT once the bug is fixed. > > BUG=825843 > R=justincohen@chromium.org,maruel@chromium.org > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I87f20f1eff838fa535970da1e2271c0dbffe939f > Reviewed-on: https://chromium-review.googlesource.com/981448 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545883} TBR=maruel@chromium.org,justincohen@chromium.org,sergeyberezin@chromium.org,martiniss@chromium.org Change-Id: If51b71c56092c2685d7cce1e3cb12c633678f8d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825843 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/982105Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546131}
-