- 24 Apr, 2019 40 commits
-
-
Sam Zackrisson authored
The acoustic echo canceler AEC2 is being deprecated. There are already no clients reporting *AecDelayAdjustmentMsSystemValue. *AecDelayAdjustmentMsAgnosticValue reports have drastically decreased since the AEC3 rollout, and are practically non-existent in M73+. Bug: webrtc:10563 Change-Id: I8999169ac4f236296cd1873289c423745edb57d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572349Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#653503}
-
Matthew Mourgos authored
Bug: 953525 Change-Id: I3541430056b9924d9d249f4c6329c249b74bb172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574610 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#653502}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a161493942fa..ea1b0983c7b4 git log a161493942fa..ea1b0983c7b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 swiftshader.regress@gmail.com Regres: Update test lists @ ed46cde6 Created with: gclient setdep -r src/third_party/swiftshader@ea1b0983c7b4 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I807d1c0b0f96f5608cd4afae5e151bb9b72cf1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653501}
-
Kuo Jen Wei authored
This CL include following UI changes and bugfixes: 1. Fix CCA window size ratio to 16:9 under all modes. 2. Centered camera-mode icons on preview. 3. Fix bug measuring square mode preview in original video size bug 4. Fix w-letterbox-l not working bug. 5. Fix switch to/from square mode preview position jumping before ready. Bug: 954672 Change-Id: I580e08db2fec3face310ca7cbf20a3edbfee6422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563132Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#653500}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/792f3c373f12..14af258cab9d Created with: gclient setdep -r src-internal@14af258cab9d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I0bc24934c91f8d7dcbb6d913820f823781f9f2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580906Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653499}
-
Dominic Mazzoni authored
This change changed the accessibility tree to be built using LayoutTreeBuilder: crrev.com/c/1547617 This caused crbug.com/951503 - a crash in blink::AXNodeObject::AddChildren, due to a node being deleted while it was in the process of iterating over its children. I can reliably reproduce this crash by loading https://www.komputerswiat.pl/gamezilla when accessibility is enabled. I discovered that the root cause was due to the change in AXObjectCacheImpl::GetOrCreate(LayoutObject*) - specifically code that identifies an old entry in the node mapping that needs to be updated. The problem with the code is that it assumes there's a 1:1 mapping between nodes and layout objects - but this isn't always true. When there's a continuation, you could have two layout objects that correspond to the same Node. The fix is easy - just check node->GetLayoutObject and skip checking the node mapping if it's not the same. Bug: 951503, 835455 Tbr: nektar@chromium.org, aboxhall@chromium.org Change-Id: Ie5bc4fa5766f00bc8fe882454a5d15a1467f198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580140Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#653498}
-
Yoichi Osato authored
This CL adds a websocket performance test where client receives arrayuffer of 1 mega bytes 100 times. Test: $ cd third_party/blink/perf_tests/websocket $ npm install $ npm start $ python ../../../../tools/perf/run_benchmark run blink_perf --browser=canary --test-path=websocket\receive-arraybuffer-1MBx100.html or open the file directly on browser. Rough result (avg ms of 6 runs) on Windows10, 28-core CPU of 2.6GHz: Chrome Canary(m75): 1709 Canary w/o extension: 637 FireFox: 338 Bug: 954000 Change-Id: Ica622aba18d57af2c97f11019588762544008d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573436Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#653497}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ed46cde6ee67..a161493942fa git log ed46cde6ee67..a161493942fa --date=short --no-merges --format='%ad %ae %s' 2019-04-24 chrisforbes@google.com Set up input attachment descriptors the same as storage images Created with: gclient setdep -r src/third_party/swiftshader@a161493942fa The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131171141 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I0f7b5d087c3eed903e122cb5df731c62394a12c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580905Reviewed-by:
-
Reilly Grant authored
This change updates ChooserContextBase's GrantObjectPermission() method to take url::Origins instead of GURLs. In the process the internal GetWebsiteSetting() and SetWebsiteSetting() methods have also been modified to take url::Origins. This is part of a migration effort to remove GURL from the interface of ChooserContextBase and its subclasses. Bug: 951785 Change-Id: I88878374ca4c8c1d56cb6f05614fb76f70ac4f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579477Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#653495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e81acfb18dab..792f3c373f12 Created with: gclient setdep -r src-internal@792f3c373f12 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: I280a4f6537b165737343f3c7790ad347b7f2a8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580904Reviewed-by:
-
Tarun Bansal authored
based study to holdback data reduction proxy. Change-Id: Ib3c900ea4bd3441272051b53911a1f46e216a020 Bug: 954958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578127 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#653493}
-
Tsuyoshi Horo authored
This class is used only in the browser process. Bug: 935267 Change-Id: I165997ea73ec8da973a8cade28bdebf9fad532e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580684Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653492}
-
Miyoung Shin authored
Replace the use of std::map of std containers with WTF::HashMap in screen_orientation_controller_impl_test.cc. Bug: 952716 Change-Id: Idb53fa6890aed3120224f5027d8791301416f9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580685Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#653491}
-
Hajime Hoshi authored
This is reland of https://chromium-review.googlesource.com/c/chromium/src/+/1536036 This was reverted once since ServiceWorkerTest.UpdateRefreshesServiceWorker became flaky on Windows, but now this doesn't, though the reason is unclear. This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual case that JavaScript is executed: ./tools/perf/run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:media:soundcloud:2018 As this is a non-standard JavaScript API execution, we adopted kInternalDefault as the task type. Bug: 913912 Change-Id: Id03b1ac9f46e6c69adea8cd42c6af193dd83fa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578144Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653490}
-
Miyoung Shin authored
Replace the use of std::map and std::string of std containers with WTF::HashMap and WTF::String in mhtml_archive_test.cc and unit_test_helpers.cc/h. Bug: 952716 Change-Id: I89a22163c5aafc64fb4f885721129b17cefb965f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580979Reviewed-by:
-
Andrey Kosyakov authored
Change-Id: I0b63dcfd3bd7f5a04340e21ed63b5c49a9c7e318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580763Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#653488}
-
Kent Tamura authored
According to the HTML standard, updating defaultValue should keep selectionStart/End, and clamp them if the new value is shorter than them. defaultValue setter doesn't have any explicit selection behavior [1], and we should apply default selection adjustment algorithm in such case [2]. The new behavior matches to Edge, Firefox, and Safari. Some test cases in selection-start-end-extra.html were not correct. This CL fixes them. Remove some test cases in textarea-selection-preservation.html because they are covered by WPT. [1] https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element:dom-textarea-defaultvalue-2 [2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#textFieldSelection:concept-textarea/input-relevant-value Bug: 822639 Change-Id: I77db0934bb10774561e947f64b4cb3f88c293679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575317 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#653487}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7f0d25d9bc6..e81acfb18dab Created with: gclient setdep -r src-internal@e81acfb18dab The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Iac5df1d9de07cbb688b290d9030817e2dfca40ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580902Reviewed-by:
-
Miyoung Shin authored
Replace the use of std::map of std container with WTF::HashMap and WTF::HashCountedSet in css_image_generator_value.cc, and add HashTraits for FloatSize to use it as the HashMap key. Bug: 952716 Change-Id: I0417570fc3cf375ef3ed9ea6759ad26b64b9d56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575315Reviewed-by:
-
Timothy Loh authored
This CL adds the Plugin VM icon (from crbug.com/950738) to the settings menu. As the provided icon was 20x20, this is scaled up 1.2x to match other icons at 24x24. Bug: 950431 Change-Id: I303839926b2f638fd0e6af858770d1b849be61d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565732Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#653484}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3398754c6a8b2435fa3ff6fbe40a5bacda93c407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580901Reviewed-by:
-
Peng Huang authored
With this CL, SkiaOutputSurface* will gather begin and end semaphores from shared images and wait on and signal with skia flush. Know issues: * ExternalVkSharedImage is not migrated to this new change. Bug: 944194 Change-Id: I630e31af52fab361759581317d9781a367a3a383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572235Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#653482}
-
Hirokazu Honda authored
There is no comment for RGB VideoPixelFormats. That makes it unclear what order the formats are defined, byte-order, big endian word-order, little endian word- order. This adds comments of byte-order definition to RGB VideoPixelFormat. Bug: None Test: None Change-Id: I9221f328b9427f1cd5035684a4aaf4051b0d2dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567578 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#653481}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I2aa8ad03a6f9b0a03afc740d61223ac9f5f10a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580470Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#653480}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/42eb66c167ee..95b5ef9328dd git log 42eb66c167ee..95b5ef9328dd --date=short --no-merges --format='%ad %ae %s' 2019-04-23 roopeshr@google.com chromeos_config: Make Mistral as improtant board. Created with: gclient setdep -r src/third_party/chromite@95b5ef9328dd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I09b19fd24bbfad341320f2ad6879ee489b06385e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580446Reviewed-by:
-
Shakti Sahu authored
Bug: 951836 Change-Id: I174bb435d3b0b4409492b17cd88de3a340d07657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575636Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#653478}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/288c3129a817..a7f0d25d9bc6 Created with: gclient setdep -r src-internal@a7f0d25d9bc6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:954594 TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ib24c5f7befedffd656f1d8df30b111df32220cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580879Reviewed-by:
-
Daniel Cheng authored
Network service embedders that use the resource_type field can provide a custom definition of the enum to suit their needs. Tbr: jochen@chromium.org Change-Id: I27c04257c90e8cf0353287b7ec8971593772dac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575519 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Mike Klein authored
So close... this is not one of the types of strings that's auto rebase_path()'d, so do it ourself. This time I've actually checked that building with #include SK_USER_CONFIG_HEADER in SkTypes.h works. Change-Id: Id9848f04412d34695094c35d8267dd177ec35ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580040 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#653475}
-
inglorion authored
This enables ThinLTO explicitly on ToTWinOfficial. Eventually, the plan is to have ThinLTO implied by the build being official. Setting it explictly now allows us to test that configuration before making that switch. R=dpranke,hans,rnk Bug: 598772 Change-Id: Ibf4a3aeec5ccf3e84abfc35dd294a82e3f884507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576515Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#653474}
-
Asanka Herath authored
Split off from follow up CLs for ease of review. Bug: 927182 Change-Id: I03b122b8378d85ba80c975981b67ada43e349f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546234Reviewed-by:
-
Ben Chan authored
cromo has been deprecated and will be removed. This CL removes all D-Bus bindings to cromo. Bug: 954634 Change-Id: I25dd909b246bb156ada6bd529957dd857bdbf8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580480Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653472}
-
Shakti Sahu authored
This CL adds 16dp padding to the image grid section. In order to keep the image width same across all the images, we use negative right edge offset for the grid view item decorations. Bug: 954437 Change-Id: I7b81be33c1c0d19549a29392301b3f64075a2f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574435 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Alan Cutter authored
Bug: 933676 Change-Id: I2b23d37608636cc7f5c3588d6ee7305dfb0f05f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580681 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
WebAppBrowserController should be Extensions agnostic. If we need |reason| or |source| in the future, we will add a nested enum in WebAppBrowserController. Bug: 953540 Change-Id: I6e277394993f474429ce8490dbd564ce9da7d87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570945Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#653469}
-
Yu-Hsuan Hsu authored
We should pause media after detaching active the audio output to avoid playing audio from other nodes. For example, it is annoying that hearing audio from the internal speaker when a bluetooth device disconnects. BUG=905923 Change-Id: Iace7eca996156b185a387848ffb27246fa945965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571111Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653468}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e9fa6a97fea6..d8beda83b669 git log e9fa6a97fea6..d8beda83b669 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 tsepez@chromium.org Remove potentially tree-corrupting methods from CXFA_LayoutItem. Created with: gclient setdep -r src/third_party/pdfium@d8beda83b669 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6877a87ab6e34f181b598917453a4fb3f5dc671f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580345Reviewed-by:
-
Antonio Gomes authored
In summary this CL: - Moves content/renderer/image_capture/image_capture_frame_grabber.cc|h to t_p/blink/renderer/modules/imagecapture/. - Changes t_p/blink/renderer/modules/imagecapture/image_capture.cc to instantiate ImageCaptureFrameGrabber directly, instead of calling out to RendererBlinkPlatformImpl::CreateImageCaptureFrameGrabber(). - Removes WebImageCaptureFrameGrabber altogether. - Removes the API in [1] creates WebImageCaptureFrameGrabber, as well as its overrides. Additionally, in order to create CrossThreadBind instances that pass ScopedWebCallbacks instances, a specialized template of CrossThreadCopier was local to [2]. [1] third_party/blink/public/platform/platform.h [2] third_party/blink/renderer/modules/imagecapture/image_capture_frame_grabber.cc Change in [3] were needed to be extended in order to allow the use of //media/base and //third_party/libyuv identifiers, similarly to media_capabilities and mediastream blink modules. [3] third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py R=haraken@chromium.org CC=blink-reviews-blink@chromium.org BUG=787245 Change-Id: I86f75aa6e3483db2d0b7e7243c7f9cc3239f9507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576468Reviewed-by:
-
rajendrant authored
This is a reland of 0ee0c8f9 after disabling the test that failed when network service is off Original change's description: > Disable DRP proxies that fail warmup fetch in config > > Warmup url fetch happens on startup and depending on whether it succeeds > the http/https proxy should be enabled or disabled in the custom proxy > config in network service. However the proxies are not getting disabled. > This CL fixes that and also adds a feature flag to turn off this > behavior. > > Bug: 954958 > Change-Id: I22f0dc4cfb0ef58b4922ecfe9ba57009744aba8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579026 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653378} Bug: 954958 Change-Id: I77d71c4c42f38dc2c6ba8b8bc55e4b0971c410d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580760Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#653465}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/34fa2d0df828..42eb66c167ee git log 34fa2d0df828..42eb66c167ee --date=short --no-merges --format='%ad %ae %s' 2019-04-23 seanabraham@chromium.org validation_pool: Filter to CrOS commits before trying to POST to Gerrit commits Created with: gclient setdep -r src/third_party/chromite@42eb66c167ee The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8fdde7634d4d6ec0ad43f3397a34021f14c36049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580340Reviewed-by:
-
