GitLab

Before, the background size was reconstituted from the layer tree by
taking the union of of black and video layers. Now, the actual size is
plumbed through.

Change-Id: I0cb643b350ef7e4fca06e3bfd419e24861a2e3c6
Reviewed-on: https://chromium-review.googlesource.com/1142962Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576521}

Change-Id: Ie5901f9f1188fb271fcf8c2d6482c2fbd490e742
Reviewed-on: https://chromium-review.googlesource.com/1130457
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576520}

This reverts commit 54fcb75f.

Reason for revert: landed too early and causing flakes

Original change's description:
> Reland #3: Switch WindowedNotificationObserver to use base::RunLoop.
> 
> Now it will quit the message loop immediately after receiving the
> notification. Also it does not allow nested tasks anymore.
> 
> Bug: 668707
> Change-Id: I8d8a0ffb073236c3bbd00877bd48cc496b1c5036
> Reviewed-on: https://chromium-review.googlesource.com/982612
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru>
> Cr-Commit-Position: refs/heads/master@{#576110}

TBR=gab@chromium.org,jam@chromium.org,ahest@yandex-team.ru

Change-Id: Ibc82b94b56e77bb9914c74517dd9f755527544f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 668707
Reviewed-on: https://chromium-review.googlesource.com/1143740Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576519}

One new theory of why DWriteFontProxy comes back with empty FontHandles
is as follows: Suppose the renderer process calls an asynchronous Mojo
method A, with callback b and continues execution. Then it reaches one
of the DWriteFontProxy methods, let's call it F, and calls F(). Then
Mojo goes into a blocking loop waiting for responses. Normally it would
just receive the response to F() and continue execution where the font
call left of. However, if A is in flight, there might be a situation in
which the Mojo loop receives the response for A(), then calls callback
b() and the renderer continues to execute in a different spot, until it
reaches another DWriteFontProxy call F2() and calls it synchronously
while a previous one is in flight, which would probably break.

This CL is intended to detect this situation with setting a thread local
boolean while the Mojo DWriteFontProxy call is in flight, and crashing
with an assertion failure if another one is issued while the first
response was not received and processed.

Bug: 561873
Change-Id: I15ad4e3484fec8b793206b1e92f319e58aee1cfd
Reviewed-on: https://chromium-review.googlesource.com/1140497
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576518}

This changes the cross axis alignment for the suggestion view's
BoxLayout to CROSS_AXIS_ALIGNMENT_STRETCH, so that labels will
vertically center themselves on the view.

Screenshots (Googlers only): https://drive.google.com/open?id=1Cfn9vBcJahBGj9oSl_5xRwBt9LDINa60

Bug: 850971
Change-Id: I877988889a6d0a3a07dbca34cb194bd3eef0668a
Reviewed-on: https://chromium-review.googlesource.com/1142371Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576517}

Uses new completion icons in the omnibox.

Bug: 864990
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic062601ec2b0eb665c8e80779ffc04d90bbb5723
Reviewed-on: https://chromium-review.googlesource.com/1143274
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576516}

We are turning off this feature until our framework for detecting if a site is
commonly visited also includes redirects as well.  Worry if a common redirecter
makes it on to our black list, then we would end up blocking all navigations
through that redirecter.

Bug: 859904
Change-Id: I02bb128a422cfce354d83326efc677eb9a8c7462
Reviewed-on: https://chromium-review.googlesource.com/1142038Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576515}

Bug: 710465
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6c42f67335f9335ac3e8d2e003bfdde1d6bfa433
Reviewed-on: https://chromium-review.googlesource.com/1086893
Commit-Queue: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576514}

NOTRY=true  # chromedriver_py_tests flake (https://crbug.com/864205)

Bug: 621126
Change-Id: I61d2722044cffc44e5bc93b5ffc7ff9d3ab6d313
Reviewed-on: https://chromium-review.googlesource.com/1142359
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576513}

Test: manual
Bug: 864236
Change-Id: I6429eb0c469ab473d5edf5db57e717c20e1d28fe
Reviewed-on: https://chromium-review.googlesource.com/1141080Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576512}

When building using jumbo, files gets merged and constants
with the same name may end up in the same scope and conflict.

This commit solves the issue by renaming the constants to
something more file specific.

Bug: 803406
Change-Id: I70976f012e9be6f395d4bfcc43e785515071ebb3
Reviewed-on: https://chromium-review.googlesource.com/1142783
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576511}

The vast majority of recent crash reports point to line 190:
  CHECK(on_handshake_stream_created_has_been_called_);

Next branch cut is around the corner and this is still number one //net
crasher on M69.  https://crrev.com/c/940463 has been clearly identified
as the culprit.  Much pondering was still not enough to understand the
real underlying cause of this crash since the last branch point.  I
propose to be defensive in WebsocketStream.  While this is not the ideal
solution, I am not hopeful that we will find anything better any time
soon.  This approach allows the request to fail safely, while still
retaining the new WebSocket over HTTP/2 functionality.

Bug: 850183
Change-Id: I21a7c3919466c4339bebce41ee8ad1342fb9c179
Reviewed-on: https://chromium-review.googlesource.com/1140916
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576510}

This is a first step towards isolating src/chromeos/dbus and adding
its own BUILD.gn file.

For DEPS file includes, all of which are inherited from src/chromeos:
TBR=rsleevi@chromium.org, dcheng@chromium.org

For minor changes to tests in chrome/browser/chromeos/policy/:
TBR=emaxx@chromium.org

Bug: 863439
Change-Id: I512a834039e7136915b30950648ab491b4c421d1
Reviewed-on: https://chromium-review.googlesource.com/1136715Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576509}

In the great blink rename, the fact that files and variables were
camel-cased like the project name HarfBuzz lead to renaming them to
harf_buzz_* which breaks the project/library name apart. This CL with
renames fixes this readability issue.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I829341c681345001c19eccd9ce7245533813065c
Reviewed-on: https://chromium-review.googlesource.com/1143399Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576508}

Update all top real world mobile pages to current websites by modifying
links or html selectors. The following pages were replaced:

cuteoverload_mobile: with google images

Fixed expectations tracked here:
https://docs.google.com/spreadsheets/d/1qx76DCRf-j4xNVfHOPII02FQnQWWXMi-FpcAtn4boAk/edit?usp=sharing

Bug: 852530
Change-Id: Ib34ba6c72f0b52fb01452581d4d8e8c2c96c0242
Reviewed-on: https://chromium-review.googlesource.com/1129459Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#576507}

The network handler purpose is:

1. Connect to the GCM channel
2. Retrieve the instance_id token and forward it to the registration manager.
3. Forward incoming messages to the message handlers.

Bug: 863893, 801985
Change-Id: I236e5a2374468aaceb69641b05d535a3685d716e
Reviewed-on: https://chromium-review.googlesource.com/1138317
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576506}

When all the sites fit on a single row (as is the case for most
devices now that only 4 sites are shown), hide the "Show more"
option and allow only compact mode.

Bug: 860799
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If2efa48bcd1cbe23c49b34be4ec084f95a703d08
Reviewed-on: https://chromium-review.googlesource.com/1143464Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576505}

This change adds an interface for the UI, to which VrShellGl will talk.
While this somewhat cleans up interfaces to the UI, the main reason is
to ensure that the UI can be severed without link issues.  Once all UI
methods called by its owner are virtual, the class can be instantiated
and used easily at runtime.

BUG=

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib634efeb157007de11342a245c949b5ea69e54f3
Reviewed-on: https://chromium-review.googlesource.com/1142303
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576504}

As a nice side effect, the issue with transparency in the generation prompt is
fixed.

Bug: 864978
Change-Id: I58d4d04053297dda1b2a4aa5cfce381b0062eadd
Reviewed-on: https://chromium-review.googlesource.com/1141962
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576503}

When building using jumbo, files gets merged and functions and
constants with the same name may end up in the same scope.
This commits moves such functions and constants to shared
util files.

Bug: 803406
Change-Id: I3a0d763741c3d6b631539fdfe51f8fddc0b255a0
Reviewed-on: https://chromium-review.googlesource.com/1141865Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#576502}

This CL restores private empty constructors for helper classes
that only have static function or members.

These constructors were deleted in:
https://chromium-review.googlesource.com/c/chromium/src/+/1133382

Change-Id: Ie14035912e430e7b9973365ecc12bd78fab28af6
Reviewed-on: https://chromium-review.googlesource.com/1142406Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#576501}

That keyed service will, in the future, be responsible for more web app
things than just policy.

Also move c/b/wa/policy to c/b/wa/bookmark_apps/policy, where c/b/wa
means chrome/browser/web_applications. We (nigeltao@, ortuno@, loyso@,
dominickn@) want to organize c/b/wa into a 'root' directory and three
or four sub-directories as we de-tangle web apps from extensions:
- c/b/wa holds only the WebAppProvider and its Factory.
- c/b/wa/extensions is code that is tightly coupled to extensions.
- c/b/wa/bookmark_apps is code that currently depends on
  c/b/wa/extensions but, in the future, should not.
- c/b/wa/components is low level code that is unrelated to extensions.
- c/b/wa/new_bookmark_apps (name pending) is high level code that is
  unrelated to extensions.

Change-Id: Ie42bfc348be7166c710fc6232848b5e9eb91960e
Reviewed-on: https://chromium-review.googlesource.com/1142844
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576500}

In r492524 we resumed performing per-character fallback for unassigned
characters. This was intended to avoid problems upgrading the emoji data
file. When updating the emoji data before updating ICU new emoji may
have appeared in the unassigned range, which we would erroneously
exclude from fallback in that case.

However, allowing the full range of unassigned characters does not make
sense either and triggered a memory regression in our benchmark when the
amazon.in page triggers fallback for the non printable U+FFFE sentinel
character.

To solve this, in addition to private use area codepoints we exclude 66
Unicode non-characters, defined in
http://www.unicode.org/faq/private_use.html#nonchar4 They are part of
the unassigned range, but have special meanings and are explicitly
intended as non-characters. We must not try to look for glyphs in fonts
for these.

Bug: 862352
Change-Id: I50b22a4acb0d148595c5ae4f99a57d59ee8c41dd
Reviewed-on: https://chromium-review.googlesource.com/1143277Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576499}

Check if sized internal format is supported before making the
glTexStorage2DEXT call. This was called by autogen code for GLES2Decoder
and was not ported over to RasterDecoder.

Also remove some dead autogen code that is not compiled in anywhere.

Bug: 862376
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I116aa08ac6d381c95650ab8fad9d984ea19af109
Reviewed-on: https://chromium-review.googlesource.com/1140358
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576498}

Moves the existing methods for creating a platform-specific instance of interface
media::VideoCaptureDeviceFactory out of the interface class and into standalone
functions in a separate file.

This is reasonable, because the factory logic does really not belong in the
abstract interface.

This is needed to be able to move the factory logic part and the
VideoCaptureDeviceFactory interface to separate gn targets in the subsequent
CL.

This CL is part of a series, see Design Doc at
https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing

Change-Id: Iddd093c3a8d0b665094ca3ded32ff4c46f592219
Reviewed-on: https://chromium-review.googlesource.com/1139175Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576497}

A preparation patch for adding MMI optimizations in libYUV project.

BUG=libyuv:804

Review-Url: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/1122064
Change-Id: I8840920f628095784756b5b3791bae47197e0a5a
Reviewed-on: https://chromium-review.googlesource.com/1137811Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576496}

I noticed that I forgot to remove android_unswarmed_n5_rel from mb_config.pyl
in https://chromium-review.googlesource.com/c/chromium/src/+/1135556, so I
tried to write some code to check that all bots referenced in mb_config.pyl
actually exist now that the bot inventory exists src-side.

I couldn't get that to work reliably, but I manually went through the list
my code produced and removed the bots that appear to really not exist according
to cs.chromium.org.

Bug: 863167
Change-Id: I4aa4744d8fda8771eded403a8ebfbfca0f09de12
Reviewed-on: https://chromium-review.googlesource.com/1138338
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576495}

This reverts commit 94218d2c.

Reason for revert: Causing official build test failures.

BUG=865406

Original change's description:
> Make TabLoader responsible for loading all tabs.
> 
> Currently there's an inversion where active tabs in minimized windows don't get
> loaded as they are created. This is an optimization in the occlusion tracking code
> that doesn't calls ReloadIfNecessary unless the window hosting the active tab
> actually becomes visible. Due to this inversion the TabLoader can start loading
> background tabs in the minimized window before the active tab in the minimized
> window is ever loaded.
> 
> Giving TabLoader responsibility to load all tabs fixes this. In the case of
> active and visible tabs whose loads are initiated by the browser this is fine
> because calling ReloadIfNecessary twice is effectively a nop, and the TabLoader
> is already smart enough to track tabs that have started loading for external
> reasons.
> 
> BUG=864725
> 
> Change-Id: I4b86a71470b2cb1a1a9106c4d4d92ee6b18c7284
> Reviewed-on: https://chromium-review.googlesource.com/1141071
> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
> Commit-Queue: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576071}

TBR=chrisha@chromium.org,sebmarchand@chromium.org

Change-Id: Icc2545c1a643042e44b15aa3fb4970045bdba105
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 864725
Reviewed-on: https://chromium-review.googlesource.com/1143565Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576494}

Only provision an AdTracker to a local frame if AdTagging is
enabled. Useful to measure the performance impact of the AdTracker.
AdTagging feature declaration moved to support RuntimeEnabledFeature

Bug: 856273
Change-Id: I898c78d5be916583744b445afad885d445b440bf
Reviewed-on: https://chromium-review.googlesource.com/1115374Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576493}

This reverts commit 15986e3d.

Reason for revert: Failures on official builds.

BUG=865420

Original change's description:
> [RC] Plumb in the enterprise policy setting.
> 
> This adds plumbing so that the enterprise policy setting can actually override
> the tab lifecycles feature.
> 
> BUG=
> 
> Change-Id: If86dd7687e993c7ed66955692be8eae88b505990
> Reviewed-on: https://chromium-review.googlesource.com/1142355
> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
> Commit-Queue: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576304}

TBR=chrisha@chromium.org,sebmarchand@chromium.org

Change-Id: I85eaea71836ceee31522cb36503d29341486b8a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1143564Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576492}

Change-Id: I954a0d3e1ea86730e67188408b384f04785d837c
Reviewed-on: https://chromium-review.googlesource.com/1142455Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576491}

We now cache the data file as binary data, which can be cached in
memory without crashing the page. When streaming, we build the final
cache by tracking the total size of the bytes streamed in. This
cache allows us to reuse the data on subsequent runs
(such as when filters change) rather than calling fetch again.

Bug: 847599
Change-Id: I09fb9f45c992984ed56c1270c1c015d274c4c167
Reviewed-on: https://chromium-review.googlesource.com/1136852
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576490}

When filling forms, Chrome identifies fields by FormFieldData::id on iOS and FormFieldData::name
on other platforms. The new FormData->PasswordForm parser failed to use 'id' on iOS. This CL
fixes that by introducing platform-dependent identifier selector, which returns 'id' on iOS and
'name' elsewhere.

The alternative solution of switching the iOS code to use 'name' (or the rest to use 'id') is not
good for various reasons:

 - non-iOS code will ultimately migrate to using FormFieldData::unique_renderer_id, which is
superior to both but not supported on iOS
 - iOS code contains significant improvements which ensure that FormFieldData::id is actually
unique; this has been neither done outside of iOS, nor for FormFieldData::name
 - the amount of code needing change would be large and the benefit virtually null (compared to
the solution from this CL).

Bug: 831123
Change-Id: I24960064bb3f792ef4e0ebe6fbf769509481bad1
Reviewed-on: https://chromium-review.googlesource.com/1142151
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576489}

Replaced --min-symbol-size with --all-symbols. By default, 100,000
symbols are included in the data file (similar to the amount when min
symbol size was 1024 bytes). If the all-symbols flag is used, every
symbol is included.

Bug: 847599
Change-Id: I4511d0fdb6c179ff368ce5eceaa529890f8d2d5b
Reviewed-on: https://chromium-review.googlesource.com/1142477
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576488}

The Cleanup task spawns some deletions tasks which access the cache
storage on another thread. This can cause a race condition with a
regular RunLoop, so I replaced it with the TestBrowserThreadBundle.

TBR=peter@chromium.org

Change-Id: I6ab56a4a0c72b50831461832bce6a3ab10ea5543
Reviewed-on: https://chromium-review.googlesource.com/1143404Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576487}

As part of issue 855840, we will need to hit test touchpad gesture fling
cancel events. However, we currently generate a synthetic fling cancel
before every wheel event in a scroll. This is excessive, since we have
wheel scroll latching, and would become expensive, since we would need
to hit test them all.

We now only generate a synthetic fling cancel at the beginning of a
touchpad scroll.

Bug: 855840
Change-Id: I108393814065c90cea80ba5326772a1764526ad7
Reviewed-on: https://chromium-review.googlesource.com/1138637
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576486}

Allow tabs to be discarded more than once. The heuristics have changed
so much in in the last 6 months that this additional protection isn't
needed.

BUG=794622

Change-Id: I094af452b5a7190f229fefbc77f4571ac0601a17
Reviewed-on: https://chromium-review.googlesource.com/1142479
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576485}

Bug: 864302
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If94e1b5b1cff588da4b83dcee1bdc652889bc05f
Reviewed-on: https://chromium-review.googlesource.com/1141119
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576484}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I60c506d9c15bce437c32c844162ec5df243bb501
Reviewed-on: https://chromium-review.googlesource.com/1142957
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576483}

This CL is similar to:
https://chromium-review.googlesource.com/1133688

BufferRegion::FitsIn() (and BufferViewBase::covers()) decides whether
a BufferRegion fits inside a buffer. A special case is whether an empty
region fits at the end of a buffer?

Previously this was considered to be a pathological case, so the result
is "false". However, this led to a DCHECK failure found by the DEX
fuzzer: a CodeItem with insns_size = 0 is checked against an empty
buffer.

It may seem straightforward to change the DCHECK to a handled failure.
However, the failing code (in CodeItemParser::GetCodeItemInsns())
occurs after CodeItem have been supposedly validated, so the DCHECK
is correctly placed! Two causes are:
(1) Technically insns_size should be > 0, as dictated by constraint A1
    ("The insns array mus tnot be empty") in Dalvik spec.
(2) The FitsIn() check is too stringent.

This CL focuses on relaxing (2). This makes checking slightly more
permissive elsewhere in code (patch_reader.cc and Win32 disassembler),
but this looks like the right thing to do.

As for (1), we plan to visit
https://source.android.com/devices/tech/dalvik/constraints
and implement more rigorous checks. So we simply add a TODO for now.

Bug: 863478
Change-Id: Iacbb2bb9bf26701db960192c7b727351ea5afdec
Reviewed-on: https://chromium-review.googlesource.com/1142517Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576482}