- 25 May, 2020 40 commits
-
-
Saurabh Nijhara authored
This CL introduces a new browser test for kiosk auto launch on views login when device is not enrolled and the user had requested to auto launch a kiosk app in the previous session. Bug: 989001 Change-Id: I25633ffda6d6b16c7e99051168a042c4dc8a4d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209219 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771616}
-
Ted Meyer authored
Wez pointed out a good issue in crrev.com/c/1153144 Bug: 867872 Change-Id: I40e6f100c1f2fdee77ff536923e202f18d4eb7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212932Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#771615}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/728938372b26..ca8a7e8ce304 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com,mpearson@google.com Change-Id: I3280cc00e52d3ce2e99335b549c2357bffa93679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215267Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771614}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ea5180e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I062cba27ee277059fe983c58b2e44d584ea52d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215118Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771613}
-
Vi Nguyen authored
Courtesy of jrummell's TODO: Now that there are 2 types of persistent sessions, the session type should be passed from blink. Type should also be passed in the constructor (and removed from initializeNewSession()). Bug: 1085463 Change-Id: Ic6f5f496d7f696d1563c0af0c80e42c8d54ec060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212685Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Vi Nguyen <ving@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771612}
-
Dominic Farolino authored
This CL adds UKM to count the number of async scripts associated with a given mainframe document. Google-internal UKM privacy review: https://docs.google.com/document/d/1bKyDRF5BAQpPJ-bRyKs2dgqBTJI43b63kOULO-HIuXM/edit Bug: 1086227 Change-Id: Iaaee8c756952613c2ea58416b453a98a0843773f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209118 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771611}
-
Jeremy Roman authored
Dead since 2013: https://codereview.chromium.org/64843004 Change-Id: I2e26bb531fca1e8e590b2f45b829fa485c145bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215303 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#771610}
-
Christopher Cameron authored
There exist standard colorSpaceConversion options of none (ignore color space) and default (use color space). Specifying srgb, p3, or rec2020 here is not appropriate. A more appropriate place would be in ImageData (where there do exist canvas color space parameters). Bug: 1083693 Change-Id: I3741454c36a59b3c8d679ec843aa05cebcc9d9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213777Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#771609}
-
Scott Little authored
The result of the call is unused, and it's called again for the switch statement directly below it, so this CL removes the unused call. Change-Id: If5d86d4c30286057442dd8f9d06ef0a0b314487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210926 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#771608}
-
Antonio Gomes authored
... to replace |opener_routing_id|. This CL switches content.mojom.CreateFrameParams::opener_routing_id to use mojo_base.mojom.UnguessableToken. Note that it is a step forward toward stopping representing |opener frames| through its routing ID when doing mojo communications between browser -> renderer. The next CL will move callers of CreateViewParams::opener_frame_route_id to also use mojo_base.mojom.UnguessableToken (ie base::UnguessableToken). That will allow the removal of RenderFrameHostManager::GetOpenerRoutingID() altogether. BUG=1051144 R=avi@chromium.org, dominickn@chromium.org, dtapuska@chromium.org, haraken@chromium.org Change-Id: Ib0789617cb35234c28cd59584064b4ac84c76bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210635 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#771607}
-
Robert Kroeger authored
Suppress intermittently failing conformance/textures/canvas_sub_rectangle/tex-2d-rgb-rgb-unsigned_byte.html on Nvidia Mac Retina. TBR=kbr@chromium.org Bug: 1086194 Change-Id: I13cf0f95f980f2236d4ceb6a7dec53faf654762f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214906Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#771606}
-
Alex Ilin authored
Currently, there are 5 different URL switches in google_apis/gaia/gaia_switches.cc that need to be manually set to set non-prod Gaia environment. This CL introduces a new command line switch to rule them all: --gaia-config=gaia_test.json A JSON config file allows to override all URLs available in google_apis/gaia/gaia_urls.h. For a format example take a look at google_apis/test/data/gaia/all_urls.json. The proposed design was chosen because of the following: - It allows to override each individual URL separately without bloating the command line. This can be useful for developers who run their own test instances. - It makes easy to hide test URLs used at Google in the internal repo. Bug: 1072731 Change-Id: I3c32c53f9dc27b01ceab8ef57eb71c00d5df0977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166197 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#771605}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590407971-070878b52cdd641358380b2e2b381cb8c8d5514d.profdata to chrome-win32-master-1590422180-44e949163b7e7ddb0abdc3ec30e05825d5bf8262.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie9a82042330dbe101aac78457cf42b23cba90e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771604}
-
Andrew Grieve authored
Disabling is no longer necessary after latest R8 roll. It now optimises away extra bridge methods. Bug: 1056299 Change-Id: I85be3b0571500e47fd6f7c2c290c7e4d814086c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169754 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#771603}
-
Koji Ishii authored
The Canvas [text-preparation-algorithm] requires to run bidi algorithm using |TextDirection|, without |ComputedStyle|. In LayoutNG, |NGBidiParagraph| splits the text into bidi runs and compute bidi levels. This patch changes |NGBidiParagraph| so that Canvas code can use it without |ComputedStyle|. This patch changes |TextMetrics| to use |NGBidiParagraph| to resolve bidi levels, and measur each run. [text-preparation-algorithm]: https://html.spec.whatwg.org/multipage/canvas.html#text-preparation-algorithm Bug: 1010893 Change-Id: I46d8e5e3fd9e76910e86a5be71f9d7247911fbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196086Reviewed-by:
-
Koji Ishii authored
Making |NGFragmentItem| not a |DisplayItemClient| has two benefits: 1. Give a persistent |DisplayItemClientId| across multiple layout cycles. 2. Allow making |Vector<NGFragmentItem>| instead of |Vector<scoped_refptr<NGFragmentItem>>|, because a |Vector| of |DisplayItemClient| is not allowed. This change is expected to reduce the memory allocation cost, which is high for text-heavy pages. This patch is only for 1. The work for 2 will be in following patches. Still, this patch improves `blink_perf.paint/ paint-offset-changes` microbenchmark by ~10%: https://pinpoint-dot-chromeperf.appspot.com/job/15b8f60a120000 https://pinpoint-dot-chromeperf.appspot.com/job/14e61bb6120000 and slight positive changes to blink_perf.layout, probably due to simpler paint invalidations: https://pinpoint-dot-chromeperf.appspot.com/job/17d3126c120000 This patch is on top of following foudnation patches: * r770260 <crrev.com/c/2207948> supported |wtf_size_t| for fragment id. * r770637 <crrev.com/c/2209774> added |NGFragment:: FragmentId()|. Bug: 982194 Change-Id: I1cb5e2633bd591723632f1acb0cbb09ab4d77f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208586Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771601}
-
Xianzhu Wang authored
These tests are still flaky on Win7. Added into NeverFixTests for Win7 because we'll never fix them and we have test coverage on Win10. Bug: 657646 Change-Id: I3f81979ca080807b645a2428f5000d22fc835db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209649Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771600}
-
David Bokan authored
Small style cleanup - there should be no behavior difference from this CL. Bug: NONE Change-Id: I532d13df78f7e02e52ae30a0fd05f46528f8ce91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213111 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771599}
-
W. James MacLean authored
Removing a redundant/repeated boolean expression. TBR=alexmos@chromium.org Bug: n/a Change-Id: I1b64c620412279ca6871710ef0a7a67807cbbb8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214902Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#771598}
-
Antonio Gomes authored
Today, to pass the opener frame when creating a content remote (aka proxy) frame, its routing ID is used. This CL changes it to use the unique base::UnguessableToken instead. Note that it is a step forward toward stopping representing |opener frame| through its routing ID when doing mojo communications between browser <-> renderer. The next CL will move callers of content.mojom.CreateFrameParams.opener_routing_id to also use mojo_base.mojom.UnguessableToken (ie base::UnguessableToken). End goal is the removal of RenderFrameHostManager::GetOpenerRoutingID() altogether. R=avi@chromium.org, dominickn@chromium.org, dtapuska@chromium.org, haraken@chromium.org Bug: 1051144 Change-Id: I1add33224ce7909bac400da13bb3f361335b9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209399 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590407971-3e57b161debb1f13fcdd2d2d0d37a285d980c990.profdata to chrome-mac-master-1590422180-66411a4557786c8add52c855489371af12277b8b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I723879d099895d254149466e2a235837472c79ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215269Reviewed-by:
-
Marc Treib authored
All Sync data types have been migrated to USS, so the migrator isn't needed anymore. Bug: 1084499 Change-Id: I62c13ae30f686c6670bec826bbf6ecf0bd1978bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207384Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#771595}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec8892b5506b..ba95542b7b83 2020-05-25 patrick.brosset@microsoft.com New simple E2E tests for the styles and computed panes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I690d459b35539efeb57e48a68e68e7ffed86e0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214474Reviewed-by:
-
Robert Kroeger authored
media/controls-layout-direction.html pixel tests are failing on Linux/SkiaRenderer with and w/o Vulkan. Suppress. TBR=jonross@chromium.org Bug: 1086181 Change-Id: If289b9ee276fb75691565cfc499c11b5073e2a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214904Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#771593}
-
Wez authored
RELR encoding is now enabled by default in the Fuchsia toolchain, but is not fully supported by parts of the Chromium build for Fuchsia x64. Disable packing of dynamic relocation sections other than in Fuchsia ARM64 builds, until the underlying toolchain issue is resolved. Bug: 1086134 Change-Id: I0544e91712860a5d3e4f190d1894686e37b380ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213527 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771592}
-
Etienne Bergeron authored
This CL is allowing the registration of PowerObservers before the PowerMonitor is initialized. The PowerMonitor has a PowerSource and a ObserverList. The call to PowerMonitor::Initialize is used to set a PowerSource that will trigger the notifications. It is thus valid to add observers before the power source is set. TBR=miu@chromium.org Bug: 1074332 Change-Id: Ia238b7caf52f80a7de01329908c4979d81341634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202877 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#771591}
-
Sebastien Marchand authored
The condition enabling WriteClangProfilingProfile for GpuService is mismatched with the implementation. The implementation is enabled with CLANG_PROFILING_INSIDE_SANDBOX flag while the mojo definition is enabled with use_clang_profiling. The correct flag is CLANG_PROFILING_INSIDE_SANDBOX. Bug: 1071664 Change-Id: I6e23168f76f5fafddeac997f7948823387b356a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211911 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#771590}
-
Andrew Grieve authored
The assert triggered for M84's TrichromeChromeGoogleSystemStable.apk because it contains a lot of small .so files (for all the DFMs). Bug: None Change-Id: I8855dda1190b063d4b860bb13272527c35d6e1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214905 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#771589}
-
Dominic Battre authored
This CL introduces conversion methods to convert from one protobuf representation of autofill queries/responses to another. The representations reflect the communication with the legacy autofill server and the new API server. Bug: 1079488 Change-Id: Id32688926ae28a1f7d90b3590b70783a7b201bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207224 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#771588}
-
Oleg Davydov authored
This CL combines number of small cosmetic changes: * extensions::InstallationReporter is renamed to extensions::InstallStageTracker as it doesn't report anything by itself, otherwise, different parts of extension installation flow report to it * extensions::InstallationTracker is renamed to extensions::ForceInstalledTracker to reflect what kind of extensions it tracks data of. * extension::InstallationMetrics is renamed to extensions::ForceInstalledMetrics to reflect what kind of extension it reports metrics about. * extensions::ForcedExtensionsInstallationTrackerTest is renamed to extensions::ForceInstalledMetrics test, as it is test for both Tracker and Metrics now, and Metrics class is more specific one. * A couple of unneeded includes are removed. * One stale TODO is removed. * Slightly updated comments to the classes. Bug: 1076159 Change-Id: Ied9252d9277543e8a8d84f67b713cb344d3916d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207462 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771587}
-
Jochen Eisinger authored
Bug: 873178 Change-Id: I6be227d81ccb236eef4e63b2ea242d6221b49298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030950Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771586}
-
Henry Jian authored
Bug: 1056751 Change-Id: Ifbf0eaed0c6a99725893e798df56298768085474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194071 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#771585}
-
Jochen Eisinger authored
Bug: 927509 Change-Id: I56ec8b5cf524a4e1d14b29427931802f80d54a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132197Reviewed-by:
-
Juanmi Huertas authored
There were some specific web_test expectations that were giving a false error, while the code was behaving as it should have been behaving in all the other cases (not mac). It probably means that at some point a false expectation was uploaded as rebase, and therefore the rebase was broken, not the actual result. Bug: 995142 Change-Id: I5bc2cd80a4c75f5daa10e61f55808c5aba1118ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171596 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#771583}
-
Samuel Huang authored
The following Python functions are directly involved in extracting .info files from .aar: * gn_helpers.py: ToGNString(). * aar.py: _IsManifestEmpty(). * aar.py: _CreateInfo(). We wish to port these files to Google3 to enable .info file extraction (while keeping the Chromium versions around for verification). However, these functions produce many Python lint warnings in Google3. This CL fixes these warnings in Chromium first, and improve comments. Change-Id: I2a826f70ac1d15f2f358195327fd0dd3f12db5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213206Reviewed-by:
-
Julie Jeongeun Kim authored
This CL replaces the PrintHostMsg_CheckForCancel IPC message with a new CheckForCancel Mojo method in the PrintPreviewUI interface. Bug: 1008939 Change-Id: Ic694b892744387bfc0c4c1232ed4b6a9cb1b6388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212181 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#771581}
-
Hans Wennborg authored
To make it harder to forget. Bug: none Change-Id: Iecf97569c56383ade299f264ae0946738e91b60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214884 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Marina Ciocea authored
PlatformNotificationServiceBrowserTest.TestShouldDisplayFullscreen is flaky on Linux TSan. Bug: 1086169 Change-Id: I919f57ecbcc586f0368553126e54999c582435c8 TBR: peter@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214892Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771579}
-
Yuki Shiino authored
Calls v8::FunctionTemplate::SetAcceptAnyReceiver(bool) appropriately not only for IDL operations but also IDL attributes (accessor properties). This patch has no behavior change for the current bindings generator, but allows the new bindings generator to control the receiver check. Bug: 839389 Change-Id: Ia7b1817aae46539747d59381cd82c808c5ae5683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212113Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#771578}
-
Takashi Sakamoto authored
Added CanvasMemoryDumpProvider, made CanvasResourceProvider the provider's client, and implemented OnMemoryDump. Since SkSurface has no interface to provide its memory usage, use SkImageInfo::computeBytesSize when allocating memory(not gpu) SkSurface. Change-Id: I51cc40ab472403bb4a1e22fcae3fc6944a5f5a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143178 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
