Commits · 9505857261d50aba30e49b60a13a194f6b8d2afa · eriksson monteiro / tangled

20 Aug, 2012 19 commits

Initial crack at new workspace behavior. Each workspace now has its · 95058572

sky@chromium.org authored Aug 20, 2012

own window. This complicates usage of shell window ids a bit.

I need to sort out animations (I've disabled them for the moment when
this is enabled).

BUG=137342
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830365

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152322 0039d316-1c4b-4281-b951-d872f2087c98

95058572

Don't show the button for hidden page/browser actions or script badges. · 103c6801

finnur@chromium.org authored Aug 20, 2012

Browser Action, Page Actions and Script Badges can be hidden, which causes us to get invalid |button| and |frame| (respectively). We'll need to figure out what to do in these cases (on all platforms) but the minimum for now is to ignore the keystroke to avoid a crash.

BUG=140396
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10828364

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152321 0039d316-1c4b-4281-b951-d872f2087c98

103c6801

Delete update_iwyu.sh · 77086caa

thakis@chromium.org authored Aug 20, 2012

IWYU in its current form doesn't work well, and this script
fell victim to bitrot due to being unused.

BUG=143643

Review URL: https://chromiumcodereview.appspot.com/10828383

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152320 0039d316-1c4b-4281-b951-d872f2087c98

77086caa

Refactor the Photo Editor to enable new feature work · 81373989

kaznacheev@chromium.org authored Aug 20, 2012

BUG=142542

Review URL: https://chromiumcodereview.appspot.com/10834354

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152319 0039d316-1c4b-4281-b951-d872f2087c98

81373989

[Android] Implement WebSettings.{get|set}Allow{Content|File}Access. · ced2f3a3

mnaganov@chromium.org authored Aug 20, 2012

This is as much as we can put upstream now.

Review URL: https://chromiumcodereview.appspot.com/10827380

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152318 0039d316-1c4b-4281-b951-d872f2087c98

ced2f3a3

Revert 152135 - Fix accessability for web notification tray. · 294d77c0

glider@chromium.org authored Aug 20, 2012


BUG=143671,142506
TBR=stevenjb@chromium.org,bryeung
Review URL: https://chromiumcodereview.appspot.com/10832389

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152317 0039d316-1c4b-4281-b951-d872f2087c98

294d77c0

Avoid log spam in Files app · aa5fd6a2

kaznacheev@chromium.org authored Aug 20, 2012

BUG=142779

Review URL: https://chromiumcodereview.appspot.com/10827410

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152316 0039d316-1c4b-4281-b951-d872f2087c98

aa5fd6a2

Disable compiler option 'mimplicit-it' for Android ARM · 657c13bd

yongsheng.zhu@intel.com authored Aug 20, 2012

Android NDK toolchain doesn't support it.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10824330

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152315 0039d316-1c4b-4281-b951-d872f2087c98

657c13bd

Redefine the ASan options for nacl_helper so that ASan does not handle SIGSEGV/SIGBUS · 9b6edd72

glider@chromium.org authored Aug 20, 2012

This should allow the platform qualification test to pass and make it possible to launch NaCl programs from an instrumented browser without additional env settings.
Review URL: https://chromiumcodereview.appspot.com/10830009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152314 0039d316-1c4b-4281-b951-d872f2087c98

9b6edd72

On mono mode, SL_SPEAKER_FRONT_CENTER is the channel mask; · ac2d29d1

xians@chromium.org authored Aug 20, 2012

On Stereo mode, SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT should be used.

For channel more than 2, we don't support it yet.


BUG=143352

Review URL: https://chromiumcodereview.appspot.com/10855218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152313 0039d316-1c4b-4281-b951-d872f2087c98

ac2d29d1

Remove suppression entry. · d925f7cb

nona@chromium.org authored Aug 20, 2012

BUG=134717
TEST=try bot


Review URL: https://chromiumcodereview.appspot.com/10826201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152312 0039d316-1c4b-4281-b951-d872f2087c98

d925f7cb

[content shell] rename layout_test_controller{,_host,_bindings}.* to webkit_test_runner · 9b4c6cd5

jochen@chromium.org authored Aug 20, 2012

BUG=111316
TEST=none
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10860037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152311 0039d316-1c4b-4281-b951-d872f2087c98

9b4c6cd5

Make sure events for browser actions, page actions and script badges are not delivered twice. · 0fc4e6ef

finnur@chromium.org authored Aug 20, 2012

BUG=124873
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10834393

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152310 0039d316-1c4b-4281-b951-d872f2087c98

0fc4e6ef

Fix missing entry showing number of cookies in first domain of chrome://settings/cookies · a1b553cb

battre@chromium.org authored Aug 20, 2012

BUG=130759
TEST=check that the chrome://settings/cookies dialog continues to work as expected

Review URL: https://chromiumcodereview.appspot.com/10832224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152309 0039d316-1c4b-4281-b951-d872f2087c98

a1b553cb

Updating trunk VERSION from 1240.0 to 1241.0 · 3b79f08c
chrome-release@google.com authored Aug 20, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152306 0039d316-1c4b-4281-b951-d872f2087c98
```
3b79f08c

Delete an obsolete comment on RenderWidgetHost::CopyFromBackingStore. · d7e11bf3

mazda@chromium.org authored Aug 20, 2012

BUG=118571

Review URL: https://chromiumcodereview.appspot.com/10823384

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152304 0039d316-1c4b-4281-b951-d872f2087c98

d7e11bf3

Update .DEPS.git · 1533b393

chrome-admin@google.com authored Aug 20, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152302 0039d316-1c4b-4281-b951-d872f2087c98

1533b393

Roll gyp 1472:1473 · e1b07074

scottmg@chromium.org authored Aug 20, 2012

r1473: Initial support for VS2012.

TBR=thakis@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10832386

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152301 0039d316-1c4b-4281-b951-d872f2087c98

e1b07074

Add RSAPrivateKey stub implementation for iOS. · 1f8cbcb9

msarda@chromium.org authored Aug 20, 2012

RSAPrivateKey is not used on iOS, but code calling it is compiled. To avoid
ifdef'ing in the client code, the class is stubbed out.

Review URL: https://chromiumcodereview.appspot.com/10823309

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152300 0039d316-1c4b-4281-b951-d872f2087c98

1f8cbcb9

19 Aug, 2012 20 commits

[Chromoting] Moving the I/O thread out of DaemonProcess (so it can be shared if needed). · 419a4b26

alexeypa@chromium.org authored Aug 19, 2012

BUG=134694


Review URL: https://chromiumcodereview.appspot.com/10837292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152299 0039d316-1c4b-4281-b951-d872f2087c98

419a4b26

Disable FullscreenControllerBrowserTest.BrowserFullscreenMouseLockContentSettings · b0e1ac9a

nsylvain@chromium.org authored Aug 19, 2012

It fails on 10.7

BUG=103912
TBR=rsesek
Review URL: https://chromiumcodereview.appspot.com/10854215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152298 0039d316-1c4b-4281-b951-d872f2087c98

b0e1ac9a

Disable many tests failing on mac 10.7 · 4639187a

nsylvain@chromium.org authored Aug 19, 2012

x VideoDecodeAccelerationSupportTest.Create
x ExtensionApiTest.UpdateWindowShowState
x FullscreenControllerTest.BrowserFullscreenAfterTabFSExit
x PPAPINaClGLibcTest.Fullscreen
x PPAPINaClNewlibTest.Fullscreen
x FullscreenControllerTest.BrowserFullscreenExit
x FullscreenControllerTest.TestTabExitsFullscreenOnNavigation
x FullscreenControllerTest.TestTabExitsFullscreenOnGoBack
x FullscreenControllerTest.TestFullscreenFromTabWhenAlreadyInBrowserFullscreenWorks
x KioskModeTest.EnableKioskModeTest
x FullscreenControllerInteractiveTest.EscapingMouseLockAndFullscreen
x FullscreenControllerInteractiveTest.MouseLockAndFullscreen
x FullscreenControllerInteractiveTest.ReloadExitsMouseLockAndFullscreen
x FullscreenExitBubbleControllerTest.DenyExitsFullscreen

BUG=103912
TBR=rsesek
Review URL: https://chromiumcodereview.appspot.com/10861003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152297 0039d316-1c4b-4281-b951-d872f2087c98

4639187a

net: Fix more clang warnings about missing virtual and OVERRIDE annotations. · 1e43b681

tfarina@chromium.org authored Aug 19, 2012

BUG=115047
R=willchan@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10825437

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152296 0039d316-1c4b-4281-b951-d872f2087c98

1e43b681

Dummy change to trigger the bots · da35960e

nsylvain@chromium.org authored Aug 19, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152295 0039d316-1c4b-4281-b951-d872f2087c98

da35960e

Dummy change to trigger the bots · 19bb0bf1

nsylvain@chromium.org authored Aug 19, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152293 0039d316-1c4b-4281-b951-d872f2087c98

19bb0bf1

ash: Remove the dependency in browser_view.h from chrome_shell_delegate.cc · 0af01e6a

tfarina@chromium.org authored Aug 19, 2012

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10860032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152286 0039d316-1c4b-4281-b951-d872f2087c98

0af01e6a

contacts: Rename provider_id to contact_id. · e3e127d4

derat@chromium.org authored Aug 19, 2012

As suggested by satorux@, this change renames the ID field
in contacts::Contact to make it clearer that it's a
contact-specific (albeit provider-assigned) ID rather than
one corresponding to the provider itself.

BUG=128805
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10827406

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152285 0039d316-1c4b-4281-b951-d872f2087c98

e3e127d4

Revert 152213 - Replace the DownloadFileManager with direct ownership of DownloadFile. · e2c1a644

rdsmith@chromium.org authored Aug 19, 2012

This CL is a re-land of http://codereview.chromium.org/10799005, which 
was reverted due to test flakiness.  

BUG=123998
R=benjhayden@chromium.org
TBR=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10836293

BUG=143600
TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10861002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152282 0039d316-1c4b-4281-b951-d872f2087c98

e2c1a644

Use ClipboardFilter in ClientSession to implement auth & disable-input blocking. · 34df2abd

wez@chromium.org authored Aug 19, 2012

This removes the need for ClientSession to implement ClipboardStub
and proxy clipboard events itself.

BUG=118511


Review URL: https://chromiumcodereview.appspot.com/10831223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152281 0039d316-1c4b-4281-b951-d872f2087c98

34df2abd

Options: s/options2/options/. · 0752a82b

jhawkins@chromium.org authored Aug 19, 2012

BUG=122251
R=csilv

Review URL: https://chromiumcodereview.appspot.com/10837331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152280 0039d316-1c4b-4281-b951-d872f2087c98

0752a82b

Options: Rename options2 namespace to options. · 6a7355ee

jhawkins@chromium.org authored Aug 19, 2012

BUG=122251
R=csilv

Review URL: https://chromiumcodereview.appspot.com/10857071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152279 0039d316-1c4b-4281-b951-d872f2087c98

6a7355ee

Suppress leak in AppCacheStorageImpl · ffa16955

bruening@google.com authored Aug 19, 2012

TBR=ajwong@chromium.org
BUG=143565
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10824369

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152278 0039d316-1c4b-4281-b951-d872f2087c98

ffa16955

base::Bind: Make use of IgnoreResult. · 38216902

jhawkins@chromium.org authored Aug 19, 2012

BUG=none
R=csilv
TBR=michaeln

Review URL: https://chromiumcodereview.appspot.com/10857073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152277 0039d316-1c4b-4281-b951-d872f2087c98

38216902

Suppress leak in TaskManagerTest · 32c22278

bruening@google.com authored Aug 19, 2012

BUG=143563
TBR=ccameron@chromium.org
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10823403

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152276 0039d316-1c4b-4281-b951-d872f2087c98

32c22278

Cleanup: Don't close single tags. · 859648c8

jhawkins@chromium.org authored Aug 19, 2012

BUG=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/10828382

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152275 0039d316-1c4b-4281-b951-d872f2087c98

859648c8

Autofill: Widen the input elements to accomodate more verbose languages. · aeb96c69

jhawkins@chromium.org authored Aug 19, 2012

BUG=136912
R=csilv

Review URL: https://chromiumcodereview.appspot.com/10831385

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152273 0039d316-1c4b-4281-b951-d872f2087c98

aeb96c69

Cocoa: Media gallery dialog unit test · b6bcda6c

sail@chromium.org authored Aug 19, 2012

This is a port of the GTK unit test:
http://codereview.chromium.org/10823303/

BUG=134929


Review URL: https://chromiumcodereview.appspot.com/10854150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152272 0039d316-1c4b-4281-b951-d872f2087c98

b6bcda6c

Cleanup: Remove unused strings related to the about page. · 0c230ff1

jhawkins@chromium.org authored Aug 19, 2012

BUG=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/10823405

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152271 0039d316-1c4b-4281-b951-d872f2087c98

0c230ff1

Cleanup: Remove empty array param from chrome.send('x', []). · 9f4d739a

jhawkins@chromium.org authored Aug 19, 2012

Fixed a few lint issues in these files as well.

BUG=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/10860031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152270 0039d316-1c4b-4281-b951-d872f2087c98

9f4d739a

18 Aug, 2012 1 commit

Fix the build by doing one more s/options2/options/. · 57ac8f5f

jhawkins@chromium.org authored Aug 18, 2012

BUG=none
TBR=csilv

Review URL: https://chromiumcodereview.appspot.com/10824368

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152269 0039d316-1c4b-4281-b951-d872f2087c98

57ac8f5f