- 14 Aug, 2018 40 commits
-
-
Nektarios Paisios authored
1. Exposes AXPositionAdjustmentBehavior on all constructor methods and propagates adjustment behavior to constructor methods when converting from DOM positions. 2. Add comment documenting default adjustment behavior. 3. When converting from a DOM to an AX position but the corresponding AX position is ignored, adjusts to neighboring DOM positions to minimize huge diviations between the DOM and the corresponding AX position. E.g. if one cell in a table row is ignored, we don't want to skip to the next table row. 4. Introduces tests for ignored objects, affinity, and HTML labels. 5. Enabled two disabled tests with: list markers and ARIA hidden. 6. Modified |AXObject::Next\PreviousInTree| to return the next / previous valid unignored object in the tree when called on accessibility ignored objects. 7. Audited all call sides for |AXObject::Next\PreviousSibling| and disallowed calling those methods on ignored objects by using |NOTREACHED|. 8. Fixed |CreatePreviousPosition| to handle a corner case: When the previous object is both the previous sibling of the container object and also a text object. 9. Fixed |ToDOMPosition| to return the correct DOM position when the AX position is "after childre" but there are some ignored children at the end of the container object. 10. Fixed |CreateNextPosition| to return an "after children" position when the previous position was inside a text object which is the child of an unignored container. 11. Investigated |TextIterator| to ensure that it doesn't skip line breaks. 12. Fixed the handling of canvas elements: A) Fallback content can also be static text not only element nodes. B) JavaScript might not run but we would still want the role to be kCanvasRole, not kGenericContainer. C) The way that we were adding children caused a DCHECK to trigger because fallback content may also be in the layout tree under some circomstances. R=dmazzoni@chromium.org Bug: 852266 Change-Id: Iedf9f61bdf0b5172605c7268cbb20966f9249c93 Reviewed-on: https://chromium-review.googlesource.com/1150669 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#582930}
-
Xianzhu Wang authored
I missed update of next_item_to_index_, causing cached items after next_item_to_index_ to be added into index repeatedly for each new valid item inserted. (This is not a new regression but exposed by crrev.com/571251 in more cases especially during upward composited scrolling when display items newly appearing in the new interest rect are inserted in front of other cached items. Before that CL the newly appearing display items were treated as not cached because of their cache generation mismatching the paint controller's. After that CL we call FindOutOfOrderCachedItemForward().) Bug: 873511 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I17bc3ee55ad678f968ac8d9904fbc6a9b087407f Reviewed-on: https://chromium-review.googlesource.com/1173405Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582929}
-
Matt Menke authored
It's no longer used, and URLRequestContextGetters will no longer be created in the browser process, at some point. TBR=noyau@chromium.org Bug: 844973 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0c3ea06e0a99795a1f09c78c005ec16f4207ef77 Reviewed-on: https://chromium-review.googlesource.com/1171105Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582928}
-
Denis Kuznetsov authored
Moving component so that it can be reused by other targets. Bug: 864455 Change-Id: I65886aebee703868d98b02b8db6f19faf457bcd4 Reviewed-on: https://chromium-review.googlesource.com/1173234Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#582927}
-
Yi Su authored
Procedure of App returning to foreground: 1. applicationWillEnterForeground (normal App event) 2. performActionForShortcutItem (3d-touch event like 'open new tab') 3. applicationDidBecomeActive (normal App event) Current impl judges if an NTP should be opened in step1, and create that NTP in step3. Step2 also creates an NTP because no one exists after step1. Bug: 831124 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib77cabca10b4afdfd01cd0ade20a7ea254f04188 Reviewed-on: https://chromium-review.googlesource.com/1172689 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#582926}
-
Charlene Yan authored
Will still need to remove calls inside src/ash before it can be fully removed from src/ui/views/bubble/bubble_dialog_delegate_view.h Bug: 869928 Change-Id: I0444a7c3d6440d7be1dfe99c26996f2524d8f29a Reviewed-on: https://chromium-review.googlesource.com/1173321Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582925}
-
Ella Ge authored
Adds resampling input events and scroll events to chrome://flags Removes an old flag enable-scroll-prediction that seems not in used not. Bug: 836352 Change-Id: I37e78acd6bde0f69f3555df998ec91fedc284360 Reviewed-on: https://chromium-review.googlesource.com/1155407 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582924}
-
Helen Li authored
This CL adds a NetLog* parameter to CookieMonster's constructors, so we can use it to log NetLog events that are related to setting cookies. This CL is split off from rdsmith@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/925181 Left TODOs to hook up headless and iOS. I will upload followup CLs to address those. TBR=pfeldman@chromium.org TBR=slan@chromium.org Bug: 801910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibd76217b45326e1763263cdda391d9d584c458bf Reviewed-on: https://chromium-review.googlesource.com/1171113 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#582923}
-
Peter Kasting authored
Bug: 866689 Change-Id: I33ba303ddad0bec0de0624f98444c252ff5251ba Reviewed-on: https://chromium-review.googlesource.com/1173752Reviewed-by:
-
Scott Violet authored
BUG=847992 TEST=covered by tests Change-Id: I94ea9b06426f100520c019759c2d10e477fbede3 Reviewed-on: https://chromium-review.googlesource.com/1173354Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582921}
-
Joe Mason authored
Also add missed chrome_utils unit tests to test list. R=proberge Bug: 872748 Change-Id: Ica0f2a33768bbe4f9cfb2ff5842e47a1b17e53a0 Reviewed-on: https://chromium-review.googlesource.com/1173315Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582920}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5059c2eca07a..246471433a96 git log 5059c2eca07a..246471433a96 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 primiano@google.com TraceProcessor: Add progress indicator and allow interrupting queries Created with: gclient setdep -r src/third_party/perfetto@246471433a96 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6c3747bcbffc82569fb3f53f634d688cb20f8a9e Reviewed-on: https://chromium-review.googlesource.com/1174671Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582919}
-
Rohit Rao authored
The WKFileUploadPanel has a bug in iOS 11 and earlier which causes view controllers to be overdismissed when the HTML file picker is used. WebKit attempts to dismiss the file picker view controller, but due to a bug inadvertently dismisses its presenting view controller instead. We previously attempted to work around this bug in BrowserViewController, but now the file picker is presented on top of BrowserContainerViewController instead. This CL copies the BVC fix into BrowserContainerViewController as well. BUG=852367 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I61651810ae9e06caee27a4c441942e4c4d09c71c Reviewed-on: https://chromium-review.googlesource.com/1174611Reviewed-by:
-
Valeriya Sinevich authored
Create PerformMultilogin function in AccountReconciler which calls SetAccountsInCookie in GaiaCookieManagerService. This function will be later called in FinishReconcile() instead of multiple PerformMergeSession. SetAccountsInCookie is implemented in child CLs. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7f8bed2e7ffcad5558c8b70a40301e85650fe50d Reviewed-on: https://chromium-review.googlesource.com/1169210 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#582917}
-
John Abd-El-Malek authored
This matches the old path's mime_sniffing_resource_handler.cc. Bug: 729849 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7afd5ac3d595ddcea5b061dd064e4413eab590df Reviewed-on: https://chromium-review.googlesource.com/1173764Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582916}
-
Javier Ernesto Flores Robles authored
An observer was missing on this class. Found while hitting a DCHECK. Most likely the product of a merge conflict. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I29fb74d9ac2a0d6404748e592089f80f4ec6f9b5 Reviewed-on: https://chromium-review.googlesource.com/1174264Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582915}
-
Fredrik Söderquist authored
The property: paint-order: stroke markers is equivalent to: paint-order: stroke markers fill (Spec: "If any of the three keywords are omitted, they are painted last, in the order they would be painted with paint-order: normal." @ https://svgwg.org/svg2-draft/painting.html#PaintOrder ) So the fill should be painted last. Add 'marker:none' to the appropriate element in the ref. Disable stroke and marker in a few cases to avoid "overdraw" and thus "incorrect" edge rendering in some cases. BUG=872972 Change-Id: I835a6980fa069825ed2a2e920862018faec6d93c Reviewed-on: https://chromium-review.googlesource.com/1172778Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582914}
-
Miguel Casas authored
lowLatency 2D contexts would crash the tab when sent to the background; this is because of the callstack HTMLCanvasElement::PageVisibilityChanged() CanvasRenderingContext2D::SetIsHidden() canvas()->GetCanvas2DLayerBridge()->SetIsHidden(hidden) ... Canvas2DLayerBridge::Hibernate() and that tries to destroy its Layer, which has not been created (because in lowLatency mode we don't use it). This CL fixes the issue by cutting at SetIsHidden() if there is no |layer_|. Test: open https://codepen.io/miguelao/full/ZjJNNw (or any other trivial sample canvas lowLatency demo), draw something , then open a new tab. The former tab crashes on ToT, doesn't with this CL. Bug: 839970, 870873 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6657a72009438cb31fac2b2d874c807b1719d16a Reviewed-on: https://chromium-review.googlesource.com/1173344Reviewed-by:Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#582913}
-
Dominic Battre authored
Chrome used to fetch password requirements specifications once the Autofill server responded. This means that two network round trips were necessary until the data was available. With this change, the requirements are fetched every time the renderer reports that password forms were found, which moves the lookup to an earlier point. As this reporting can happen multiple times through the life-cycle of a site, the CL also introduces an extra in-memory cache lookup that prevents further processing if the requirements have been fetched already. Bug: 873653, 846694 Change-Id: Id1bdd575fa659fcf05b40a937cb6aa00206e8965 Reviewed-on: https://chromium-review.googlesource.com/1172972Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#582912}
-
Xu Xing authored
Main changes: 1), move flag enable viz inside DelegatedFrameHost. 2), cache host_frame_sink_manager_, so this matches DelegatedFrameHostAndroid and saves several lines of code. 3), if enable_viz_ is true, support_ is nullptr. Otherwise, support_ is valid. So (enable_viz_ || support_ ) is always true. Bug: 859977 Change-Id: If13d08dc7dc1ba04de507d181bf2a940d8010466 Reviewed-on: https://chromium-review.googlesource.com/1168740Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#582911}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8f60c708bfd1..193e9338017c git log 8f60c708bfd1..193e9338017c --date=short --no-merges --format='%ad %ae %s' 2018-08-14 anthonyalridge@google.com Create ability to zoom on dot plots. Created with: gclient setdep -r src/third_party/catapult@193e9338017c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I4315739c22c6f86fcecdc1a2ce2eaf5914837840 Reviewed-on: https://chromium-review.googlesource.com/1174451Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582910}
-
Mugdha Lakhani authored
1. backgroundfetchclick and backgroundfetchabort are of type BackgroundFetchEvent now. 2. BackgroundFetchEvent includes a BackgroundFetchRegistration object. 3. Temporarily (until match() and matchAll() have been implemented on BackgroundFetchRegistration), BackgroundFetchUpdateUIEvent also includes a BackgroundFetchSettledFetches object. 4. BackgroundFetchUpdateEvent --> BackgroundFetchUpdateUIEvent, and inherits from BackgroundFetchEvent. 5. backgroundfetched --> backgroundfetchsuccess. 6. backgroundfetchsuccess and backgroundfetchfail are of type BackgroundFetchUpdateUIEvent. 7. Update WPT tests accordingly. Bug: 869918 Change-Id: Ibb05087e692b39c2dd34c990baeff642627b6520 Reviewed-on: https://chromium-review.googlesource.com/1158835 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582909}
-
Kevin Schoedel authored
Plumbs the CastSystemGestureDispatcher through to touch exploration, and invokes tap actions when touch exploration calls for a tap at a location outside lift activation bounds (currently always the case). This allows waking from the ambient screen in screen reading mode. Bug: internal b/112073530 Test: manual Change-Id: Iab086ee76c0aa254c23e2635a4b283ff6156434d Reviewed-on: https://chromium-review.googlesource.com/1168117 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Ryan Daum <rdaum@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#582908}
-
Luke Halliwell authored
Generalize MediaLoadDeferrer interface to handle other media playback options; add IPC to send background suspend enabled state from browser to renderer, and replace switch with content client implementation. Not using a switch will allow this to be robust against redirects and prewarmed render processes. Bug: b/73820381 Change-Id: Ib6b5adb7aa477dae06a1bb911bf6adb896023abe Reviewed-on: https://chromium-review.googlesource.com/1154138 Commit-Queue: Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582907}
-
James Cook authored
The existing aura::Env::GetInstance() doesn't create anything. Most callers were using GetInstanceDontCreate() to mean HasInstance(), so rename the method. This makes it easier to write presubmits for aura::Env::GetInstance(). Bug: none Test: bots Change-Id: I0c606df7c8e439579d4ae39fa11dd119b610cb77 Reviewed-on: https://chromium-review.googlesource.com/1173473Reviewed-by:
-
Javier Ernesto Flores Robles authored
Marking ContextMenuJsTest.FindLinkImageAtPointOutsideElement, ContextMenuJsTest.GetImageTitleAtPoint and ContextMenuJsFindElementAtPointTest.LinkOfTextWithoutCalloutProperty as flaky on devices. Bug: 796418 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1639c935a5f33cccd58a809f63f8bbeac32dcd45 TBR: eugenebut@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174536Reviewed-by:
-
Kevin McNee authored
The associated bug which required this extra tab is fixed. Bug: 147644 Change-Id: Ic256c30eda064134d670f3ce49ca7483a0ed5ff7 Reviewed-on: https://chromium-review.googlesource.com/1173400Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582904}
-
Elly Fong-Jones authored
Without any stored images, TabCloseButton falls back to the default sizing for ImageButton, which is 16x14. This change makes it always a square, which makes the focus ring and ink drop circles instead of ovals. Bug: 873063 Change-Id: I5c2deec54f768d64be14ee0f9c0adcb52a8d754e Reviewed-on: https://chromium-review.googlesource.com/1172506Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582903}
-
Gauthier Ambard authored
The bottom insets of the popup menus were wrong because of a rounding error. This CL adjusts it by rounding at the end of the additions instead of doing everytime a new element is computed. Bug: 850516 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic99c3d71e1f7d8a0b47a3e6453242d4a36007e66 Reviewed-on: https://chromium-review.googlesource.com/1174253 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582902}
-
Fernando Serboncini authored
TBR=kbr@chromium.org Change-Id: I9a732afd2670bca16f6cbcde309e1397093f42a1 Reviewed-on: https://chromium-review.googlesource.com/1173364 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Rohit Rao authored
This reverts commit 4e0162d3. Reason for revert: Logic in the conditional was wrong. Reverting and relanding to make cherrypicking easier. Original change's description: > [ios] Fixes an issue where BVC is overdismissed by a bug in WebKit. > > The WKFileUploadPanel has a bug in iOS 11 and earlier which causes view > controllers to be overdismissed when the HTML file picker is > used. WebKit attempts to dismiss the file picker view controller, but > due to a bug inadvertently dismisses its presenting view controller > instead. > > We previously attempted to work around this bug in > BrowserViewController, but now the file picker is presented on top of > BrowserContainerViewController instead. This CL copies the BVC fix into > BrowserContainerViewController as well. > > BUG=852367 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I8c3ef4b55cc052f832aa3e9e995c20880a96db00 > Reviewed-on: https://chromium-review.googlesource.com/1172505 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582899} TBR=rohitrao@chromium.org,marq@chromium.org Change-Id: Id199b64138930f430e5b753d00e78cc1ecab54a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852367 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1174551Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582900}
-
Rohit Rao authored
The WKFileUploadPanel has a bug in iOS 11 and earlier which causes view controllers to be overdismissed when the HTML file picker is used. WebKit attempts to dismiss the file picker view controller, but due to a bug inadvertently dismisses its presenting view controller instead. We previously attempted to work around this bug in BrowserViewController, but now the file picker is presented on top of BrowserContainerViewController instead. This CL copies the BVC fix into BrowserContainerViewController as well. BUG=852367 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c3ef4b55cc052f832aa3e9e995c20880a96db00 Reviewed-on: https://chromium-review.googlesource.com/1172505Reviewed-by:
-
Amirhossein Simjour authored
I also made some changes on Build files to make sure that there is no circular dependencies. More tests to come in follow up CLs. BUG=810847 Change-Id: I04fe2d848ebd76a076a09d1c0aab7cdaba9e205a Reviewed-on: https://chromium-review.googlesource.com/1099563 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#582898}
-
Ian Clelland authored
The flag has been removed from RuntimeEnabledFeatures, so this change eliminates a warning message on startup. Change-Id: I8f6f8027f7f0446a5cf3c03f0740cd90277a7ecf Reviewed-on: https://chromium-review.googlesource.com/1173255Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#582897}
-
Pavol Marko authored
Temporarily add ChromeOS-only logging to diagnose certificates disappearing from the system token: (*) Log info about all all User certificates on chrome start up (*) Log a message when a certificate is being deleted. Bug: 844537 Test: Examine output of net_unittests --gtest_filter=*LogUserCerts* Change-Id: Ie9f173573ba7e0704bc8e21462183390fac0c640 Reviewed-on: https://chromium-review.googlesource.com/1169478 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582896}
-
Oriol Brufau authored
Spec: https://drafts.csswg.org/css-logical/#box BUG=873101 TEST=external/wpt/css/css-logical/animation-004.html Change-Id: I104a8ecc746f4516e567b16a75c5d32a31d4dab8 Reviewed-on: https://chromium-review.googlesource.com/1170769Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#582895}
-
Jun Choi authored
Add observer function to notify embedder when Bluetooth adapter power has changed. Bug: 866601 Change-Id: I711b752c75b96a6428b7d1f28f425a5f17cf3bb9 Reviewed-on: https://chromium-review.googlesource.com/1170230 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582894}
-
Rayan Kanso authored
Record the duration of web exposed methods in BackgroundFetchManager using UMA. Bug: 780025 Change-Id: Ide4f4ce2f416f450475d4a75862b2a20ebee41fb Reviewed-on: https://chromium-review.googlesource.com/1170902 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Pavol Marko authored
* Add function GetEndOfCurrent interval to obtain the last end of the interval which contains the current time. * Add function MaterializeIntervalsToLocalTimezone, which materializes the given intervals to the current local timezone. * Add function TimeIsInsideCrosSettingsIntervals, which checks if the current time is inside the intervals set in cros settings. It then returns the localized string of the end of the interval that contains the current time. This is a reland of CL:1132676 which fixes memory leaks that lead to a revert (revert was CL:1172003). BUG=chromium:852860 TEST=added unittests Change-Id: I8ad01d4ab90d4e699e4b7377c24e4932513ebe1b Reviewed-on: https://chromium-review.googlesource.com/1172128Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582892}
-
Javier Ernesto Flores Robles authored
FindImageElementAtPointOutsideElement is flaky on devices. Bug: 796418 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I36781de8c1127f74196457c0a0ec7ebf0bd6c5d5 TBR: eugenebut@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174437Reviewed-by:
-
